r295381 - Use correct fix-it location for -Wblock-capture-autoreleasing

Author: arphaman Date: Thu Feb 16 17:15:36 2017 New Revision: 295381 URL: http://llvm.org/viewvc/llvm-project?rev=295381&view=rev Log: Use correct fix-it location for -Wblock-capture-autoreleasing The '__autoreleasing' keyword should be inserted after the Objective-C pointer type. rdar://3012354

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama updated this revision to Diff 88799. pirama added a comment. Stricter tests. https://reviews.llvm.org/D30015 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep test/Drive

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

pirama added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// pirama wrote: > I feel this test is fragile. Any idea how to further restrict and require > that t

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

EricWF updated this revision to Diff 88803. EricWF added a comment. - Enumerate and test each constructor. https://reviews.llvm.org/D29863 Files: include/string test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp utils/libcxx/test/config.py Index: utils/libcxx/te

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

rsmith added a comment. Other than (5), all the failing cases look like they should fail per the current `basic_string` spec. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with i

[libcxx] r295390 - add tests for ENAMETOOLONG

Author: ericwf Date: Thu Feb 16 19:00:37 2017 New Revision: 295390 URL: http://llvm.org/viewvc/llvm-project?rev=295390&view=rev Log: add tests for ENAMETOOLONG Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.exists/exists.pass.cpp libcxx/trunk/test/std/experime

r295391 - [ubsan] Reduce null checking of C++ object pointers (PR27581)

Author: vedantk Date: Thu Feb 16 19:05:42 2017 New Revision: 295391 URL: http://llvm.org/viewvc/llvm-project?rev=295391&view=rev Log: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per method/lambda.

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

This revision was automatically updated to reflect the committed changes. Closed by commit rL295391: [ubsan] Reduce null checking of C++ object pointers (PR27581) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29530?vs=88259&id=88808#toc Repository: rL LLVM https:

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

EricWF added inline comments. Comment at: test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp:57 + { // Testing (2) +// FIXME: (2) doesn't work with implicit deduction. +// const test_allocator alloc{}; rsmith wrote: > I think t

[PATCH] D29863: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

EricWF updated this revision to Diff 88812. EricWF added a comment. - Clarify comments about conforming constructors that still don't support guides. https://reviews.llvm.org/D29863 Files: include/string test/std/strings/basic.string/string.cons/implicit_deduction_guides.pass.cpp test/su

[libcxx] r295393 - [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types.

Author: ericwf Date: Thu Feb 16 19:17:10 2017 New Revision: 295393 URL: http://llvm.org/viewvc/llvm-project?rev=295393&view=rev Log: [libc++] Fix PR 31938 - std::basic_string constructors use non-deductible parameter types. Summary: This patch fixes http://llvm.org/PR31938. The description below

[PATCH] D30035: Add const to function parameters

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This change is ABI breaking because these functions are exported using explicit template instantiations, and because changing their signature changes the mangling. Can you explain w

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. I really don't like this change (and https://reviews.llvm.org/D29757) because they start to include a ton of extra headers, and because they lift complex configuration logic into wha

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Same comment as https://reviews.llvm.org/D29818 I really don't like this change (and https://reviews.llvm.org/D29818) because they start to include a ton of extra headers, and becaus

r295396 - Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)"

Author: vedantk Date: Thu Feb 16 19:42:36 2017 New Revision: 295396 URL: http://llvm.org/viewvc/llvm-project?rev=295396&view=rev Log: Revert "[ubsan] Reduce null checking of C++ object pointers (PR27581)" This reverts commit r295391. It breaks this bot: http://lab.llvm.org:8011/builders/clang-wi

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere else? https://reviews.llvm.org/D29157

Re: [libcxx] r294116 - Remove CMake hack

Eric Fiselier via cfe-commits writes: > Author: ericwf > Date: Sat Feb 4 19:19:02 2017 > New Revision: 294116 > > URL: http://llvm.org/viewvc/llvm-project?rev=294116&view=rev > Log: > Remove CMake hack FWIW, I just spent half an hour trying to figure out why a tree I hadn't built in a bit wouldn

Re: [libcxx] r294116 - Remove CMake hack

Sorry about the breakage. I'm not sure what else to do. The hack had been sitting there for more than a month IIRC. Any advice for next time? /Eric On Thu, Feb 16, 2017 at 7:00 PM, Justin Bogner wrote: > Eric Fiselier via cfe-commits writes: > > Author: ericwf > > Date: Sat Feb 4 19:19:02 2

[libcxx] r295399 - update revision in CHANGELOG.TXT and fix python error

Author: ericwf Date: Thu Feb 16 19:56:57 2017 New Revision: 295399 URL: http://llvm.org/viewvc/llvm-project?rev=295399&view=rev Log: update revision in CHANGELOG.TXT and fix python error Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT libcxx/trunk/utils/libcxx/sym_check/extract.py Modified:

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr or

r295401 - Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581)

Author: vedantk Date: Thu Feb 16 20:03:51 2017 New Revision: 295401 URL: http://llvm.org/viewvc/llvm-project?rev=295401&view=rev Log: Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581) This patch teaches ubsan to insert exactly one null check for the 'this' pointer per method/la

[PATCH] D29967: Get class property selectors from property decl if it exists

compnerd added a comment. I think Im misunderstanding something. How does the test actually test what you are changing? https://reviews.llvm.org/D29967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[libcxx] r295403 - Mark a couple for basic_string member templates as inline. no ABI change this time.

Author: ericwf Date: Thu Feb 16 20:31:56 2017 New Revision: 295403 URL: http://llvm.org/viewvc/llvm-project?rev=295403&view=rev Log: Mark a couple for basic_string member templates as inline. no ABI change this time. Modified: libcxx/trunk/include/string Modified: libcxx/trunk/include/strin

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added a comment. I applied `inline` to most of the functions changed in `basic_string`, and updated the ABI lists accordingly. Please update this patch so it merges with trunk. Note you can add `_LIBCPP_HIDDEN` to the functions in `basic_string` as well if you want, however the `inline`

r295404 - Added doxygen comments to smmintrin.h's intrinsics.

Author: kromanova Date: Thu Feb 16 20:49:50 2017 New Revision: 295404 URL: http://llvm.org/viewvc/llvm-project?rev=295404&view=rev Log: Added doxygen comments to smmintrin.h's intrinsics. Note: The doxygen comments are automatically generated based on Sony's intrinsic s document. I got an OK fro

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added inline comments. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point After applying the changes to `__config` but not this header `check-cxx-abilist` didn't report any changes to these symbols. Wh

[PATCH] D30045: Remove `std::random_shuffle` in C++17

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after fixing inline comments. Comment at: include/algorithm:3029 +#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE) class _LIBCPP_TYP

[PATCH] D28172: [libcxx] Remove unexpected handlers in C++17

EricWF updated this revision to Diff 88843. EricWF added a comment. - Update so that it merges with master. - add `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` macro for re-enabling all removed C++17 features. https://reviews.llvm.org/D28172 Files: docs/UsingLibcxx.rst include/__config includ

[libcxx] r295406 - [libcxx] Remove unexpected handlers in C++17

Author: ericwf Date: Thu Feb 16 21:25:08 2017 New Revision: 295406 URL: http://llvm.org/viewvc/llvm-project?rev=295406&view=rev Log: [libcxx] Remove unexpected handlers in C++17 Summary: This patch implements [P0003R5](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0003r5.html) which

[PATCH] D29967: Get class property selectors from property decl if it exists

herzka added a comment. Currently, `A.customGetterProperty` would be turned into `[A customGetterProperty]`, which would fail to compile because that selector isn't declared anywhere. With my fix, it does compile because it (correctly) resolves to `[A customGet]`, which does exist. Similarly, `

[libcxx] r295407 - Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES

Author: ericwf Date: Thu Feb 16 21:30:25 2017 New Revision: 295407 URL: http://llvm.org/viewvc/llvm-project?rev=295407&view=rev Log: Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under _LIBCPP_ENABLE_CXX17_REMOVED_FEATURES Modified: libcxx/trunk/docs/UsingLibcxx.rst

[PATCH] D30045: Remove `std::random_shuffle` in C++17

EricWF added a comment. @mclow.lists A couple of additional things: - Add `_LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE` to the `_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES` list in `__config`. - Add a test for that in `test/libcxx/depr/enable_removed_cpp17_features.pass.cpp` Comme

[PATCH] D29806: [clang-tidy] Add -path option to clang-tidy-diff.py

ehsan added a comment. Gentle ping. :-) https://reviews.llvm.org/D29806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added a comment. In https://reviews.llvm.org/D24812#678931, @tigerleapgorge wrote: > @rjmccall > > Hi John, I've made the changes to volatile.cpp. > I take it this patch is good for commit? Yes, I think I have the information I wanted from Reid. LGTM. https://reviews.llvm.org/D2481

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rjmccall added a comment. LGTM. https://reviews.llvm.org/D29986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r295411 - Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers

Author: ericwf Date: Thu Feb 16 22:26:22 2017 New Revision: 295411 URL: http://llvm.org/viewvc/llvm-project?rev=295411&view=rev Log: Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected handlers Modified: libcxxabi/trunk/test/test_exception_storage.pass.cpp Modified: l

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF updated this revision to Diff 88852. EricWF added a comment. - Update so that it merges with https://reviews.llvm.org/D26057 https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp test/CodeGenCorout

r295416 - [index] Improvde how we handle synthesized ObjC properties and the associated ivars.

Author: akirtzidis Date: Thu Feb 16 22:49:41 2017 New Revision: 295416 URL: http://llvm.org/viewvc/llvm-project?rev=295416&view=rev Log: [index] Improvde how we handle synthesized ObjC properties and the associated ivars. Related synthesized properties with the ivar they use with the 'accessor'

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai added a comment. Will do the rebase. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point EricWF wrote: > After applying the changes to `__config` but not this header > `check-cxx-abilist` didn't repo

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 88854. smeenai added a comment. Rebase https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++ include/str

[libcxx] r295417 - Work around Clang assertion when testing C++17 deduction guides with '-g'.

Author: ericwf Date: Thu Feb 16 23:04:09 2017 New Revision: 295417 URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev Log: Work around Clang assertion when testing C++17 deduction guides with '-g'. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction

Re: r295379 - Properly set up the DeclContext for parameters of implicit deduction guides;

Hi Richard, One more issue. When compiling with `-g` the following code hits a `llvm_unreachable` in CGDebugInfo::CreateTypeNode. template struct S { S(T) {} }; S s(42); /Eric On Thu, Feb 16, 2017 at 2:29 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith

r295421 - Add better ODR checking for modules.

Author: rtrieu Date: Thu Feb 16 23:54:30 2017 New Revision: 295421 URL: http://llvm.org/viewvc/llvm-project?rev=295421&view=rev Log: Add better ODR checking for modules. A slightly weaker form of ODR checking than previous attempts, but hopefully won't break the modules build bot. Future work wi

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF created this revision. Herald added a subscriber: aprantl. Currently the following code hits an `llvm_unreachable` in `CGDebugInfo::CreateTypeNode` because `DeducedTemplateSpecialization` isn't handled. // clang++ -std=c++1z -g test.cpp template struct S { S(T) {} }; S s(42); Th

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF updated this revision to Diff 88859. EricWF added a comment. Remove unintentional changes. https://reviews.llvm.org/D30082 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-template-deduction-guide.cpp Index: test/CodeGenCXX/debug-info-template-deduction-guide.cpp =

Re: r295379 - Properly set up the DeclContext for parameters of implicit deduction guides;

I put my attempt to fix this up for review: https://reviews.llvm.org/D30082 On Thu, Feb 16, 2017 at 10:17 PM, Eric Fiselier wrote: > Hi Richard, > > One more issue. When compiling with `-g` the following code hits a > `llvm_unreachable` in CGDebugInfo::CreateTypeNode. > > template struct S { S

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

majnemer added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2479 +case Type::DeducedTemplateSpecialization: { + QualType DT = dyn_cast(T)->getDeducedType(); + assert(!DT.isNull() && "Undeduced types shouldn't reach here."); You are uncon

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2479 +case Type::DeducedTemplateSpecialization: { + QualType DT = dyn_cast(T)->getDeducedType(); + assert(!DT.isNull() && "Undeduced types shouldn't reach

[PATCH] D30082: Fix assertion when generating debug information for deduced template specialization types.

EricWF updated this revision to Diff 88861. EricWF marked an inline comment as done. EricWF added a comment. Address @majnemer's comments. https://reviews.llvm.org/D30082 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-template-deduction-guide.cpp Index: test/CodeGenCXX/debu

[libcxx] r295422 - add implicit deduction guide tests for string_view

Author: ericwf Date: Fri Feb 17 00:59:11 2017 New Revision: 295422 URL: http://llvm.org/viewvc/llvm-project?rev=295422&view=rev Log: add implicit deduction guide tests for string_view Added: libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp Added:

[libcxx] r295423 - Remove dead code in test

Author: ericwf Date: Fri Feb 17 01:00:04 2017 New Revision: 295423 URL: http://llvm.org/viewvc/llvm-project?rev=295423&view=rev Log: Remove dead code in test Modified: libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp Modified: libcxx/trunk/test/

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added a comment. Please adapt the title and summary for the more general changes this has evolved to. Comment at: lib/Driver/Tools.cpp:284 +// If we are not cross-compling, add '-rpath' with architecture-specific +// library path so libraries lined from this p

r295427 - Revert r295421, new ODR checker for modules, to fix build bot.

Author: rtrieu Date: Fri Feb 17 01:19:24 2017 New Revision: 295427 URL: http://llvm.org/viewvc/llvm-project?rev=295427&view=rev Log: Revert r295421, new ODR checker for modules, to fix build bot. Removed: cfe/trunk/include/clang/AST/ODRHash.h cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/te

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

mgorny added a comment. Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES

[libcxx] r295428 - Use inline namespaces with GCC instead of __attribute__((__strong__)).

Author: ericwf Date: Fri Feb 17 01:31:38 2017 New Revision: 295428 URL: http://llvm.org/viewvc/llvm-project?rev=295428&view=rev Log: Use inline namespaces with GCC instead of __attribute__((__strong__)). GCC 7.0.1 started warning that __attribute__((__strong__)) is depricated. This patch switches

[PATCH] D30015: [OpenMP] Add arch-specific directory to search path

Hahnfeld added inline comments. Comment at: test/Driver/arch-specific-libdir-rpath.c:6 +// -rpath only gets added during native compilation +// REQUIRES: native +// mgorny wrote: > Hahnfeld wrote: > > pirama wrote: > > > pirama wrote: > > > > I feel this test is

<    1   2