Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

2017-01-26 Thread Marshall Clow via cfe-commits
On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg wrote: > What's the status here? Waiting for Marshall? > I'm fine with merging this to the 4.0 branch -- Marshall ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

r293254 - [docs] Add help text and refine grouping for various options.

2017-01-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jan 26 20:08:37 2017 New Revision: 293254 URL: http://llvm.org/viewvc/llvm-project?rev=293254&view=rev Log: [docs] Add help text and refine grouping for various options. Also accept -G= (and -msmall-data-threshold=) as an alias for -G on MIPS as well as Hexagon. Modifie

[PATCH] D26345: Extend small data threshold driver options to PPC target

2017-01-26 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. As of r293254, the `-G=` and `-msmall-data-threshold=` flags are just aliases of `-G`, so you don't need those parts of this patch any more. The PPC part looks fine, but please add a testcase.

[PATCH] D29198: clang-cl: Warn about /U flags that look like filenames (PR31662)

2017-01-26 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. Thanks for adding this, diagnosing what was going on here the first time around took a little bit of thinking. https://reviews.llvm.org/D29198 ___ cfe-commits mailing list cfe-commits@lists

[libunwind] r293257 - Revert "DWARF: convert error logs to _LIBUNWIND_LOG"

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 26 20:26:52 2017 New Revision: 293257 URL: http://llvm.org/viewvc/llvm-project?rev=293257&view=rev Log: Revert "DWARF: convert error logs to _LIBUNWIND_LOG" This reverts SVN r292721. Avoid the use of the GNU extension as the preprocessor in C++11 mode requires at l

Re: [libunwind] r292721 - DWARF: convert error logs to _LIBUNWIND_LOG

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
Sorry, somehow I missed that. Ive gone ahead and reverted this change for now (SVN r293257). On Thu, Jan 26, 2017 at 2:30 PM, Evgenii Stepanov wrote: > Actually, the bot has been red since Jan 21 with this exact error. > > On Thu, Jan 26, 2017 at 2:27 PM, Evgenii Stepanov > wrote: > > Hi, > >

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

2017-01-26 Thread Warren Ristow via Phabricator via cfe-commits
wristow created this revision. Guard against a null pointer dereference that caused Clang to crash when processing a class containing an _Atomic() data member, and that is tagged with 'dllexport'. https://reviews.llvm.org/D29208 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/atomic-dllexpor

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

2017-01-26 Thread Saleem Abdulrasool via cfe-commits
I think that this is safe enough and does make libunwind work on x86 Linux, so lets go for it. On Thu, Jan 26, 2017 at 10:10 AM, Hans Wennborg wrote: > MichaƂ suggested on the PR that this should be merged to the release > branch. > > Saleem, what do you think? > > On Sat, Jan 21, 2017 at 8:22 A

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

2017-01-26 Thread Warren Ristow via Phabricator via cfe-commits
wristow added a comment. When a class that has been tagged as dllexport (for an MSVC target) contains an atomic data member via the C11 '_Atomic' approach, the front end crashes with a null pointer dereference. This patch fixes it by guarding the null dereference with the approach used by simil

[PATCH] D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux

2017-01-26 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. This really needs a new driver flag (`-unwinder`?) similar to `-rtlib`, as there are multiple unwinders, and it is unclear which unwinder is the proper one on a given target. Th

[PATCH] D29209: Use copy.deepcopy instead of doing it manually.

2017-01-26 Thread Dan Albert via Phabricator via cfe-commits
danalbert created this revision. Repository: rL LLVM https://reviews.llvm.org/D29209 Files: test/libcxx/compiler.py test/libcxx/test/format.py Index: test/libcxx/test/format.py === --- test/libcxx/test/format.py +++ test/lib

[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

2017-01-26 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. The static analyzer is definitely the place to go for bug detection that requires path sensitivity. It's also reasonably good for anything that needs flow-sensitivity. Although, most flow-sensitive analysis (such as liveness) now live in lib/Analysis/, which is used b

[clang-tools-extra] r293267 - Revert "Implement a new clang-tidy check that suggests users replace dynamic exception specifications with noexcept exception specifications."

2017-01-26 Thread Diana Picus via cfe-commits
Author: rovka Date: Fri Jan 27 01:19:22 2017 New Revision: 293267 URL: http://llvm.org/viewvc/llvm-project?rev=293267&view=rev Log: Revert "Implement a new clang-tidy check that suggests users replace dynamic exception specifications with noexcept exception specifications." This reverts commit r

Re: [clang-tools-extra] r293217 - Implement a new clang-tidy check that suggests users replace dynamic exception specifications with noexcept exception specifications.

2017-01-26 Thread Diana Picus via cfe-commits
Hi Don, Hi Aaron, I had to revert this in r293267 because all the clang-tools-extra buildbots were still broken many hours after it was committed. See for instance http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1039 Eugene Zelenko also had some small fixes to modernize-use-noex

<    1   2