mgorny updated this revision to Diff 84947.
mgorny retitled this revision from "[compiler-rt] [test] Fix page address logic
in clear_cache_test to use binary negation" to "[compiler-rt] [test] Fix page
address logic in clear_cache_test".
mgorny edited the summary of this revision.
mgorny added a
mgorny added a comment.
Just to be clear, the values also differ per -O0 vs -O2. I'm not sure if we can
even reliably figure that out.
I've tried to work around the issue by building everything in 387 mode.
However, in that case muldc3_test has even larger mismatches and didn't really
want to
On 19 January 2017 at 03:47, Aaron Ballman wrote:
> It is not used in an unevaluated context -- that is a bug.
It is an evaluated expression, but is it odr-used?
C++14 [basic.def.odr] p3:
A variable x whose name appears as a potentially-evaluated expression
ex is odr-used by ex unless applying
Author: malcolm.parsons
Date: Thu Jan 19 03:27:45 2017
New Revision: 292477
URL: http://llvm.org/viewvc/llvm-project?rev=292477&view=rev
Log:
[docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing
Summary:
Docs for clang::Decl and clang::TemplateSpecializationType have
not been generated since LLV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292477: [docs] Tell Doxygen to expand LLVM_ALIGNAS to
nothing (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D28850?vs=84812&id=84950#toc
Repository:
rL LLVM
https:
hokein created this revision.
https://reviews.llvm.org/D28895
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_test.h
test/clang-move/move-multiple-classes.cpp
Index: test/clang-move/move-multiple-classes.cpp
Hi,
I noticed a change from clang 3.8 to 3.9, that it disabled all OpenCL extension
pragmas per default.
This broke pocl on e.g. ARM for LLVM 3.9
(https://github.com/pocl/pocl/issues/409).
Example:
$ echo "#pragma OPENCL EXTENSION cl_khr_icd: enable" > hello.cl
$ clang -emit-llvm -x cl -o tmp
On Thu, Jan 19, 2017 at 4:37 AM, Malcolm Parsons
wrote:
> On 19 January 2017 at 03:47, Aaron Ballman wrote:
>> It is not used in an unevaluated context -- that is a bug.
>
> It is an evaluated expression, but is it odr-used?
>
> C++14 [basic.def.odr] p3:
>
> A variable x whose name appears as a p
On 19 January 2017 at 12:49, Aaron Ballman wrote:
> You are correct, it is not an odr use. MSVC is wrong to require the capture.
Should the warning be rephrased?
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
On Thu, Jan 19, 2017 at 7:49 AM, Aaron Ballman wrote:
> On Thu, Jan 19, 2017 at 4:37 AM, Malcolm Parsons
> wrote:
>> On 19 January 2017 at 03:47, Aaron Ballman wrote:
>>> It is not used in an unevaluated context -- that is a bug.
>>
>> It is an evaluated expression, but is it odr-used?
>>
>> C++
ioeric requested changes to this revision.
ioeric added a comment.
This revision now requires changes to proceed.
Per offline discussion, this change is not intact - we want using decls in
headers to be moveable symbols as well since it can have references outside of
the local TU.
https://revi
On 19 January 2017 at 13:16, Aaron Ballman wrote:
> I wasn't thinking about that kind of odr-unuse when reviewing your
> patch, so I am starting to think that perhaps it's not worth
> distinguishing unevaluated contexts or not in the diagnostic. :-( If
> we could do it, then great (we seem to be a
Author: malcolm.parsons
Date: Thu Jan 19 07:38:19 2017
New Revision: 292484
URL: http://llvm.org/viewvc/llvm-project?rev=292484&view=rev
Log:
[docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing
Summary:
Docs for clang::Decl and clang::TemplateSpecializationType have
not been generated since LLV
flx created this revision.
Herald added a subscriber: JDevlieghere.
Repository:
rL LLVM
https://reviews.llvm.org/D28899
Files:
clang-tidy/utils/DeclRefExprUtils.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
On Thu, Jan 19, 2017 at 8:45 AM, Malcolm Parsons
wrote:
> On 19 January 2017 at 13:16, Aaron Ballman wrote:
>> I wasn't thinking about that kind of odr-unuse when reviewing your
>> patch, so I am starting to think that perhaps it's not worth
>> distinguishing unevaluated contexts or not in the di
arphaman added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-palachev added a comment.
Thanks for review!
> As Artem points out, the checkers in tree do not create a node for every bug
> reported - there is no reason to do that.
Yes... But why does `generateNonFatalErrorNode` return `nullptr` in case when
the node already exists? Isn't it designed
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
scanon added a comment.
These tests should either be exact, or should have a tolerance that's
mathematically sound. +/-1ulp is not sound; the allowed error should be
proportional to the magnitude of the larger of the real and imaginary
components of the result -- e.g. if one component is very s
Author: marshall
Date: Thu Jan 19 09:30:36 2017
New Revision: 292490
URL: http://llvm.org/viewvc/llvm-project?rev=292490&view=rev
Log:
Mark two of the TS implementations as 'in progress'
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://ll
malcolm.parsons created this revision.
The warning doesn't know why the variable was looked up but not
odr-used, so reword it to not claim that it was used in an unevaluated
context.
https://reviews.llvm.org/D28902
Files:
include/clang/Basic/DiagnosticSemaKinds.td
test/SemaCXX/warn-unused-l
Author: flx
Date: Thu Jan 19 09:51:10 2017
New Revision: 292491
URL: http://llvm.org/viewvc/llvm-project?rev=292491&view=rev
Log:
[clang-tidy] Do not trigger move fix for non-copy assignment operators in
performance-unnecessary-value-param check
Reviewers: alexfh, sbenza, malcolm.parsons
Subscr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292491: [clang-tidy] Do not trigger move fix for non-copy
assignment operators in… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D28899?vs=84960&id=84967#toc
Repository:
rL LLV
hintonda updated this revision to Diff 84975.
hintonda added a comment.
- Fix diagnostic when removing throwing specs.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-
IvanSidorenko created this revision.
Function call can appear in the arguments of another function call. This patch
adds support for such cases.
https://reviews.llvm.org/D28905
Files:
lib/Analysis/CallGraph.cpp
test/Analysis/debug-CallGraph.c
Index: test/Analysis/debug-CallGraph.c
==
Author: hans
Date: Thu Jan 19 10:50:46 2017
New Revision: 292494
URL: http://llvm.org/viewvc/llvm-project?rev=292494&view=rev
Log:
Merging r292091:
r292091 | marshall | 2017-01-15 19:02:10 -0800 (Sun, 15 Jan 2017) | 1 line
I
Merged to 4.0 in r292494 as requested.
On Sun, Jan 15, 2017 at 7:02 PM, Marshall Clow via cfe-commits
wrote:
> Author: marshall
> Date: Sun Jan 15 21:02:10 2017
> New Revision: 292091
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292091&view=rev
> Log:
> Implement the missing constexpr stuff i
Author: hans
Date: Thu Jan 19 10:52:39 2017
New Revision: 292495
URL: http://llvm.org/viewvc/llvm-project?rev=292495&view=rev
Log:
Merging r292135:
r292135 | marshall | 2017-01-16 07:28:03 -0800 (Mon, 16 Jan 2017) | 1 line
M
Author: sgundapa
Date: Thu Jan 19 10:54:04 2017
New Revision: 292496
URL: http://llvm.org/viewvc/llvm-project?rev=292496&view=rev
Log:
[Hexagon] Linux linker does not support .gnu-hash
Hexagon Linux dynamic loader does not use (in fact does not support)
.gnu-hash
Differential Revision: https://r
On Tue, Jan 17, 2017 at 9:48 PM, Marshall Clow wrote:
> One is for libc++abi: r292135
Merged in r292495.
> The other two are for libc++:
> r292276
Eric merged this one.
> r292091
Merged in r292494.
Cheers,
Hans
___
cfe-commits mailing list
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D28902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: arphaman
Date: Thu Jan 19 11:17:57 2017
New Revision: 292497
URL: http://llvm.org/viewvc/llvm-project?rev=292497&view=rev
Log:
[Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode
rdar://28532840
Differential Revision: https://reviews.llvm.org/D25213
Added:
cfe/trun
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rL292497: [Sema] Fix PR28181 by avoiding calling
BuildOverloadedBinOp in C mode (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25213?
Author: malcolm.parsons
Date: Thu Jan 19 11:19:22 2017
New Revision: 292498
URL: http://llvm.org/viewvc/llvm-project?rev=292498&view=rev
Log:
[Sema] Reword unused lambda capture warning
Summary:
The warning doesn't know why the variable was looked up but not
odr-used, so reword it to not claim th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292498: [Sema] Reword unused lambda capture warning
(authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D28902?vs=84966&id=84984#toc
Repository:
rL LLVM
https://reviews.
As mentioned on cfe-dev as well, although it doesn't seem too critical it is
generally not logical to enable all extensions by default because most of the
targets don't even support OpenCL. But I understand your situation with using
x86 or ARM backends in a generic way. Do you think this can be
Hi Hans,
Would it be possible to merge this for 4.0?
Cheers,
Alex
On 19 January 2017 at 17:17, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Thu Jan 19 11:17:57 2017
> New Revision: 292497
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292497&view
zaks.anna added a comment.
> It is not supported to run the analyzer with some of the core checkers turned
> off.
Correct.
> Maybe we should change the behavior such that turning off core checkers turn
> off the warnings from those checkers but not the checkers themselves?
Having this as the
LegalizeAdulthood added a comment.
In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote:
> Don't do this without introducing an option to turn it off.
To clarify my reasoning:
You imposing your subjective idea of goodness on the code, i.e. style. Other
people will have differen
leanil added a comment.
In https://reviews.llvm.org/D28667#650585, @LegalizeAdulthood wrote:
> In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote:
>
> > Don't do this without introducing an option to turn it off.
>
>
> To clarify my reasoning:
> You imposing your subjective idea
LegalizeAdulthood added a comment.
In https://reviews.llvm.org/D28667#650586, @leanil wrote:
> In https://reviews.llvm.org/D28667#650585, @LegalizeAdulthood wrote:
>
> > In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote:
> >
> > > Don't do this without introducing an option to t
george.burgess.iv updated this revision to Diff 84988.
george.burgess.iv added a comment.
Sprinkle in a few `const`s, use `const auto *` in range for loops.
https://reviews.llvm.org/D28889
Files:
include/clang/Sema/Overload.h
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
lib/Sema/
Author: mren
Date: Thu Jan 19 13:05:55 2017
New Revision: 292508
URL: http://llvm.org/viewvc/llvm-project?rev=292508&view=rev
Log:
Module: Improve diagnostic message when cxx modules are disabled and @import is
used in Objective CXX.
rdar://problem/19399671
Added:
cfe/trunk/test/Modules/che
ahatanak added a comment.
Looks good to me, but one more comment/question.
Comment at: lib/Sema/SemaLookup.cpp:3433
+ // is not hidden by the using declaration.
+ if (isa(ND) && isa(D))
+continue;
Do we have to check that ND's UsingDecl is equ
leanil updated this revision to Diff 85014.
leanil added a comment.
Add config parameter to control new functionality.
Update the test cases accordingly.
https://reviews.llvm.org/D28667
Files:
clang-tidy/modernize/RawStringLiteralCheck.cpp
clang-tidy/modernize/RawStringLiteralCheck.h
test
Author: rsmith
Date: Thu Jan 19 15:00:13 2017
New Revision: 292518
URL: http://llvm.org/viewvc/llvm-project?rev=292518&view=rev
Log:
PR13403 (+duplicates): implement C++ DR1310 (http://wg21.link/cwg1310).
Under this defect resolution, the injected-class-name of a class or class
template cannot be
On 19 Jan 2017 11:16 am, "Manman Ren via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: mren
Date: Thu Jan 19 13:05:55 2017
New Revision: 292508
URL: http://llvm.org/viewvc/llvm-project?rev=292508&view=rev
Log:
Module: Improve diagnostic message when cxx modules are disabled and
@impor
On 19 Jan 2017 11:16 am, "Manman Ren via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: mren
Date: Thu Jan 19 13:05:55 2017
New Revision: 292508
URL: http://llvm.org/viewvc/llvm-project?rev=292508&view=rev
Log:
Module: Improve diagnostic message when cxx modules are disabled and
@impor
I think the supported extensions for a target should be as accurate as
possible, for it to be useful. Setting all extensions to be supported on all
targets will defeat its purpose.
I recommend to introduce "pocl" as an environment in the triple and add
supported OpenCL extensions for different
Author: hans
Date: Thu Jan 19 15:33:13 2017
New Revision: 292522
URL: http://llvm.org/viewvc/llvm-project?rev=292522&view=rev
Log:
Don't inline dllimport functions referencing non-imported methods
This is another follow-up to r246338. I had assumed methods were already
handled by the AST visitor,
Author: hans
Date: Thu Jan 19 15:57:56 2017
New Revision: 292524
URL: http://llvm.org/viewvc/llvm-project?rev=292524&view=rev
Log:
Merging r292418:
r292418 | jroelofs | 2017-01-18 10:12:39 -0800 (Wed, 18 Jan 2017) | 15 lines
dylanmckay updated this revision to Diff 85051.
dylanmckay marked 5 inline comments as done.
dylanmckay added a comment.
Code review from Aaron
- Use 'handleSimpleAttribute' rather than duplicating it
- Use 'auto' where a type is explicitly casted
- Add warnings for when the attribute is not on a
dylanmckay updated this revision to Diff 85052.
dylanmckay added a comment.
Remove a test for the 'naked' attribute
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/avr/
dylanmckay updated this revision to Diff 85053.
dylanmckay added a comment.
Add 'Subjects' field to 'AVRSignal'
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/avr/attr
dylanmckay added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5145
+if (!isFunctionOrMethod(D)) {
+ S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type)
+ << "'interrupt'" << ExpectedFunctionOrMethod;
I'm pretty sure that thi
Richard, what do you think?
On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote:
> Hi Hans,
>
> Would it be possible to merge this for 4.0?
>
> Cheers,
> Alex
>
> On 19 January 2017 at 17:17, Alex Lorenz via cfe-commits
> wrote:
>>
>> Author: arphaman
>> Date: Thu Jan 19 11:17:57 2017
>> New Revision:
Author: ericwf
Date: Thu Jan 19 17:48:05 2017
New Revision: 292539
URL: http://llvm.org/viewvc/llvm-project?rev=292539&view=rev
Log:
Adjust msvc_stdlib_force_include.hpp to handle clang++
Summary: This patch adjusts the newly added `msvc_stdlib_force_include.hpp` so
that it also works when used
jordan_rose created this revision.
The AST printer was dropping attributes on enumerators (enum constants). Now
it's not.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
Files:
lib/AST/DeclPrinter.cpp
test/Sema/ast-print.c
Index: test/Sema/ast-print.c
=
Author: ericwf
Date: Thu Jan 19 18:00:31 2017
New Revision: 292541
URL: http://llvm.org/viewvc/llvm-project?rev=292541&view=rev
Log:
Fix demangle helper after r286788
Modified:
libcxx/trunk/test/support/demangle.h
libcxx/trunk/test/support/test.support/test_demangle.pass.cpp
Modified: li
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though if you wanted to add one more test with a C++ attribute
(deprecated would work in C++14 mode), that would not make me sad. Something
like:
enum [[deprecated]] E {
jordan_rose added a comment.
Good idea, will do.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 01/08/2017 -
01/14/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the week of 01/01/2017 - 01/07/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: rsmith
Date: Thu Jan 19 18:20:39 2017
New Revision: 292545
URL: http://llvm.org/viewvc/llvm-project?rev=292545&view=rev
Log:
Finish implementation of C++ DR1310 (http://wg21.link/cwg1310).
Diagnose the case when a dependent template name instantiates to an
injected-class-name outside a ne
Author: rsmith
Date: Thu Jan 19 18:45:35 2017
New Revision: 292555
URL: http://llvm.org/viewvc/llvm-project?rev=292555&view=rev
Log:
P0426: Make the library implementation of constexpr char_traits a little easier
by providing a memchr builtin that returns char* instead of void*.
Also add a __has_
Author: rsmith
Date: Thu Jan 19 18:57:59 2017
New Revision: 292558
URL: http://llvm.org/viewvc/llvm-project?rev=292558&view=rev
Log:
Add documentation for constexpr string builtin support.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
h
EricWF created this revision.
This patch disables the aligned new/delet overloads on Apple platforms without
`posix_memalign`. This fixes libc++.dylib build regressions on such platforms.
This fixes http://llvm.org/PR31448.
This patch should also be merged into the 4.0 release branch
https://r
Author: rsmith
Date: Thu Jan 19 19:08:15 2017
New Revision: 292559
URL: http://llvm.org/viewvc/llvm-project?rev=292559&view=rev
Log:
Fix documentation typo.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
URL:
http://llvm.org/viewvc/llvm-proje
Hans, can we get this onto the Clang 4 release branch (along with the
documentation added in r292558 and fixed in r292559)? This will allow us to
avoid libc++ carrying a version test for Clang, and allow it to cleanly
finish off its implementation of P0426.
On 19 January 2017 at 16:45, Richard Smi
Author: ericwf
Date: Thu Jan 19 19:13:49 2017
New Revision: 292560
URL: http://llvm.org/viewvc/llvm-project?rev=292560&view=rev
Log:
[NFC] Group aligned new/delete definitions together in new.cpp
This patch is cleanup to prepare for future changes
Modified:
libcxx/trunk/src/new.cpp
Modified
jordan_rose added a comment.
Interestingly, this case doesn't actually work yet; we unconditionally print
enum attributes after the close-brace even though that's not valid for C++
attributes. Do you think I should change that as well, or just land this patch
as is?
Repository:
rL LLVM
htt
EricWF updated this revision to Diff 85072.
EricWF added a comment.
- Remove NFC parts of this patch and commit them to master.
https://reviews.llvm.org/D28931
Files:
include/__config
include/new
src/new.cpp
Index: src/new.cpp
Author: rsmith
Date: Thu Jan 19 19:19:46 2017
New Revision: 292561
URL: http://llvm.org/viewvc/llvm-project?rev=292561&view=rev
Log:
PR31701: Fix crash on invalid caused by parsing a dependent initializer when we
don't know we're in a dependent context.
Modified:
cfe/trunk/lib/AST/ASTContext.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292562: clang-format: fix fallback style set to "none" not
always formatting (authored by amaiorano).
Changed prior to commit:
https://reviews.llvm.org/D28844?vs=84795&id=85074#toc
Repository:
rL LLV
Author: amaiorano
Date: Thu Jan 19 19:22:42 2017
New Revision: 292562
URL: http://llvm.org/viewvc/llvm-project?rev=292562&view=rev
Log:
clang-format: fix fallback style set to "none" not always formatting
This fixes clang-format not formatting if fallback-style is explicitly set to
"none", and ei
aaron.ballman added a comment.
In https://reviews.llvm.org/D28924#651139, @jordan_rose wrote:
> Interestingly, this case doesn't actually work yet; we unconditionally print
> enum attributes after the close-brace even though that's not valid for C++
> attributes. Do you think I should change th
EricWF added a comment.
In https://reviews.llvm.org/D28785#650101, @compnerd wrote:
> While I love this direction (the original version really was an
> unintelligible pile of code), I really think that this change may be taking
> on too much. Why not split it up first and do nothing else. We
jlebar updated this revision to Diff 85076.
jlebar added a comment.
Remove (broken) implementations of removed intrinsics from clang.
We realized we don't need this, as none of these intrinsics are accessible to
user code in nvcc.
https://reviews.llvm.org/D28793
Files:
clang/lib/Headers/__cl
jlebar marked 4 inline comments as done.
jlebar added a comment.
Sorry about that broken code in the clang headers. All removed now; we
established it's not needed. PHAL.
https://reviews.llvm.org/D28793
___
cfe-commits mailing list
cfe-commits@li
EricWF updated this revision to Diff 85080.
EricWF added a comment.
- Remove `` include in place of defining the required macros
manually.
https://reviews.llvm.org/D28931
Files:
include/__config
include/new
src/new.cpp
Index: src/new.cpp
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
EricWF updated this revision to Diff 85082.
EricWF added a comment.
- Move `__config` block lower down in the file as suggested by Marshall.
https://reviews.llvm.org/D28931
Files:
include/__config
include/new
src/new.cpp
Index: src/new.cpp
===
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: ericwf
Date: Thu Jan 19 19:47:26 2017
New Revision: 292564
URL: http://llvm.org/viewvc/llvm-project?rev=292564&view=rev
Log:
Disable aligned new/delete on Apple platforms without posix_memalign
Summary:
This patch disables the aligned new/delet overloads on Apple platforms without
`posix
Hi Hans,
Marshall gave this commit and r292560 permission to be merged into 4.0,
which I will being doing shortly.
/Eric
On Thu, Jan 19, 2017 at 6:47 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Thu Jan 19 19:47:26 2017
> New Revision: 292564
>
Author: ericwf
Date: Thu Jan 19 19:52:28 2017
New Revision: 292565
URL: http://llvm.org/viewvc/llvm-project?rev=292565&view=rev
Log:
Merge r292560 - [NFC] Group aligned new/delete definitions together in new.cpp
Modified:
libcxx/branches/release_40/src/new.cpp
Modified: libcxx/branches/relea
Author: ericwf
Date: Thu Jan 19 19:54:53 2017
New Revision: 292566
URL: http://llvm.org/viewvc/llvm-project?rev=292566&view=rev
Log:
Merge r292564 - Disable aligned new/delete on Apple platforms without
posix_memalign
This patch disables the aligned new/delet overloads on Apple platforms without
Merged.
Relevant commits:
* r292566 - Merge r292564
* r292565 - Merge r292560
/Eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gparker
Date: Thu Jan 19 20:12:22 2017
New Revision: 292568
URL: http://llvm.org/viewvc/llvm-project?rev=292568&view=rev
Log:
[test] Remove an unwanted match for `UNSUPPORTED:`.
Modified:
cfe/trunk/test/Driver/embed-bitcode.c
Modified: cfe/trunk/test/Driver/embed-bitcode.c
URL:
http
rsmith added a comment.
Does OS X have the C11 `aligned_alloc` function? Perhaps we could use that
instead, when available.
https://reviews.llvm.org/D28931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
On 19 January 2017 at 15:52, Hans Wennborg wrote:
> Richard, what do you think?
Yes, let's merge this.
> On Thu, Jan 19, 2017 at 9:34 AM, Alex L wrote:
> > Hi Hans,
> >
> > Would it be possible to merge this for 4.0?
> >
> > Cheers,
> > Alex
> >
> > On 19 January 2017 at 17:17, Alex Lorenz v
gparker42 added a comment.
No, the old versions of OS X that lack `posix_memalign` also lack
`aligned_alloc`.
https://reviews.llvm.org/D28931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
mclow.lists created this revision.
In C++11/14, the return type of `emplace_front` and `emplace_back` was `void`.
In http://wg21.link/p0084, Alan Talbot proposed changing the return type to
return a reference to the newly created element.
We implemented that - but unilaterally.
This changes th
Author: jrose
Date: Thu Jan 19 21:33:42 2017
New Revision: 292571
URL: http://llvm.org/viewvc/llvm-project?rev=292571&view=rev
Log:
[AST Printer] Print attributes on enum constants
The AST printer was dropping attributes on enumerators (enum
constants). Now it's not.
Modified:
cfe/trunk/lib/
jordan_rose closed this revision.
jordan_rose added a comment.
Landed as-is in https://reviews.llvm.org/rL292571.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
compnerd added inline comments.
Comment at: test/builtins/Unit/clear_cache_test.c:71
+char* start = (char*)((uintptr_t)execution_buffer & (-get_page_size()));
+char* end = (char*)((uintptr_t)(&execution_buffer[128+4096]) &
(-get_page_size()));
#if defined(_WIN32)
--
Author: ericwf
Date: Thu Jan 19 22:39:17 2017
New Revision: 292577
URL: http://llvm.org/viewvc/llvm-project?rev=292577&view=rev
Log:
Refactor unique_ptr/shared_ptr deleter test types into single header.
Added:
libcxx/trunk/test/support/deleter_types.h
- copied, changed from r292564,
li
ahatanak added reviewers: ABataev, malcolm.parsons.
ahatanak added a comment.
Add a few more people who have looked at this part of clang in the past to the
reviewers list.
https://reviews.llvm.org/D25556
___
cfe-commits mailing list
cfe-commits@li
EricWF created this revision.
Exactly what the title says.
This patch also adds a `std::hash` specialization in C++17, but it
was not added by this paper and I can't find the actual paper that adds it.
See http://wg21.link/P0513R0 for more info.
If there are no comments in the next couple of d
Author: ericwf
Date: Fri Jan 20 00:27:34 2017
New Revision: 292582
URL: http://llvm.org/viewvc/llvm-project?rev=292582&view=rev
Log:
Still expose std::align_val_t in C++17 even if we don't have aligned new/delete.
r292564 disabled the aligned new/delete overloads on platforms without
posix_memali
1 - 100 of 103 matches
Mail list logo
