pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added inline comments.
This revision now requires changes to proceed.
Comment at: docs/UsersManual.rst:2065
+
+ $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl
+
---
hokein updated this revision to Diff 84639.
hokein marked 2 inline comments as done.
hokein added a comment.
Add more tests.
https://reviews.llvm.org/D28774
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/macro_helper_test.cpp
test/clang-move/Inputs/macro_helper_test.h
test/clang
smeenai added a comment.
I really like the cleanup, but I'm not the biggest fan of taking more Microsoft
dependencies than necessary. I don't see any way around `operator
new`/`operator delete` (since replacement in COFF can only work with a static
library with one function per object file, the
Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.
Do you have some results from running it on LLVM? If nothing crashes and all
fixit are correct then LGTM.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:27-3
It's by design. Do we want to change this? I always had the impression
turning on the state changes for the list is a bit noisy, but I'm happy if
that's not the general sentiment.
On Mon, Jan 16, 2017, 11:07 PM Benjamin Kramer wrote:
I got an email where it says that I accepted the revision. Loo
aaboud added a comment.
Richard, can you please review the new patch?
https://reviews.llvm.org/D16135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere added a comment.
In https://reviews.llvm.org/D28768#647949, @Prazek wrote:
> Do you have some results from running it on LLVM? If nothing crashes and all
> fixit are correct then LGTM.
There's still an issue with type narrowing, which is allowed in regular
constructor but not in
EricWF added inline comments.
Comment at: include/exception:85
+#if defined(_LIBCPP_ABI_MICROSOFT)
+#include
smeenai wrote:
> What's the rationale for relying on Microsoft's exception implementation
> rather than libc++'s?
`vcruntime_new.h` brings in `vcrunti
EricWF added inline comments.
Comment at: include/new:177
+#if !defined(_LIBCPP_ABI_MICROSOFT)
+
EricWF wrote:
> smeenai wrote:
> > Might be helpful to have a comment explaining why we wanna defer these to
> > msvcrt on Windows?
> >
> > Also, VS 2015 doesn't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292207: [clang-move] Ignore using decls which are defined in
macros. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D28774?vs=84639&id=84643#toc
Repository:
rL LLVM
https://
Author: hokein
Date: Tue Jan 17 04:08:11 2017
New Revision: 292207
URL: http://llvm.org/viewvc/llvm-project?rev=292207&view=rev
Log:
[clang-move] Ignore using decls which are defined in macros.
Summary:
Also ignore helpers which are defined in macro. Currently clang-move doesn't
handle macro well
If we add all state transitions it will only create noise. I will
teach myself to always write "lg" into the text field when approving a
change instead.
On Tue, Jan 17, 2017 at 9:57 AM, Manuel Klimek via cfe-commits
wrote:
> It's by design. Do we want to change this? I always had the impression
>
krasimir created this revision.
Tests under tools/llvm-objdump should not use inputs from Object. Copied the
required inputs and aligned the new tests to be more consistent with the
existing
tests in this respect.
https://reviews.llvm.org/D28799
Files:
test/tools/llvm-objdump/X86/Inputs/open
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: test/clang-tidy/modernize-return-braced-init-list.cpp:132
+auto v1 = []() { return vector({1, 2}); }();
+auto v2 = []() -> vector { return vector({1
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
@davide I think this change makes sense. I'll accept this to unbreak our
internal build. Let us know if you have any concern.
https://reviews.llvm.org/D28799
__
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:44
+} else {
+ /* If a single one is not valid, we cannot apply the fix as we need to
+ *
hokein created this revision.
https://reviews.llvm.org/D28801
Files:
clang-move/ClangMove.cpp
clang-move/HelperDeclRefGraph.cpp
test/clang-move/Inputs/helper_decls_test.cpp
test/clang-move/Inputs/helper_decls_test.h
test/clang-move/move-used-helper-decls.cpp
Index: test/clang-move/move
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm.
https://reviews.llvm.org/D28801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: hokein
Date: Tue Jan 17 07:22:37 2017
New Revision: 292215
URL: http://llvm.org/viewvc/llvm-project?rev=292215&view=rev
Log:
[clang-move] Handle helpers with forward declarations.
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292215: [clang-move] Handle helpers with forward
declarations. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D28801?vs=84655&id=84659#toc
Repository:
rL LLVM
https://review
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A few more comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:153
+ const SourceRange FVLoc(DeclStmt->getLocStart(), Location);
+ std::st
ABataev added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:84-115
+/// Lexical scope for OpenMP parallel construct, that handles correct codegen
+/// for captured expressions.
+class OMPParallelScope final : public CodeGenFunction::LexicalScope {
+ void emitPreInitS
Author: hokein
Date: Tue Jan 17 07:46:59 2017
New Revision: 292218
URL: http://llvm.org/viewvc/llvm-project?rev=292218&view=rev
Log:
Remove dead code.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp
URL:
http://llvm.org/v
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:543
virtual llvm::Value *emitParallelOrTeamsOutlinedFunction(
- const OMPExecutableDirective &D, const VarDecl *ThreadIDVar,
- OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);
This revision was automatically updated to reflect the committed changes.
Closed by commit rL29: [llvm-objdump tests] Copy the inputs of tests closer
to tests. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D28799?vs=84653&id=84667#toc
Repository:
rL LLVM
http
On Tue, Jan 17, 2017 at 12:57 AM Manuel Klimek wrote:
> It's by design. Do we want to change this? I always had the impression
> turning on the state changes for the list is a bit noisy, but I'm happy if
> that's not the general sentiment.
>
For approval it's important that that reaches the maili
grimar created this revision.
https://reviews.llvm.org/D28684 changed llvm::zlib to return Error instead of
Status.
It was accepted and committed in r292214, but then reverted in r292217
because I missed that clang code also needs to be updated.
Patch do that.
https://reviews.llvm.org/D28807
LGTM
George Rimar via Phabricator writes:
> grimar created this revision.
>
> https://reviews.llvm.org/D28684 changed llvm::zlib to return Error instead of
> Status.
> It was accepted and committed in r292214, but then reverted in r292217
> because I missed that clang code also needs to be upda
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292227: [Clang] - Update code to match upcoming llvm::zlib
API. (authored by grimar).
Changed prior to commit:
https://reviews.llvm.org/D28807?vs=84669&id=84676#toc
Repository:
rL LLVM
https://revie
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:543
virtual llvm::Value *emitParallelOrTeamsOutlinedFunction(
- const OMPExecutableDirective &D, const VarDecl *ThreadIDVar,
- OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &Code
Author: alexfh
Date: Tue Jan 17 10:14:03 2017
New Revision: 292229
URL: http://llvm.org/viewvc/llvm-project?rev=292229&view=rev
Log:
[clang-tidy] Fix crash in modernize-use-using (http://llvm.org/PR29135)
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseUsingCheck.cpp
clang-tools
Author: grimar
Date: Tue Jan 17 09:45:31 2017
New Revision: 292227
URL: http://llvm.org/viewvc/llvm-project?rev=292227&view=rev
Log:
[Clang] - Update code to match upcoming llvm::zlib API.
D28684 changed llvm::zlib to return Error instead of Status.
It was accepted and committed in r292214, but t
malcolm.parsons added a comment.
This fixes PR24967.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
Sorry for the delay in replying.
Comment at: lib/Serialization/ASTReaderDecl.cpp:2715
return (FuncX->getLinkageInternal() == FuncY->getLinkageInternal()) &&
FuncX->getASTContext().hasSameType(FuncX->getType(), FuncY->getType());
}
--
Hi Hans,
Could this go into the stable branch ?
On Sat, Jan 14, 2017 at 10:11 PM, Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: akirtzidis
> Date: Sun Jan 15 00:11:04 2017
> New Revision: 292052
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292052&view=rev
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
This patch changes the language design of the atomic builtins, which is outside
the normal scope of patch review. You need to post an RFC to cfe-dev. I've
gone ahead and made s
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:543
virtual llvm::Value *emitParallelOrTeamsOutlinedFunction(
- const OMPExecutableDirective &D, const VarDecl *ThreadIDVar,
- OpenMPDirectiveKind InnermostKind, const RegionCodeGenTy &CodeGen);
yaxunl added a comment.
In https://reviews.llvm.org/D28691#648267, @rjmccall wrote:
> This patch changes the language design of the atomic builtins, which is
> outside the normal scope of patch review. You need to post an RFC to
> cfe-dev. I've gone ahead and made some material comments, but
yaxunl added a comment.
The link for the RFC:
http://lists.llvm.org/pipermail/cfe-dev/2017-January/052304.html
https://reviews.llvm.org/D28691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
arpith-jacob updated this revision to Diff 84689.
arpith-jacob added a comment.
The patch was updated to split 'emitParallelOrTeamsOutlinedFunction' into
'emitParallelOutlinedFunction' and 'emitTeamsOutlinedFunction' to enable the
use of getCapturedStmt().
Also updated an assert statement for c
Author: phst
Date: Tue Jan 17 11:30:55 2017
New Revision: 292234
URL: http://llvm.org/viewvc/llvm-project?rev=292234&view=rev
Log:
Make sure that clang-format input is in the right encoding
Summary: Add unit tests.
Reviewers: klimek, massberg
Reviewed By: massberg
Differential Revision: https:
rnk accepted this revision.
rnk added a comment.
lgtm
https://reviews.llvm.org/D28705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia created this revision.
ObjC IR generation for Blocks currently:
I. Generates local to block variable declaration block literal in case it
contains captures.
II. Global variable block literal in case it doesn't have any captures.
The address spaces are missing however if we use this gen
beanz added inline comments.
Comment at: cfe/trunk/CMakeLists.txt:531
+ if(BOOTSTRAP_LLVM_ENABLE_LLD)
+add_dependencies(clang-bootstrap-deps lld)
+ elseif(LLVM_BINUTILS_INCDIR)
mehdi_amini wrote:
> I come back to this a bit late, sorry, but I'm
davide added a comment.
In https://reviews.llvm.org/D28799#648062, @ioeric wrote:
> @davide I think this change makes sense. I'll accept this to unbreak our
> internal build. Let us know if you have any concern.
Yes, makes sense. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D28799
JDevlieghere updated this revision to Diff 84700.
JDevlieghere added a comment.
- Added test cases suggested by @Prazek
- Added test cases suggested by @alexfh
I don't match on `CXXUnresolvedConstructExpr` so the template dependent cases
are not impacted by this check. This is what I intended, b
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:84-115
+/// Lexical scope for OpenMP parallel construct, that handles correct codegen
+/// for captured expressions.
+class OMPParallelScope final : public CodeGenFunction::LexicalScope {
+ void emitPre
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:84-115
+/// Lexical scope for OpenMP parallel construct, that handles correct codegen
+/// for captured expressions.
+class OMPParallelScope final : public CodeGenFunction::LexicalScope {
+ void emitPre
Anastasia added inline comments.
Comment at: docs/UsersManual.rst:2065
+
+ $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl
+
pekka.jaaskelainen wrote:
> Is this correct? I cannot make it work:
>
> ```
> ~/local/stow/llvm-4.0-unpatche
sfertile added a comment.
I think the fix/test looks good, but someone with more experience than me
should review it before accepting it
https://reviews.llvm.org/D28620
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
arpith-jacob added a comment.
Another correction. We'll have to create a similar scope OMPTeamsScope that
inherits from OMPLexicalScope for target-teams combined directives.
https://reviews.llvm.org/D28781
___
cfe-commits mailing list
cfe-commits@
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
I don't have any particular ownership or knowledge of this file, but the change
still LGTM
https://reviews.llvm.org/D28146
___
cfe-commits mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292245: [Sema] Fix bug in handling of designated
initializer. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D28705?vs=84418&id=84714#toc
Repository:
rL LLVM
https://revie
Author: ahatanak
Date: Tue Jan 17 13:35:54 2017
New Revision: 292245
URL: http://llvm.org/viewvc/llvm-project?rev=292245&view=rev
Log:
[Sema] Fix bug in handling of designated initializer.
CheckDesignatedInitializer wasn't taking into account the base classes
when computing the index for the fiel
jroelofs created this revision.
Herald added a subscriber: aemerson.
The idea for this originated from a really tricky bug: ISRs on ARM don't
automatically save off the VFP regs, so if say, memcpy gets interrupted and the
ISR itself calls memcpy, the regs are left clobbered when the ISR is done.
phosek created this revision.
Herald added a subscriber: mgorny.
These two are options independent: it's possible to use LLD without LTO, and
it's possible to do LTO build without LLD.
Repository:
rL LLVM
https://reviews.llvm.org/D28821
Files:
CMakeLists.txt
Index: CMakeLists.txt
==
phosek added inline comments.
Comment at: cfe/trunk/CMakeLists.txt:531
+ if(BOOTSTRAP_LLVM_ENABLE_LLD)
+add_dependencies(clang-bootstrap-deps lld)
+ elseif(LLVM_BINUTILS_INCDIR)
beanz wrote:
> mehdi_amini wrote:
> > I come back to this a bit lat
Author: jbcoe
Date: Tue Jan 17 14:03:54 2017
New Revision: 292247
URL: http://llvm.org/viewvc/llvm-project?rev=292247&view=rev
Log:
Fix Python 3 language issues and add an explicit check for Python version == 2.
Summary:
Python bindings cannot support Python 3 without work being done to fix Unico
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Many thanks for the quick cleanup! LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D28821
___
cfe-commits mailing list
cfe-commits@lists.llvm
mehdi_amini added a comment.
Yes, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D28821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:961
+// then incorrectly applied to the target declaration. This can be avoided
+// by resetting the declaration that's being hidden.
+if (Hiding && isa(Hiding))
I'm not sure ab
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292257: [test] [builtins] Remove obsolete/UB tests in
__fixuns?fdi based (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28146?vs=82625&id=84737#toc
Repository:
rL LLVM
http
dim added inline comments.
Comment at: include/__threading_support:43
+#if defined(__clang__) && __has_attribute(acquire_capability)
+#define _LIBCPP_THREAD_SAFETY_ATTRIBUTE(x) __attribute__((x))
I think the least intrusive way would be to add a `defined(__Free
Author: hans
Date: Tue Jan 17 15:31:57 2017
New Revision: 292265
URL: http://llvm.org/viewvc/llvm-project?rev=292265&view=rev
Log:
UsersManual.rst: add missing newline
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-project/
Author: rengolin
Date: Tue Jan 17 15:37:24 2017
New Revision: 292268
URL: http://llvm.org/viewvc/llvm-project?rev=292268&view=rev
Log:
[xray] try to fix thumb buildbot
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewvc/llvm-project/
Author: djg
Date: Tue Jan 17 15:46:38 2017
New Revision: 292269
URL: http://llvm.org/viewvc/llvm-project?rev=292269&view=rev
Log:
[WebAssembly] Add minimal support for the new wasm object format triple.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/CodeGen/BackendUtil.cpp
cf
zaks.anna added a comment.
From what I recall, it is not clear that this patch is the step in the right
direction. At least, it need more investigation.
https://reviews.llvm.org/D27202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
tra added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:124
+}
+inline long long __nvvm_max_i(long long __a, long long __b) {
+ return __a >= __b ? __a : __b;
Shouldn't that be `_ll` ? That was the name of the max of long long arg
Author: ericwf
Date: Tue Jan 17 16:10:32 2017
New Revision: 292276
URL: http://llvm.org/viewvc/llvm-project?rev=292276&view=rev
Log:
Fix std::string assignment ambiguity from braced initializer lists.
When support for `basic_string_view` was added to string it also
added new assignment operators
Hi Marshall,
We should merge this fix into the 4.0 release.
It fixes a regression which was reported by the FreeBSD maintainers here:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216177
Am I OK to merge this?
/Eric
On Tue, Jan 17, 2017 at 3:10 PM, Eric Fiselier via cfe-commits <
cfe-commit
Author: stl_msft
Date: Tue Jan 17 16:24:45 2017
New Revision: 292281
URL: http://llvm.org/viewvc/llvm-project?rev=292281&view=rev
Log:
[libcxx] [test] Don't ask whether Incomplete& can be assigned to.
This is the subject of an active NB comment. Regardless of what the Working
Paper currently says
delesley added a comment.
Sorry about the slow response. My main concern here is that the thread safety
analysis was designed for use with a library that wraps the system mutex in a
separate Mutex class. We did that specifically to avoid breaking anything;
code has to opt-in to the static ch
Author: ericwf
Date: Tue Jan 17 17:27:56 2017
New Revision: 292291
URL: http://llvm.org/viewvc/llvm-project?rev=292291&view=rev
Log:
Don't strip -m32 from the user provide command line flags. This fixes the
compiler-rt 32 bit sanitizer build
Modified:
libcxx/trunk/CMakeLists.txt
Modified: l
bruno created this revision.
Diagnostics related to redefinition errors that point to the same header file
do not provide much information that helps fixing the issue. In modules context
it usually happens because of a non modular include, in non-module context it
might happen because of the la
Author: ericwf
Date: Tue Jan 17 17:41:42 2017
New Revision: 292294
URL: http://llvm.org/viewvc/llvm-project?rev=292294&view=rev
Log:
Fix type_info's constructor by making it explicit again.
In recent changes type_info's private constructor was
accidentally made implicit. This patch fixes that.
M
FYI Once the bots finish checking this commit I'm going to merge this into
the 4.0 branch.
This fixes a very recently introduced regression.
/Eric
On Tue, Jan 17, 2017 at 4:41 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Tue Jan 17 17:41:42 201
Author: ericwf
Date: Tue Jan 17 18:05:01 2017
New Revision: 292297
URL: http://llvm.org/viewvc/llvm-project?rev=292297&view=rev
Log:
Allow sym_diff.py to report non-zero for non-breaking ABI changes
Modified:
libcxx/trunk/lib/abi/CMakeLists.txt
libcxx/trunk/utils/sym_check/sym_check/diff.
Richard, what do you think?
On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote:
> I would love to see this merged. It would make it easier to write libc++
> tests if the tests didn't have to worry about the old 4.0 behavior.
>
> CC'ing Richard: Would merging this be OK?
>
> On Fri, Jan 13, 2017
EricWF updated this revision to Diff 84770.
EricWF added a comment.
Herald added a subscriber: mgorny.
- Allow standalone libc++ build on OS X to default to using `libc++abi`.
https://reviews.llvm.org/D28785
Files:
CMakeLists.txt
include/exception
include/new
include/typeinfo
src/exce
Yes, go ahead.
Apologies for the delay.
- Hans
On Sat, Jan 14, 2017 at 5:54 AM, Eric Fiselier wrote:
> +1 from me. @Hans am I OK to merge this?
>
> On Sat, Jan 14, 2017 at 4:53 AM, Hahnfeld, Jonas
> wrote:
>>
>> Hi Hans,
>>
>> can this be merged for 4.0? Eric suggested this in
>> https://revi
Author: ericwf
Date: Tue Jan 17 18:14:31 2017
New Revision: 292309
URL: http://llvm.org/viewvc/llvm-project?rev=292309&view=rev
Log:
Merge r292294: Fix type_info's constructor by making it explicit again.
In recent changes type_info's private constructor was accidentally made
implicit. This patch
Merged into the 4.0 branch in r292309.
On Tue, Jan 17, 2017 at 4:55 PM, Eric Fiselier wrote:
> FYI Once the bots finish checking this commit I'm going to merge this into
> the 4.0 branch.
>
> This fixes a very recently introduced regression.
>
> /Eric
>
> On Tue, Jan 17, 2017 at 4:41 PM, Eric Fi
@Jonas please go ahead and merge this patch.
On Tue, Jan 17, 2017 at 5:24 PM, Hans Wennborg wrote:
> Yes, go ahead.
>
> Apologies for the delay.
>
> - Hans
>
> On Sat, Jan 14, 2017 at 5:54 AM, Eric Fiselier wrote:
> > +1 from me. @Hans am I OK to merge this?
> >
> > On Sat, Jan 14, 2017 at 4:5
On Sat, Jan 14, 2017 at 1:26 PM, Dimitry Andric wrote:
> On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits
> wrote:
>> Author: yrnkrn
>> Date: Sat Jan 14 15:12:08 2017
>> New Revision: 292032
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev
>> Log:
>> Fix PR31644 introduced
Merged in r292313.
Thanks,
Hans
On Tue, Jan 17, 2017 at 8:56 AM, Argyrios Kyrtzidis wrote:
> Hi Hans,
>
> Could this go into the stable branch ?
>
> On Sat, Jan 14, 2017 at 10:11 PM, Argyrios Kyrtzidis via cfe-commits
> wrote:
>>
>> Author: akirtzidis
>> Date: Sun Jan 15 00:11:04 2017
>> New Re
GorNishanov created this revision.
Herald added a subscriber: mehdi_amini.
Sema::CheckCompletedCoroutineBody was growing unwieldy with building all of the
substatements. Also, constructors for CoroutineBodyStmt had way too many
parameters.
Instead, CoroutineBodyStmt now defines CtorArgs struct
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM
Manman
https://reviews.llvm.org/D28790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM
Manman
https://reviews.llvm.org/D28779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Thank you!
> On Jan 17, 2017, at 4:35 PM, Hans Wennborg wrote:
>
> Merged in r292313.
>
> Thanks,
> Hans
>
> On Tue, Jan 17, 2017 at 8:56 AM, Argyrios Kyrtzidis wrote:
>> Hi Hans,
>>
>> Could this go into the stable branch ?
>>
>> On Sat, Jan 14, 2017 at 10:11 PM, Argyrios Kyrtzidis via cfe
Author: djg
Date: Tue Jan 17 19:03:35 2017
New Revision: 292324
URL: http://llvm.org/viewvc/llvm-project?rev=292324&view=rev
Log:
[WebAssembly] Update grow_memory's return type.
The grow_memory instruction now returns the previous memory size. Add the
return type to the clang intrinsic.
Modified
STL_MSFT created this revision.
[libcxx] [test] Fix MSVC warnings C4127 and C6326 about constants.
MSVC has compiler warnings C4127 "conditional expression is constant" (enabled
by /https://reviews.llvm.org/W4) and C6326 "Potential comparison of a constant
with another constant"
(enabled by /ana
Author: ericwf
Date: Tue Jan 17 19:48:54 2017
New Revision: 292326
URL: http://llvm.org/viewvc/llvm-project?rev=292326&view=rev
Log:
Add support for running our test suite against MSVC's STL
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/thread/thread.mutex/threa
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The changes sure look funny but I have no issue with them.
https://reviews.llvm.org/D28837
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: ctopper
Date: Tue Jan 17 20:17:10 2017
New Revision: 292329
URL: http://llvm.org/viewvc/llvm-project?rev=292329&view=rev
Log:
[AVX-512] Replace subvector broadcast builtins with shufflevectors and selects.
Verified that the backend codegens this equally well.
Modified:
cfe/trunk/incl
pcc created this revision.
This is the final change necessary to support CFI with ThinLTO.
TODO: avoid breaking Darwin.
Depends on https://reviews.llvm.org/D28840
https://reviews.llvm.org/D28843
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGenCXX/type-metadata-thinlto.cpp
Inde
Author: awatry
Date: Tue Jan 17 21:13:37 2017
New Revision: 292334
URL: http://llvm.org/viewvc/llvm-project?rev=292334&view=rev
Log:
math: Add expm1 builtin function
Ported from the amd-builtins branch.
Signed-off-by: Aaron Watry
Reviewed-by: Matt Arsenault
CC: Tom Stellard
Added:
libclc
Author: awatry
Date: Tue Jan 17 21:14:10 2017
New Revision: 292335
URL: http://llvm.org/viewvc/llvm-project?rev=292335&view=rev
Log:
math: Add logb builtin
Ported from the amd-builtins branch.
Signed-off-by: Aaron Watry
Reviewed-by: Matt Arsenault
CC: Tom Stellard
Added:
libclc/trunk/gen
amaiorano created this revision.
This change fixes the fact that fallback style set to "none" should not format.
Without this change, fallback style "none" ends up applying LLVM formatting.
https://reviews.llvm.org/D28844
Files:
lib/Format/Format.cpp
test/Format/style-on-command-line.cpp
amaiorano added inline comments.
Comment at: lib/Format/Format.cpp:1906
- // FIXME: If FallbackStyle is explicitly "none", format is disabled.
- if (!getPredefinedStyle(FallbackStyle, Style.Language, &Style))
-return make_string_error("Invalid fallback style \"" +
Fallba
1 - 100 of 120 matches
Mail list logo
