Prazek updated this revision to Diff 84489.
Prazek added a comment.
suggested fix
https://reviews.llvm.org/D28727
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++ docs/UsersManual.rst
@@
Prazek updated this revision to Diff 84491.
Prazek added a comment.
Added link to documentation
https://reviews.llvm.org/D28606
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++ docs/Re
Prazek updated this revision to Diff 84492.
Prazek added a comment.
Removed [no-] so hyperlink would work
https://reviews.llvm.org/D28727
Files:
docs/UsersManual.rst
Index: docs/UsersManual.rst
===
--- docs/UsersManual.rst
+++
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
> In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> >
> > > As discussed with
ioeric added a comment.
In https://reviews.llvm.org/D28672#646336, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D28672#646151, @aaron.ballman wrote:
>
> > I'm not seeing anything wrong, per se, but why has so much of this file
> > changed recently?
>
>
> The script looks for doxygen doc
RKSimon abandoned this revision.
RKSimon added a comment.
Abandoning this - unless we have a way to known when to automatically insert
emms/femms then its not safe to do this.
Repository:
rL LLVM
https://reviews.llvm.org/D12340
___
cfe-commits m
Prazek created this revision.
Prazek added reviewers: tejohnson, mehdi_amini, hans.
Prazek added a subscriber: cfe-commits.
It would be good to also mention
other improvements in ThinLTO for 4.0 release
https://reviews.llvm.org/D28746
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rs
Prazek added a comment.
Maybe I should change ThinLTO for '-flto=thin' and also mention this
improvement in LLVM release notes?
BTW '-flto=thin' is not documented in UsersManual
https://reviews.llvm.org/D28746
___
cfe-commits mailing list
cfe-comm
mehdi_amini added inline comments.
Comment at: docs/ReleaseNotes.rst:69
+ called from cold callsite.
+
We need to mention ThinLTO in the Release Notes, so thanks for initiating this.
We likely should go with a paragraph summarizing the improvements, I don't k
On Sun, Jan 15, 2017 at 1:00 PM, Eric Liu via Phabricator
wrote:
> ioeric added a comment.
>
> In https://reviews.llvm.org/D28672#646336, @malcolm.parsons wrote:
>
>> In https://reviews.llvm.org/D28672#646151, @aaron.ballman wrote:
>>
>> > I'm not seeing anything wrong, per se, but why has so much
I've sent an email to cfe-dev (and Tanya) about this. And this patch will
be abandoned since it doesn't fix anything.
On Sun, Jan 15, 2017 at 10:04 PM Aaron Ballman
wrote:
> On Sun, Jan 15, 2017 at 1:00 PM, Eric Liu via Phabricator
> wrote:
> > ioeric added a comment.
> >
> > In https://reviews
On Sun, Jan 15, 2017 at 4:19 PM, Eric Liu wrote:
> I've sent an email to cfe-dev (and Tanya) about this. And this patch will be
> abandoned since it doesn't fix anything.
Thank you for taking care of this!
~Aaron
>
> On Sun, Jan 15, 2017 at 10:04 PM Aaron Ballman
> wrote:
>>
>> On Sun, Jan 15,
amaiorano added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:892
+ llvm::errs() << llvm::toString(Style.takeError()) << "\n";
+ continue;
+}
amaiorano wrote:
> amaiorano wrote:
> > ioeric wrote:
> > > I'd still like to apply rep
tejohnson added a comment.
In https://reviews.llvm.org/D28746#646793, @Prazek wrote:
> Maybe I should change ThinLTO for '-flto=thin' and also mention this
> improvement in LLVM release notes?
>
> BTW '-flto=thin' is not documented in UsersManual
It's documented here:
http://clang.llvm.org/
Prazek updated this revision to Diff 84503.
Prazek added a comment.
update
https://reviews.llvm.org/D28746
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++ docs/ReleaseNotes.rst
@@ -63
Prazek marked 2 inline comments as done.
Prazek added a comment.
Cool, This still might require some small fixes - I haven't generate docs for
it, so I will check it before release.
https://reviews.llvm.org/D28746
___
cfe-commits mailing list
cfe-c
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Comment at: docs/ReleaseNotes.rst:70
+
+ - Integration with profile data. When available, profile data enables mo
Prazek updated this revision to Diff 84504.
Prazek marked an inline comment as done.
Prazek added a comment.
(PGO)
https://reviews.llvm.org/D28746
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNo
Prazek added a comment.
Shoud I add the same note to LLVM Release notes?
https://reviews.llvm.org/D28746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
Oh I didn't notice that we were in the clang Release Notes, actually I've only
updated the LLVM ones in the past.
So yes, I think this should be in LLVM as well, I don't know if it should
differ in some way?
https://reviews.llvm.org/D28746
_
Prazek added a comment.
In https://reviews.llvm.org/D28729#646758, @aaron.ballman wrote:
> In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
>
> > In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D28729#646548, @alexfh wrote:
> > >
> >
Prazek added a comment.
In https://reviews.llvm.org/D28746#646875, @mehdi_amini wrote:
> Oh I didn't notice that we were in the clang Release Notes, actually I've
> only updated the LLVM ones in the past.
>
> So yes, I think this should be in LLVM as well, I don't know if it should
> differ in
aaron.ballman added a comment.
In https://reviews.llvm.org/D28729#646876, @Prazek wrote:
> In https://reviews.llvm.org/D28729#646758, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D28729#646560, @alexfh wrote:
> >
> > > In https://reviews.llvm.org/D28729#646555, @aaron.ballman wrote:
>
This patch seems to break on some of our code. Reproducer:
$ cat /tmp/ctor.cc
template
struct A {
A() {}
};
template
class B : T {
using T::T;
};
struct C {
B> d;
C(A b) : d(b) {}
};
djasper@dj:~/llvm/release$ bin/clang -cc1 -std=c++11 /tmp/ctor.cc
/tmp/ctor.cc:13:17: error: no matchi
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with comment
Comment at: docs/UsersManual.rst:1103
+ Enable optimizations based on the strict rules for overwriting polymorphic
+ C++ objects, e.g. vptr is invariant dur
Sorry, for the noise.
This is probably not the revision that caused this.
On Mon, Jan 16, 2017 at 1:08 AM, Daniel Jasper wrote:
> This patch seems to break on some of our code. Reproducer:
>
> $ cat /tmp/ctor.cc
> template
> struct A {
> A() {}
> };
>
> template
> class B : T {
> using T::
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0,
caomhin, gtbercea.
arpith-jacob added a subscriber: cfe-commits.
This patch refactors code that calls codegen for target regions. Currently
the codebase only supports the 'target' directive
Author: phosek
Date: Sun Jan 15 18:33:11 2017
New Revision: 292086
URL: http://llvm.org/viewvc/llvm-project?rev=292086&view=rev
Log:
Reland "[CMake][libcxx] Check that we have libcxxabi before using it"
This relands commit r291726.
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trun
Author: phosek
Date: Sun Jan 15 18:33:09 2017
New Revision: 292085
URL: http://llvm.org/viewvc/llvm-project?rev=292085&view=rev
Log:
Reland "[CMake][libcxx] Do not rely on the existence of c++abi or unwind
targets"
This relands commit r291727.
Modified:
libcxx/trunk/CMakeLists.txt
libcx
Author: phosek
Date: Sun Jan 15 18:33:07 2017
New Revision: 292084
URL: http://llvm.org/viewvc/llvm-project?rev=292084&view=rev
Log:
Reland "[CMake][libcxx] Move Python check to main CMake file"
This relands commit r291728.
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, caomhin,
kkwli0, gtbercea.
arpith-jacob added a subscriber: cfe-commits.
Herald added a subscriber: jholewinski.
This patch adds support for codegen of 'target parallel' on the host.
It is also the
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, caomhin,
kkwli0, gtbercea.
arpith-jacob added a subscriber: cfe-commits.
Herald added a subscriber: jholewinski.
This patch adds codegen for the 'target parallel' directive on the NVPTX
device. We
Author: marshall
Date: Sun Jan 15 21:02:10 2017
New Revision: 292091
URL: http://llvm.org/viewvc/llvm-project?rev=292091&view=rev
Log:
Implement the missing constexpr stuff in . Fixes PR#31645.
Modified:
libcxx/trunk/include/array
libcxx/trunk/test/std/containers/sequences/array/at.pass.c
vlad.tsyrklevich updated this revision to Diff 84517.
vlad.tsyrklevich added a comment.
Artem, thank you for the very detailed reply! Between this, and hitting the
right search terms to find your clang analyzer guide my understanding of the
symbol abstractions the analyzer exposes has improved s
leanil added inline comments.
Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94
+char const *const Concatenated("\"foo\""
+ "\"bar\"");
alexfh wrote:
> Does this test fail without the patch? Also, should there be a te
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
Is this an NFC patch? If so add 'NFC' to this patch.
LG
https://reviews.llvm.org/D28752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
36 matches
Mail list logo
