mgorny planned changes to this revision.
mgorny added a comment.
Since https://reviews.llvm.org/D26894 was accepted, I will be preparing a patch
using that instead.
https://reviews.llvm.org/D28295
___
cfe-commits mailing list
cfe-commits@lists.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291217: [cmake] Disable appending -msse4.2 flag implicitly
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28304?vs=83298&id=83347#toc
Repository:
rL LLVM
https://reviews.ll
mgorny added reviewers: EricWF, mclow.lists, phosek, compnerd, Hahnfeld.
mgorny added a comment.
Little ping here. This is quite trivial, and since
https://reviews.llvm.org/D26894 has been committed already I'd like to start
adding changes like this one to all LLVM projects using llvm-config in
chapuni added a comment.
It fails with LLVM_DEFAULT_TARGET_TRIPLE=i686-pc-win32, on linux.
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/33445
Seems it assumes Windows' layout even if the host is not Windows.
128838 stat64("/path/to/llvm-project/clang/test/Driver/Inputs/CUDA/Progra
arphaman updated this revision to Diff 83354.
arphaman added a comment.
Set the macro unconditionally.
Repository:
rL LLVM
https://reviews.llvm.org/D28349
Files:
lib/Frontend/InitPreprocessor.cpp
test/Frontend/objc-bool-is-bool.m
Index: test/Frontend/objc-bool-is-bool.m
===
arphaman added a comment.
In https://reviews.llvm.org/D28349#636968, @doug.gregor wrote:
> The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably
> defining this macro in C because the Objective-C runtime is usable from C,
> but that same logic applies to C++ code. It seems like
Author: yrnkrn
Date: Fri Jan 6 05:15:57 2017
New Revision: 291230
URL: http://llvm.org/viewvc/llvm-project?rev=291230&view=rev
Log:
Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
Modified: cfe/trunk/include/clang/AST/DeclCXX.h
U
Author: arphaman
Date: Fri Jan 6 05:31:12 2017
New Revision: 291231
URL: http://llvm.org/viewvc/llvm-project?rev=291231&view=rev
Log:
[ObjC] The declarator for a block literal should be a definition
This change avoids the -Wstrict-prototypes warning for block literals with an
empty argument list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291231: [ObjC] The declarator for a block literal should be
a definition (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28296?vs=83061&id=83355#toc
Repository:
rL LLVM
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291232: [CodeCompletion] Block property setters: Use dynamic
priority heuristic (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26034?vs=82866&id=83356#toc
Repository:
rL L
Author: arphaman
Date: Fri Jan 6 06:00:44 2017
New Revision: 291232
URL: http://llvm.org/viewvc/llvm-project?rev=291232&view=rev
Log:
[CodeCompletion] Block property setters: Use dynamic priority heuristic
Now when completing blocks properties that return void the block call completion
result sh
Hi,
I just downloaded VS2017 RC on a clean Win10 machine, checked out LLVM &
clang and tried to build clang.
The following code in
\tools\clang\utils\TableGen\ClangDiagnosticsEmitter.cpp failed to compile:
RecordSet DiagsInPedanticSet;
RecordSet GroupsInPedanticSet;
InferPedantic inf
On 01/05/2017 08:30 PM, Eric Christopher via cfe-commits wrote:
Ok, thanks. I agree that it's a problem. I'm definitely open for
testing ideas here. There are a few other things in the
TargetOptions/MCTargetOptions area that are already problematic to test.
I think that we need to add seriali
filcab accepted this revision.
filcab added a reviewer: filcab.
filcab added a comment.
This revision is now accepted and ready to land.
Since Richard has already LGTMed the previous version, and this is a trivial
change, I'll go ahead with committing.
https://reviews.llvm.org/D28242
___
Author: filcab
Date: Fri Jan 6 08:40:12 2017
New Revision: 291236
URL: http://llvm.org/viewvc/llvm-project?rev=291236&view=rev
Log:
[ubsan] Minimize size of data for type_mismatch (Redo of D19667)
Summary:
This patch makes the type_mismatch static data 7 bytes smaller (and it
ends up being 16 by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291236: [ubsan] Minimize size of data for type_mismatch
(Redo of D19667) (authored by filcab).
Changed prior to commit:
https://reviews.llvm.org/D28242?vs=82913&id=83362#toc
Repository:
rL LLVM
http
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Fixes a crash in modules where the template class decl becomes the most recent
decl in the redeclaration chain and
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> mgorny wrote:
> > scanon wrote:
> > > Strictly speaking there's no need to adjust `a` he
scanon added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
mgorny wrote:
> scanon wrote:
> > mgorny wrote:
> > > scanon wrote:
> > > > Strictly speaking there's no
mcrosier created this revision.
mcrosier added reviewers: jmolloy, t.p.northover, gberry, RKSimon, rengolin.
mcrosier added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Per the title, this patch replaces the target-specific intrinsic with a
target-independent equivalent.
This
sunfish added a comment.
Since we may soon have people prototyping actual atomics, I'd prefer to find a
less invasive way to fix this.
Would it be difficult to enable atomic.c in Emscripten's compiler-rt build, to
define these libcalls (assuming that the problem is just that they're not
curren
Author: kzhuravl
Date: Fri Jan 6 10:14:41 2017
New Revision: 291243
URL: http://llvm.org/viewvc/llvm-project?rev=291243&view=rev
Log:
[OpenCL] Re-enable supported core extensions based on opencl version when
disabling all extensions using pragma
Differential Revision: https://reviews.llvm.org/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291243: [OpenCL] Re-enable supported core extensions based
on opencl version when… (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.org/D28257?vs=82956&id=83369#toc
Repository:
r
dschuff added a comment.
Making it guarded by thread model makes sense, although I'm not exactly sure
whether emscripten sets that or not. But even when we do start prototyping
actual atomics, I had assumed we'd be defining i64 atomics symmetrically along
with i32 atomics, in which case we woul
dschuff added inline comments.
Comment at: test/Preprocessor/init.c:8613
// WEBASSEMBLY32-NEXT:#define __GCC_ATOMIC_INT_LOCK_FREE 2
-// WEBASSEMBLY32-NEXT:#define __GCC_ATOMIC_LLONG_LOCK_FREE 1
+// WEBASSEMBLY32-NEXT:#define __GCC_ATOMIC_LLONG_LOCK_FREE 2
// WEBASSEMBLY32-NEXT:
aaron.ballman added a comment.
I think that these changes look good to me, and I noticed Richard signed off on
the other review for the exception spec changes (thank you for working on
that!), so I think this is ready to commit.
https://reviews.llvm.org/D20428
__
amaiorano added a comment.
In https://reviews.llvm.org/D28315#636888, @hokein wrote:
> In https://reviews.llvm.org/D28315#636821, @amaiorano wrote:
>
> > Is there a way to run tests without ninja? I'm on Windows. If not, I'll use
> > my Linux VM.
>
>
> It is not related to the build system. Ther
hintonda updated this revision to Diff 83371.
hintonda added a comment.
Herald added subscribers: JDevlieghere, mgorny.
Updated patch.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCh
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:19
+
+using CandidateSet = llvm::StringSet;
+
Unused?
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:38
+
+Please note that since ``throw(
That test should be updated to explicitly specify the triple, that
should also fix the problem. I'll spin that change as soon as I can.
I agree that using the triple to determine the expected directory
layout is kind of bogus. I have no idea if cross-compiling CUDA is
even going to work...
Do w
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> mgorny wrote:
> > scanon wrote:
> > > mgorny wrote:
> > > > scanon wrote:
> > > > > Stri
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:19
+
+using CandidateSet = llvm::StringSet;
+
malcolm.parsons wrote:
> Unused?
Good catch -- left over from a previous version.
Comment at: docs/clang-tidy/chec
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob,
mikerice, hfinkel.
kkwli0 added a subscriber: cfe-commits.
This patch is to add support of the 'is_device_ptr' clause in the 'target
parallel for simd' pragma.
https://reviews.llvm.org/D28402
hintonda added a comment.
Great, thanks. Spoke to Richard about it last night and believe he's
comfortable with this change, but I'll let him weigh in...
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
sunfish added a comment.
(Emscripten does set the thread model.)
Whether WebAssembly should provide 64-bit atomics when on hardware where
they're not lock-free is an interesting wasm design question, and the code here
and in target-independent parts of clang may need to be changed as a result
hintonda updated this revision to Diff 83375.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexcep
cryptoad updated this revision to Diff 83376.
cryptoad added a comment.
Adding tests to test/Driver.
https://reviews.llvm.org/D28238
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/opensuse_42.2_aarch64_tree/
test/Driver/Inputs/opensuse_42.2_aarch64_tree/usr/
test/Driver/Inputs/open
rengolin added inline comments.
Comment at: test/Driver/linux-ld.c:623
+// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
+// RUN: --target=arm64-unknown-linux-gnu \
+// RUN: --gcc-toolchain="" \
shouldn't you have used your triple?
https://r
kimgr added a comment.
I think we're seeing similar new behavior in IWYU, I've been meaning to bring
it up on cfe-dev. But since it might be relevant here, I'll add our
observations.
To us, it looks like friends in templates form their own redecl chain. An
example:
// template.h
void foo(
cuda-version-check.cu seems to be failing since this change:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1768
The relevant failing part:
$
"C:/b/slave/clang-x86-windows-msvc2015/clang-x86-windows-msvc2015/stage1/./bin/clang.EXE"
"-v" "-###" "--cuda-gpu-arch=sm_60"
"--sysro
yaron.keren added a comment.
While at it, llvm.org/pr30994
Repository:
rL LLVM
https://reviews.llvm.org/D28399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dblaikie
Date: Fri Jan 6 11:47:10 2017
New Revision: 291249
URL: http://llvm.org/viewvc/llvm-project?rev=291249&view=rev
Log:
Revert "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and
CodeCompleteConsumer"
Caused a memory leak reported by asan. Reverting while I inves
Author: dblaikie
Date: Fri Jan 6 11:47:19 2017
New Revision: 291251
URL: http://llvm.org/viewvc/llvm-project?rev=291251&view=rev
Log:
Revert "Fix for shared_ptrification in Clang"
The original commit caused an asan-detected memory leak in Clang.
Reverting while I investigate.
This reverts commi
scanon accepted this revision.
scanon added a comment.
This revision is now accepted and ready to land.
OK, I'm satisfied with that.
https://reviews.llvm.org/D27898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: dblaikie
Date: Fri Jan 6 11:50:34 2017
New Revision: 291252
URL: http://llvm.org/viewvc/llvm-project?rev=291252&view=rev
Log:
Revert "Fix examples for recent shared_ptrification"
(should've rolled in to this revert of the CompilerInstance change in
the first place... anyway)
This revert
Author: ahatanak
Date: Fri Jan 6 11:56:15 2017
New Revision: 291253
URL: http://llvm.org/viewvc/llvm-project?rev=291253&view=rev
Log:
Make ASTContext::getDeclAlign return the correct alignment for
FunctionDecls.
This commit silences an incorrect warning that is issued when a function
pointer is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291253: Make ASTContext::getDeclAlign return the correct
alignment for (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D27478?vs=80464&id=83378#toc
Repository:
rL LLVM
http
chapuni pointed it out in the review thread a few minutes ago --
ongoing discussion there, would actually appreciate a pointer or two.
-Justin
On Fri, Jan 6, 2017 at 9:46 AM, Reid Kleckner wrote:
> cuda-version-check.cu seems to be failing since this change:
> http://lab.llvm.org:8011/builders/c
zaks.anna added a comment.
Phabricator still says that context is not available. Please, pass -U when
generating the patch.
Thanks!
Anna
Comment at: test/Analysis/gmalloc.c:1
+// RUN: %clang_cc1 -analyze
-analyzer-checker=core,alpha.deadcode.UnreachableCode,alpha.core.Ca
Author: rnk
Date: Fri Jan 6 12:16:03 2017
New Revision: 291255
URL: http://llvm.org/viewvc/llvm-project?rev=291255&view=rev
Log:
[CUDA] Add a host target triple to cuda-version-check.cu
It passes --sysroot for the Linux CUDA installation. To make this test
pass when targetting Windows, you would
rnk added a comment.
I went ahead and landed https://reviews.llvm.org/rL291255 to try to fix
forward. Take a look and let me know if that's not the right fix.
Repository:
rL LLVM
https://reviews.llvm.org/D28320
___
cfe-commits mailing list
cfe-c
v.g.vassilev added a comment.
@kimgr, here is the discussion about the change in r283207
https://reviews.llvm.org/D16989
Repository:
rL LLVM
https://reviews.llvm.org/D28399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291259: [builtins] Implement __floattitf() & __floatuntitf()
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D27898?vs=82414&id=83385#toc
Repository:
rL LLVM
https://reviews.
Author: kli
Date: Fri Jan 6 12:49:49 2017
New Revision: 291260
URL: http://llvm.org/viewvc/llvm-project?rev=291260&view=rev
Log:
[OpenMP] fix typo - the standalone 'distribute' pragma should be 'teams
distribute' pragma
Modified:
cfe/trunk/test/OpenMP/teams_distribute_collapse_messages.cpp
Author: gbiv
Date: Fri Jan 6 13:10:48 2017
New Revision: 291264
URL: http://llvm.org/viewvc/llvm-project?rev=291264&view=rev
Log:
Clean up redundant isa before getAs. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llvm
mgehre added a comment.
Hi,
this is a good idea for a check.
I would prefer when the FixIt just removes throw(A,B) specifier, instead of
replacing it by noexcept(false),
because noexcept(false) means the same things as having no noexcept specifier
at all.
And less code to read means its easier
mehdi_amini created this revision.
mehdi_amini added reviewers: chandlerc, rsmith.
mehdi_amini added subscribers: cfe-commits, dexonsmith.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: nhaehnle.
Amongst other, this will help LTO to correctly handle/honor files
compiled with O0,
mehdi_amini updated this revision to Diff 83391.
mehdi_amini added a comment.
Herald added a subscriber: wdng.
Remove spurious change
https://reviews.llvm.org/D28404
Files:
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/CodeGenMo
EricWF added a comment.
In https://reviews.llvm.org/D28383#637672, @compnerd wrote:
> @rnk happy to add such a macro. Would `__cpp_abi_itanium` and
> `__cpp_abi_microsoft` be palatable?
I would love these macros. I would prefer if the stock `__config` worked for
all but the rarest of configu
hintonda added a comment.
I could be wrong (please let me know if I am), but my understanding is:
// Does not throw
throw() --> noexcept == noexcept(true)
// Does throw
throw(something) --> noexcept(false)
Please see http://en.cppreference.com/w/cpp/language/noexcept_spec
https://reviews.llvm
kastiglione created this revision.
kastiglione added reviewers: mclow.lists, EricWF, compnerd, smeenai.
kastiglione added a subscriber: cfe-commits.
Replace preprocess conditions of `defined(_MSC_VER) && !defined(__clang__)` with
`defined(_LIBCPP_MSVC)`.
No functional change.
https://reviews.ll
aaron.ballman added a comment.
In https://reviews.llvm.org/D20693#638062, @mgehre wrote:
> Hi,
> this is a good idea for a check.
>
> I would prefer when the FixIt just removes throw(A,B) specifier, instead of
> replacing it by noexcept(false),
> because noexcept(false) means the same things a
Author: dblaikie
Date: Fri Jan 6 13:49:09 2017
New Revision: 291272
URL: http://llvm.org/viewvc/llvm-project?rev=291272&view=rev
Log:
Reapply "Fix for shared_ptrification in Clang"
Aleksey Shlyapnikov pointed out the memory leak I'd introduced, so
recommitted the clang change with a fix for that
Author: dblaikie
Date: Fri Jan 6 13:49:01 2017
New Revision: 291270
URL: http://llvm.org/viewvc/llvm-project?rev=291270&view=rev
Log:
Reapply "IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and
CodeCompleteConsumer"
Aleksey Shlypanikov pointed out my mistake in migrating an ex
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Although Ironically we can no longer support MSVC due to our use of
`#include_next` which MSVC doesn't support.
Comment at: utils/google-benchmark/include/benchmark/ma
kastiglione updated this revision to Diff 83400.
kastiglione added a comment.
Revert change to Google Benchmark
https://reviews.llvm.org/D28407
Files:
include/__config
include/__undef___deallocate
include/__undef_min_max
include/ext/hash_map
include/ext/hash_set
src/exception.cpp
EricWF updated this revision to Diff 83399.
EricWF added a comment.
- Merge with master
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists
Author: ericwf
Date: Fri Jan 6 14:05:40 2017
New Revision: 291275
URL: http://llvm.org/viewvc/llvm-project?rev=291275&view=rev
Log:
[libc++] Cleanup and document <__threading_support>
Summary:
This patch attempts to clean up the macro configuration mess in
`<__threading_support>`, specifically
timshen added a comment.
Friendly ping :)
Is there anyone else I can add as a reviewer, if no one feels comfortable
reviewing the semantic?
https://reviews.llvm.org/D27872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
This needs to be rebased following the `<__threading_support>` cleanup in
r291275.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
EricWF added a comment.
This isn't applying against master. Could you rebase?
Comment at: include/typeinfo:109
protected:
+#if defined(_LIBCPP_HAS_MS_ABI_TYPEINFO)
+#else
Don't we need a constructor here?
Repository:
rL LLVM
https://reviews.llvm.org/D2821
EricWF added a comment.
Nevermind. Missed the dependency. Would you be willing to kill that dependency
for now and we can fix it once we get Clang support?
Repository:
rL LLVM
https://reviews.llvm.org/D28212
___
cfe-commits mailing list
cfe-comm
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27429#637507, @bruno wrote:
> @EricWF ok to commit?
Yes sorry This LGTM. (I thought I had approved this yesterday, but I forgot to
hit enter).
==
ahatanak added a comment.
Test case?
Comment at: lib/Basic/Targets.cpp:8506
+ case 'N': // Integer constant (Range: -1)
+Info.setRequiresImmediate(-1);
+ case 'O': // Integer constant (Range: 8, 16, 24)
Is this meant to fall through or do you
mgehre added a comment.
I'm working on code bases where their is no manually written noexcept(false)
anywhere,
and I don't think the FixIt should look different than manually written code.
At least a configuration option for the check would be nice.
https://reviews.llvm.org/D20693
__
mehdi_amini created this revision.
mehdi_amini added reviewers: echristo, chandlerc.
mehdi_amini added a subscriber: cfe-commits.
Clang was initializing the TargetMachine with CodeGenOpt::Default
for https://reviews.llvm.org/owners/package/1/. This change is aligning it on
llc:
-O0: OptLevel = C
mehdi_amini updated this revision to Diff 83404.
mehdi_amini added a comment.
clang-format
https://reviews.llvm.org/D28409
Files:
clang/lib/CodeGen/BackendUtil.cpp
Index: clang/lib/CodeGen/BackendUtil.cpp
===
--- clang/lib/Code
tejohnson added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:65
+"Ignore an empty index file and perform non-ThinLTO compilation"),
+llvm::cl::init(false));
+
tejohnson wrote:
> mehdi_amini wrote:
> > Is it common to do this in clang?
> Do
tejohnson updated this revision to Diff 83405.
tejohnson added a comment.
Move option to LLVM.
https://reviews.llvm.org/D28362
Files:
lib/CodeGen/BackendUtil.cpp
test/CodeGen/thinlto_backend.ll
Index: test/CodeGen/thinlto_backend.ll
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sounds fine to me. I want to modify https://reviews.llvm.org/owners/package/1/
at some point, but there's nothing wrong with consistency for now.
https://reviews.llvm.org/D28409
__
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: mehdi_amini
Date: Fri Jan 6 14:52:30 2017
New Revision: 291276
URL: http://llvm.org/viewvc/llvm-project?rev=291276&view=rev
Log:
Use CodegenOpts::less when creating a TargetMachine for clang `-O1`
Summary:
Clang was initializing the TargetMachine with CodeGenOpt::Default
for O1. This cha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291276: Use CodegenOpts::less when creating a TargetMachine
for clang `-O1` (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D28409?vs=83404&id=83408#toc
Repository:
rL LL
probinson added a comment.
Maybe instead, pass a flag to enable setting optnone on everything when the
driver sees `-O0 -flto`? The patch as-is obviously has a massive testing cost,
and it's easy to imagine people being tripped up by this in the future.
https://reviews.llvm.org/D28404
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#638217, @probinson wrote:
> Maybe instead, pass a flag to enable setting optnone on everything when the
> driver sees `-O0 -flto`?
I'm not fond of this: limiting discrepancy between LTO and non-LTO reduces the
LTO specific bugs a
Author: ericwf
Date: Fri Jan 6 14:58:25 2017
New Revision: 291278
URL: http://llvm.org/viewvc/llvm-project?rev=291278&view=rev
Log:
Replace _LIBCPP_HAS_NO_DELETED_FUNCTIONS with _LIBCPP_CXX03_LANG
Added:
libcxx/trunk/test/std/input.output/iostream.format/input.streams/istream/istream.cons/c
mgorny added a comment.
@compnerd, ping. Do you really think this is a real issue? As I said on the
other patch, the only case when compiler-rt would generate i686-suffixed
library is if the builder specifically used `-march=i686` for the compiler-rt
build, and in that case the i386 variant (wh
tejohnson added a comment.
In https://reviews.llvm.org/D28362#638203, @mehdi_amini wrote:
> LGTM
Thanks, let me know if the llvm companion patch
(https://reviews.llvm.org/D28410) is ok as well.
https://reviews.llvm.org/D28362
___
cfe-commits mai
rnk added a comment.
The new MSVC layout suggests to me that we should look try looking at the path
of cl.exe before we open the exe and try to check its version. We'd change this
code to inspect the path before looking in the exe:
VersionTuple MSVCToolChain::computeMSVCVersion(const Driver *
mehdi_amini added a comment.
> In order to simplify distributed build system integration, where actions
may be scheduled before the Thin Link which determines the list of
objects selected by the linker. The gold plugin currently will emit
0-sized index files for objects not selected by the link,
tejohnson added a comment.
In https://reviews.llvm.org/D28362#638260, @mehdi_amini wrote:
> > In order to simplify distributed build system integration, where actions
> > may be scheduled before the Thin Link which determines the list of
> > objects selected by the linker. The gold plugin curre
Author: ericwf
Date: Fri Jan 6 15:42:58 2017
New Revision: 291286
URL: http://llvm.org/viewvc/llvm-project?rev=291286&view=rev
Log:
Add _LIBCPP_COMPILER_[CLANG|GCC|MSVC|IBM] macros.
This patch refactors the compiler detection done in `__config` by creating a
set of `_LIBCPP_COMPILER_` macros. Th
probinson added a comment.
In https://reviews.llvm.org/D28404#638221, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28404#638217, @probinson wrote:
>
> > The patch as-is obviously has a massive testing cost, and it's easy to
> > imagine people being tripped up by this in the future.
>
>
> C
compnerd updated this revision to Diff 83430.
compnerd marked an inline comment as done.
compnerd added a comment.
rebase, address negative timeouts, fix thunking for `__libcpp_tls_create`
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_sup
EricWF added a comment.
Is there a way to write this patch so that old `llvm-config`'s continue to
work, at least for a little while until everybody upgrades?
https://reviews.llvm.org/D26900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
amaiorano added a comment.
@ioeric Okay, check-clang-tools passes with my changes.
FYI, tests were originally failing for me (without my changes) because I use
Git, and it's configured to convert line endings to Windows (crlf) on checkout,
but some of the tools tests specify extract offsets int
mgorny added a comment.
In https://reviews.llvm.org/D26900#638328, @EricWF wrote:
> Is there a way to write this patch so that old `llvm-config`'s continue to
> work, at least for a little while until everybody upgrades?
Technically it's possible but I think it would add a lot of complexity. S
compnerd removed rL LLVM as the repository for this revision.
compnerd updated this revision to Diff 83432.
compnerd added a comment.
rebase
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_support
include/thread
Index: include/thread
==
halyavin added a comment.
LGTM.
Comment at: include/__threading_support:480
+ if (!SleepConditionVariableSRW(__cv, __m,
+ timeout_ms.count() > 0 ? timeout_ms.count()
+: 0,
manmanren created this revision.
manmanren added reviewers: rsmith, benlangmuir, doug.gregor.
manmanren added a subscriber: cfe-commits.
In r276159, we started to say that a module X is defined in a pch if we specify
-fmodule-name when building the pch.
This caused a regression that reports modul
1 - 100 of 189 matches
Mail list logo
