On 22 Dec 2016 9:32 pm, "Chandler Carruth via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
On Thu, Dec 22, 2016 at 5:41 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> ==
> --- cfe/trunk/in
On Fri, Dec 23, 2016 at 12:32 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 22 Dec 2016 9:32 pm, "Chandler Carruth via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
> On Thu, Dec 22, 2016 at 5:41 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org>
chandlerc created this revision.
chandlerc added reviewers: rsmith, mehdi_amini.
chandlerc added a subscriber: cfe-commits.
chandlerc added a dependency: D28076: [PM] Add support for building a default
AA pipeline to the PassBuilder..
Herald added a subscriber: mcrosier.
The option is actually a
mgorny added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
scanon wrote:
> Strictly speaking there's no need to adjust `a` here. If we rounded up into a
> new bin
SilverGeri updated this revision to Diff 82401.
SilverGeri added a comment.
remove brackets
https://reviews.llvm.org/D21298
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeleteNullPointerCheck.cpp
clang-tidy/readability/DeleteNullPointerCheck.h
clang-tidy/readabili
mgorny created this revision.
mgorny added reviewers: dschuff, kledzik, rengolin.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Fix missing "int_lib.h" includes in ARM negdf2vfp and subdf3vfp tests.
Additionally, extend the __arm__ guard to cover the builtin definiti
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D28052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ioeric
Date: Fri Dec 23 04:47:09 2016
New Revision: 290421
URL: http://llvm.org/viewvc/llvm-project?rev=290421&view=rev
Log:
[change-namespace] consider namespace aliases to shorten qualified names.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290421: [change-namespace] consider namespace aliases to
shorten qualified names. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D28052?vs=82345&id=82405#toc
Repository:
rL L
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290422: [tests] Add missing "int_lib.h" includes and extend
guards (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D28078?vs=82402&id=82407#toc
Repository:
rL LLVM
https://re
Author: prazek
Date: Fri Dec 23 05:40:44 2016
New Revision: 290424
URL: http://llvm.org/viewvc/llvm-project?rev=290424&view=rev
Log:
Use after move bug fixes
Summary: Bunch of fixed bugs in Clang after running misc-use-after-move in
clang-tidy.
Reviewers: rsmith, mboehme
Subscribers: cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290424: Use after move bug fixes (authored by Prazek).
Changed prior to commit:
https://reviews.llvm.org/D27752?vs=81369&id=82408#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27752
Files:
cfe
scanon added inline comments.
Comment at: lib/builtins/floattitf.c:65
+if (a & ((tu_int)1 << LDBL_MANT_DIG)) {
+a >>= 1;
+++e;
mgorny wrote:
> scanon wrote:
> > Strictly speaking there's no need to adjust `a` here. If we rounded up
scanon requested changes to this revision.
scanon added a reviewer: scanon.
scanon added a comment.
This revision now requires changes to proceed.
I don't particularly care about the shift, since the code is completely
equivalent either way, though it would be nice to clean up. However, please
r
Anastasia created this revision.
Anastasia added reviewers: yaxunl, pekka.jaaskelainen, bader.
Anastasia added subscribers: cfe-commits, rsmith.
Adding information on OpenCL to Clang documentation. This currently contain the
main features only. I am hoping we can improve it with time documenting
Anastasia added inline comments.
Comment at: test/SemaOpenCL/unknown_type.cl:1
+// RUN: %clang_cc1 -cl-std=CL1.1 -fsyntax-only -verify %s
+typedef double double2 __attribute__((ext_vector_type(2))); //
expected-error {{use of type 'double' requires cl_khr_fp64 extension to be
Anastasia accepted this revision.
Anastasia added a comment.
Excellent! Thanks!
https://reviews.llvm.org/D28048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
firolino marked 18 inline comments as done.
firolino added a comment.
Addressed suggestions from @aaron.ballman Thanks!
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:22
+
+const internal::VariadicDynCastAllOfMatcher tagDecl;
+
aaron.ballman
I can confirm that r290169 indeed fixes the three test failures I got earlier.
Thanks George!
-Dimitry
> On 23 Dec 2016, at 02:29, George Burgess IV
> wrote:
>
> It looks like the root of this is that we're treating calls to `allocsize`
> functions as AllocLike (e.g. any allocation function
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2491
+llvm::Value *Range = NDRangeL.getAddress().getPointer();
+llvm::Type *RangeTy = NDRangeL.getAddress().getType();
I think following standard Clang CodeGen convention we should a
Author: echuraev
Date: Fri Dec 23 08:55:49 2016
New Revision: 290431
URL: http://llvm.org/viewvc/llvm-project?rev=290431&view=rev
Log:
Fix problems in "[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare
operand."
Summary: Fixed warnings in commit: https://reviews.llvm.org/rL290171
Reviewe
Author: alexfh
Date: Fri Dec 23 09:03:12 2016
New Revision: 290434
URL: http://llvm.org/viewvc/llvm-project?rev=290434&view=rev
Log:
[clang-tidy] Flag implicit conversion operators.
Modified:
clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp
clang-tools-extra/trunk/do
alexfh added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:38
+
+const auto CXX11_AlgorithmNames =
+CXX_AlgorithmNames + "; "
No global `auto` variables, please. In this case `auto` just isn't buying you
anything, but in other cases i
Author: echuraev
Date: Fri Dec 23 10:11:25 2016
New Revision: 290436
URL: http://llvm.org/viewvc/llvm-project?rev=290436&view=rev
Log:
[OpenCL] Align fake address space map with the SPIR target maps.
Summary:
We compile user opencl kernel code with spir triple. But built-ins are written
in OpenC
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 82414.
mgorny added a comment.
Changed mantissa -> significand.
https://reviews.llvm.org/D27898
Files:
lib/builtins/CMakeLists.txt
lib/builtins/floattitf.c
lib/builtins/floatuntitf.c
test/builtins/Unit/fl
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM! Exciting to see the new PM arriving in clang :)
Comment at: lib/CodeGen/BackendUtil.cpp:757
+ setCommandLineOpts();
+ cl::PrintOptionValues();
+
---
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Tests please! They should be somewhere under
`test/std/utilities/optional/optional.object/optional.object.observe`
https://reviews.llvm.org/D27850
___
Author: ericwf
Date: Fri Dec 23 13:07:54 2016
New Revision: 290440
URL: http://llvm.org/viewvc/llvm-project?rev=290440&view=rev
Log:
Add apple-clang-8 to list of XFAILS for some variant tests. Patch from Michael
Park
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/varia
Author: ericwf
Date: Fri Dec 23 13:09:14 2016
New Revision: 290441
URL: http://llvm.org/viewvc/llvm-project?rev=290441&view=rev
Log:
Update TestingLibcxx doc to reflect the use_system_cxx_lib flag. Patch from
Michael Park
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/
Author: ed
Date: Fri Dec 23 13:20:07 2016
New Revision: 290443
URL: http://llvm.org/viewvc/llvm-project?rev=290443&view=rev
Log:
Extend the tests for -Wmissing-variable-declarations.
We shouldn't throw a warning when the static keyword is not present in
an anonymous namespace, just like we do for
Author: ericwf
Date: Fri Dec 23 13:30:24 2016
New Revision: 290444
URL: http://llvm.org/viewvc/llvm-project?rev=290444&view=rev
Log:
Add release update instructions for libc++
Added:
libcxx/trunk/RELEASE.TXT
Added: libcxx/trunk/RELEASE.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/tru
Author: ericwf
Date: Fri Dec 23 13:38:43 2016
New Revision: 290445
URL: http://llvm.org/viewvc/llvm-project?rev=290445&view=rev
Log:
Add test that _LIBCPP_VERSION matches __libcpp_version
Added:
libcxx/trunk/test/libcxx/libcpp_version.pass.cpp
Added: libcxx/trunk/test/libcxx/libcpp_version.p
Author: ericwf
Date: Fri Dec 23 14:00:13 2016
New Revision: 290446
URL: http://llvm.org/viewvc/llvm-project?rev=290446&view=rev
Log:
Update doc and various cleanup
Added:
libcxx/trunk/NOTES.TXT
Removed:
libcxx/trunk/RELEASE.TXT
Modified:
libcxx/trunk/TODO.TXT
libcxx/trunk/test/lib
Author: ericwf
Date: Fri Dec 23 14:03:52 2016
New Revision: 290447
URL: http://llvm.org/viewvc/llvm-project?rev=290447&view=rev
Log:
Fix PR31440: Make __sanitizer_annotate_contigious_container always visible. Fix
from Jan Beich
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/
Author: ericwf
Date: Fri Dec 23 14:17:23 2016
New Revision: 290448
URL: http://llvm.org/viewvc/llvm-project?rev=290448&view=rev
Log:
Don't use posix_memalign on Windows platforms
Modified:
libcxx/trunk/src/new.cpp
Modified: libcxx/trunk/src/new.cpp
URL:
http://llvm.org/viewvc/llvm-project/l
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Sorry about that. I'm working to turn on -Wunused-parameter and others to avoid
these issues.
https://reviews.llvm.org/D27785
___
cfe-commits ma
chandlerc marked 4 inline comments as done.
chandlerc added a comment.
Thanks for the review, will land shortly with suggested fixes.
Comment at: lib/CodeGen/BackendUtil.cpp:757
+ setCommandLineOpts();
+ cl::PrintOptionValues();
+
mehdi_amini wrote:
> This is
Author: chandlerc
Date: Fri Dec 23 14:44:01 2016
New Revision: 290450
URL: http://llvm.org/viewvc/llvm-project?rev=290450&view=rev
Log:
[PM] Introduce options to enable the (still experimental) new pass
manager, and a code path to use it.
The option is actually a top-level option but does contain
This revision was automatically updated to reflect the committed changes.
chandlerc marked 4 inline comments as done.
Closed by commit rL290450: [PM] Introduce options to enable the (still
experimental) new pass (authored by chandlerc).
Changed prior to commit:
https://reviews.llvm.org/D28077?v
Author: chandlerc
Date: Fri Dec 23 15:19:16 2016
New Revision: 290451
URL: http://llvm.org/viewvc/llvm-project?rev=290451&view=rev
Log:
[PM] Fix up from r290449 to start requiring the x86 target to be
available.
It doesn't seem terribly important to test this with a specific target
triple but wit
Leporacanthicus added inline comments.
Comment at: docs/UsersManual.rst:2083
+space is represented by the absence of an address space attribute in the IR
(see
+also :ref:`the section on address space attribute `).
+
Should this be `opencl_addrsp` (two d's)?
==
ahatanak updated this revision to Diff 82421.
ahatanak added a comment.
When compiling for C, insert lifetime.start at the beginning of the current
lexical scope, rather than moving it retroactively when a goto jumps backwards
over the variable declaration.
Also, insert lifetime.start at a more
Prazek added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:62
+ auto CallsAlgorithm = hasDeclaration(
+ functionDecl(Names.size() > 0 ? hasAnyName(Names) : anything()));
+
alexfh wrote:
> Does this check make sense without the names
Author: kromanova
Date: Fri Dec 23 16:47:16 2016
New Revision: 290455
URL: http://llvm.org/viewvc/llvm-project?rev=290455&view=rev
Log:
[DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics.
Tagged parameter names with \a doxygen command to display parameters in italics.
Added \n command
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kromanova
Date: Fri Dec 23 17:36:26 2016
New Revision: 290458
URL: http://llvm.org/viewvc/llvm-project?rev=290458&view=rev
Log:
[DOXYGEN] Improved doxygen comments for tmmintrin.h intrinsics.
Added \n commands to insert a line breaks where necessary to make the
documentation more readabl
On 22 December 2016 at 21:19, Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Dec 22 23:19:47 2016
> New Revision: 290417
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290417&view=rev
> Log:
> Add an assert to catch improperly constructed %d
Author: rsmith
Date: Fri Dec 23 17:46:56 2016
New Revision: 290461
URL: http://llvm.org/viewvc/llvm-project?rev=290461&view=rev
Log:
ArrayRefize lists of TemplateArguments in template argument deduction.
Modified:
cfe/trunk/include/clang/AST/TemplateBase.h
cfe/trunk/lib/Sema/SemaTemplateD
EricWF added a comment.
Alright. The unused parameter parts of this patch are no longer needed.
`-Wunused-parameter` and `-Wunused-variable` have been enabled within libc++.
Just working on `-Wsign-compare` now.
https://reviews.llvm.org/D27785
___
Author: ericwf
Date: Fri Dec 23 18:24:44 2016
New Revision: 290469
URL: http://llvm.org/viewvc/llvm-project?rev=290469&view=rev
Log:
fix sign comparison warnings
Modified:
libcxx/trunk/include/__bit_reference
libcxx/trunk/include/deque
libcxx/trunk/include/istream
libcxx/trunk/inc
Author: ericwf
Date: Fri Dec 23 18:28:19 2016
New Revision: 290470
URL: http://llvm.org/viewvc/llvm-project?rev=290470&view=rev
Log:
Fix another unused warning
Modified:
libcxx/trunk/test/support/test.support/test_demangle.pass.cpp
Modified: libcxx/trunk/test/support/test.support/test_demang
Author: ericwf
Date: Fri Dec 23 18:37:13 2016
New Revision: 290471
URL: http://llvm.org/viewvc/llvm-project?rev=290471&view=rev
Log:
Fix warnings in libc++abi tests
Modified:
libcxxabi/trunk/test/backtrace_test.pass.cpp
libcxxabi/trunk/test/cxa_bad_cast.pass.cpp
libcxxabi/trunk/test/t
Author: ericwf
Date: Fri Dec 23 18:40:45 2016
New Revision: 290472
URL: http://llvm.org/viewvc/llvm-project?rev=290472&view=rev
Log:
fix newly failing c++03 tests
Modified:
libcxx/trunk/test/std/thread/thread.condition/thread.condition.condvarany/wait_for_pred.pass.cpp
libcxx/trunk/test
Author: ericwf
Date: Fri Dec 23 18:44:20 2016
New Revision: 290473
URL: http://llvm.org/viewvc/llvm-project?rev=290473&view=rev
Log:
Fix missed sign-compare warning
Modified:
libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp
M
Author: ericwf
Date: Fri Dec 23 19:07:54 2016
New Revision: 290474
URL: http://llvm.org/viewvc/llvm-project?rev=290474&view=rev
Log:
fix warnings only produced by apple-clang
Modified:
libcxx/trunk/test/std/containers/sequences/deque/deque.cons/size.pass.cpp
libcxx/trunk/test/std/containe
Author: ericwf
Date: Fri Dec 23 19:12:28 2016
New Revision: 290475
URL: http://llvm.org/viewvc/llvm-project?rev=290475&view=rev
Log:
Fix unused warning which only triggers in C++11
Modified:
libcxx/trunk/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.ops/reverse.iter.opre
EricWF added a comment.
`-Wsign-compare` has also landed :-) Now just `-Wconversion` to go (but that
will likely take a while).
https://reviews.llvm.org/D27785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: ericwf
Date: Fri Dec 23 19:29:27 2016
New Revision: 290476
URL: http://llvm.org/viewvc/llvm-project?rev=290476&view=rev
Log:
Fix yet another missed -Wunused warning. Hopefully this is the last one
Modified:
libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.cons/size.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm OK with this change. Although I'm not 100% sure it's needed, since the
XFAIL seems to work for these tests. However using UNSUPPORTED is more
consistent with other tests.
https://reviews
Author: ericwf
Date: Fri Dec 23 19:43:54 2016
New Revision: 290477
URL: http://llvm.org/viewvc/llvm-project?rev=290477&view=rev
Log:
Fix warning caused by platforms providing a signed wint_t
Modified:
libcxx/trunk/test/std/input.output/file.streams/fstreams/filebuf.virtuals/underflow.pass.cp
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Marking as changes requested.
Please make sure we fall back to the old implementation on Apple platforms when
`CLOCK_UPTIME_RAW` isn't available.
https://reviews.llvm.org/D27429
Author: chapuni
Date: Fri Dec 23 19:55:12 2016
New Revision: 290478
URL: http://llvm.org/viewvc/llvm-project?rev=290478&view=rev
Log:
clangCodeGen: Add LLVMPasses to libdeps. r290450 introduced it.
Modified:
cfe/trunk/lib/CodeGen/CMakeLists.txt
Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt
Author: ericwf
Date: Fri Dec 23 19:56:25 2016
New Revision: 290479
URL: http://llvm.org/viewvc/llvm-project?rev=290479&view=rev
Log:
Avoid unused warning in __throw_future_error w/o exceptions enabled
Modified:
libcxx/trunk/include/future
Modified: libcxx/trunk/include/future
URL:
http://ll
Author: ericwf
Date: Fri Dec 23 21:09:00 2016
New Revision: 290480
URL: http://llvm.org/viewvc/llvm-project?rev=290480&view=rev
Log:
Fix sign-compare warnings on ARM platforms caused by wchar_t being unsigned
Modified:
libcxx/trunk/test/std/re/re.traits/value.pass.cpp
Modified: libcxx/trunk/
Author: ericwf
Date: Fri Dec 23 21:20:53 2016
New Revision: 290481
URL: http://llvm.org/viewvc/llvm-project?rev=290481&view=rev
Log:
Fix -Wsign-compare warnings in re tests that only run on OS X
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.pass.cpp
libcxx/trunk/test/std/re
Author: ericwf
Date: Fri Dec 23 21:27:52 2016
New Revision: 290482
URL: http://llvm.org/viewvc/llvm-project?rev=290482&view=rev
Log:
Fix ASAN test failure
Modified:
libcxx/trunk/test/libcxx/containers/sequences/vector/asan.pass.cpp
Modified: libcxx/trunk/test/libcxx/containers/sequences/vect
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I'll re-review the mutexor changes post-commit.
Comment at: CMakeLists.txt:121
option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of
pthread API" O
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CMakeLists.txt:58
if (LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY)
+ set(LIBCXX_TEST_DEPS cxx_experimental)
I always prefer `set(LIBCXX_TES
Author: rsmith
Date: Fri Dec 23 22:09:05 2016
New Revision: 290483
URL: http://llvm.org/viewvc/llvm-project?rev=290483&view=rev
Log:
When producing a name of a partial specialization in a diagnostic, use the
template arguments as written rather than the canonical template arguments,
so we print mo
Author: rsmith
Date: Fri Dec 23 22:20:31 2016
New Revision: 290484
URL: http://llvm.org/viewvc/llvm-project?rev=290484&view=rev
Log:
Fix crash if substitution fails during deduction of variable template partial
specialization arguments.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaK
Author: rsmith
Date: Fri Dec 23 22:22:52 2016
New Revision: 290485
URL: http://llvm.org/viewvc/llvm-project?rev=290485&view=rev
Log:
Remove accidentally-left-behind commented out code.
Modified:
cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplateInstantia
Author: ericwf
Date: Fri Dec 23 22:34:33 2016
New Revision: 290486
URL: http://llvm.org/viewvc/llvm-project?rev=290486&view=rev
Log:
Enable -Wunreachable-code and fix duplicate warning flags
Modified:
libcxx/trunk/test/libcxx/compiler.py
libcxx/trunk/test/libcxx/test/config.py
libcxx/
Author: ericwf
Date: Fri Dec 23 23:01:55 2016
New Revision: 290487
URL: http://llvm.org/viewvc/llvm-project?rev=290487&view=rev
Log:
Suppress unreachable code warning in unwind tests
Modified:
libcxxabi/trunk/test/unwind_01.pass.cpp
libcxxabi/trunk/test/unwind_02.pass.cpp
libcxxabi/tr
amaiorano added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:72
TEST_F(FormatTestObjC, DetectsObjCInHeaders) {
- Style = getStyle("LLVM", "a.h", "none", "@interface\n"
+ Style = *getStyle("LLVM", "a.h", "none", "@interface\n"
EricWF added a comment.
wow this is old. I'll try and re-review before the new year.
https://reviews.llvm.org/D13289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Resigning as a reviewer since I don't feel comfortable reviewing generic LLVM
patches.
Repository:
rL LLVM
https://reviews.llvm.org/D27513
___
cfe-com
EricWF abandoned this revision.
EricWF added a comment.
Another fix was applied for this.
https://reviews.llvm.org/D27658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
LGTM.
https://reviews.llvm.org/D27153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
This review hasn't generated any interest in ~3 weeks. Accepting for
post-commit review.
https://reviews.llvm.org/D27402
__
80 matches
Mail list logo
