[PATCH] D27784: Add a class ASTRecordReader which wraps an ASTReader, a RecordData, and ModuleFile.

2016-12-15 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Serialization/ASTReader.cpp:5870-5876 +TL.setWrittenTypeSpec( +static_cast(Reader.getRecordData()[Idx++])); +TL.setWrittenSignSpec( +

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

2016-12-15 Thread Mads Ravn via cfe-commits
Hi Piotr, That is a good point. Because it is not always -1 or 1 that determines lexicographical higher or lower. However, I don't think that is in the scope of this check. This check checks for string comparison (equality or inequality). Adding a match for if the user is using the compare functi

r289865 - [test] Extend llvm_shlib_dir fix to unittests

2016-12-15 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Thu Dec 15 14:31:08 2016 New Revision: 289865 URL: http://llvm.org/viewvc/llvm-project?rev=289865&view=rev Log: [test] Extend llvm_shlib_dir fix to unittests Extend the fix from rL286952 to unittests. The fix added clang built library directories (via llvm_shlib_dir) to LD_LI

[PATCH] D27812: [test] Extend llvm_shlib_dir fix to unittests

2016-12-15 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289865: [test] Extend llvm_shlib_dir fix to unittests (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D27812?vs=81587&id=81635#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

2016-12-15 Thread Amjad Aboud via Phabricator via cfe-commits
aaboud added a subscriber: bwyma. aaboud updated this revision to Diff 81640. aaboud added a comment. Moved getChecksum from SourceManager to CGDebugInfo. Also, now checksum is emitted only for CodeView. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugI

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

2016-12-15 Thread Piotr Padlewski via cfe-commits
I think that the feature I mentioned is right thing to put in this check, however you don't have to implement it right now, just leave FIXIT comment 2016-12-15 20:55 GMT+01:00 Mads Ravn : > Hi Piotr, > > That is a good point. Because it is not always -1 or 1 that determines > lexicographical high

[PATCH] D27784: Add a class ASTRecordReader which wraps an ASTReader, a RecordData, and ModuleFile.

2016-12-15 Thread David L. Jones via Phabricator via cfe-commits
dlj added a comment. https://reviews.llvm.org/D27784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

2016-12-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:1078 + QualType T = FD->getReturnType(); + if (T.isTriviallyCopyableType(Context)) { +// Avoid the optimization for functions that return trivially copyable arphaman wrote: > Quuxpl

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

2016-12-15 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin marked 2 inline comments as done. dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:30 +// +// The gtest unit testing API provides macros for assertions that that expand +// into an if statement that calls a series of constructors

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

2016-12-15 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin updated the summary for this revision. dcoughlin updated this revision to Diff 81651. dcoughlin marked an inline comment as done. dcoughlin added a comment. Update to address Aleksei's comments. https://reviews.llvm.org/D27773 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2016-12-15 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: manmanren, dexonsmith, rjmccall, thakis. erik.pilkington added a subscriber: cfe-commits. This patch adds CodeGen support for `@available` on macos. This is done by compiling @available predicates into calls to `clang.is_os_v

r289873 - [analyzer] Add a new SVal to support pointer-to-member operations.

2016-12-15 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Dec 15 15:27:06 2016 New Revision: 289873 URL: http://llvm.org/viewvc/llvm-project?rev=289873&view=rev Log: [analyzer] Add a new SVal to support pointer-to-member operations. Add a new type of NonLoc SVal for C++ pointer-to-member operations. This SVal supports both po

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

2016-12-15 Thread Devin Coughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289873: [analyzer] Add a new SVal to support pointer-to-member operations. (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D25475?vs=81598&id=81655#toc Repository: rL LLVM

Re: [libcxx] r286789 - Add check-cxx-abilist target when supported.

2016-12-15 Thread Justin Bogner via cfe-commits
Yep, the copy-libcxx-headers-into-build-tree logic is so that they end up somewhere where a just built clang will find them relative to itself (it looks for something like ../include/c++/v1). It's purely a convenience so you don't need to call `ninja install` to use a clang that refers to headers t

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

2016-12-15 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I'm not sure that this is good name for module. Singe reason for this is check for STL algorithms, may be //stl// module is more correct destination? https://reviews.llvm.org/D27815 ___ cfe-commits mailing list cfe-

[PATCH] D27180: Testbed and skeleton of a new expression parser

2016-12-15 Thread Sean Callanan via Phabricator via cfe-commits
spyffe updated this revision to Diff 81661. spyffe marked 2 inline comments as done. spyffe added a comment. Herald added a subscriber: jgosnell. Applied Vassil and Vedant's comments. I will commit this soon. Repository: rL LLVM https://reviews.llvm.org/D27180 Files: test/Import/clang-fla

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

2016-12-15 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D27815#624294, @Eugene.Zelenko wrote: > I'm not sure that this is good name for module. > > Singe reason for this is check for STL algorithms, may be //stl// module is > more correct destination? The reason for this module is that I want to m

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

2016-12-15 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. There are many other checks or compiler warnings which could be classified as obvious bugs. https://reviews.llvm.org/D27815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

2016-12-15 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D27815#624322, @Eugene.Zelenko wrote: > There are many other checks or compiler warnings which could be classified as > obvious bugs. Sure, but unfortunatelly they won't be able to become warning because of false positive rate. In the examp

r289883 - [analyzer] Include type name in Retain Count Checker diagnostics

2016-12-15 Thread Anna Zaks via cfe-commits
Author: zaks Date: Thu Dec 15 16:55:03 2016 New Revision: 289883 URL: http://llvm.org/viewvc/llvm-project?rev=289883&view=rev Log: [analyzer] Include type name in Retain Count Checker diagnostics The more detailed diagnostic will make identifying which object the diagnostics refer to easier. Dif

r289885 - [analyzer] Refine the diagnostics in the nullability checker to differentiate between nil and null

2016-12-15 Thread Anna Zaks via cfe-commits
Author: zaks Date: Thu Dec 15 16:55:15 2016 New Revision: 289885 URL: http://llvm.org/viewvc/llvm-project?rev=289885&view=rev Log: [analyzer] Refine the diagnostics in the nullability checker to differentiate between nil and null This is a big deal for ObjC, where nullability annotations are ext

r289884 - [analyzer] Refer to macro names in diagnostics for macros representing a literal

2016-12-15 Thread Anna Zaks via cfe-commits
Author: zaks Date: Thu Dec 15 16:55:11 2016 New Revision: 289884 URL: http://llvm.org/viewvc/llvm-project?rev=289884&view=rev Log: [analyzer] Refer to macro names in diagnostics for macros representing a literal When a macro expending to a literal is used in a comparison, use the macro name in th

r289886 - [analyzer] Teach the analyzer that pointers can escape into __cxa_demangle

2016-12-15 Thread Anna Zaks via cfe-commits
Author: zaks Date: Thu Dec 15 16:55:18 2016 New Revision: 289886 URL: http://llvm.org/viewvc/llvm-project?rev=289886&view=rev Log: [analyzer] Teach the analyzer that pointers can escape into __cxa_demangle This fixes a reported false positive in the malloc checker. Differential Revision: https:/

[PATCH] D27740: [analyzer] Include type name in Retain Count Checker diagnostics

2016-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289883: [analyzer] Include type name in Retain Count Checker diagnostics (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D27740?vs=81482&id=81668#toc Repository: rL LLVM https:

[PATCH] D27599: [analyzer] Teach the analyzer that pointers can escape into __cxa_demangle

2016-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289886: [analyzer] Teach the analyzer that pointers can escape into __cxa_demangle (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D27599?vs=80842&id=81672#toc Repository: rL LL

r289887 - [asan][docs] Fix the documentation to use clang++ for the C++ example

2016-12-15 Thread Anna Zaks via cfe-commits
Author: zaks Date: Thu Dec 15 16:55:21 2016 New Revision: 289887 URL: http://llvm.org/viewvc/llvm-project?rev=289887&view=rev Log: [asan][docs] Fix the documentation to use clang++ for the C++ example After Darwin has been updated not to link in stdc++ on Darwin this actually started to break. D

[PATCH] D27600: [analyzer] Refine the diagnostics in the nullability checker to differentiate between nil and null

2016-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289885: [analyzer] Refine the diagnostics in the nullability checker to differentiate… (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D27600?vs=80925&id=81671#toc Repository: r

[PATCH] D27726: [analyzer] Refer to macro names in diagnostics for macros representing a literal

2016-12-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289884: [analyzer] Refer to macro names in diagnostics for macros representing a literal (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D27726?vs=81277&id=81669#toc Repository:

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

2016-12-15 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Huh, I'm surprised this has a runtime component, I missed that. I thought this would be a statically-checked thing. But having this does seem useful :-) I'm also surprised that this compiles down to Gestalt – Gestalt is deprecated in newer SDKs, and in Chromium we invest

r289890 - [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when building compiler-rt from clang/runtime/CMakeLists.txt

2016-12-15 Thread Kuba Mracek via cfe-commits
Author: kuba.brecka Date: Thu Dec 15 17:20:54 2016 New Revision: 289890 URL: http://llvm.org/viewvc/llvm-project?rev=289890&view=rev Log: [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when building compiler-rt from clang/runtime/CMakeLists.txt Differential Revision: h

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

2016-12-15 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: test/CodeGen/debug-info-file-checksum.c:1 +// RUN: %clang -emit-llvm -S -g -gcodeview -x c %s.source -o - | FileCheck %s + Instead of %s.source, you can do %S/Inputs/debug-info-file-checksum.c. Comment at:

[PATCH] D27832: Add -plugin-opt=sample-profile for thinLTO build.

2016-12-15 Thread Dehao Chen via Phabricator via cfe-commits
danielcdh created this revision. danielcdh added reviewers: tejohnson, mehdi_amini, davidxl. danielcdh added a subscriber: cfe-commits. ThinLTO needs to pass down the sample profile file path to linker. https://reviews.llvm.org/D27832 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

[PATCH] D27832: Add -plugin-opt=sample-profile for thinLTO build.

2016-12-15 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Is this covered by a driver test usually? https://reviews.llvm.org/D27832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289897 - Fix typo in error messages. NFC.

2016-12-15 Thread Kelvin Li via cfe-commits
Author: kli Date: Thu Dec 15 18:15:54 2016 New Revision: 289897 URL: http://llvm.org/viewvc/llvm-project?rev=289897&view=rev Log: Fix typo in error messages. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp Modified: cfe/trunk/test/OpenMP/teams_distr

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

2016-12-15 Thread Jacob Young via Phabricator via cfe-commits
jacobly added a comment. rsmith, is this ready to be commited? https://reviews.llvm.org/D27263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289901 - Update for LLVM global variable debug info API change.

2016-12-15 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Dec 15 18:35:42 2016 New Revision: 289901 URL: http://llvm.org/viewvc/llvm-project?rev=289901&view=rev Log: Update for LLVM global variable debug info API change. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk/tes

[PATCH] D27813: [clang-tidy] fix missing anchor for MPI Module

2016-12-15 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. LG, thank you! https://reviews.llvm.org/D27813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289905 - [c++1z] P0195R2: Allow multiple using-declarators in a single using-declaration.

2016-12-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Dec 15 18:58:48 2016 New Revision: 289905 URL: http://llvm.org/viewvc/llvm-project?rev=289905&view=rev Log: [c++1z] P0195R2: Allow multiple using-declarators in a single using-declaration. Added: cfe/trunk/test/Parser/cxx1z-using-declaration.cpp Modified: cfe/trun

r289908 - Revert "Update for LLVM global variable debug info API change."

2016-12-15 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Dec 15 19:01:40 2016 New Revision: 289908 URL: http://llvm.org/viewvc/llvm-project?rev=289908&view=rev Log: Revert "Update for LLVM global variable debug info API change." This reverts commit 289901 while investigating bot breakage. Modified: cfe/trunk/lib/CodeGen/CG

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

2016-12-15 Thread Felix Berger via Phabricator via cfe-commits
flx updated this revision to Diff 81693. https://reviews.llvm.org/D27187 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp Index: test/clang-tidy/performance-unnecessary-value-param.cpp ==

r289909 - clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-15 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Dec 15 19:37:01 2016 New Revision: 289909 URL: http://llvm.org/viewvc/llvm-project?rev=289909&view=rev Log: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability Presently, the version number of the VSIX matches the LLVM version number

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289909: clang-format-vsix: add a date stamp to the VSIX version number to ensure… (authored by amaiorano). Changed prior to commit: https://reviews.llvm.org/D27438?vs=80527&id=81696#toc Repository: r

[PATCH] D27837: Add fix-it notes to the nullability consistency warning

2016-12-15 Thread Jordan Rose via Phabricator via cfe-commits
jordan_rose created this revision. jordan_rose added a reviewer: doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. This is especially important for arrays, since no one knows the proper syntax for putting qualifiers in arrays.

r289910 - clang-format-vsix: add command to format document

2016-12-15 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Dec 15 19:51:43 2016 New Revision: 289910 URL: http://llvm.org/viewvc/llvm-project?rev=289910&view=rev Log: clang-format-vsix: add command to format document Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the extension to the Readme. Different

[PATCH] D27501: clang-format-vsix: add command to format document

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289910: clang-format-vsix: add command to format document (authored by amaiorano). Changed prior to commit: https://reviews.llvm.org/D27501?vs=80533&id=81701#toc Repository: rL LLVM https://reviews.

[clang-tools-extra] r289912 - [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

2016-12-15 Thread Felix Berger via cfe-commits
Author: flx Date: Thu Dec 15 20:47:56 2016 New Revision: 289912 URL: http://llvm.org/viewvc/llvm-project?rev=289912&view=rev Log: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop Summary: This fixes a bug where the performance-unnecessary-value-param check suggests

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

2016-12-15 Thread Felix Berger via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. flx marked an inline comment as done. Closed by commit rL289912: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop (authored by flx). Changed prior to commit: https://reviews.llvm.org/D27187?v

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

2016-12-15 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Thanks, this is fine to commit. https://reviews.llvm.org/D27187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

2016-12-15 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. It may be good idea to create LLVM check which will suggest to use STLExtras.h wrappers instead of STL algorithms. https://reviews.llvm.org/D27806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

r289914 - [Sema] Fix handling of enumerators used as default arguments of lambda

2016-12-15 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Dec 15 21:19:41 2016 New Revision: 289914 URL: http://llvm.org/viewvc/llvm-project?rev=289914&view=rev Log: [Sema] Fix handling of enumerators used as default arguments of lambda expressions in a function or class template. This patch makes the following changes: - Cre

r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Dec 15 22:18:53 2016 New Revision: 289919 URL: http://llvm.org/viewvc/llvm-project?rev=289919&view=rev Log: Remove "-disable-llvm-optzns -verify" from the RUN line. Modified: cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp Modified: cfe/trunk/test/SemaTemp

r289921 - Update for LLVM global variable debug info API change.

2016-12-15 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Dec 15 22:26:15 2016 New Revision: 289921 URL: http://llvm.org/viewvc/llvm-project?rev=289921&view=rev Log: Update for LLVM global variable debug info API change. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk/tes

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added a comment. Hi @djasper, just curious about your opinion on this change, and on the conversation following it, specifically regarding whether clang-format should really use the fallback style when failing to parse a .clang-format file. Thanks! https://reviews.llvm.org/D27440

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

2016-12-15 Thread Antonio Maiorano via Phabricator via cfe-commits
amaiorano added a comment. Hi @djasper, just curious about your opinion on this change, and on the conversation following it, specifically regarding whether clang-format should really use the fallback style when failing to parse a .clang-format file. Thanks! https://reviews.llvm.org/D27440

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
Are you aware that this is still failing on all the bots? ( http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493 eg) On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ahatanak > Date: Thu Dec 15 22:18:53 2016 > New R

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
I think the problem was that you didn't pipe the output to /dev/null or -, and so a .ll file got created which now confuses the bots. I suggest: 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through magic lit vars to find one that expands to the right thing) 2. If the intent fo

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
On Fri, Dec 16, 2016 at 12:08 AM, Nico Weber wrote: > I think the problem was that you didn't pipe the output to /dev/null or -, > and so a .ll file got created which now confuses the bots. > > I suggest: > 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through > magic lit vars

r289924 - attempt to fix bots after r289914/r289919

2016-12-15 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Dec 15 23:03:44 2016 New Revision: 289924 URL: http://llvm.org/viewvc/llvm-project?rev=289924&view=rev Log: attempt to fix bots after r289914/r289919 Modified: cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp Modified: cfe/trunk/test/SemaTemplate/default-expr-a

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
I gave this a shot in 289924. Please check that's the right thing. On Fri, Dec 16, 2016 at 12:09 AM, Nico Weber wrote: > On Fri, Dec 16, 2016 at 12:08 AM, Nico Weber wrote: > >> I think the problem was that you didn't pipe the output to /dev/null or >> -, and so a .ll file got created which now

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Akira Hatanaka via cfe-commits
> On Dec 15, 2016, at 9:08 PM, Nico Weber wrote: > > I think the problem was that you didn't pipe the output to /dev/null or -, > and so a .ll file got created which now confuses the bots. > > I suggest: > 1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through > magic lit v

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka wrote: > > On Dec 15, 2016, at 9:08 PM, Nico Weber wrote: > > I think the problem was that you didn't pipe the output to /dev/null or -, > and so a .ll file got created which now confuses the bots. > > I suggest: > 1. Add `// RUN: rm -f right_path

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Akira Hatanaka via cfe-commits
> On Dec 15, 2016, at 9:18 PM, Nico Weber wrote: > > On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka > wrote: > >> On Dec 15, 2016, at 9:08 PM, Nico Weber > > wrote: >> >> I think the problem was that you didn't pipe the output to /dev/

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
On Fri, Dec 16, 2016 at 12:21 AM, Akira Hatanaka wrote: > > On Dec 15, 2016, at 9:18 PM, Nico Weber wrote: > > On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka > wrote: > >> >> On Dec 15, 2016, at 9:08 PM, Nico Weber wrote: >> >> I think the problem was that you didn't pipe the output to /dev/

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Akira Hatanaka via cfe-commits
It looks like it failed again. I’m still looking. > On Dec 15, 2016, at 9:14 PM, Nico Weber wrote: > > I gave this a shot in 289924. Please check that's the right thing. > > On Fri, Dec 16, 2016 at 12:09 AM, Nico Weber > wrote: > On Fri, Dec 16, 2016 at 12:08 AM, Ni

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Akira Hatanaka via cfe-commits
Your commit seemed to have fixed the bot. Thanks! I’m going to wait until all the other bots are green again and then fix the test case later. > On Dec 15, 2016, at 9:45 PM, Akira Hatanaka via cfe-commits > wrote: > > It looks like it failed again. I’m still looking. > >> On Dec 15, 2016, at

Re: r289919 - Remove "-disable-llvm-optzns -verify" from the RUN line.

2016-12-15 Thread Nico Weber via cfe-commits
On Fri, Dec 16, 2016 at 12:45 AM, Akira Hatanaka wrote: > It looks like it failed again. I’m still looking. > Well, the bot needs to run once with my change in. In that run, the .ll file is still around and the tests will still fail, but the .cpp test will remove it. On the first build _after_ m

[PATCH] D27818: [OpenMP] Sema and parsing for 'target teams' pragma

2016-12-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D27821: [OpenMP] support is_device_ptr clause with 'target parallel' pragma

2016-12-15 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: r289787 - Re-commit r289252 and r289285, and fix PR31374

2016-12-15 Thread Nico Weber via cfe-commits
Thanks! The test now also includes a regression test for PR31374, yes? On Thu, Dec 15, 2016 at 3:09 AM, Yaxun Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yaxunl > Date: Thu Dec 15 02:09:08 2016 > New Revision: 289787 > > URL: http://llvm.org/viewvc/llvm-project?rev=289787&v

<    1   2