[PATCH] D27334: [OpenCL] Ambiguous function call.

bader added a comment. In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > This change seems to modify normal C behavior again. Is there any strong > motivation for doing this and if yes could it be done generically with C? Motivation: // Non-portable OpenCL 1.2 code __kernel

[PATCH] D27384: [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality

skalinichev abandoned this revision. skalinichev added a comment. Turns out we already have another patch that fixes the same problem: https://reviews.llvm.org/D26907 https://reviews.llvm.org/D27384 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

RKSimon added reviewers: mkuper, dim, RKSimon. RKSimon added a comment. https://llvm.org/bugs/show_bug.cgi?id=30426#c3 On PR30426 the proposal was that we should just not accept x86_64 triples with no-sse/no-sse2 at the command line parsing level - we just have no way to guess what the coder wa

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

joerg added a comment. Rejecting -mno-sse2 for x86_64 is even worse. Dynamic linkers e.g. in FreeBSD and NetBSD depend on that. They also don't contain floating point code, but that's a separate question. Similar constraints exist for the kernels. https://reviews.llvm.org/D27304 ___

[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added a comment. I wonder if we should consider this a breaking ABI change and control it using a `_LIBCPP_ABI` macro. @mclow.lists thoughts? https://reviews.llvm.org/D27387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added inline comments. Comment at: src/functional.cpp:1 +//===--- functional.cpp ---===// +// smeenai wrote: > Should I clang-format new files? I based the style of this file on the > existing source files,

[libcxx] r288623 - Choose better hash values for std::monostate and valueless variants.

Author: ericwf Date: Sun Dec 4 15:37:37 2016 New Revision: 288623 URL: http://llvm.org/viewvc/llvm-project?rev=288623&view=rev Log: Choose better hash values for std::monostate and valueless variants. Previously these hashes were 0 and -1 respectively. These seem like common sentinel values and

[libcxx] r288625 - Update status page for variant implementation

Author: ericwf Date: Sun Dec 4 16:14:53 2016 New Revision: 288625 URL: http://llvm.org/viewvc/llvm-project?rev=288625&view=rev Log: Update status page for variant implementation Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/v

r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules semant

Author: djasper Date: Sun Dec 4 16:34:37 2016 New Revision: 288626 URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev Log: Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still

Re: r288449 - Recover better from an incompatible .pcm file being provided by -fmodule-file=.

This is unfortunately causing problems as is, as it can change the diagnostic that's created when the include of a module with config-mismatch is inside a namespace. I have tried to fix this for a bit, but I am not sure what the right solution is. For now, I have reverted this in r288626 and left t

r288629 - IRGen: Remove an unused overload of CreateAlignedLoad.

Author: pcc Date: Sun Dec 4 18:02:18 2016 New Revision: 288629 URL: http://llvm.org/viewvc/llvm-project?rev=288629&view=rev Log: IRGen: Remove an unused overload of CreateAlignedLoad. Modified: cfe/trunk/lib/CodeGen/CGBuilder.h Modified: cfe/trunk/lib/CodeGen/CGBuilder.h URL: http://llvm.o

Re: r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules se

On 4 Dec 2016 2:44 pm, "Daniel Jasper via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: djasper Date: Sun Dec 4 16:34:37 2016 New Revision: 288626 URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev Log: Revert "Recover better from an incompatible .pcm file being provided by

r288645 - Adapt to llvm/TableGen DagInit changes.

Author: matze Date: Mon Dec 5 00:00:51 2016 New Revision: 288645 URL: http://llvm.org/viewvc/llvm-project?rev=288645&view=rev Log: Adapt to llvm/TableGen DagInit changes. Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL: http://llvm.

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

echuraev updated this revision to Diff 80229. echuraev marked 2 inline comments as done. https://reviews.llvm.org/D27300 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index: test/CodeGenOpenCL/spir_version.cl ===

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. In https://reviews.llvm.org/D27387#612975, @EricWF wrote: > I wonder if we should consider this a breaking ABI change and control it > using a `_LIBCPP_ABI` macro. @mclow.lists thoughts? This is forward-compatible (as in clients built against an older libc++ would be

r288654 - DR1213: element access on an array xvalue or prvalue produces an xvalue. In the

Author: rsmith Date: Mon Dec 5 01:49:14 2016 New Revision: 288654 URL: http://llvm.org/viewvc/llvm-project?rev=288654&view=rev Log: DR1213: element access on an array xvalue or prvalue produces an xvalue. In the latter case, a temporary array object is materialized, and can be lifetime-extended b