[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

alexshap added inline comments. Comment at: test/Analysis/lifetime-extension.cpp:11 + int j[2]; + S s; + A() : i(1) { what is the role of S in this test ? https://reviews.llvm.org/D26839 ___ cfe-commits mailing

[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

NoQ updated this revision to Diff 78478. https://reviews.llvm.org/D26839 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/lifetime-extension.cpp Index: test/Analysis/lifetime-extension.cpp === --- /dev/null +++ test/A

[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: test/Analysis/lifetime-extension.cpp:11 + int j[2]; + S s; + A() : i(1) { alexshap wrote: > what is the role of S in this test ? I copy-pasted this from the original bug report. The o

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

malcolm.parsons added a comment. @mclow.lists is working on this in https://reviews.llvm.org/D26667. The review comments from that apply here too. https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

EricWF added a comment. Should this review be closed then? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

seaneveson added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:334 void BlockCodeRegion::Profile(llvm::FoldingSetNodeID& ID) const { + locTy->getTypePtr()->isBlockPointerType(); BlockCodeRegion::ProfileRegion(ID, BD, locTy, AC, superRegion);

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D26844 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/multiple_class_test.cpp test/clang-move/move-multiple-classes.cpp Index: test/clang-move/move-multi

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

NoQ updated this revision to Diff 78489. NoQ marked an inline comment as done. NoQ added a comment. Remove unused expression. https://reviews.llvm.org/D26837 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:334 void BlockCodeRegion::Profile(llvm::FoldingSetNodeID& ID) const { + locTy->getTypePtr()->isBlockPointerType(); BlockCodeRegion::ProfileRegion(ID, BD, locTy, AC, superRegion); se

[libcxxabi] r287327 - Rename TU names to not conflict with libc++.

Author: ericwf Date: Fri Nov 18 03:54:49 2016 New Revision: 287327 URL: http://llvm.org/viewvc/llvm-project?rev=287327&view=rev Log: Rename TU names to not conflict with libc++. In order to easily merge libc++ and libc++abi static archives it's important that none of the source files share the sa

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

ioeric added inline comments. Comment at: test/clang-move/move-multiple-classes.cpp:21 // CHECK-OLD-TEST-CPP: #include "{{.*}}multiple_class_test.h" +// CHECK-OLD-TEST-CPP: using a::Move1; +// CHECK-OLD-TEST-CPP: using namespace a; Would there be empty lines bet

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78490. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/Lexer.cpp Index: lib/Lex/Lexer.cpp === --- lib/Lex/Lexer.cpp +++ lib/Lex/Lexer.cpp @@ -

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

hokein added inline comments. Comment at: test/clang-move/move-multiple-classes.cpp:21 // CHECK-OLD-TEST-CPP: #include "{{.*}}multiple_class_test.h" +// CHECK-OLD-TEST-CPP: using a::Move1; +// CHECK-OLD-TEST-CPP: using namespace a; ioeric wrote: > Would there be

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

hokein updated this revision to Diff 78491. hokein marked an inline comment as done. hokein added a comment. Add FIXME. https://reviews.llvm.org/D26844 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/multiple_class_test.cpp test/clang-move/move-multiple-classes.cpp Index: test/cl

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D26844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D26844: [clang-move] Fix not moving using-decls in global namespace in old.cc

This revision was automatically updated to reflect the committed changes. Closed by commit rL287330: [clang-move] Fix not moving using-decls in global namespace in old.cc (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D26844?vs=78491&id=78492#toc Repository: rL LLVM

[clang-tools-extra] r287330 - [clang-move] Fix not moving using-decls in global namespace in old.cc

Author: hokein Date: Fri Nov 18 04:51:16 2016 New Revision: 287330 URL: http://llvm.org/viewvc/llvm-project?rev=287330&view=rev Log: [clang-move] Fix not moving using-decls in global namespace in old.cc Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev updated this revision to Diff 78493. AntonBikineev marked an inline comment as done. https://reviews.llvm.org/D26830 Files: include/string_view test/std/strings/string.view/string.view.literals/literal.pass.cpp test/std/strings/string.view/string.view.literals/literal1.fail.cp

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev added inline comments. Comment at: include/string_view:749 +inline namespace literals +{ EricWF wrote: > If this is new to C++17 then the new declarations should be guarded by `#if > _LIBCPP_VERSION > 14`. Eric, I was thinking about it, but the f

r287335 - Wdocumentation fix

Author: rksimon Date: Fri Nov 18 05:18:28 2016 New Revision: 287335 URL: http://llvm.org/viewvc/llvm-project?rev=287335&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Driver/Driver.h Modified: cfe/trunk/include/clang/Driver/Driver.h URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny retitled this revision from "[Driver] Add unit tests for DetectDistro()" to "[Driver] Add unit tests for Distro detection". mgorny updated the summary for this revision. mgorny updated this revision to Diff 78494. mgorny added a comment. Ok, here are the tests updated for the new API. I'll

[libcxx] r287336 - Add merge_archives.py utility

Author: ericwf Date: Fri Nov 18 05:26:14 2016 New Revision: 287336 URL: http://llvm.org/viewvc/llvm-project?rev=287336&view=rev Log: Add merge_archives.py utility Added: libcxx/trunk/utils/merge_archives.py Added: libcxx/trunk/utils/merge_archives.py URL: http://llvm.org/viewvc/llvm-project

[libcxx] r287337 - Make merge_archives.py executable

Author: ericwf Date: Fri Nov 18 05:29:05 2016 New Revision: 287337 URL: http://llvm.org/viewvc/llvm-project?rev=287337&view=rev Log: Make merge_archives.py executable Modified: libcxx/trunk/utils/merge_archives.py (props changed) Propchange: libcxx/trunk/utils/merge_archives.py ---

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added inline comments. Comment at: include/string_view:749 +inline namespace literals +{ AntonBikineev wrote: > EricWF wrote: > > If this is new to C++17 then the new declarations should be guarded by `#if > > _LIBCPP_VERSION > 14`. > Eric, I was thinki

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev updated this revision to Diff 78497. https://reviews.llvm.org/D26830 Files: include/string_view test/std/strings/string.view/string.view.literals/literal.pass.cpp test/std/strings/string.view/string.view.literals/literal1.fail.cpp test/std/strings/string.view/string.view.lit

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev updated this revision to Diff 78498. https://reviews.llvm.org/D26830 Files: include/string_view test/std/strings/string.view/string.view.literals/literal.pass.cpp test/std/strings/string.view/string.view.literals/literal1.fail.cpp test/std/strings/string.view/string.view.lit

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev marked an inline comment as done. AntonBikineev added inline comments. Comment at: include/string_view:749 +inline namespace literals +{ EricWF wrote: > AntonBikineev wrote: > > EricWF wrote: > > > If this is new to C++17 then the new declarations

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos created this revision. pmatos added a reviewer: efriedma. pmatos added a subscriber: cfe-commits. Ensure sizeof expression context is partially evaluated so that potential typeof operators inside are evaluated if necessary. Fixes PR31042. https://reviews.llvm.org/D26843 Files: lib/Pa

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. This isn't correct. For example this change breaks: struct T { int m; }; int x = sizeof(T::m); https://reviews.llvm.org/D26843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk created this revision. puetzk added a subscriber: cfe-commits. puetzk set the repository for this revision to rL LLVM. Although not specifically mentioned in the documentation, MSVC accepts __uuidof(…) and declspec(uuid("…")) attributes on enumeration types in addition to structs/classes.

[Patch] D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC

I'm new here, so not sure who should review this, thanks. See the patch for details of the problem: https://reviews.llvm.org/D26847 Works around https://connect.microsoft.com/VisualStudio/feedback/details/3111599/microsoft-c-c-compiler-driver-crashes-building-llvm

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, rsmith. malcolm.parsons added a subscriber: cfe-commits. clang-tidy checks frequently use source ranges of functions. The source range of constructors and destructors in template instantiations is currently a si

[PATCH] D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC

malcolm.parsons added a comment. This file doesn't exist in clang. Did you mean to report this to swift-clang? Repository: rL LLVM https://reviews.llvm.org/D26847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

arphaman added a comment. Is it possible to add a test for this change? Maybe you could dump the AST and check if the range is the one that you would expect (See test/Misc/ast-dump-decl.cpp for an example). https://reviews.llvm.org/D26849 ___ cfe-

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. In https://reviews.llvm.org/D26843#599635, @EricWF wrote: > This isn't correct. For example this change breaks: > > struct T { int m; }; > int x = sizeof(T::m); > But that is not valid in C afaik and in C++ I get: error: invalid use of non-static data member 'm'

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. > But that is not valid in C afaik and in C++ I get: > > error: invalid use of non-static data member 'm' > int x = sizeof(T::m); >~~~^ > > > Can you post a full reproducible example of what the change breaks? That is a full reproducible exampl

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added a comment. ping https://reviews.llvm.org/D25475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny updated this revision to Diff 78506. mgorny added a comment. Added tests for SUSE and Arch Linux (and found a bug for the former, https://reviews.llvm.org/D26850). https://reviews.llvm.org/D25869 Files: unittests/Driver/CMakeLists.txt unittests/Driver/DistroTest.cpp Index: unittest

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated the summary for this revision. AntonBikineev updated this revision to Diff 78507. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralS

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78510. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp ==

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78511. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp ==

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

a.sidorin added a comment. Personally, I like this change because it makes our assumptions clearer. My comments are below. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:54 + : store(st), region(r) { +assert(r->getValueType()->isRecor

r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Author: joey Date: Fri Nov 18 08:10:54 2016 New Revision: 287343 URL: http://llvm.org/viewvc/llvm-project?rev=287343&view=rev Log: [OpenCL] Introduce ReadPipeType and WritePipeType. This allows Sema to diagnose passing a read_only pipe to a write_only pipe argument. Modified: cfe/trunk/i

[PATCH] D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe

joey closed this revision. joey marked 3 inline comments as done. joey added a comment. Committed as r287343. Repository: rL LLVM https://reviews.llvm.org/D26746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D26838: [analyzer] Enforce super-region classes for various memory regions through compile-time and run-time type checks.

a.sidorin added a comment. Hi Artem! I like this change mostly but I also have some remarks. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279 /// associated element type, index, and super region. const ElementRegion *getElementRegion(QualType

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

ioeric created this revision. ioeric added reviewers: klimek, djasper, bkramer. ioeric added a subscriber: cfe-commits. The new error information contains the type of error (e.g. overlap or bad file path) and the replacement(s) that is causing the error. This enables us to resolve some errors. F

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

mibintc removed rL LLVM as the repository for this revision. mibintc updated this revision to Diff 78518. mibintc added a comment. I regenerated the diff using diff -x -U99 https://reviews.llvm.org/D26636 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h lib/Parse/ParseExpr.cpp

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

malcolm.parsons updated this revision to Diff 78522. malcolm.parsons added a comment. Add test. https://reviews.llvm.org/D26849 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/Misc/ast-dump-decl.cpp Index: test/Misc/ast-dump-decl.cpp ==

[PATCH] D26847: Fix Internal Compiler Error compiling Clang with the latest version of MSVC

hughbe added a comment. Thanks Malcolm. You're right, my bad! Sorry for wasting your time Repository: rL LLVM https://reviews.llvm.org/D26847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78523. AntonBikineev added a comment. Just added a small test case https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp test/SemaCXX/

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

majnemer added a comment. Do we have a testcase where the declspec is applied to something inappropriate like an int? Comment at: lib/Sema/SemaDeclAttr.cpp:4669-4673 + if (!(isa(D) || isa(D))) { S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) - << Attr.g

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

baloghadamsoftware updated this revision to Diff 78527. baloghadamsoftware added a comment. Test updated to include test case where system headers are inlined. https://reviews.llvm.org/D25660 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. In https://reviews.llvm.org/D26843#599673, @EricWF wrote: > > But that is not valid in C afaik and in C++ I get: > > > > error: invalid use of non-static data member 'm' > > int x = sizeof(T::m); > >~~~^ > > > > > > Can you post a full reproduc

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1621 let Args = [StringArgument<"Guid">]; -// let Subjects = SubjectList<[CXXRecord]>; + let Subjects = SubjectList<[CXXRecord, Enum], WarnDiag, "Expe

[PATCH] D26858: [AArch64] Don't constrain the assembler when using -mgeneral-regs-only

sbaranga created this revision. sbaranga added reviewers: jmolloy, rengolin, t.p.northover. sbaranga added a subscriber: cfe-commits. Herald added a subscriber: aemerson. We use the neonasm, cryptoasm, fp-armv8asm and fullfp16asm features to enable the assembling of instructions that were disabled

[PATCH] D26830: [libcxx] Add string_view literals

AntonBikineev updated this revision to Diff 78532. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Fixing typos... https://reviews.llvm.org/D26830 Files: include/string_view test/std/strings/string.view/string.view.literals/literal.pass.cpp test/std/strings/

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8064 + ScalarCast = CK_FloatingCast; +} else if (ScalarTy->isIntegralType(S.Context)) { + // Determine if the integer constant can be expressed as a floating point bruno wrote: > I don

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 78531. sdardis marked 4 inline comments as done. sdardis added a comment. Addressed review comments. https://reviews.llvm.org/D25866 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c test/Sema/vector-gcc

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

joerg added a comment. Besides "it triggers on SPEC", why should the warning be disabled here? I think it is perfectly sensible to have a warning for all six conditional contexts here. https://reviews.llvm.org/D26636 ___ cfe-commits mailing list c

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

malcolm.parsons added a comment. Does `Sema::CheckLiteralOperatorDeclaration` need to check `StringLiteralParser::isValidUDSuffix`? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D26845: [analyzer] Fix crash on the access to a union's region.

NoQ added a comment. Thanks for looking into this! It seems to be exactly the same as https://reviews.llvm.org/D26442. I was just about to commit this last one, however maybe we should actually have a more careful investigation on this issue now that we have duplicates. Repository: rL LLVM

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325 + const CallEvent *Call, + const LocationContext *LCtx) { +return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated, -

[PATCH] D26858: [AArch64] Don't constrain the assembler when using -mgeneral-regs-only

sbaranga updated this revision to Diff 78541. sbaranga added a comment. Update regression tests. https://reviews.llvm.org/D26858 Files: docs/UsersManual.rst lib/Driver/Tools.cpp test/Driver/aarch64-mgeneral_regs_only.c Index: lib/Driver/Tools.cpp

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

arphaman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10270 +static void setSrcAlign(Expr *SE, CharUnits &SrcAlign, ASTContext &Context) { + if (const auto *DRE = dyn_cast(SE)) I'm not sure if you can, since I don't really know `CharUnits`, but

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

kzhuravl created this revision. kzhuravl added reviewers: tstellarAMD, arsenm. kzhuravl added subscribers: b-sumner, cfe-commits. Herald added subscribers: tony-tye, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D26863 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp

[PATCH] D25869: [Driver] Add unit tests for Distro detection

bruno added a comment. LGTM! Please add this before https://reviews.llvm.org/D26850, which should contain a testcase on top of this! Thanks https://reviews.llvm.org/D25869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

RE: D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

Thanks for your question The bug was originally posted in llvm bugs database, see 25965, there is discussion between Richard Smith and the submitter Gregory Pakosz which concludes "maybe we should suppress the diagnostic entirely". Evidently there is fairly usage to guard against divide by zero

[PATCH] D26863: [AMDGPU] Change frexp.exp builtin to return i16 for f16 input

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

anemet added a comment. Mehdi offered to help out making this work for ThinLTO on the LLVM side. For now this option will be ignored by ThinLTO. https://reviews.llvm.org/D26833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. > This is different from your initial snippet and compiles fine with my patch. Your confused. Both examples compile fine w/o your patch and are rejected with it. I just double checked. https://reviews.llvm.org/D26843 ___ cf

[PATCH] D26544: [PPC] support for arithmetic builtins in the FE

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r287358 - LTO support for -fsave-optimization-record on Darwin

Author: anemet Date: Fri Nov 18 12:17:36 2016 New Revision: 287358 URL: http://llvm.org/viewvc/llvm-project?rev=287358&view=rev Log: LTO support for -fsave-optimization-record on Darwin I guess this would have to be added for each linker. Differential Revision: https://reviews.llvm.org/D26833 M

r287357 - Fix a comment for -fsave-optimization-record

Author: anemet Date: Fri Nov 18 12:17:33 2016 New Revision: 287357 URL: http://llvm.org/viewvc/llvm-project?rev=287357&view=rev Log: Fix a comment for -fsave-optimization-record Differential Revision: https://reviews.llvm.org/D26807 Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/tru

[PATCH] D26807: Fix a comment for -fsave-optimization-record

This revision was automatically updated to reflect the committed changes. Closed by commit rL287357: Fix a comment for -fsave-optimization-record (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D26807?vs=78389&id=78551#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL287358: LTO support for -fsave-optimization-record on Darwin (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D26833?vs=78464&id=78552#toc Repository: rL LLVM https://reviews.

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. In https://reviews.llvm.org/D22955#598081, @rnk wrote: > If I understand correctly, this patch takes template function patterns, > copies them into instantiated context, parses them in that context, and then > instantiates them in that context. The key difference is tha

[PATCH] D26845: [analyzer] Fix crash on the access to a union's region.

alexshap added a comment. Thanks, - just want to have one of them (https://reviews.llvm.org/D26442 or this one) checked in sooner rather than later. Looks like i have missed that diff on cfe-commits, I'm ok to abandon my patch in favor of https://reviews.llvm.org/D26442. Repository: rL LLVM

[PATCH] D26808: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. I think it's all right to be conservative here. The inference rules could get quite complicated if (for example) the use looked like this extern void foo (double *bar); extern __unknown_a

[libcxxabi] r287364 - __cxa_demangle: use default member initialization

Author: compnerd Date: Fri Nov 18 13:01:53 2016 New Revision: 287364 URL: http://llvm.org/viewvc/llvm-project?rev=287364&view=rev Log: __cxa_demangle: use default member initialization Sink the Db initialization into the structure rather than out-of-line at the declaration size. This just makes

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin added inline comments. Comment at: test/ubsan/TestCases/TypeCheck/null.cpp:1 -// RUN: %clangxx -fsanitize=null %s -O3 -o %t -// RUN: %run %t l 2>&1 | FileCheck %s --check-prefix=CHECK-LOAD -// RUN: %expect_crash %run %t s 2>&1 | FileCheck %s --check-prefix=CHECK-STORE -//

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin updated this revision to Diff 78557. krasin added a comment. sync & address the comments. https://reviews.llvm.org/D26560 Files: test/ubsan/TestCases/TypeCheck/null.cpp Index: test/ubsan/TestCases/TypeCheck/null.cpp ===

[PATCH] D26843: Make sizeof expression context partially evaluated

EricWF added a comment. In case your wondering *why* this happens In https://reviews.llvm.org/D26843#599804, @pmatos wrote: > In https://reviews.llvm.org/D26843#599673, @EricWF wrote: > > > > But that is not valid in C afaik and in C++ I get: > > > > > > error: invalid use of non-static data

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. Apologies if I am being shallow and wasting your time but `sizeof(T::m)` doesn't compile at the moment with clang trunk. Using the same service you used before . https://reviews.llvm.org/D26843

r287366 - [CMake] Fixing variable names that were mistyped

Author: cbieneman Date: Fri Nov 18 13:20:39 2016 New Revision: 287366 URL: http://llvm.org/viewvc/llvm-project?rev=287366&view=rev Log: [CMake] Fixing variable names that were mistyped This is a silly bug that I'm sure I caused... Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified: cf

Re: [PATCH] D26843: Make sizeof expression context partially evaluated

On Fri, Nov 18, 2016 at 2:22 PM, Paulo Matos via cfe-commits wrote: > pmatos added a comment. > > Apologies if I am being shallow and wasting your time but `sizeof(T::m)` > doesn't compile at the moment with clang trunk. Using the same service you > used before

[PATCH] D26234: [Frontend] Add a predefined macro that describes the Objective-C bool type

t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Tim. Repository: rL LLVM https://reviews.llvm.org/D26234 ___

r287371 - Adapt to llvm NamedRegionTimer changes

Author: matze Date: Fri Nov 18 13:43:25 2016 New Revision: 287371 URL: http://llvm.org/viewvc/llvm-project?rev=287371&view=rev Log: Adapt to llvm NamedRegionTimer changes We have to specify a name and description for the timers and groups now. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp

[libcxx] r287373 - Make LIBCXX_ENABLE_STATIC_ABI_LIBRARY merge libc++.a and libc++abi.a

Author: ericwf Date: Fri Nov 18 13:53:45 2016 New Revision: 287373 URL: http://llvm.org/viewvc/llvm-project?rev=287373&view=rev Log: Make LIBCXX_ENABLE_STATIC_ABI_LIBRARY merge libc++.a and libc++abi.a Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/lib/CMakeLists.txt libcxx/trunk/

Re: [PATCH] D26843: Make sizeof expression context partially evaluated

On 18/11/16 20:30, Aaron Ballman wrote: > On Fri, Nov 18, 2016 at 2:22 PM, Paulo Matos via cfe-commits > wrote: >> pmatos added a comment. >> >> Apologies if I am being shallow and wasting your time but `sizeof(T::m)` >> doesn't compile at the moment with clang trunk. Using the same service you

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk updated this revision to Diff 78569. puetzk added a comment. Address comments from @aaron.ballman and @majnemer Add a test case wihich triggers "the 'uuid' attribute only applies to classes and enumerations" warning Repository: rL LLVM https://reviews.llvm.org/D26846 Files: includ

[PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

puetzk added a comment. Also rebased against r287335/496a3f56c7 Repository: rL LLVM https://reviews.llvm.org/D26846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D26843: Make sizeof expression context partially evaluated

FYI I took the example from the [C++1z standard]( http://eel.is/c++draft/expr.prim.id#2) > [expr.prim.id]p2: > An id-expression that denotes a non-static data member or non-static member function of a class can only > be used [...] if that id-expression denotes a non-static data member and it appe

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rL287380: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26773?vs=78392&id=78575#toc Repository: r

r287380 - [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

Author: ddcc Date: Fri Nov 18 15:07:03 2016 New Revision: 287380 URL: http://llvm.org/viewvc/llvm-project?rev=287380&view=rev Log: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Differential Revision: https

r287378 - [ARM] Fix sema check of ARM special register names

Author: oleg Date: Fri Nov 18 15:00:08 2016 New Revision: 287378 URL: http://llvm.org/viewvc/llvm-project?rev=287378&view=rev Log: [ARM] Fix sema check of ARM special register names Summary: This is a simple sema check patch for arguments of `__builtin_arm_rsr` and the related builtins, which cu

[PATCH] D26868: Sema: As of MSVC 2015, a user-declared move operation causes the deletion of both copy operations.

pcc created this revision. pcc added reviewers: rnk, rsmith. pcc added a subscriber: cfe-commits. https://reviews.llvm.org/D26868 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/MicrosoftCompatibility.cpp Index: clang/test/SemaCXX/MicrosoftCompatibility.cpp

[PATCH] D26816: [libcxx] [test] Fix non-Standard assumptions when testing sample().

STL_MSFT marked an inline comment as done. STL_MSFT added a comment. Added the requested comment, will commit. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.sample/sample.pass.cpp:74 assert(end.base() - oa == std::min(os, is)); - assert(std::equal(oa,

[libcxx] r287383 - [libcxx] [test] D26816: Fix non-Standard assumptions when testing sample().

Author: stl_msft Date: Fri Nov 18 15:54:43 2016 New Revision: 287383 URL: http://llvm.org/viewvc/llvm-project?rev=287383&view=rev Log: [libcxx] [test] D26816: Fix non-Standard assumptions when testing sample(). sample() isn't specified with a reproducible algorithm, so expecting exact output is n

[libcxx] r287381 - [libcxx] [test] D26813: allocator is non-Standard.

Author: stl_msft Date: Fri Nov 18 15:54:31 2016 New Revision: 287381 URL: http://llvm.org/viewvc/llvm-project?rev=287381&view=rev Log: [libcxx] [test] D26813: allocator is non-Standard. N4582 17.6.3.5 [allocator.requirements] says that allocators are given cv-unqualified object types, and N4582 2

[libcxx] r287382 - [libcxx] [test] D26815: Fix an assumption about the state of moved-from std::functions.

Author: stl_msft Date: Fri Nov 18 15:54:38 2016 New Revision: 287382 URL: http://llvm.org/viewvc/llvm-project?rev=287382&view=rev Log: [libcxx] [test] D26815: Fix an assumption about the state of moved-from std::functions. The Standard doesn't provide any guarantees beyond "valid but unspecified

  1   2   >