r285140 - [Myriad] Find libc++ adjacent to libstdc++

2016-10-25 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Oct 25 18:02:30 2016 New Revision: 285140 URL: http://llvm.org/viewvc/llvm-project?rev=285140&view=rev Log: [Myriad] Find libc++ adjacent to libstdc++ Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-tool

Re: r284272 - Implement no_sanitize_address for global vars

2016-10-25 Thread Kostya Serebryany via cfe-commits
ping On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote: > Did you code-review this? > (sorry if I missed it) > > On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dougk >> Date: Fri Oct 14 14:55:09 2016 >> New Revision: 2

Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

2016-10-25 Thread Brad Smith via cfe-commits
On 10/18/16 22:13, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: Author: emaste Date: Fri Oct 14 12:59:53 2016 New Revision: 284256 URL: http://llvm.org/vie

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-10-25 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 75812. tra added a comment. - Instead of relying on the first attribute we find, check all matching ones. - Specializations inherit their target attributes from their base template only. Their effective target always matches that of the template and is no longer

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

2016-10-25 Thread Artem Belevich via cfe-commits
tra updated this revision to Diff 75816. tra added a comment. - handle using declarations found in the overload set we check. https://reviews.llvm.org/D25809 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sem

[PATCH] D25940: [analyzer] LibraryFunctions: Fix errors due to different integral types and typedefs on different architectures.

2016-10-25 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Are the parameter types actually needed? I think in general the rest of the analyzer uses arity alone. Is the idea to allow for overloads in C++? If so, then I think this equivalent-up-to-size-and-sign approach will disallow those overloads. Commen

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

2016-10-25 Thread Artem Belevich via cfe-commits
tra added a comment. I'm OK with the change, but the comments suggest that things may be more complicated. How about disabling assert for CUDA only? https://reviews.llvm.org/D25640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

2016-10-25 Thread Akira Hatanaka via cfe-commits
ahatanak updated this revision to Diff 75819. ahatanak marked 2 inline comments as done. ahatanak added a comment. Skip the step to correct typo if ParseInitializer returns ExprError(). Add a test case that exercises the change. https://reviews.llvm.org/D25206 Files: lib/Parse/ParseExprCXX.c

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

2016-10-25 Thread Jordan Rose via cfe-commits
jordan_rose retitled this revision from "[WIP] Accept nullability annotations (_Nullable) on array parameters" to "Accept nullability annotations (_Nullable) on array parameters". jordan_rose updated the summary for this revision. jordan_rose updated this revision to Diff 75820. jordan_rose added

r285144 - [Myriad] add empty file to simulated bin dir

2016-10-25 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Oct 25 18:59:11 2016 New Revision: 285144 URL: http://llvm.org/viewvc/llvm-project?rev=285144&view=rev Log: [Myriad] add empty file to simulated bin dir Added: cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/ cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/.k

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

2016-10-25 Thread Jordan Rose via cfe-commits
jordan_rose marked an inline comment as done. jordan_rose added a comment. Oops. Ignore the API notes file, which is only in Swift's branch of Clang right now. Repository: rL LLVM https://reviews.llvm.org/D25850 ___ cfe-commits mailing list cfe-

[PATCH] D25958: [libc++] Silence "unused parameter" warnings in test/support/archetypes.hpp

2016-10-25 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

2016-10-25 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

r285150 - Implement name mangling proposal for exception specifications from cxx-abi-dev 2016-10-11.

2016-10-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 25 20:05:54 2016 New Revision: 285150 URL: http://llvm.org/viewvc/llvm-project?rev=285150&view=rev Log: Implement name mangling proposal for exception specifications from cxx-abi-dev 2016-10-11. This has the following ABI impact: 1) Functions whose parameter or ret

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

2016-10-25 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Looks better than before. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285152 - Treat module headers wrapped by our builtin headers as implicitly being textual

2016-10-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 25 20:08:55 2016 New Revision: 285152 URL: http://llvm.org/viewvc/llvm-project?rev=285152&view=rev Log: Treat module headers wrapped by our builtin headers as implicitly being textual headers. We previously got this check backwards and treated the wrapper header as bei

Re: [libcxx] r249738 - Split out of .

2016-10-25 Thread Richard Smith via cfe-commits
Committed as r285152. On Tue, Oct 25, 2016 at 3:09 PM, Richard Smith wrote: > Missed one change from the test suite: > > Index: test/Modules/cstd.m > === > --- test/Modules/cstd.m (revision 285117) > +++ test/Modules/cstd.m (working

r285154 - [cxx_status] update comment

2016-10-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 25 20:37:36 2016 New Revision: 285154 URL: http://llvm.org/viewvc/llvm-project?rev=285154&view=rev Log: [cxx_status] update comment Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

r285159 - [Sema] Handle CaseStmt and DefaultStmt as SwitchCase

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 25 21:00:00 2016 New Revision: 285159 URL: http://llvm.org/viewvc/llvm-project?rev=285159&view=rev Log: [Sema] Handle CaseStmt and DefaultStmt as SwitchCase Summary: rsmith Differential Revision: https://reviews.llvm.org/D25665 Modified: cfe/trunk/lib/Sema/J

r285158 - [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 25 20:59:57 2016 New Revision: 285158 URL: http://llvm.org/viewvc/llvm-project?rev=285158&view=rev Log: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place Summary: D24693 will need access to it from other places Reviewers: eugenis Subscribers: c

[PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-10-25 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285158: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24695?vs=72908&id=75827#toc Repository: rL LLV

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

2016-10-25 Thread Justin Lebar via cfe-commits
jlebar added a comment. In https://reviews.llvm.org/D25640#579238, @tra wrote: > I'm OK with the change, but the comments suggest that things may be more > complicated. > How about disabling assert for CUDA only? I don't think that is the right approach. This function has nothing to do with

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

2016-10-25 Thread Bob Haarman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285132: [codeview] emit debug info for indirect virtual base classes (authored by inglorion). Changed prior to commit: https://reviews.llvm.org/D25579?vs=75381&id=75804#toc Repository: rL LLVM https

[PATCH] D25974: Fix implementation of the likely resolution of core issue 253 to support class based arrays.

2016-10-25 Thread Ian Tessier via cfe-commits
itessier created this revision. itessier added a subscriber: cfe-commits. https://reviews.llvm.org/D16552 implemented the likely resolution of core issue 253, but didn't include support for class based array fields. E.g.: struct A { } struct B { A a[2]; } const B b; // Fails, but should p

r285132 - [codeview] emit debug info for indirect virtual base classes

2016-10-25 Thread Bob Haarman via cfe-commits
Author: inglorion Date: Tue Oct 25 17:19:32 2016 New Revision: 285132 URL: http://llvm.org/viewvc/llvm-project?rev=285132&view=rev Log: [codeview] emit debug info for indirect virtual base classes Summary: Fixes PR28281. MSVC lists indirect virtual base classes in the field list of a class. This

r285160 - [modules] Fix assert if multiple update records provide a definition for a

2016-10-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Oct 25 21:31:56 2016 New Revision: 285160 URL: http://llvm.org/viewvc/llvm-project?rev=285160&view=rev Log: [modules] Fix assert if multiple update records provide a definition for a class template specialization and that specialization has attributes. Modified: cfe/t

[PATCH] D19853: [safestack] Add -fruntime-init to support invoking functions during runtime init

2016-10-25 Thread Michael LeMay via cfe-commits
mlemay-intel abandoned this revision. mlemay-intel added a comment. I was able to setup a temporary thread control block early enough in musl libc initialization to obviate the need for an attribute like runtime_init. https://reviews.llvm.org/D19853 __

r285162 - Use printf instead of "echo -ne".

2016-10-25 Thread Rui Ueyama via cfe-commits
Author: ruiu Date: Tue Oct 25 22:38:48 2016 New Revision: 285162 URL: http://llvm.org/viewvc/llvm-project?rev=285162&view=rev Log: Use printf instead of "echo -ne". Not all echo commands support "-e". Modified: cfe/trunk/test/Driver/response-file-extra-whitespace.c Modified: cfe/trunk/test/

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

2016-10-25 Thread Justin Lebar via cfe-commits
jlebar added a comment. Is it possible to write a testcase for the using-declaration change? https://reviews.llvm.org/D25809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

2016-10-25 Thread Justin Lebar via cfe-commits
jlebar added a comment. Doesn't look like we changed any testcases when we changed this behavior? The change in behavior may be unobservable, but even still it seems worthwhile to have tests that check that we're not doing any of the alternatives we considered. Comment at:

r285175 - [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

2016-10-25 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Oct 26 00:35:38 2016 New Revision: 285175 URL: http://llvm.org/viewvc/llvm-project?rev=285175&view=rev Log: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. Summary: The preserved input should be the first argument and the vector inputs sh

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

2016-10-25 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285175: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D25902?vs=75557&id=75830#toc Repository:

r285176 - [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Oct 26 00:42:30 2016 New Revision: 285176 URL: http://llvm.org/viewvc/llvm-project?rev=285176&view=rev Log: [CodeGen] Don't emit lifetime intrinsics for some local variables Summary: Current generation of lifetime intrinsics does not handle cases like: ``` { ch

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-25 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285176: [CodeGen] Don't emit lifetime intrinsics for some local variables (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24693?vs=74814&id=75832#toc Repository: rL LLVM

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

2016-10-25 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. gentle ping https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

2016-10-25 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. any progress? https://reviews.llvm.org/D22452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2