Hi All,
Sorry about the delay. I'll unbreak the tests tomorrow afternoon (I have a
midterm in the morning)
/Eric
On Oct 18, 2016 9:00 PM, "Tim Northover" wrote:
> On 15 October 2016 at 13:08, Eric Fiselier via cfe-commits
> wrote:
> > Are these tests still broken for you?
>
> They're still b
On 17/10/16 17:07, Benjamin Kramer wrote:
I'm running into something else and your patch doesn't fix it. It
boils down to 'std::is_nothrow_move_constructible' from libstdc++
not compiling because Foo is not visible inside the noexcept
specification of that template. I failed to come up with a sm
Author: ioeric
Date: Wed Oct 19 03:19:46 2016
New Revision: 284573
URL: http://llvm.org/viewvc/llvm-project?rev=284573&view=rev
Log:
[clang-format] Add comment manipulation header
Summary:
Introduces a separate target for comment manipulation.
Currently, comment manipulation is in BreakableCommen
srhines created this revision.
srhines added a reviewer: cfe-commits.
srhines added subscribers: danalbert, pirama.
Herald added subscribers: tberghammer, rengolin, aemerson.
This is only forced on if there is no non-Cortex-A53 CPU specified as
well. Android's platform and NDK builds need to assum
jmolloy accepted this revision.
jmolloy added a reviewer: jmolloy.
jmolloy added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
srhines added a comment.
From what I can tell, there is no nice way to generate tests for Clang's driver
when producing linker flags. -### only works for the -cc1 command line (which
won't see this flag, since it is only for linking, and not compilation). If
there is a suggestion for how to aut
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Another fix is to move the whole anonymous namespace declaration
completely instead of moving fun/var declarations only.
https://reviews.llvm.org/D25762
Files:
clang-move/ClangMove.cpp
tes
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_anonymous_ns"),
+ usingDecl(InOldCC,
rengolin added a comment.
In https://reviews.llvm.org/D25761#573892, @srhines wrote:
> From what I can tell, there is no nice way to generate tests for Clang's
> driver when producing linker flags. -### only works for the -cc1 command line
> (which won't see this flag, since it is only for link
srhines added a comment.
In https://reviews.llvm.org/D25761#573902, @rengolin wrote:
> In https://reviews.llvm.org/D25761#573892, @srhines wrote:
>
> > From what I can tell, there is no nice way to generate tests for Clang's
> > driver when producing linker flags. -### only works for the -cc1 co
rengolin added a comment.
In https://reviews.llvm.org/D25761#573903, @srhines wrote:
> > I think "clang -v" will show the linker invocation, with all its flags.
>
> But is there a way to get a dry-run of the linker? I don't want to run
> /usr/bin/ld for ARM targets. It seems like all of the othe
bader accepted this revision.
bader added a comment.
LGTM
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Wed Oct 19 06:19:30 2016
New Revision: 284577
URL: http://llvm.org/viewvc/llvm-project?rev=284577&view=rev
Log:
[modules] Do not report missing definitions of demoted constexpr variable
templates.
This is a followup to regression introduced in r284284.
This should fix ou
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r284577.
https://reviews.llvm.org/D25678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I totally misinterpreted this revert. I was confused it reverted
r284284. Sorry for the noise. With the fix introduced in r284577 our
bots should be happy.
On 19/10/16 09:50, Vassil Vassilev wrote:
On 17/10/16 17:07, Benjamin Kramer wrote:
I'm running into something else and your patch doesn'
Author: asbokhan
Date: Wed Oct 19 07:06:10 2016
New Revision: 284579
URL: http://llvm.org/viewvc/llvm-project?rev=284579&view=rev
Log:
[Sema] Gcc compatibility of vector shift
Gcc prints error if elements of left and right parts of a shift have different
sizes. This patch is provided the GCC comp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284579: [Sema] Gcc compatibility of vector shift (authored
by asbokhan).
Changed prior to commit:
https://reviews.llvm.org/D24669?vs=74269&id=75130#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: mgorny
Date: Wed Oct 19 07:21:39 2016
New Revision: 284582
URL: http://llvm.org/viewvc/llvm-project?rev=284582&view=rev
Log:
[cmake] Use LLVM_CMAKE_PATH for GetSVN script
Use the LLVM_CMAKE_PATH variable to locate the GetSVN.cmake script.
The variable was already available in stand-alone
Author: mgorny
Date: Wed Oct 19 07:34:17 2016
New Revision: 284583
URL: http://llvm.org/viewvc/llvm-project?rev=284583&view=rev
Log:
[cmake] Allow testing against installed LLVM with no sources
Adjust the stand-alone build files to accept either CMake files from
LLVM_CMAKE_PATH or from LLVM_MAIN_
mgorny added a comment.
Thanks for the review. Committed now.
Repository:
rL LLVM
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284583: [cmake] Allow testing against installed LLVM with no
sources (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25093?vs=73048&id=75132#toc
Repository:
rL LLVM
https://
fhahn created this revision.
fhahn added a reviewer: hfinkel.
fhahn added a subscriber: cfe-commits.
The patch adds the loop end location to the loop metadata. This additional
information can be used to improve the locations when generating remarks for
loops.
The patch depends on the companion
coby created this revision.
coby added reviewers: m_zuckerman, igorb, AsafBadouh, craig.topper.
coby added a subscriber: cfe-commits.
coby set the repository for this revision to rL LLVM.
The following patch introduces the following alternations:
1. correcting the 'vpmulshiftqb' instruction, alon
eladcohen added a comment.
In https://reviews.llvm.org/D25337#571845, @bruno wrote:
> > The long answer is that there is a history of problems regarding the
> > intrinsic files:
> > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html
> > http://lists.llvm.org/pipermail/cfe-dev/2016-Se
eladcohen created this revision.
eladcohen added reviewers: rsmith, bruno, zvi.
eladcohen added a subscriber: cfe-commits.
-fbuiltin-module-map loads the clang builtins modulemap file.
(This is equivalent to -fmodule-map-file=/include/module.modulemap)
It can be used for enabling clang's 'modules
eladcohen added a comment.
In https://reviews.llvm.org/D25337#571877, @rsmith wrote:
> I really don't like the command-line interface you're proposing here. It
> seems like it will be extremely confusing what something like `-fmodules
> -fexclusive-builtin-modules` means, for instance (usually,
v.g.vassilev added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
Using emplace seems to break our modules libstdc++ 4.7 bu
malcolm.parsons created this revision.
malcolm.parsons added a reviewer: djasper.
malcolm.parsons added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Remove colon and commas after replacing constructor body with = default.
Fix annotation of TT_CtorInitializerColon when preceded by
hokein updated this revision to Diff 75139.
hokein marked 2 inline comments as done.
hokein added a comment.
Address comments.
- Cover type alias declarations.
- Fix an issue of moving function-scope static definitions in non-moved classes.
https://reviews.llvm.org/D25762
Files:
clang-move/C
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:372
+ // Match static functions/variabale definitions which are defined in named
+ // spaces.
+ auto IsOldCCStaticDefinition =
bkramer added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
v.g.vassilev wrote:
> Using emplace seems to break our modules
malcolm.parsons created this revision.
malcolm.parsons added reviewers: angelgarcia, aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
clang-tidy now cleans up after replacements, so leave colon and comma
removal to that.
https://reviews.llvm.org/D25769
Files:
clang-tidy
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D25768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
smeenai added a comment.
Ping.
The way I see it, this doesn't change anything for people not building with
hidden visibility (which should be most people, including the buildbots), but
it does make `_LIBCPP_TYPE_VIS` more useful (and consistent with the existing
Windows behavior) for people bu
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85
+ // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default'
+ // CHECK-FIXES: /* don't delete */ = default;
int Field;
I don't know why cleanup removes th
smeenai updated this revision to Diff 75142.
smeenai added a comment.
Addressing @mclow.lists's comment
https://reviews.llvm.org/D25741
Files:
include/__config
include/fstream
Index: include/fstream
===
--- include/fstream
++
vleschuk updated this revision to Diff 75143.
vleschuk added a comment.
- Removed all changes non-related to CGDebugInfo: will post them in separate
NFC patch which will switch all unsigned alignment entries to uint32_t.
https://reviews.llvm.org/D25621
Files:
lib/CodeGen/CGDebugInfo.cpp
Ind
vleschuk added a comment.
In https://reviews.llvm.org/D25621#573671, @aprantl wrote:
> This patch is conflating two set of changes:
> (1) NFC: rename all occurrences of unsigned for alignment purposes in the
> frontend with uint32_t
> (2) shrink all debug-info-related alignment variables from
Author: d0k
Date: Wed Oct 19 08:50:17 2016
New Revision: 284589
URL: http://llvm.org/viewvc/llvm-project?rev=284589&view=rev
Log:
Don't copy replacements in for-range loop. NFC.
Modified:
cfe/trunk/lib/Format/TokenAnalyzer.cpp
Modified: cfe/trunk/lib/Format/TokenAnalyzer.cpp
URL:
http://llv
Author: d0k
Date: Wed Oct 19 08:50:17 2016
New Revision: 284589
URL: http://llvm.org/viewvc/llvm-project?rev=284589&view=rev
Log:
Don't copy replacements in for-range loop. NFC.
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp
Modified: clang-tools-extra/trunk/inclu
curdeius created this revision.
curdeius added reviewers: alexfh, hokein.
curdeius added a subscriber: cfe-commits.
This adds cert-err09-cpp alias for completeness, similar to cert-err61-cpp.
https://reviews.llvm.org/D25770
Files:
clang-tidy/cert/CERTTidyModule.cpp
docs/clang-tidy/checks/ce
v.g.vassilev added a subscriber: rsmith.
v.g.vassilev added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
bkramer wrote:
>
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D25770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: hokein
Date: Wed Oct 19 09:13:21 2016
New Revision: 284592
URL: http://llvm.org/viewvc/llvm-project?rev=284592&view=rev
Log:
[clang-move] Move using-decl in old cc.
Summary:
Another fix is to move the whole anonymous namespace declaration
completely instead of moving fun/var declarations
This revision was automatically updated to reflect the committed changes.
hokein marked 2 inline comments as done.
Closed by commit rL284592: [clang-move] Move using-decl in old cc. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D25762?vs=75139&id=75146#toc
Repository:
Author: d0k
Date: Wed Oct 19 09:22:38 2016
New Revision: 284595
URL: http://llvm.org/viewvc/llvm-project?rev=284595&view=rev
Log:
Remove unused diagnostics. NFC.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
Author: mkurdej
Date: Wed Oct 19 09:28:19 2016
New Revision: 284596
URL: http://llvm.org/viewvc/llvm-project?rev=284596&view=rev
Log:
[clang-tidy] Add cert-err09-cpp check alias.
Summary: This adds cert-err09-cpp alias for completeness, similar to
cert-err61-cpp.
Reviewers: alexfh, hokein
Subs
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
when replacing symbol references in moved namespaces, trying to make the replace
name as short as possible by considering UsingDecl (i.e. UsingShadow) and
UsingDirectiveDecl (i.e. using namespace
ioeric abandoned this revision.
ioeric added a comment.
Thanks all!
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks, this LGTM!
https://reviews.llvm.org/D25621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: marshall
Date: Wed Oct 19 10:12:50 2016
New Revision: 284602
URL: http://llvm.org/viewvc/llvm-project?rev=284602&view=rev
Log:
Implement constexpr support for reverse_iterator. Reviewed as
https://reviews.llvm.org/D25534
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/test/
mclow.lists closed this revision.
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
Landed as revision 284602
https://reviews.llvm.org/D25534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Target/X86/X86ISelLowering.cpp:32315
+}
+ // Else fall through (handle "Y" constraint).
case 'v':
Use LLVM_FALLTHROUGH here to avoid w
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
https://reviews.llvm.org/D25702
___
cfe-commi
jlebar added a comment.
In https://reviews.llvm.org/D25702#574289, @rnk wrote:
> lgtm
>
> I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
Yes, that's in https://reviews.llvm.org/D25704.
https://reviews.llvm.org/D25702
___
rnk added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
Rather than having a custom key type, maybe it would be better to phrase this
as a `MapVector,
arphaman created this revision.
arphaman added reviewers: rjmccall, manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an invalid `Winitializer-overrides` warning that's shown for a
piece of code like this:
template
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Why this change?
https://rev
vsk updated this revision to Diff 75168.
vsk added a comment.
Thanks for the feedback!
Patch update:
- Pass in the right CalleeDecl to EmitCXXMemberOrOperatorCall. This lets us
drop the unnecessary 'DevirtualizedClassTy' optional parameter.
- Extend the test case with John's example (devirt for
mclow.lists added a comment.
In https://reviews.llvm.org/D25595#572043, @timshen wrote:
> BTW, `re.const/re.matchflag/match_flag_type.pass.cpp` contains match_not_bow,
> but it doesn't actually test the functionality.
It tests that it exists and that it has a sane value - which are a good thin
Author: dougk
Date: Wed Oct 19 12:30:40 2016
New Revision: 284617
URL: http://llvm.org/viewvc/llvm-project?rev=284617&view=rev
Log:
[Myriad] Find libc++ headers next to clang binary
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk
mclow.lists added a comment.
Do we need to test calling `regex_match` with `match_not_null`?
If not, then I think this is good to go.
Do you have commit access, or would you rather I committed it?
https://reviews.llvm.org/D25595
___
cfe-commits mai
Anastasia added a comment.
In https://reviews.llvm.org/D25343#567374, @tstellarAMD wrote:
> In https://reviews.llvm.org/D25343#565288, @Anastasia wrote:
>
> > Do you have any code example where Clang/LLVM performs wrong optimizations
> > with respect to the control flow of SPMD execution?
> >
>
hans created this revision.
hans added a reviewer: pcc.
hans added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
getClassAtVTableLocation() was calling ASTRecordLayout::getBaseClassOffset() on
a virtual base, causing an assert.
https://reviews.llvm.org/D25779
Files:
lib/
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sdardis
Date: Wed Oct 19 12:50:52 2016
New Revision: 284620
URL: http://llvm.org/viewvc/llvm-project?rev=284620&view=rev
Log:
[mips][msa] Range check MSA intrinsics with immediates
This patch teaches clang to range check immediates for MIPS MSA instrinsics.
This checking is done strictly
srhines updated this revision to Diff 75174.
srhines added a comment.
Added a test for this behavior.
I missed that "-### -v" was actually working correctly last night. Tests added
so I am more satisfied that this won't break accidentally in the future.
https://reviews.llvm.org/D25761
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284620: [mips][msa] Range check MSA intrinsics with
immediates (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D25017?vs=74499&id=75173#toc
Repository:
rL LLVM
https://revie
mclow.lists added a comment.
I don't have a problem with this being marked as inline, as long as it doesn't
disappear out of the dylib.
There *has* to be a version of `basic_string,
Allocator>::~basic_string` in the dylib - existing applications depend
upon it. (same for `wchar_t`).
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284624: MS ABI: Fix assert when generating virtual function
call with virtual bases and… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D25779?vs=75171&id=75177#toc
Repository:
Author: hans
Date: Wed Oct 19 13:04:27 2016
New Revision: 284624
URL: http://llvm.org/viewvc/llvm-project?rev=284624&view=rev
Log:
MS ABI: Fix assert when generating virtual function call with virtual bases and
-flto (PR30731)
getClassAtVTableLocation() was calling
ASTRecordLayout::getBaseClassO
mclow.lists added a comment.
This is the same problem as is facing https://reviews.llvm.org/D24991
https://reviews.llvm.org/D25624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malcolm.parsons wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman w
jlebar updated this revision to Diff 75178.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address rnk's comments.
https://reviews.llvm.org/D25704
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/
sdardis added a comment.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
rnk wrote:
> Rather than having a custom key type, maybe it would be better to phrase this
rnk added a comment.
In https://reviews.llvm.org/D19996#422906, @rafael wrote:
> Is there a gcc option or they just assume they are targeting the
> linker that was around when gcc was built?
IIRC there's no GCC option. They base their decision on the configure-time
check like you suggested.
tmsriram updated this revision to Diff 75179.
tmsriram added a comment.
- Changed help text to "Avail copy relocations support for PIE builds"
- Removed mno-pie... as a CC1 option
- Removed help text from mno-pie..
https://reviews.llvm.org/D19996
Files:
include/clang/Driver/Options.td
inclu
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks.
https://reviews.llvm.org/D25448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def note_called_by : Note<"called by %0">;
def err_kern_type_not_void_return : Error<
Do
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include/clang/Driver/Options.td:1696
+ Flags<[CC1Option]>,
+ HelpText<"Copy Relocations support for PIE builds">;
+def mno_pie_copy_relocations : Flag<["-"], "mn
mgrang added inline comments.
Comment at: lib/Driver/Tools.cpp:4502
+ if (Args.hasFlag(options::OPT_mpie_copy_relocations,
options::OPT_mno_pie_copy_relocations,
+ false)) {
Please fix indentation.
Comment at: lib/Frontend
tmsriram added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:589
Args.hasArg(OPT_mincremental_linker_compatible);
+ Opts.PIECopyRelocations =
+ Args.hasArg(OPT_mpie_copy_relocations);
mgrang wrote:
> You should also check for the n
timshen added a comment.
In https://reviews.llvm.org/D25595#574364, @mclow.lists wrote:
> Do we need to test calling `regex_match` with `match_not_null`?
> If not, then I think this is good to go.
Done.
> Do you have commit access, or would you rather I committed it?
Yes, I have the commit a
tmsriram updated this revision to Diff 75189.
tmsriram added a comment.
- Fix Help text.
- Fix indentation.
https://reviews.llvm.org/D19996
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/Co
timshen updated this revision to Diff 75186.
timshen added a comment.
Add tests for regex_match.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > malcolm.parsons
majnemer added a comment.
Why did this only fail with -flto? Seems strange.
Repository:
rL LLVM
https://reviews.llvm.org/D25779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D25779#574630, @majnemer wrote:
> Why did this only fail with -flto? Seems strange.
I was asking myself the same thing :-) It's because of this code in
MicrosoftCXXABI::getVirtualFunctionPointer:
if (CGM.getCodeGenOpts().PrepareForLTO) // XX
yaxunl updated this revision to Diff 75203.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Fix typo in test.
https://reviews.llvm.org/D25343
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CGCall.cpp
lib/Headers/opencl-c.h
lib/Sema/Sema
yaxunl added a comment.
> Should we deprecate noduplicate then as convergent should cover both use
> cases for OpenCL I believe? As far as I understand noduplicate was added
> specifically for SPMD use cases...
noduplicate has different semantics than convergent. Although it is proposed
for SP
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malcolm.parsons wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman w
mgorny added a comment.
Do you think I should just focus on the suffix, or maybe try to make the whole
path configurable?
https://reviews.llvm.org/D23752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: vedantk
Date: Wed Oct 19 15:21:16 2016
New Revision: 284636
URL: http://llvm.org/viewvc/llvm-project?rev=284636&view=rev
Log:
[ubsan] Use the object pointer's type info for devirtualized calls
ubsan reports a false positive 'invalid member call' diagnostic on the
following example (PR3047
Author: tmsriram
Date: Wed Oct 19 15:24:06 2016
New Revision: 284638
URL: http://llvm.org/viewvc/llvm-project?rev=284638&view=rev
Log:
New clang option -mpie-copy-relocations to use copy relocations for PIE builds.
Differential Revision: https://reviews.llvm.org/D19996
Modified:
cfe/trunk/in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284638: New clang option -mpie-copy-relocations to use copy
relocations for PIE builds. (authored by tmsriram).
Changed prior to commit:
https://reviews.llvm.org/D19996?vs=75189&id=75212#toc
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284636: [ubsan] Use the object pointer's type info for
devirtualized calls (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25448?vs=75168&id=75211#toc
Repository:
rL LLVM
h
Author: vedantk
Date: Wed Oct 19 15:28:35 2016
New Revision: 284639
URL: http://llvm.org/viewvc/llvm-project?rev=284639&view=rev
Log:
[ubsan] Re-work check lines to try to appease a bot (NFC)
This bot does not produce the IR I expect -- it's missing some
'handler.dynamic_type_cache_miss:' labels.
1 - 100 of 152 matches
Mail list logo
