timshen updated this revision to Diff 74894.
timshen marked an inline comment as done.
timshen added a comment.
Updated file location and documentation.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libc
timshen added a comment.
In https://reviews.llvm.org/D25595#571171, @mclow.lists wrote:
> I like the fix. :-)
>
> However, I think that the test, rather than going in a bug specific file
> (pr21597.pass.cpp), should be added to the existing tests - where it should
> have been in the first place
ahatanak added a comment.
In https://reviews.llvm.org/D25556#569809, @rjmccall wrote:
> Richard should probably weigh in about whether we should be recording
> potential captures at *all* capturing scopes. But at the very least, I think
> you have a bug here where the variable is declared outs
Author: adrian
Date: Mon Oct 17 15:37:56 2016
New Revision: 284423
URL: http://llvm.org/viewvc/llvm-project?rev=284423&view=rev
Log:
Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment
target.
This fixes the green dragon builders after r284416.
Modified:
cfe/trunk/test
rjmccall added a comment.
In https://reviews.llvm.org/D25448#571941, @vsk wrote:
> Thanks for your feedback so far, and sorry for the delayed response.
>
> In https://reviews.llvm.org/D25448#570014, @rjmccall wrote:
>
> > Wait, can you talk me through the bug here?
>
>
> Derived inherits from Bas
rjmccall added a comment.
Thanks! A couple minor tweaks, then LGTM.
Comment at: lib/CodeGen/CGExpr.cpp:1652
+Src = RValue::get(EmitObjCExtendObjectLifetime(Dst.getType(),
+ Src.getScalarVal()));
// fall into
mgorny created this revision.
mgorny added reviewers: bkramer, bruno, rafael.
mgorny added a subscriber: cfe-commits.
Replace the string matching for /etc/debian_version with split
integer/string matching algorithm. When the file contains 'major.minor'
version number, parse the major version as in
vleschuk updated this revision to Diff 74899.
vleschuk added a comment.
- Use uint32_t directly for alignment instead of creating typedef ofr it
- Get rid of DebugInfo dependency in AST
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DeclBase.h
lib/
rjmccall added a comment.
In https://reviews.llvm.org/D25556#572054, @ahatanak wrote:
> In https://reviews.llvm.org/D25556#569809, @rjmccall wrote:
>
> > Richard should probably weigh in about whether we should be recording
> > potential captures at *all* capturing scopes. But at the very least
Hi,
On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote:
> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes
> wrote:
>>
>> Hi Richard,
>>
>> I have a patch on top of your suggested patch from a year ago, that
>> break the cyclic dependency we're seeing, with this (and a few changes
>> to t
phosek created this revision.
phosek added a reviewer: davide.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
When comparing the linker name in Fuchsia driver, use stem rather than filename
to get the name of the linker becase on Windows, the filen
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thank you for the cleanup!
Anna.
https://reviews.llvm.org/D25663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Was going to commit the same. Thanks. LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists
davide added a comment.
And yes, if you can add a test case that will be great (there's no bot that
caught this upstream) but one of our internal bots did.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-comm
bruno added a reviewer: bruno.
bruno added a comment.
Can you add a testcase for that?
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
phosek added a comment.
In https://reviews.llvm.org/D25700#572158, @bruno wrote:
> Can you add a testcase for that?
This is already covered by an existing testcase which was failing on Windows
(davide pointed that out to me).
Repository:
rL LLVM
https://reviews.llvm.org/D25700
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, rnk.
This fixes two related bugs:
1. Previously, if you had a non-wrong side call at some source code
location L, we wouldn't emit errors for wrong-side calls that appeared
at L.
2. We'd only emit
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
Previously, when you did something not allowed in a host+device function
and then caused it to be codegen'ed, we would print out an error telling
you that you did something bad, but we wouldn't
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
CanonicalDeclPtr is just like a T*, except it calls
T::getCanonicalDecl() on construction.
This is useful as the key in a "set of canonical Decls" -- it's much
less error-prone than calling get
bruno accepted this revision.
bruno added a comment.
Ok, thanks! LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phosek
Date: Mon Oct 17 17:02:53 2016
New Revision: 284430
URL: http://llvm.org/viewvc/llvm-project?rev=284430&view=rev
Log:
[Driver] Use stem rather than filename for executable name
When comparing the linker name in Fuchsia driver, use stem rather
than filename to get the name of the li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284430: [Driver] Use stem rather than filename for
executable name (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D25700?vs=74905&id=74917#toc
Repository:
rL LLVM
https://re
vsk retitled this revision from "[ubsan] Disable -fsanitize=vptr checks for
devirtualized calls" to "[ubsan] Use the object pointer's type info for
devirtualized calls".
vsk updated the summary for this revision.
vsk added a subscriber: rsmith.
vsk updated this revision to Diff 74916.
vsk added a
falho removed rL LLVM as the repository for this revision.
falho updated this revision to Diff 74908.
falho added a comment.
Herald added subscribers: modocache, mgorny, beanz.
updated diff according to first reviews
https://reviews.llvm.org/D22346
Files:
clang-tidy/cert/.LimitedRandomnessChe
> On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>
> Hi,
>
> On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote:
>> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes
>> wrote:
>>>
>>> Hi Richard,
>>>
>>> I have a patch on top of your suggested patch from a
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
This is better than what I asked for :]
Manman
https://reviews.llvm.org/D25284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
manmanren added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10129
+!Var->isThisDeclarationADemotedDefinition()) {
+ assert(Var->isThisDeclarationADemotedDefinition() &&
getLangOpts().Modules
+ && "Demoting decls is only in the contest of modules!"
> @Bruno,
>
> Can you try "-fdiagnostics-show-note-include-stack” so we know the other path
> that leads to string.h?
Attached the complete error log (this snippet won't help without full
context anyway)
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
output.log
Description: Binary data
_
dberris added a comment.
Sorry for the delay, I had thought I pointed to some potentially helpful
documentation. :/
BTW, did the test get removed from the latest change? I don't see it being
added anymore.
https://reviews.llvm.org/D24799
___
cfe-
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
Since this doubles the size of the type loc for builtin types, do you happen to
have any data
aaron.ballman added a comment.
Thank you for continuing your efforts on this, I have just a few minor nits
remaining.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDecl->getLocStart(),
+ "rand() function has limited randomness; " + msg);
+}
---
vsk created this revision.
vsk added a reviewer: jlebar.
vsk added a subscriber: cfe-commits.
https://reviews.llvm.org/D25711
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
Index: lib/Basic/SourceManager.cpp
===
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
The great thing about unique_ptr is, if it compiles, we're probably good. :)
https://reviews.llvm.org/D25711
___
cfe-commits mailing list
cfe-co
dberris added a comment.
In https://reviews.llvm.org/D24799#566507, @rSerge wrote:
> I have extended this feature to check for OS support too (currently Linux
> only). I can't commit it so far because I don't know how to implement a test.
> XFAIL cannot check for both CPU and OS: it can only ch
Author: vedantk
Date: Mon Oct 17 19:23:27 2016
New Revision: 284442
URL: http://llvm.org/viewvc/llvm-project?rev=284442&view=rev
Log:
[Basic] unique_ptr-ify SourceManager::MacroArgsCacheMap (NFC)
Differential Revision: https://reviews.llvm.org/D25711
Modified:
cfe/trunk/include/clang/Basic/S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284442: [Basic] unique_ptr-ify
SourceManager::MacroArgsCacheMap (NFC) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25711?vs=74935&id=74937#toc
Repository:
rL LLVM
https:
Did you code-review this?
(sorry if I missed it)
On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dougk
> Date: Fri Oct 14 14:55:09 2016
> New Revision: 284272
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
> Log:
>
Author: cbieneman
Date: Mon Oct 17 19:50:20 2016
New Revision: 284443
URL: http://llvm.org/viewvc/llvm-project?rev=284443&view=rev
Log:
[CMake] Add a few default passthrough variables for bootstrap builds
This just passes through a few missing CMake variables for multi-stage builds.
Modified:
jlebar added a comment.
> The tests should be runnable with lit. I generally just do an in-tree build
> and run make check-libcxx. @EricWF , what's the recommended way of running
> the tests from an out-of-tree build?
Things seem broken at the moment with clang from tip of tree.
I did a clean
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks for working on this!
Fwiw, I double-checked the API coverage with:
$ git grep -E "CXCursor_[a-zA-Z_0-9]+ *= *[0-9]+" | grep -Eo "[0-9]+" | sort -u
| uniq | wc -l
2
beanz added a comment.
Is there a bug you're trying to fix here? It seems to me that the existing
behavior works correctly. I'm also pretty sure from the comment in
https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in the list.
https://reviews.llvm.org/D23745
vsk updated this revision to Diff 74943.
vsk added a comment.
- Remove some default arguments left over from an older revision of this patch.
- Simplify the test.
https://reviews.llvm.org/D25448
Files:
lib/CodeGen/CGExprCXX.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCXX/ubsan-devirtual
beanz added a comment.
Looking more closely at this, there is a problem that I see.
The clang runtime directory only supports building compiler-rt, and is going to
be replaced by the llvm runtimes directory in the (hopefully near) future.
Maybe a better way to go is to define `RUNTIMES_LIBDIR_S
rjmccall added a comment.
In https://reviews.llvm.org/D25448#572245, @vsk wrote:
> Patch update: Pass along the type info of the derived class to the ubsan
> runtime when we devirtualize a method call. This squashes the FP. I tested
> this with 'check-ubsan' in addition to adding a lit test.
>
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:31
+CallArgList &Args, CallArgList *RtlArgs,
+llvm::Optional DevirtualizedClassTy) {
assert(CE == nullptr || isa(CE) ||
Shouldn't MD just be the devirtualized method? That should av
ahatanak updated this revision to Diff 74944.
ahatanak added a comment.
Address review comments. Simplify and add comments.
https://reviews.llvm.org/D25547
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunct
Hi Erik,
This change does not work with one of the headers from the AVFoundation
framework in tvOS 10.0. We can try to get a fix into the tvOS SDK, but it will
probably be a while before we could release an SDK with that change. In the
meantime, this is kind of disruptive. Can you find a way to
mgorny added a comment.
In https://reviews.llvm.org/D23745#572517, @beanz wrote:
> Is there a bug you're trying to fix here? It seems to me that the existing
> behavior works correctly. I'm also pretty sure from the comment in
> https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in th
Hahnfeld updated this revision to Diff 74948.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Update comments to express that `platform` should only be used in tests
https://reviews.llvm.org/D25669
Files:
lib/Driver/ToolChain.cpp
Index: lib/Driver/ToolChain.cpp
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:553-559
+ // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB
+ if (LibName == "libc++")
+return ToolChain::CST_Libcxx;
+ else if (LibName == "libstdc++")
+return ToolChain::CST_L
RedX2501 added a comment.
Has this been merged yet?
https://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a comment.
Ping?
https://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Oct 18 01:47:03 2016
New Revision: 284457
URL: http://llvm.org/viewvc/llvm-project?rev=284457&view=rev
Log:
[c++1z] Use canonical expression equivalence to determine whether two different
dependent noexcept specifications result in the same canonical function type.
We sti
101 - 153 of 153 matches
Mail list logo
