Hahnfeld added a comment.
Have you run all tests with `CLANG_DEFAULT_LINKER` not being the platform
default? I imagine there might be some tests that expect `ld` to be used...
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use
Hahnfeld created this revision.
Hahnfeld added reviewers: mgorny, ddunbar, phosek.
Hahnfeld added subscribers: cfe-commits, zlei.
I made the wrong assumption that execution would continue after an error Diag
which led to unneeded complex code.
This patch aligns with the better implementation of
Author: hokein
Date: Mon Oct 17 03:33:59 2016
New Revision: 284368
URL: http://llvm.org/viewvc/llvm-project?rev=284368&view=rev
Log:
Recommit "[ClangTidy] Add UsingInserter and NamespaceAliaser"
Summary: This adds helper classes to add using declaractions and namespace
aliases to function bodies
Yeah, "make -j 32" won't compile binaries in clang-tools-extra repo.
"make check-clang-tools" should work though I don't use make. I usually run
`ninja check-clang-tools` command to build all binaries and run all
lint-tests/unittest in clang-extra-tools. There is a remaining build error
in the uni
hokein abandoned this revision.
hokein added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005
+/// \endcode
+AST_MATCHER(VarDecl, isStaticDataMember) {
+ return Node.isStaticDataMember();
aaron.ballman wrote:
> hokein wrote:
> > aaron.ba
Author: hokein
Date: Mon Oct 17 05:05:25 2016
New Revision: 284370
URL: http://llvm.org/viewvc/llvm-project?rev=284370&view=rev
Log:
Fix windows buildbot error.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/NamespaceAliaserTest.cpp
clang-tools-extra/trunk/unittests/clang-tidy/Usi
Author: vvassilev
Date: Mon Oct 17 05:15:25 2016
New Revision: 284372
URL: http://llvm.org/viewvc/llvm-project?rev=284372&view=rev
Log:
Do not reset TUScope when we are in incremental processing mode.
Patch by Axel Naumann!
Reviewed by Richard Smith and me.
Modified:
cfe/trunk/lib/Sema/Sema
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r284372.
https://reviews.llvm.org/D25602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
aprantl wrote:
> I'm not sure we want t
ABataev added inline comments.
Comment at: lib/Driver/ToolChain.cpp:553-559
+ // "platform" is only used in tests to override CLANG_DEFAULT_CXX_STDLIB
+ if (LibName == "libc++")
+return ToolChain::CST_Libcxx;
+ else if (LibName == "libstdc++")
+return ToolChain::CST_Li
On 16 October 2016 at 22:13, Davide Italiano wrote:
> On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva wrote:
>> Nice to see this land!
>>
>> One nit:
>> Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user
>> uses the "gold syntax" then LLD will silently ignore it, which isn't
ABataev added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1438
+ if (GCCToolchainDir == "" || GCCToolchainDir == D.SysRoot + "/usr") {
+for (unsigned k = 0, ke = CandidateTripleAliases.size(); k < ke; ++k) {
+ llvm::ErrorOr> File =
Use range-
rSerge updated this revision to Diff 74829.
https://reviews.llvm.org/D24799
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -4804,7 +4804,16 @@
if (Args.hasFla
rSerge added a comment.
Ping? (please, see the question about the test)
https://reviews.llvm.org/D24799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kparzysz added a comment.
This change
bool FileManager::getStatValue(StringRef Path, FileData &Data, bool isFile,
std::unique_ptr *F) {
// FIXME: FileSystemOpts shouldn't be passed in here, all paths should be
// absolute!
llvm::dbgs() << "FileSystemOp
kparzysz added a comment.
In https://reviews.llvm.org/D25597#571532, @kparzysz wrote:
> `FileSystemOpts.WorkingDir: ''`
There is no space between the single quotes.
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.ll
kparzysz added a comment.
Printing Path shows
`/../target/hexagon/include`
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added a comment.
ping.
https://reviews.llvm.org/D25363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Mon Oct 17 08:00:44 2016
New Revision: 284382
URL: http://llvm.org/viewvc/llvm-project?rev=284382&view=rev
Log:
Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling
of"
This reverts commit r284176. It still marks some modules as invisible
that should b
elsteveogrande added a comment.
I'll need help landing this... I also tried `git svn dcommit` but command hung
there forever.
Thanks!
https://reviews.llvm.org/D25153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
On Mon, Oct 17, 2016 at 5:13 AM, Rafael Espíndola <
rafael.espind...@gmail.com> wrote:
> On 16 October 2016 at 22:13, Davide Italiano wrote:
> > On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva
> wrote:
> >> Nice to see this land!
> >>
> >> One nit:
> >> Currently, doesn't LLD/ELF ignore -plugin-opt?
ikudrin created this revision.
ikudrin added reviewers: compnerd, ABataev, erik.pilkington, ogoffart.
ikudrin added a subscriber: cfe-commits.
https://reviews.llvm.org/D25673
Files:
bindings/python/clang/cindex.py
Index: bindings/python/clang/cindex.py
=
mclow.lists added inline comments.
Comment at: libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp:12
+
+// template
+// bool
Rather than this comment about `regex_search`, there should be a comment about
`match_not_null`, which is really what we're te
Author: kparzysz
Date: Mon Oct 17 08:23:41 2016
New Revision: 284383
URL: http://llvm.org/viewvc/llvm-project?rev=284383&view=rev
Log:
Return correct path from HexagonToolChain::getHexagonTargetDir
This problem was exposed by r284129, causing clang-hexagon-elf to fail
clang tests.
Modified:
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman.
hubert.reinterpretcast added subscribers: nwilson, cfe-commits.
This adds associated constraints as a property of class templates.
An error is produced if redeclarations are not si
On Mon, Oct 17, 2016 at 6:15 AM, Teresa Johnson
wrote:
>
>
> On Mon, Oct 17, 2016 at 5:13 AM, Rafael Espíndola <
> rafael.espind...@gmail.com> wrote:
>
>> On 16 October 2016 at 22:13, Davide Italiano wrote:
>> > On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva
>> wrote:
>> >> Nice to see this land!
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Previously, automatic semicolon insertion would add an unwrapped line
when a template string contained a line break.
var x = `foo${
bar}`;
Would b
On 14 October 2016 at 13:33, Tim Northover wrote:
> On 14 October 2016 at 06:01, Haojian Wu via cfe-commits
> wrote:
>> + std::string GuardName(FileName);
>> + if (IsHeader) {
>> +std::replace(GuardName.begin(), GuardName.end(), '/', '_');
>> +std::replace(GuardName.begin(), GuardName.e
sammccall added a comment.
Ping - let me know if there's a more appropriate reviewer!
https://reviews.llvm.org/D25311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
And now the test fails everywhere, including the hexagon bot. Please fix.
On Mon, Oct 17, 2016 at 3:23 PM, Krzysztof Parzyszek via cfe-commits
wrote:
> Author: kparzysz
> Date: Mon Oct 17 08:23:41 2016
> New Revision: 284383
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284383&view=rev
> Log:
I was just to commit a fix :(
On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote:
Author: d0k
Date: Mon Oct 17 08:00:44 2016
New Revision: 284382
URL: http://llvm.org/viewvc/llvm-project?rev=284382&view=rev
Log:
Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling
Too slow ;)
Do you have the fix somewhere, so I can try it?
On Mon, Oct 17, 2016 at 4:38 PM, Vassil Vassilev wrote:
> I was just to commit a fix :(
>
> On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote:
>>
>> Author: d0k
>> Date: Mon Oct 17 08:00:44 2016
>> New Revision: 284382
>>
>> URL:
On 17/10/16 16:40, Benjamin Kramer wrote:
Too slow ;)
Do you have the fix somewhere, so I can try it?
That would be https://reviews.llvm.org/D25678
Do you run into something else than what I have as a test case (merging
templated constexpr variables)?
On Mon, Oct 17, 2016 at 4:38 PM, Vassil
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, bkramer.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D25678
Files:
lib/Sema/SemaDecl.cpp
test/Modules/Input
Author: kparzysz
Date: Mon Oct 17 09:47:29 2016
New Revision: 284389
URL: http://llvm.org/viewvc/llvm-project?rev=284389&view=rev
Log:
Revert r284383, while I figure out how to reproduce the failures locally
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolCha
danielmarjamaki updated this revision to Diff 74849.
danielmarjamaki added a comment.
make pattern to avoid warnings more specific
Repository:
rL LLVM
https://reviews.llvm.org/D25606
Files:
lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp
test/Analysis/unreachable-code-path.c
Ind
On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk
wrote:
> vleschuk marked an inline comment as done.
> vleschuk added inline comments.
>
>
>
> Comment at: include/clang/AST/ASTContext.h:83
> uint64_t Width;
> -unsigned Align;
> +llvm::DIAlignment Align;
> bool Ali
I'm running into something else and your patch doesn't fix it. It
boils down to 'std::is_nothrow_move_constructible' from libstdc++
not compiling because Foo is not visible inside the noexcept
specification of that template. I failed to come up with a small test
case so far as it involves at least
Hello Tim,
Sorry for the trouble and delay (I missed this email previously).
I'm looking into it. Could you give me a link to the problematic buildbot?
On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover
wrote:
> On 14 October 2016 at 13:33, Tim Northover
> wrote:
> > On 14 October 2016 at 06:01,
ahatanak updated this revision to Diff 74851.
ahatanak added a comment.
Simplify the code a bit more.
https://reviews.llvm.org/D25547
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGObjC.cpp
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenOb
Not worth/reasonable to have a test case?
On Thu, Oct 13, 2016 at 7:44 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Oct 13 21:35:11 2016
> New Revision: 284187
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284187&view=rev
> Log:
> Fix bogus
Author: hokein
Date: Mon Oct 17 10:26:34 2016
New Revision: 284391
URL: http://llvm.org/viewvc/llvm-project?rev=284391&view=rev
Log:
[clang-move] Fix generating illegal header guard.
The filepath might contain some characters (i.e. '@') which are not
illegal in c identifiers. This patch changes a
Author: kparzysz
Date: Mon Oct 17 10:30:10 2016
New Revision: 284392
URL: http://llvm.org/viewvc/llvm-project?rev=284392&view=rev
Log:
Reapply r284383. The test failures were due to a missing dir in test/
Added:
cfe/trunk/test/Driver/Inputs/hexagon_tree/Tools/bin/
Modified:
cfe/trunk/lib/
Should be fixed in r284391.
On Mon, Oct 17, 2016 at 4:59 PM, Haojian Wu wrote:
> Hello Tim,
>
> Sorry for the trouble and delay (I missed this email previously).
>
> I'm looking into it. Could you give me a link to the problematic buildbot?
>
> On Mon, Oct 17, 2016 at 3:44 PM, Tim Northover
> w
mgorny added a comment.
Thanks for working on this. Your code is much cleaner ;-).
Comment at: lib/Driver/ToolChain.cpp:553
- // If no argument was provided or its value was invalid, look for the
- // default unless forced or configured to take the platform default.
- if (
mgorny updated this revision to Diff 74855.
mgorny added a comment.
Updated to use range-based for loop as suggested by @ABataev.
https://reviews.llvm.org/D25661
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/gentoo_linux_gcc_multi_version_tree/etc/env.d/gcc/config-x86_64-pc-linux-gnu
ABataev added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
On 17 October 2016 at 08:36, Haojian Wu wrote:
> Sorry for the trouble and delay (I missed this email previously).
No worries. I thought that might be what had happened, the weekend
deluge can hide anything.
> Should be fixed in r284391.
Thanks.
Tim.
___
Agreed. We should define them as aliases to existing options without
-plugin-opt.
On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Nice to see this land!
>
> One nit:
> Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a
> user
kparzysz added a comment.
I committed https://reviews.llvm.org/rL284383 and the Hexagon bot is passing
now. (The patch was reverted, but then it was recommitted.)
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Looks like things are still unexpectedly passing at r284389 on macOS (but
we currently only build and test libc++ on macOS, so maybe it's broken
elsewhere too).
https://codereview.chromium.org/2429533002/
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/106/step
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
ABataev added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
mgorny added a reviewer: beanz.
mgorny added a comment.
A gentle ping here.
https://reviews.llvm.org/D23745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
vleschuk wrote:
> aprantl wrote:
> > I'
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
On 17 October 2016 at 09:11, Nico Weber via cfe-commits
wrote:
> Looks like things are still unexpectedly passing at r284389 on macOS (but we
> currently only build and test libc++ on macOS, so maybe it's broken
> elsewhere too).
Green dragon is showing similar failures:
http://lab.llvm.org:8080/
GorNishanov added a comment.
friendly ping
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov added a comment.
@rsmith, I am wondering what were your thoughts on where to generate try { body
} catch (...) { p.set_exception(std::exception()); }
Would it be in SemaCoroutine.cpp? Essentially, add something like this:
`
bool makeBody() {
if (!OnException)
ret
ABataev added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1446-1463
+ // CURRENT=triple-version
+ if (Line.startswith("CURRENT=")) {
+const std::pair ActiveVersion =
+ Line.substr(8).rsplit('-');
+// Note: Strictly
Ping.
Thanks,
--Serge
2016-10-13 11:51 GMT+07:00 Serge Pavlov :
> sepavloff updated the summary for this revision.
>
> https://reviews.llvm.org/D21508
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
bruno added a comment.
Nice! Thanks
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhen added a comment.
Adding arron.ballman as a reviewer as alexfh seems to be on leave for a few
weeks.
https://reviews.llvm.org/D25450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: alexfh
Date: Mon Oct 17 12:25:02 2016
New Revision: 284399
URL: http://llvm.org/viewvc/llvm-project?rev=284399&view=rev
Log:
[clang-tidy] Clean up code after applying replacements.
Summary:
Remove empty namespaces and initializer list commas / colons in
affected ranges. Initial patch: pro
Hi Krzysztof,
This still seems to be failing on Darwin:
/Users/tim/llvm/llvm/tools/clang/test/Driver/hexagon-toolchain-elf.c:9:14:
error: expected string not found in input
// CHECK000: "-cc1" {{.*}} "-internal-externc-isystem"
"{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/include"
The
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284399: [clang-tidy] Clean up code after applying
replacements. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D24572?vs=74160&id=74868#toc
Repository:
rL LLVM
https://revie
[Re-send to correct addresses.]
On Thu, Dec 26, 2013 at 3:38 PM, Nico Weber wrote:
> Author: nico
> Date: Thu Dec 26 17:38:39 2013
> New Revision: 198063
>
> URL: http://llvm.org/viewvc/llvm-project?rev=198063&view=rev
> Log:
> Warn on mismatched parentheses in memcmp and friends.
>
> Thisadds a
Author: adrian
Date: Mon Oct 17 12:41:51 2016
New Revision: 284400
URL: http://llvm.org/viewvc/llvm-project?rev=284400&view=rev
Log:
Fix a typo.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/To
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM!
https://reviews.llvm.org/D25641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok, great!
LGTM
https://reviews.llvm.org/D24669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
On 14 October 2016 at 14:21, Eric Fiselier via cfe-commits
wrote:
> Could you give me more information about the compiler your using?
Do you mostly build libcxx outside of a Clang source tree? I suspect
the problem is that if Clang is built at the same time then that's the
Clang which gets used t
mgorny created this revision.
mgorny added reviewers: bob.wilson, rengolin, rafael, ddunbar.
mgorny added subscribers: cfe-commits, zlei.
Herald added a subscriber: aemerson.
Support the arm-hardfloat-*-*eabi triples used by Gentoo to signify
hardfloat variants of ARM *EABI. Add tests for correct
Author: tnorthover
Date: Mon Oct 17 13:00:27 2016
New Revision: 284401
URL: http://llvm.org/viewvc/llvm-project?rev=284401&view=rev
Log:
Hexagon: add dummy files to test dir so git keeps them.
Should fix hexagon-elf-toolchain.c tests on Git.
Added:
cfe/trunk/test/Driver/Inputs/hexagon_tree/T
Author: kparzysz
Date: Mon Oct 17 13:04:05 2016
New Revision: 284402
URL: http://llvm.org/viewvc/llvm-project?rev=284402&view=rev
Log:
Add a dummy file in each subdirectory in test/Driver/Inputs/hexagon_tree
Git does not store empty subdirectories (while SVN does). Git clone of
the clang reposito
That is crazy! You are right---git does not store empty directories.
"SVN co" worked fine for me, but "git clone" didn't. D:
Fixed in r284402.
-Krzysztof
On 10/17/2016 12:34 PM, Tim Northover wrote:
Hi Krzysztof,
This still seems to be failing on Darwin:
/Users/tim/llvm/llvm/tools/clang/t
On 17 October 2016 at 11:13, Krzysztof Parzyszek
wrote:
> That is crazy! You are right---git does not store empty directories. "SVN
> co" worked fine for me, but "git clone" didn't. D:
Oops, a bit of overlap. Thanks for fixing it more thoroughly than me!
Tim.
___
Author: mgorny
Date: Mon Oct 17 13:07:15 2016
New Revision: 284403
URL: http://llvm.org/viewvc/llvm-project?rev=284403&view=rev
Log:
[Driver] Use VFS to perform all distribution checks
Use the VFS provided by D.getVFS() for all distribution checks,
including those performing read of the release f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284403: [Driver] Use VFS to perform all distribution checks
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25641?vs=74767&id=74874#toc
Repository:
rL LLVM
https://reviews.l
On 17 October 2016 at 10:34, Tim Northover wrote:
> I think this might be something to do with git not actually recording
> empty directories. Could you have another look?
Never mind, I've confirmed and committed a fix in r284401.
Tim.
___
cfe-commits
bruno added a comment.
> The long answer is that there is a history of problems regarding the
> intrinsic files:
> http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html
> http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html
> Mainly compatibility issues because MSVC make
hfinkel added a comment.
It seems like we should teach Triple how to parse this triples correctly (i.e.
to recognize that the vendor is ARM), and then canonicalize the environment to
GNUEABIHF (or whatever)?
https://reviews.llvm.org/D25686
___
cfe
rsmith added a comment.
I really don't like the command-line interface you're proposing here. It seems
like it will be extremely confusing what something like `-fmodules
-fexclusive-builtin-modules` means, for instance (usually, later `-f` flags
override earlier ones, so does this *turn off* mo
ABataev added inline comments.
Comment at: include/clang/AST/Type.h:2934
ExtInfo(bool noReturn, bool hasRegParm, unsigned regParm, CallingConv cc,
-bool producesResult) {
+bool producesResult, bool noCallerSavedRegs) {
assert((!hasRegParm || re
mgorny added a comment.
In https://reviews.llvm.org/D25686#571857, @hfinkel wrote:
> It seems like we should teach Triple how to parse this triples correctly
> (i.e. to recognize that the vendor is ARM), and then canonicalize the
> environment to GNUEABIHF (or whatever)?
I've attempted that b
mgorny added a comment.
A gentle ping.
https://reviews.llvm.org/D23752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny planned changes to this revision.
mgorny added a comment.
I'm going to delay this one a bit. I've already fixed all other distro checks
to use VFS. Now I'd like to update them to use proper numeric parsing.
https://reviews.llvm.org/D24954
__
vitalybuka marked an inline comment as done.
vitalybuka added a comment.
Slowdown from this function is below: 0.05% and it's mostly just traversing AST.
https://reviews.llvm.org/D24693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D25606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
vsk added a comment.
Thanks for your feedback so far, and sorry for the delayed response.
In https://reviews.llvm.org/D25448#570014, @rjmccall wrote:
> Wait, can you talk me through the bug here?
Derived inherits from Base1 and Base2. We upcast an instance of Derived to
Base2, then call a met
mgorny planned changes to this revision.
mgorny added a comment.
Damn it, it seems that SunOS isn't actually exposing some functions. I need to
work on this further, and figure out WTF.
https://reviews.llvm.org/D25431
___
cfe-commits mailing list
c
On 17 Oct 2016 12:06 pm, "Vedant Kumar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
vsk added a comment.
Thanks for your feedback so far, and sorry for the delayed response.
In https://reviews.llvm.org/D25448#570014, @rjmccall wrote:
> Wait, can you talk me through the bug here?
Deri
Author: adrian
Date: Mon Oct 17 14:36:18 2016
New Revision: 284416
URL: http://llvm.org/viewvc/llvm-project?rev=284416&view=rev
Log:
Driver/Darwin: Set the DWARF version based on the deployment target.
System utilities such as atos only support DWARF 4 on OS X 10.11+ and
iOS 9+. We thus want to e
Author: adrian
Date: Mon Oct 17 14:46:26 2016
New Revision: 284417
URL: http://llvm.org/viewvc/llvm-project?rev=284417&view=rev
Log:
Update testcase for r284416.
Modified:
cfe/trunk/test/CodeGen/dwarf-version.c
Modified: cfe/trunk/test/CodeGen/dwarf-version.c
URL:
http://llvm.org/viewvc/llv
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Adrian Prantl via cfe-commits
> Sent: Monday, October 17, 2016 12:36 PM
> To: cfe-commits@lists.llvm.org
> Subject: r284416 - Driver/Darwin: Set the DWARF version based on the
> deployment
GorNishanov added a comment.
friendly ping
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: davide
Date: Mon Oct 17 15:06:32 2016
New Revision: 284419
URL: http://llvm.org/viewvc/llvm-project?rev=284419&view=rev
Log:
[Coverage] Update test after r284418.
We now strip coverage metadata if debug info are not present.
Modified:
cfe/trunk/test/CodeGen/code-coverage.c
Modified:
Glad we all agree. I opened
https://llvm.org/bugs/show_bug.cgi?id=30720 to keep track of this.
On Mon, Oct 17, 2016 at 9:08 AM, Rui Ueyama wrote:
> Agreed. We should define them as aliases to existing options without
> -plugin-opt.
>
> On Sun, Oct 16, 2016 at 6:43 PM, Sean Silva via cfe-commits
>
Author: adrian
Date: Mon Oct 17 15:14:23 2016
New Revision: 284420
URL: http://llvm.org/viewvc/llvm-project?rev=284420&view=rev
Log:
Improve the CHECK lines in debug-options.c by separating out the check
for debug info kind and dwarf version.
Modified:
cfe/trunk/test/Driver/debug-options.c
M
Thanks for noticing! I improved the test in r284420 by separating the check for
debug info kind and dwarf version.
-- adrian
> On Oct 17, 2016, at 1:11 PM, Robinson, Paul wrote:
>
>
>
>> -Original Message-
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
>
1 - 100 of 153 matches
Mail list logo
