Re: r284284 - Reinstate r284008 reverted in r284081, with two fixes:

2016-10-15 Thread Vassil Vassilev via cfe-commits
Thanks! When calling makeMergedDefinitionVisible shouldn't we get the template instantiation pattern? On 14/10/16 23:41, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Oct 14 16:41:24 2016 New Revision: 284284 URL: http://llvm.org/viewvc/llvm-project?rev=284284&view=rev Log: Re

[PATCH] D25641: [Driver] Use VFS to perform all distribution checks

2016-10-15 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: bruno, rafael, bkramer. mgorny added subscribers: cfe-commits, bruno. Use the VFS provided by D.getVFS() for all distribution checks, including those performing read of the release file. Requested by @bruno on https://reviews.llvm.org/D24954.

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

2016-10-15 Thread Aditya Kumar via cfe-commits
hiraditya added a comment. Marshall suggests using macro as we discussed offline. For some reason the reply does not appear here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html Repository: rL LLVM https://reviews.llvm.org/D24991 _

[PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

2016-10-15 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 74769. malcolm.parsons added a comment. Use ignoringImplicit https://reviews.llvm.org/D24339 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantMemberInitCheck.cpp cl

Re: r284284 - Reinstate r284008 reverted in r284081, with two fixes:

2016-10-15 Thread Vassil Vassilev via cfe-commits
It seems that we are still missing a piece, because this broke the libstdc++ selfhost: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/5891 On 14/10/16 23:41, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Oct 14 16:41:24 2016 New Revision: 284284

[PATCH] D25642: [clang-tidy] Use ignoreImplicit in cert-err58-cpp check

2016-10-15 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added a reviewer: aaron.ballman. malcolm.parsons added a subscriber: cfe-commits. Fix a false negative in cert-err58-cpp check when calling a constructor creates objects that require cleanup. https://reviews.llvm.org/D25642 Files: clang-t

[PATCH] D25642: [clang-tidy] Use ignoreImplicit in cert-err58-cpp check

2016-10-15 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In what is surely a record response time for code reviews on a weekend, this LGTM. :-D https://reviews.llvm.org/D25642 ___ cfe-com

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-15 Thread Eric Fiselier via cfe-commits
Hi Nico, Are these tests still broken for you? /Eric On Fri, Oct 14, 2016 at 3:21 PM, Eric Fiselier wrote: > Hi Nico, > > Could you give me more information about the compiler your using? > > /Eric > > On Fri, Oct 14, 2016 at 1:21 PM, Nico Weber wrote: > >> This is breaking tests for me: >> >

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-15 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. Ping https://reviews.llvm.org/D25153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-15 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks for your patience, this looks great to me. Do you need someone to commit this for you? https://reviews.llvm.org/D25153 ___ cfe-commits ma

[libcxx] r284309 - Update the status of issues

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 15:58:51 2016 New Revision: 284309 URL: http://llvm.org/viewvc/llvm-project?rev=284309&view=rev Log: Update the status of issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-15 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. Thank you! I tried with`arc land` but got a 403... https://reviews.llvm.org/D25153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284310 - Implement LWG2664 and update its status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 16:29:44 2016 New Revision: 284310 URL: http://llvm.org/viewvc/llvm-project?rev=284310&view=rev Log: Implement LWG2664 and update its status Added: libcxx/trunk/test/libcxx/experimental/filesystem/class.path/path.member/ libcxx/trunk/test/libcxx/experiment

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-15 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D25491#571003, @phosek wrote: > Ping, do you have any other comments? Fine by me. Please wait for an okay by @EricWF . Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mai

[libcxx] r284313 - Implement modified LWG 2665

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 17:37:42 2016 New Revision: 284313 URL: http://llvm.org/viewvc/llvm-project?rev=284313&view=rev Log: Implement modified LWG 2665 Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/src/experimental/filesystem/path.cpp libcxx/trunk/test/

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

2016-10-15 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. This doesn't work after converting SmallSetVector to use DenseSet. Instead we can just use a SmallVector. https://reviews.llvm.org/D25647 Files: clang-

[libcxx] r284314 - Implement LWG 2672.

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 18:05:04 2016 New Revision: 284314 URL: http://llvm.org/viewvc/llvm-project?rev=284314&view=rev Log: Implement LWG 2672. Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.is_em

[libcxx] r284315 - Mark LWG 2680 as done

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 18:12:30 2016 New Revision: 284315 URL: http://llvm.org/viewvc/llvm-project?rev=284315&view=rev Log: Mark LWG 2680 as done Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-proje

[libcxx] r284316 - Implement LWG 2681 and 2682

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:29:22 2016 New Revision: 284316 URL: http://llvm.org/viewvc/llvm-project?rev=284316&view=rev Log: Implement LWG 2681 and 2682 Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.

r284317 - Revert "[analyzer] Re-apply r283093 "Add extra notes to ObjCDeallocChecker""

2016-10-15 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Sat Oct 15 19:30:08 2016 New Revision: 284317 URL: http://llvm.org/viewvc/llvm-project?rev=284317&view=rev Log: Revert "[analyzer] Re-apply r283093 "Add extra notes to ObjCDeallocChecker"" Revert: r283662: [analyzer] Re-apply r283093 "Add extra notes to ObjCDeallocChecker"

[libcxx] r284318 - Implement LWG 2712 and update other issues status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:47:59 2016 New Revision: 284318 URL: http://llvm.org/viewvc/llvm-project?rev=284318&view=rev Log: Implement LWG 2712 and update other issues status Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/file

[libcxx] r284319 - Update notes for LWG 2678

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:49:33 2016 New Revision: 284319 URL: http://llvm.org/viewvc/llvm-project?rev=284319&view=rev Log: Update notes for LWG 2678 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-p

[libcxx] r284321 - Update issue status for LWG 2768 and 2769

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 20:43:43 2016 New Revision: 284321 URL: http://llvm.org/viewvc/llvm-project?rev=284321&view=rev Log: Update issue status for LWG 2768 and 2769 Added: libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/any_cast_request_invalid_value_category.fail.cpp R

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

2016-10-15 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. I like the fix. :-) However, I think that the test, rather than going in a bug specific file (pr21597.pass.cpp), should be added to the existing tests - where it should have been in the first place. (If this test had been there in the first place, we would have re

[libcxx] r284322 - Update issue status for LWG 2744

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 21:51:50 2016 New Revision: 284322 URL: http://llvm.org/viewvc/llvm-project?rev=284322&view=rev Log: Update issue status for LWG 2744 Added: libcxx/trunk/test/libcxx/utilities/utility/utility.inplace/__is_inplace_tag.pass.cpp Removed: libcxx/trunk/test/li

[libcxx] r284323 - Update status for std::optional LWG issues and fix an optional SFINAE bug

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:21:35 2016 New Revision: 284323 URL: http://llvm.org/viewvc/llvm-project?rev=284323&view=rev Log: Update status for std::optional LWG issues and fix an optional SFINAE bug Modified: libcxx/trunk/include/experimental/optional libcxx/trunk/include/optional

[libcxx] r284324 - Update LWG 2767 and add test case

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:45:06 2016 New Revision: 284324 URL: http://llvm.org/viewvc/llvm-project?rev=284324&view=rev Log: Update LWG 2767 and add test case Modified: libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp libcxx/trunk/www/upcoming_meeting.h

[libcxx] r284325 - Fix use of non-constexpr C++14 addressof

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:49:18 2016 New Revision: 284325 URL: http://llvm.org/viewvc/llvm-project?rev=284325&view=rev Log: Fix use of non-constexpr C++14 addressof Modified: libcxx/trunk/include/experimental/optional Modified: libcxx/trunk/include/experimental/optional URL: http:/

[libcxx] r284326 - Update LWG 2754 status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:52:48 2016 New Revision: 284326 URL: http://llvm.org/viewvc/llvm-project?rev=284326&view=rev Log: Update LWG 2754 status Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-proj

r284331 - Extend this test and make it a bit clearer which cases Clang is getting wrong.

2016-10-15 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Oct 16 01:23:29 2016 New Revision: 284331 URL: http://llvm.org/viewvc/llvm-project?rev=284331&view=rev Log: Extend this test and make it a bit clearer which cases Clang is getting wrong. Modified: cfe/trunk/test/CXX/temp/temp.fct.spec/temp.deduct/temp.deduct.conv/p4.c