[PATCH] D25264: Implement MS _BitScan intrinsics

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. This looks right to me. https://reviews.llvm.org/D25264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

jlebar added a comment. If you're busy with other stuff, that's cool, this is not urgent, but pinging in case this got lost. https://reviews.llvm.org/D25139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r284060 - Implement MS _BitScan intrinsics

Author: agutowski Date: Wed Oct 12 17:01:05 2016 New Revision: 284060 URL: http://llvm.org/viewvc/llvm-project?rev=284060&view=rev Log: Implement MS _BitScan intrinsics Summary: _BitScan intrinsics (and some others, for example _Interlocked and _bittest) are supposed to work on both ARM and x86.

[PATCH] D25534: Implement part of P0031; adding `constexpr` to `reverse_iterator`

mclow.lists created this revision. mclow.lists added reviewers: EricWF, lefticus, AntonBikineev. mclow.lists added a subscriber: cfe-commits. This just does the `reverse_iterator` bits of http://wg21.link/P0031 - not any of the other parts. This duplicates some (but not all) of the work that was

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

hxy9243 added a comment. Thanks for pointing out. It's true that it may cause ABI breakage. It would be nice to keep compatibility while getting the performance benefits from inlining. I've tested the patch with google-benchmark/util_smartptr_libcxx shipped with libcxx on x86_64 server, and att

r284062 - fix regexes for label names in ms-intrinsics test

Author: agutowski Date: Wed Oct 12 17:22:34 2016 New Revision: 284062 URL: http://llvm.org/viewvc/llvm-project?rev=284062&view=rev Log: fix regexes for label names in ms-intrinsics test Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c URL: ht

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak added a comment. It looks like this patch doesn't do what I thought would do when the unprototyped function declaration is in the header and the prototyped function declaration is in the source code. The DeclRefExpr created for the call to func1("abc", 12) points to the unprototyped fu

[PATCH] D25537: [ThinLTO] Update doc to include lld

davide created this revision. davide added reviewers: tejohnson, mehdi_amini. davide added a subscriber: cfe-commits. https://reviews.llvm.org/D25537 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst === --- docs/ThinLTO.rst +++ do

[PATCH] D25537: [ThinLTO] Update doc to include lld

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D25537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r284080 - [NFC] Fixing the description for _mm_store_ps and _mm_store_ps1.

Author: ygao Date: Wed Oct 12 18:27:27 2016 New Revision: 284080 URL: http://llvm.org/viewvc/llvm-project?rev=284080&view=rev Log: [NFC] Fixing the description for _mm_store_ps and _mm_store_ps1. It seems that the doxygen description of these two intrinsics were swapped by mistake. Modified:

r284081 - Revert r284008. This is us to fail to instantiate static data members in some

Author: rsmith Date: Wed Oct 12 18:29:02 2016 New Revision: 284081 URL: http://llvm.org/viewvc/llvm-project?rev=284081&view=rev Log: Revert r284008. This is us to fail to instantiate static data members in some cases. I'm working on reducing a testcase. Removed: cfe/trunk/test/Modules/Inputs/

[PATCH] D25537: [ThinLTO] Update doc to include lld

mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. You have to add which platforms are supported. https://reviews.llvm.org/D25537 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D24958: Test linked to D24957

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D24958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r284083 - fix ms-intrinsics labels code to work with builds with assertions

Author: agutowski Date: Wed Oct 12 18:52:38 2016 New Revision: 284083 URL: http://llvm.org/viewvc/llvm-project?rev=284083&view=rev Log: fix ms-intrinsics labels code to work with builds with assertions Modified: cfe/trunk/test/CodeGen/ms-intrinsics.c Modified: cfe/trunk/test/CodeGen/ms-intri

[PATCH] D25537: [ThinLTO] Update doc to include lld

davide updated this revision to Diff 74459. davide added a comment. I mentioned that's ELF only. Are you OK with that or you want me to put more detailed info? https://reviews.llvm.org/D25537 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst ==

r284084 - [analyzer] DeallocChecker: Don't warn about directly-set IBOutlet ivars on macOS

Author: dcoughlin Date: Wed Oct 12 18:57:05 2016 New Revision: 284084 URL: http://llvm.org/viewvc/llvm-project?rev=284084&view=rev Log: [analyzer] DeallocChecker: Don't warn about directly-set IBOutlet ivars on macOS On macOS (but not iOS), if an ObjC property has no setter, the nib-loading code

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

alexshap added a comment. I've just run scan-build against LLVM & clang & clang-extra-tools - the new version (with PriorityQueue) is a bit faster - i was running the build on OSX & -j8 and the total time for the new version is 88 minutes vs 92 minutes for the old one. Certainly i think that th

Re: [PATCH] D25537: [ThinLTO] Update doc to include lld

Perfect! LGTM, thanks! — Mehdi > On Oct 12, 2016, at 5:04 PM, Davide Italiano wrote: > > davide updated this revision to Diff 74459. > davide added a comment. > > I mentioned that's ELF only. Are you OK with that or you want me to put more > detailed info? > > > https://reviews.llvm.org/D2

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Sema/Sema.h:9238 +/// +/// if (CUDADiagBuilder(...) << foo << bar) +/// return ExprError(); jlebar wrote: >

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

vsk created this revision. vsk added reviewers: arphaman, ikudrin. vsk added a subscriber: cfe-commits. Generate coverage mappings for in switch (; ). I'm unsure about whether or not the CodeGenPGO change in this patch deserves more testing. https://reviews.llvm.org/D25539 Files: lib/CodeG

[PATCH] D25540: Implement MS _ReturnAddress and _AddressOfReturnAddress intrinsics

agutowski created this revision. agutowski added reviewers: rnk, hans, thakis, majnemer. agutowski added a subscriber: cfe-commits. https://reviews.llvm.org/D25540 Files: include/clang/Basic/Builtins.def include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

hfinkel added a comment. Ping. https://reviews.llvm.org/D9403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25541: [CUDA] Emit deferred diagnostics during Sema rather than during codegen.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, rsmith, cfe-commits. Emitting deferred diagnostics during codegen was a hack. It did work, but usability was poor, both for us as compiler devs and for users. We don't codegen if there are any sema errors,

Re: [PATCH] D25539: [Coverage] Support for C++17 switch initializers

Do we need the same change for if-statements too? On 12 Oct 2016 6:26 pm, "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > vsk created this revision. > vsk added reviewers: arphaman, ikudrin. > vsk added a subscriber: cfe-commits. > > Generate coverage mappings for in switch

Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Hi Eric, This is not clear to me that this patch is correct as-is. See the last message in the thread: http://lists.llvm.org/pipermail/cfe-dev/2016-July/049985.html I think we should reach a consensus on the right course of actio

[libcxx] r284101 - Revert r282345 - Use __attribute__((internal_linkage)) when available.

Author: ericwf Date: Wed Oct 12 23:07:58 2016 New Revision: 284101 URL: http://llvm.org/viewvc/llvm-project?rev=284101&view=rev Log: Revert r282345 - Use __attribute__((internal_linkage)) when available. Modified: libcxx/trunk/include/__config libcxx/trunk/src/string.cpp Modified: libcxx

Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Sure, I've reverted the change in r284101. I'll try and respond in detail tomorrow. /Eric On Wed, Oct 12, 2016 at 9:57 PM, Mehdi Amini wrote: > Hi Eric, > > This is not clear to me that this patch is correct as-is. > > See the last message in the thread: http://lists.llvm.org/ > pipermail/cfe-

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM! I would add info on how much speedup you see in the cryptographic libraries to the commit message. (You could say something like "on a cryptographic library that uses code generat

[PATCH] D1805: [scan-build] Whitelist all -fXXXX options.

zaks.anna added a comment. Please, provide more information on why this patch is needed and why the existing processing of the -f flags does not work as expected. Looks like the last modifications to the -f flags were made in r186138. (Please, submit patches with more context: http://llvm.org/

[PATCH] D1805: [scan-build] Whitelist all -fXXXX options.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Just realized that this is super old and has probably been fixed by r186138. Closing. https://reviews.llvm.org/D1805 ___ cfe-commits maili

[PATCH] D20811: [analyzer] Model some library functions

zaks.anna added a comment. Ping? Is there something blocking progress here? This functionality is very useful and almost done. Thanks! https://reviews.llvm.org/D20811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [libcxx] r282345 - Use __attribute__((internal_linkage)) when available.

Thanks Eric! > On Oct 12, 2016, at 9:18 PM, Eric Fiselier wrote: > > Sure, I've reverted the change in r284101. > > I'll try and respond in detail tomorrow. > > /Eric > > On Wed, Oct 12, 2016 at 9:57 PM, Mehdi Amini > wrote: > Hi Eric, > > This is not clear to

[PATCH] D22968: [analyzer] A checker for macOS-specific bool- and number-like objects.

zaks.anna accepted this revision. zaks.anna added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:479 + InPackage, + HelpText<"Check for erroneous conversions of number pointers into numbers">, + D

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. When compiling a constexpr NSString initialized with an objective-c string literal, CodeGen currently emits objc_storeStrong on an uninitialized alloca, which causes a crash: constex

[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1291 +// where the pointer to the local variable is the key in the map. +void CodeGenFunction::EmitAutoVarNoAlias(const AutoVarEmission &emission) { + assert(emission.Variable && "emission was not valid!"); -

<    1   2