[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny updated this revision to Diff 73887. mgorny added a comment. A simple test case included. https://reviews.llvm.org/D25338 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td lib/Driver/Driver.cpp test/Driver/print-libgcc-file-name.c Index: test/Driver/print-libgc

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added reviewers: NoQ, zaks.anna, dcoughlin, a.sidorin, xazax.hun. danielmarjamaki added a comment. adding reviewers. Repository: rL LLVM https://reviews.llvm.org/D25326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

2016-10-07 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 73888. hokein marked 3 inline comments as done. hokein added a comment. Update. https://reviews.llvm.org/D25309 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp test/clang-move/Inputs/database_template.json t

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

2016-10-07 Thread Eric Liu via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg. Thanks! https://reviews.llvm.org/D25309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a comment. In https://reviews.llvm.org/D25326#564082, @NoQ wrote: > Funny facts about the Environment: > > (a) Environment allows taking SVals of ReturnStmt, which is not an > expression, by transparently converting it into its sub-expression. In fact, > it only stores exp

[PATCH] D22968: [analyzer] A checker for macOS-specific bool- and number-like objects.

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ updated this revision to Diff 73889. NoQ added a comment. - Rename test files for consistency. - Suppress false positives on `intptr_t`. - Add a triple to the tests to in order to stop worrying about integer types. https://reviews.llvm.org/D22968 Files: include/clang/StaticAnalyzer/Checke

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D25326#564185, @danielmarjamaki wrote: > as I understand it the ProgramPoint when CallExitBegin is called is the same > (in the exit block). do you suggest that we take the ProgramPoint for the > exit block's predecessor? CallExitBegin is //**t

[clang-tools-extra] r283525 - Revert "Revert "Add a static_assert to enforce that parameters to llvm::format() are not totally unsafe""

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 03:25:42 2016 New Revision: 283525 URL: http://llvm.org/viewvc/llvm-project?rev=283525&view=rev Log: Revert "Revert "Add a static_assert to enforce that parameters to llvm::format() are not totally unsafe"" This reverts commit r283510 and reapply r283509, wit

[clang-tools-extra] r283526 - [clang-move] Support moving multiple classes in one run.

2016-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 7 03:29:20 2016 New Revision: 283526 URL: http://llvm.org/viewvc/llvm-project?rev=283526&view=rev Log: [clang-move] Support moving multiple classes in one run. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25309 Added:

r283527 - Use StringReg in TargetParser APIs (NFC)

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 03:37:29 2016 New Revision: 283527 URL: http://llvm.org/viewvc/llvm-project?rev=283527&view=rev Log: Use StringReg in TargetParser APIs (NFC) Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Basic/Target

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

2016-10-07 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:316 auto InMovedClass = - hasDeclContext(cxxRecordDecl(hasName(FullyQualifiedName))); + hasDeclContext(cxxRecordDecl(*InMovedClassNames)); ioeric wrote: > hokein wrote: > > ioeric w

[libcxxabi] r283531 - Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

2016-10-07 Thread Igor Kudrin via cfe-commits
Author: ikudrin Date: Fri Oct 7 03:48:28 2016 New Revision: 283531 URL: http://llvm.org/viewvc/llvm-project?rev=283531&view=rev Log: Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion. Throwing an exception for the first time may

[PATCH] D25309: [clang-move] Support moving multiple classes in one run.

2016-10-07 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283526: [clang-move] Support moving multiple classes in one run. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25309?vs=73888&id=73890#toc Repository: rL LLVM https://revi

[PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

2016-10-07 Thread Igor Kudrin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283531: Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D17815?vs=72951&id=73893#toc Repository:

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

2016-10-07 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D25316#563930, @Prazek wrote: > Please add tests with > > long long p = static_cast(4); > > > and the same with const at beginning. I remember I had problems with this > last time (Type->SourceRange was returning only source range

[clang-tools-extra] r283534 - Fix buildbot error.

2016-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 7 04:23:28 2016 New Revision: 283534 URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev Log: Fix buildbot error. The error maybe caused by the mixed environment of the two lint tests. Cleanup the environment before running each test. Modified: clang-to

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

2016-10-07 Thread Alex Lorenz via cfe-commits
arphaman updated this revision to Diff 73898. arphaman marked an inline comment as done. arphaman added a comment. The updated patch uses Adrian's suggestion. Repository: rL LLVM https://reviews.llvm.org/D25321 Files: lib/Analysis/ReachableCode.cpp test/Sema/warn-unreachable.c Index: t

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

2016-10-07 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In https://reviews.llvm.org/D25316#564217, @malcolm.parsons wrote: > In https://reviews.llvm.org/D25316#563930, @Prazek wrote: > > > Please add tests with > > > > long long p = static_cast(4); > > > > > > and the same with const at beginning. I remember I had problems

[PATCH] D25210: [ARM] Add Cortex-R52 target to CLANG

2016-10-07 Thread Javed Absar via cfe-commits
javed.absar updated this revision to Diff 73896. javed.absar added a comment. This patch changes the default cpu for armv8-r from 'generic' to cortex-r52. This is also to reflect the equivalent changes made in llvm, based on review comments. https://reviews.llvm.org/D25210 Files: lib/Basic/

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a comment. ok. As far as I see it's not trivial to know which ReturnStmt there was when CallExitBegin is created. Do you suggest that I move it or that I try to lookup the ReturnStmt? I guess it can be looked up by looking in the predecessors in the ExplodedGraph? > Final

[PATCH] D25210: [ARM] Add Cortex-R52 target to CLANG

2016-10-07 Thread James Molloy via cfe-commits
jmolloy added a comment. Still LGTM. https://reviews.llvm.org/D25210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25361: [libcxx] Add the missing limits.h header

2016-10-07 Thread Asiri Rathnayake via cfe-commits
rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists, rsmith. rmaprath added a subscriber: cfe-commits. The implementation of [depr.c.headers] in https://reviews.llvm.org/D12747 introduced the necessary C headers into libc++. This patch adds one more missing headers: limi

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D25326#564239, @danielmarjamaki wrote: > ok. As far as I see it's not trivial to know which ReturnStmt there was when > CallExitBegin is created. We're in `HandleBlockEdge`, just pass down the statement from CFG here? In https://reviews.llvm.or

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a comment. In https://reviews.llvm.org/D25326#564283, @NoQ wrote: > In https://reviews.llvm.org/D25326#564239, @danielmarjamaki wrote: > > > ok. As far as I see it's not trivial to know which ReturnStmt there was > > when CallExitBegin is created. > > > We're in `HandleBloc

r283536 - [analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 05:44:09 2016 New Revision: 283536 URL: http://llvm.org/viewvc/llvm-project?rev=283536&view=rev Log: [analyzer] Try to re-apply r283092 "Extend bug reports with extra notes" Replace SmallVector with a vector of plain pointers. Would insignificantly increase memo

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D25326#564291, @danielmarjamaki wrote: > The Blk->dump() says: > > [B0 (EXIT)] > Preds (2): B1 B2 > What about the source block? Repository: rL LLVM https://reviews.llvm.org/D25326 ___ cf

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki added a comment. In https://reviews.llvm.org/D25326#564291, @danielmarjamaki wrote: > In https://reviews.llvm.org/D25326#564283, @NoQ wrote: > > > In https://reviews.llvm.org/D25326#564239, @danielmarjamaki wrote: > > > > > ok. As far as I see it's not trivial to know which Return

[clang-tools-extra] r283538 - Revert "fix buildbot error" since it is not right fix.

2016-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 7 05:59:03 2016 New Revision: 283538 URL: http://llvm.org/viewvc/llvm-project?rev=283538&view=rev Log: Revert "fix buildbot error" since it is not right fix. Modified: clang-tools-extra/trunk/test/clang-move/move-class.cpp clang-tools-extra/trunk/test/clang-m

r283537 - Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 05:56:44 2016 New Revision: 283537 URL: http://llvm.org/viewvc/llvm-project?rev=283537&view=rev Log: Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes" Vector of smart pointers wasn't the thing that caused msvc crash. Modified:

r283540 - [analyzer] Re-apply r283092, attempt no.3, in small chunks this time.

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 06:26:15 2016 New Revision: 283540 URL: http://llvm.org/viewvc/llvm-project?rev=283540&view=rev Log: [analyzer] Re-apply r283092, attempt no.3, in small chunks this time. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h Modif

r283541 - Revert "[analyzer] Re-apply r283092, attempt no.3, in small chunks this time."

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 06:29:32 2016 New Revision: 283541 URL: http://llvm.org/viewvc/llvm-project?rev=283541&view=rev Log: Revert "[analyzer] Re-apply r283092, attempt no.3, in small chunks this time." Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.

[PATCH] D25363: Store a SourceRange for multi-token builtin types

2016-10-07 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added a reviewer: Prazek. malcolm.parsons added a subscriber: cfe-commits. clang-tidy's modernize-use-auto check uses the SourceRange of a TypeLoc when replacing the type with auto. This was producing the wrong result for multi-token builtin t

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-07 Thread Steve O'Brien via cfe-commits
elsteveogrande updated this revision to Diff 73916. elsteveogrande added a comment. Dropped escaping function, adds logic to this diff which isn't 100% necessary at this time. See updated description, under test plan, for details. The output already does hint at the path which was used to reso

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-07 Thread Steve O'Brien via cfe-commits
elsteveogrande updated this revision to Diff 73917. elsteveogrande updated the summary for this revision. elsteveogrande added a comment. update description w/ `arc diff --verbatim` https://reviews.llvm.org/D25153 Files: include/clang/Driver/Options.td include/clang/Frontend/PreprocessorOut

[PATCH] D25316: [clang-tidy] Fix PR25499: Enhance modernize-use-auto to casts

2016-10-07 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 73918. malcolm.parsons added a comment. Add more tests. https://reviews.llvm.org/D25316 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-use-auto.rst test/clang-tidy/modernize-

Re: [clang-tools-extra] r283534 - Fix buildbot error.

2016-10-07 Thread Renato Golin via cfe-commits
On 7 October 2016 at 10:23, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Fri Oct 7 04:23:28 2016 > New Revision: 283534 > > URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev > Log: > Fix buildbot error. > > The error maybe caused by the mixed environment of the two lint t

r283543 - [ARM]: Add Cortex-R52 target

2016-10-07 Thread Javed Absar via cfe-commits
Author: javed.absar Date: Fri Oct 7 07:08:41 2016 New Revision: 283543 URL: http://llvm.org/viewvc/llvm-project?rev=283543&view=rev Log: [ARM]: Add Cortex-R52 target This patch adds Cortex-R52, the new ARM real-time processor. Cortex-R52 implements the ARMv8-R architecture. Modified: cfe/t

[clang-tools-extra] r283545 - [clang-move] Simplify lint tests

2016-10-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 7 07:35:37 2016 New Revision: 283545 URL: http://llvm.org/viewvc/llvm-project?rev=283545&view=rev Log: [clang-move] Simplify lint tests No need to use compilation database. Removed: clang-tools-extra/trunk/test/clang-move/Inputs/database_template.json Modified:

r283549 - Wdocumentation fix

2016-10-07 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Oct 7 08:25:41 2016 New Revision: 283549 URL: http://llvm.org/viewvc/llvm-project?rev=283549&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/t

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 73926. danielmarjamaki added a comment. Refactoring. https://reviews.llvm.org/D25326 Files: include/clang/Analysis/ProgramPoint.h include/clang/StaticAnalyzer/Core/PathSensitiv

[PATCH] D25369: [clang-move] Better support enclosing class.

2016-10-07 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. - When moving an outermost enclosing class, all its nested classes should also be moved together. - Add a test for not moving nested class. https://reviews.llvm.org/D25369 Files: clang-move

[PATCH] D25244: [clang-tidy] Add a whitelist option in google-runtime-references.

2016-10-07 Thread Haojian Wu via cfe-commits
hokein added a comment. friendly ping. Aaron, could you take a look on this patch? https://reviews.llvm.org/D25244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r283553 - Revert "[clang-move] Support moving multiple classes in one run."

2016-10-07 Thread Renato Golin via cfe-commits
Author: rengolin Date: Fri Oct 7 08:58:10 2016 New Revision: 283553 URL: http://llvm.org/viewvc/llvm-project?rev=283553&view=rev Log: Revert "[clang-move] Support moving multiple classes in one run." This reverts commit r283526 et al as it keeps randomly breaking bots, even after the commit has

Re: [clang-tools-extra] r283534 - Fix buildbot error.

2016-10-07 Thread Renato Golin via cfe-commits
On 7 October 2016 at 13:06, Renato Golin wrote: > On 7 October 2016 at 10:23, Haojian Wu via cfe-commits > wrote: >> Author: hokein >> Date: Fri Oct 7 04:23:28 2016 >> New Revision: 283534 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev >> Log: >> Fix buildbot error. >> >> The

[PATCH] D25369: [clang-move] Better support enclosing class.

2016-10-07 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:27 +AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass, + ast_matchers::internal::Matcher, InnerMatcher) { I'm not sure if we really need to limit this to the `outer-most` class

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay, this is great. Thanks for investigating all those loss of coverage issues! Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:610 // Use the callee location context. - Cal

r283554 - [analyzer] Don't merge different return nodes in ExplodedGraph

2016-10-07 Thread Daniel Marjamaki via cfe-commits
Author: danielmarjamaki Date: Fri Oct 7 09:21:08 2016 New Revision: 283554 URL: http://llvm.org/viewvc/llvm-project?rev=283554&view=rev Log: [analyzer] Don't merge different return nodes in ExplodedGraph Returns when calling an inline function should not be merged in the ExplodedGraph unless th

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-07 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D25343#564092, @arsenm wrote: > These should be convergent instead Unfortunately convergent is not supported as Clang attribute. There was patch to add it but the author withdrew it. Anastasia/Alexey, Do you think it is a good idea to add _

[PATCH] D20428: Tracking exception specification source locations

2016-10-07 Thread Stanisław Barzowski via cfe-commits
sbarzowski added a comment. What's happening here? It's accepted, but not merged and the last activity is 3 months old while my change is waiting for it. Can I help somehow? https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@l

r283564 - Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132

2016-10-07 Thread Dehao Chen via cfe-commits
Author: dehao Date: Fri Oct 7 10:21:29 2016 New Revision: 283564 URL: http://llvm.org/viewvc/llvm-project?rev=283564&view=rev Log: Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132 Summary: https://reviews.llvm.org/D25132 added discriminator even add -g0.

r283566 - [analyzer] Re-apply r283092, attempt no.4, a small chunk.

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 10:23:02 2016 New Revision: 283566 URL: http://llvm.org/viewvc/llvm-project?rev=283566&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, a small chunk. Define PathDiagnosticNotePiece. The next commit would be able to address the BugReport class code that

r283568 - [analyzer] Re-apply r283092, attempt no.4, chunk no.2.

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 10:55:18 2016 New Revision: 283568 URL: http://llvm.org/viewvc/llvm-project?rev=283568&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.2. Define the list of pieces in BugReport class. This is half of the changes in the BugReport class code, whi

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

2016-10-07 Thread Adrian Prantl via cfe-commits
aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rL LLVM https://reviews.llvm.org/D25321 ___ cfe-commits mailing list cfe-commit

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. Please, fix the style issues before committing. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:266 +ExplodedNode *Pred, +const ReturnSt

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-07 Thread Brian Sumner via cfe-commits
b-sumner added a comment. clang does not recognize convergent as a valid attribute. There was an attempt to add this, see https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg22271.html but it hasn't had any result. Matt do you see "real uses" for this now? https://reviews.llvm.org/D2

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. Can you also add a test that tests this more directly (i.e., with clang_analyzer_warnIfReached). I don't think it is good to have the only test for this core coverage issue to be in tests for an alpha checker. Adding the direct test would also make it easier to track

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Artem Dergachev via cfe-commits
NoQ added inline comments. Comment at: test/Analysis/unreachable-code-path.c:201 +static int inlineFunction(const int i) { + if (table[i] != 0) +return 1; a.sidorin wrote: > I have a small question. Is it possible to simplify this sample with removing > of

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny added a comment. Thanks for the review. https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Fri Oct 7 12:08:06 2016 New Revision: 283572 URL: http://llvm.org/viewvc/llvm-project?rev=283572&view=rev Log: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used Make the -print-libgcc-file-name option print an appropriate compiler runtime library, that is

r283573 - [analyzer] Re-apply r283092, attempt no.4, chunk no.3.

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 12:12:05 2016 New Revision: 283573 URL: http://llvm.org/viewvc/llvm-project?rev=283573&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.3. This is the primary suspect for causing the msvc crash, now that vector of smart pointers was proven to be

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Aleksei Sidorin via cfe-commits
a.sidorin added inline comments. Comment at: test/Analysis/unreachable-code-path.c:201 +static int inlineFunction(const int i) { + if (table[i] != 0) +return 1; I have a small question. Is it possible to simplify this sample with removing of table[] array?

r283574 - [analyzer] Re-apply r283092, attempt no.4, chunk no.3, fixup 1.

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 12:24:06 2016 New Revision: 283574 URL: http://llvm.org/viewvc/llvm-project?rev=283574&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.3, fixup 1. Remove the brace default initializer to see if this is what's causing the msvc crash. Modified:

Re: [PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Bill Seurer via cfe-commits
On 10/07/16 08:39, Daniel Marjamäki via cfe-commits wrote: danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 73926. danielmarjamaki added a comment. Refactoring. https://reviews.llvm.org/D25326 Files: include/clang/Analysis/Pr

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

2016-10-07 Thread Daniel Marjamäki via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283554: [analyzer] Don't merge different return nodes in ExplodedGraph (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D25326?vs=73926&id=73947#toc Repository: rL LLV

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283572: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25338?vs=73887&id=73953#toc Repository: rL LLVM

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-10-07 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a reviewer: bruno. bruno added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306 + "vector operands do not have the same elements sizes (%0 and %1)">, + InGroup>, DefaultError; def err_ext_vector_component_exceeds_length

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny added a comment. It seems that my test doesn't work on Darwin, and I should exclude the libgcc part there. Do you happen to have any suggestion how to do that? I'm going to wait for other buildbots to finish to see if I haven't broken any other platform, then revert it and look for a pro

[PATCH] D25244: [clang-tidy] Add a whitelist option in google-runtime-references.

2016-10-07 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit. Comment at: clang-tidy/google/NonConstReferences.cpp:71-75 + for (const auto &WhiteListType: WhiteListTypes) { +if (ReferencedType.g

Re: r283554 - [analyzer] Don't merge different return nodes in ExplodedGraph

2016-10-07 Thread Galina Kistanova via cfe-commits
Hi Daniel, This revision introduced warnings on one our of builders: http://lab.llvm.org:8011/builders/clang-3stage-ubuntu/builds/4719 The warnings: /home/buildbot/Buildbot/Slave1a/clang-3stage-ubuntu/llvm.src/tools/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:316:59: warning: suggest parenthese

[PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-07 Thread Erich Keane via cfe-commits
erichkeane created this revision. erichkeane added reviewers: cfe-commits, dblaikie, majnemer, gbenyei. erichkeane set the repository for this revision to rL LLVM. OpenMP creates a variable array type with a a null size-expr. The Debug generation failed to properly consider this case. This patc

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-07 Thread David Blaikie via cfe-commits
Could you explain how/why there's a null size expr? I would've thought it must have /some/ size for code generation purposes... On Fri, Oct 7, 2016 at 11:33 AM Erich Keane wrote: > erichkeane created this revision. > erichkeane added reviewers: cfe-commits, dblaikie, majnemer, gbenyei. > erichke

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-07 Thread Keane, Erich via cfe-commits
I cannot personally right now, though I will dig into OpenMP implementation to see how intentional that is. The size is seemingly determined by the OMP code generation as far as I can tell. From: David Blaikie [mailto:dblai...@gmail.com] Sent: Friday, October 7, 2016 11:51 AM To: reviews+d25373

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-07 Thread Keane, Erich via cfe-commits
Added Alexey to the list, he’s the OMP Maintainer, so hopefully he knows better ☺ From: David Blaikie [mailto:dblai...@gmail.com] Sent: Friday, October 7, 2016 11:51 AM To: reviews+d25373+public+d8ec2a4bb41b1...@reviews.llvm.org; Keane, Erich ; cfe-commits@lists.llvm.org; david.majne...@gmail.co

[libcxx] r283580 - Remove MSVC workarounds. Patch from s...@microsoft.com

2016-10-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 7 13:51:33 2016 New Revision: 283580 URL: http://llvm.org/viewvc/llvm-project?rev=283580&view=rev Log: Remove MSVC workarounds. Patch from s...@microsoft.com Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.

[PATCH] D25141: [libcxx] [test] Remove MSVC workarounds

2016-10-07 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r283580. https://reviews.llvm.org/D25141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-07 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. Hi @rsmith -- now this simply reports the `#include` line (or whatever token) without fiddly path escaping. So this is simplified and there's less room for error and such. https://reviews.llvm.org/D25153 ___ cfe-co

r283583 - Silence Warning. NFC.

2016-10-07 Thread Nirav Dave via cfe-commits
Author: niravd Date: Fri Oct 7 14:11:33 2016 New Revision: 283583 URL: http://llvm.org/viewvc/llvm-project?rev=283583&view=rev Log: Silence Warning. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp URL: http://llvm.o

r283584 - [analyzer] Re-apply r283092, attempt no.4, chunk no.4 (last)

2016-10-07 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Oct 7 14:25:10 2016 New Revision: 283584 URL: http://llvm.org/viewvc/llvm-project?rev=283584&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.4 (last) The problem that caused the msvc crash has been indentified and fixed in the previous commit. This p

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

2016-10-07 Thread Keane, Erich via cfe-commits
Ok, I dug into this deeper. ASTContext.cpp:2811 (getVariableArrayDecayedType) intentionaly sets size to nullptr in this case for the purpose of turning it into a [*] type. OpenMP.cpp:236 (CodeGenFunction::GenerateOpenMPCapturedStmtFunction) calls this to replace variably modified type with th

[PATCH] D25369: [clang-move] Better support enclosing class.

2016-10-07 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 73976. hokein marked 2 inline comments as done. hokein added a comment. support moving static member of nested class when moving its enclosing class. https://reviews.llvm.org/D25369 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/multiple_class_te

[PATCH] D25369: [clang-move] Better support enclosing class.

2016-10-07 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-move/ClangMove.cpp:27 +AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass, + ast_matchers::internal::Matcher, InnerMatcher) { ioeric wrote: > I'm not sure if we really need to limit this to the `o

r283586 - Revert r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Fri Oct 7 15:04:00 2016 New Revision: 283586 URL: http://llvm.org/viewvc/llvm-project?rev=283586&view=rev Log: Revert r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used Revert the -print-libgcc-file-name change as the new test fails on Darwin. I

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny planned changes to this revision. mgorny added a comment. Reverted, I need to update it to run libgcc part of the test only on platforms supporting that. Repository: rL LLVM https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny removed rL LLVM as the repository for this revision. mgorny updated this revision to Diff 73979. This revision is now accepted and ready to land. https://reviews.llvm.org/D25338 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td lib/Driver/Driver.cpp test/Driver/pri

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

2016-10-07 Thread Michał Górny via cfe-commits
mgorny requested a review of this revision. mgorny added a comment. I have updated the patch to include a feature check for platforms rejecting `-rtlib=libgcc` and split the test appropriately. Could you re-review, please? https://reviews.llvm.org/D25338 _

Re: r283537 - Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

2016-10-07 Thread Bill Seurer via cfe-commits
On 10/07/16 05:56, Artem Dergachev via cfe-commits wrote: > Author: dergachev > Date: Fri Oct 7 05:56:44 2016 > New Revision: 283537 > > URL: http://llvm.org/viewvc/llvm-project?rev=283537&view=rev One of these recent changes introduced a problem in sanitizer testing. /home/seurer/llvm/build/l

r283601 - Visually align table def with respective enum. NFC

2016-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 7 16:02:38 2016 New Revision: 283601 URL: http://llvm.org/viewvc/llvm-project?rev=283601&view=rev Log: Visually align table def with respective enum. NFC 'warn_attribute_wrong_decl_type' has to stay in sync with 'enum AttributeDeclKind' which is much easier when they

[libcxx] r283606 - Fix various issues in std::any and the related tests.

2016-10-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 7 16:27:45 2016 New Revision: 283606 URL: http://llvm.org/viewvc/llvm-project?rev=283606&view=rev Log: Fix various issues in std::any and the related tests. * Fix self-swap. Patch from Casey Carter. * Remove workarounds and tests for types with deleted move construc

r283605 - Turn ArchName/BoundArch in Driver from raw pointer to StringRef (NFC)

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 16:27:26 2016 New Revision: 283605 URL: http://llvm.org/viewvc/llvm-project?rev=283605&view=rev Log: Turn ArchName/BoundArch in Driver from raw pointer to StringRef (NFC) Modified: cfe/trunk/include/clang/Driver/Action.h cfe/trunk/include/clang/Driver/

[PATCH] D25249: [libc++] Many any test fixes

2016-10-07 Thread Eric Fiselier via cfe-commits
EricWF added a comment. @CaseyCarter Thank you for the patch. I fixed most of your issues in r283606 {as well as a bunch of libc++ bugs). I'm still deciding what to do about the `in_place` SFINAE tests, but I'll follow up on that shortly. As for this patch please update it if there are any fix

r283611 - Driver: use StringRef instead of raw pointer in lookupTypeForExtension() (NFC)

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 16:41:00 2016 New Revision: 283611 URL: http://llvm.org/viewvc/llvm-project?rev=283611&view=rev Log: Driver: use StringRef instead of raw pointer in lookupTypeForExtension() (NFC) Modified: cfe/trunk/include/clang/Driver/ToolChain.h cfe/trunk/include/c

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

2016-10-07 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Why do you want to build `libc++.so` with hidden visibility? What's wrong with the existing way we build `libc++.so`? https://reviews.llvm.org/D25208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D25248: [libcxx] [test] Fix shadow warnings.

2016-10-07 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT added a comment. Thanks Marshall. Can either you or Eric commit this? https://reviews.llvm.org/D25248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

2016-10-07 Thread Richard Smith via cfe-commits
rsmith added a comment. I'm concerned that name lookup will find an inappropriate declaration after this merging. If we have two visible declarations of a function in the same scope, and one has a prototype but the other does not, the user should be able to rely on the prototype being used. `is

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

2016-10-07 Thread Philip Reames via cfe-commits
reames resigned from this revision. reames removed a reviewer: reames. reames added a comment. I know very little about our cmake infrastructure. Repository: rL LLVM https://reviews.llvm.org/D1 ___ cfe-commits mailing list cfe-commits@lists.l

r283616 - Rename variable to not use C++ reserved name (leading underscore + capital) (NFC)

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 17:03:03 2016 New Revision: 283616 URL: http://llvm.org/viewvc/llvm-project?rev=283616&view=rev Log: Rename variable to not use C++ reserved name (leading underscore + capital) (NFC) Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/trunk/lib/Drive

r283615 - Fix MSVC build: requires namespace in front of StringRef (NFC)

2016-10-07 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Oct 7 17:02:59 2016 New Revision: 283615 URL: http://llvm.org/viewvc/llvm-project?rev=283615&view=rev Log: Fix MSVC build: requires namespace in front of StringRef (NFC) Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/trunk/lib/Driver/Action.cpp URL: h

[PATCH] D25154: [libc++] Fix stack_allocator

2016-10-07 Thread Eric Fiselier via cfe-commits
EricWF added a comment. > Why does test_stack_allocator.pass.cpp line 11 have a commented-out path? Typically tests name the header they test in a comment. > Why is > test/std/containers/sequences/deque/deque.cons/size_value_alloc.pass.cpp > 84-85 gaining totally empty braces? Mass-translatio

[PATCH] D25154: [libc++] Fix stack_allocator

2016-10-07 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 73995. EricWF added a comment. Address @STL_MSFT's comments. https://reviews.llvm.org/D25154 Files: test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_comp.pass.cpp test/std/containers/container.adaptors/priority.queue/priqueue.co

  1   2   >