rnk added a comment.
Looks good functionally with some surface level nits
> X86ISelLowering.cpp:31979
>break;
> }
>}
Let's check size 2 after size 1, it seems more logical, and is 1 is probably
the common case.
> X86ISelLowering.cpp:32025
>case 'Y':
> +// Impliment Y
rnk added inline comments.
> avx512-mask-op-inline_asm_specific.c:1
> +// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror
> | FileCheck %s
> +// This test checks validity of inline assembly for avx512 supported
> constraint k and Yk along with the required
Please chec
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The title says it all. Additionally this patch refactors the diagnostic code
into a separate function.
https://reviews.llvm.org/D25292
File
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL177633.
https://reviews.llvm.org/D545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
EricWF added a comment.
In https://reviews.llvm.org/D24562#562339, @rmaprath wrote:
> First batch of XFAIL fixes.
>
> I've changed some XFAILs to UNSUPPORTED where the test is all about exception
> handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to
> conditionally excl
hfinkel added a comment.
@rsmith @rjmccall - I chatted with @anemet about this on IRC, and he's happy
with it. Please look this over, in part to make sure you're happy with the
option name.
On the name, two of my thoughts behind using -fsave-optimization-record were:
1) I did not want to call
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: rsmith
Date: Wed Oct 5 17:41:02 2016
New Revision: 283406
URL: http://llvm.org/viewvc/llvm-project?rev=283406&view=rev
Log:
PR22924, PR22845, some of CWG1464: When checking the initializer for an array
new expression, distinguish between the case of a constant and non-constant
initializer
majnemer added inline comments.
> PrintPreprocessedOutput.cpp:331-349
> + const size_t N = Path.size();
> + size_t I = 0;
> + while (I < N) {
> +if (Path[I] == '\\' || Path[I] == '\"') {
> + // Have to escape backslashes or double-quotes.
> + // Send out backslash to escape the n
Author: ericwf
Date: Wed Oct 5 17:55:10 2016
New Revision: 283408
URL: http://llvm.org/viewvc/llvm-project?rev=283408&view=rev
Log:
Fix strict-aliasing violation in typeinfo::hash_code()
Summary:
The current implementation of `hash_code()` for uniqued RTTI strings violates
strict aliasing by de
EricWF updated this revision to Diff 73704.
EricWF added a comment.
Diagnose a coroutine `main` function in the same way as other invalid contexts.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Ind
Eugene.Zelenko added a comment.
This revision now requires review to proceed.
Looks like patch was not committed.
https://reviews.llvm.org/D390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Previously the statement `co_return {42}` would be transformed into
`P.return_void()`, since the type of `{42}` is represented as `void` by Cl
Hello everyone,
Below are some buildbot numbers for the last week of 9/25/2016 - 10/1/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
On Wed, Oct 5, 2016 at 7:40 PM, Galina Kistanova via cfe-commits
wrote:
> Hello everyone,
>
> Below are some buildbot numbers for the last week of 9/25/2016 - 10/1/2016.
>
> Please see the same data in attached csv files:
Can we please fix the clang-tools-sphinx-docs builder or take it
offline en
beanz added a comment.
This is actually not the right fix here. We should actually fix this in LLVM to
setup the rpath correctly on the targets during llvm_add_executable, then we
can remove this hack from LLVM instead of copying it to Clang. It might also
let us fix the RPATH goop in other too
majnemer added inline comments.
> SemaCoroutine.cpp:140
> + // or the function 'main' are declared as a coroutine.
> + CXXMethodDecl *MD = dyn_cast(FD);
> + if (MD && isa(MD))
`auto *`
https://reviews.llvm.org/D25292
___
cfe-commits mailing list
mshockwave added a comment.
> From this picture I don't see how the flattening itself can help us to avoid
> using global memory. Surely in both cases the captures content will have to
> be copied into the memory accessible for the enqueued kernel (which is a
> global memory in a general case,
EricWF updated this revision to Diff 73715.
EricWF added a comment.
- Address @majnemer's comment about using `auto`.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cp
erichkeane updated this revision to Diff 73716.
erichkeane marked 6 inline comments as done.
erichkeane added a comment.
Updated tests to properly show mangling for C++ types. Required some fixes.
Note that the decorating of names doesn't match ICC in non-named functions due
to a bug in ICC, a
elsteveogrande marked an inline comment as done.
elsteveogrande added inline comments.
> majnemer wrote in PrintPreprocessedOutput.cpp:331-349
> I think this loop would be easier to understand like so:
>
> while (!Path.empty()) {
> if (Path.consume_front("\\")) {
> Buffer.push_back("
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
elsteveogrande updated this revision to Diff 73720.
elsteveogrande marked an inline comment as done.
elsteveogrande added a comment.
Using `consume_front(sequence)`, cleaner escaping code.
https://reviews.llvm.org/D25153
Files:
include/clang/Driver/Options.td
include/clang/Frontend/Preproce
Author: mehdi_amini
Date: Wed Oct 5 23:26:16 2016
New Revision: 283416
URL: http://llvm.org/viewvc/llvm-project?rev=283416&view=rev
Log:
Use llvm::raw_string_ostream instead of std::stringstream (NFC)
As a side effect, this avoid having to call .data() on the StringRef.
Modified:
cfe/trunk/
Author: mehdi_amini
Date: Thu Oct 6 00:11:48 2016
New Revision: 283417
URL: http://llvm.org/viewvc/llvm-project?rev=283417&view=rev
Log:
Taking StringRef in Driver.h APIs instead of raw pointers (NFC)
Modified:
cfe/trunk/include/clang/Driver/Driver.h
cfe/trunk/lib/Driver/Driver.cpp
Modi
ahatanak added inline comments.
> TargetInfo.cpp:430
>if (AN == Name && ARN.RegNum < Names.size())
> -return Name;
> +if (ReturnCanonical)
> + return Names[ARN.RegNum];
Please use braces or a ternary operator here.
> ahatanak wrote in Targets.cpp:2718
> Can we s
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
> add_new_check.py:58
> +f.write(b'//===--- ')
> +f.write((os.path.basename(filename)).encode())
> +f.write(b' - clang-tidy')
Too many parentheses.
> add_new_check
Author: phosek
Date: Thu Oct 6 01:08:09 2016
New Revision: 283420
URL: http://llvm.org/viewvc/llvm-project?rev=283420&view=rev
Log:
[Driver] Add driver support for Fuchsia
Provide toolchain and tool support for Fuchsia operating system.
Fuchsia uses compiler-rt as the runtime library and libc++,
dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.
Are we sure this will not fail on Windows? i.e. have you built/run the tests on
Windws ARM or X86_64?
> Tools.cpp:4787
> options::OPT_fnoxray_instrument, fals
101 - 129 of 129 matches
Mail list logo
