[PATCH] D25154: [libc++] Fix stack_allocator

2016-10-01 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, howard.hinnant, STL_MSFT. EricWF added a subscriber: cfe-commits. To quote STL the problems with stack allocator are" > "stack_allocator is seriously nonconformant to N4582 17.6.3.5 > [allocator.requirements]. > First, it lacks

[PATCH] D22973: [libcxx] [test] Add TEST_STACK_ALLOCATOR_WORKAROUND.

2016-10-01 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Nevermind. I decided to just fix stack_allocator so this patch is no longer needed. Please let me know if the stack allocator fix doesn't work https://reviews.llvm.org/D22973 __

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

2016-10-01 Thread Michał Górny via cfe-commits
mgorny retitled this revision from "cmake: Adjust llvm-lit search to match the one in LLVM" to "[cmake] Update lit search to match the one in LLVM". mgorny updated the summary for this revision. mgorny updated this revision to Diff 73192. Herald added a subscriber: beanz. https://reviews.llvm.org

[libcxx] r283030 - Replace test_throw.h header with a single test macro

2016-10-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 1 05:34:13 2016 New Revision: 283030 URL: http://llvm.org/viewvc/llvm-project?rev=283030&view=rev Log: Replace test_throw.h header with a single test macro Removed: libcxx/trunk/test/support/test_throw.h Modified: libcxx/trunk/test/std/utilities/memory/speci

[libcxx] r283032 - Remove all instances of _LIBCPP_HAS_NO_RVALUE_REFERENCES from test/std/utilities

2016-10-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 1 05:46:01 2016 New Revision: 283032 URL: http://llvm.org/viewvc/llvm-project?rev=283032&view=rev Log: Remove all instances of _LIBCPP_HAS_NO_RVALUE_REFERENCES from test/std/utilities Modified: libcxx/trunk/test/std/utilities/allocator.adaptor/allocator.adaptor.

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* consistently for libs & tests

2016-10-01 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: beanz, samsonov. mgorny added a subscriber: cfe-commits. Herald added subscribers: dberris, kubabrecka, srhines, danalbert, tberghammer. Refactor the code to respect COMPILER_RT_BUILD_SANITIZERS and COMPILER_RT_BUILD_XRAY consistently for both

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

2016-10-01 Thread Teresa Johnson via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D24644#557774, @pcc wrote: > Perhaps it would be better to enable -ffunction-sections/-fdata-sections > unconditionally at the linker level if the linker supports it? See also > PR22999. My understanding is that these are not typically th

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests

2016-10-01 Thread Michał Górny via cfe-commits
mgorny retitled this revision from "[compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* consistently for libs & tests" to "[compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests". mgorny updated the summary for this revision. mgorny updated this revision to Diff 73198. mgorny

r283039 - Use StringRef in Registry API (NFC)

2016-10-01 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sat Oct 1 10:44:54 2016 New Revision: 283039 URL: http://llvm.org/viewvc/llvm-project?rev=283039&view=rev Log: Use StringRef in Registry API (NFC) Modified: cfe/trunk/lib/Tooling/CompilationDatabase.cpp Modified: cfe/trunk/lib/Tooling/CompilationDatabase.cpp URL:

Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

2016-10-01 Thread Joerg Sonnenberger via cfe-commits
On Fri, Sep 30, 2016 at 03:41:53PM -0700, Richard Trieu via cfe-commits wrote: > Currently, this warning is on by default. As you said, the results you > found look intentional in many cases, so there is a high false positive > rate. For on by default warnings, we expect a high true positive rate

r283043 - Use StringRef for MemoryBuffer identifier API (NFC)

2016-10-01 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Sat Oct 1 11:38:28 2016 New Revision: 283043 URL: http://llvm.org/viewvc/llvm-project?rev=283043&view=rev Log: Use StringRef for MemoryBuffer identifier API (NFC) Modified: cfe/trunk/include/clang/Basic/SourceManager.h cfe/trunk/include/clang/Lex/DirectoryLookup

[PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-10-01 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D18639#545697, @EricWF wrote: > LGTM. > > In https://reviews.llvm.org/D18639#514991, @hfinkel wrote: > > > In https://reviews.llvm.org/D18639#491232, @mclow.lists wrote: > > > > > And is there any reason why `__libcpp_isinf` can't just return `

[libcxx] r283051 - Use __builtin_isnan/isinf/isfinite in complex

2016-10-01 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sat Oct 1 15:38:31 2016 New Revision: 283051 URL: http://llvm.org/viewvc/llvm-project?rev=283051&view=rev Log: Use __builtin_isnan/isinf/isfinite in complex The libc-provided isnan/isinf/isfinite macro implementations are specifically designed to function correctly, even in

[PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-10-01 Thread Hal Finkel via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283051: Use __builtin_isnan/isinf/isfinite in complex (authored by hfinkel). Changed prior to commit: https://reviews.llvm.org/D18639?vs=67992&id=73202#toc Repository: rL LLVM https://reviews.llvm.o

[libcxx] r283052 - Remove some additional unnecessary std:: in cmath

2016-10-01 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sat Oct 1 15:38:44 2016 New Revision: 283052 URL: http://llvm.org/viewvc/llvm-project?rev=283052&view=rev Log: Remove some additional unnecessary std:: in cmath Unlike in math.h, as Eric pointed out in the review of D18639, we don't need the std:: in cmath. Modified: l

r283053 - [AVX-512] Add _MM_FROUND_NO_EXC to test cases that pass a rounding mode intrinsics. This is preparation for a follow up commit that will check validity of rounding mode argument.

2016-10-01 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 1 16:03:46 2016 New Revision: 283053 URL: http://llvm.org/viewvc/llvm-project?rev=283053&view=rev Log: [AVX-512] Add _MM_FROUND_NO_EXC to test cases that pass a rounding mode intrinsics. This is preparation for a follow up commit that will check validity of roundin

r283054 - [AVX-512] Check rounding mode for builtins that take one. Rounding mode should be either _MM_FROUND_CUR_DIRECTION or a 2-bit rounding mode ORed with _MM_FROUND_NO_EXC.

2016-10-01 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 1 16:03:50 2016 New Revision: 283054 URL: http://llvm.org/viewvc/llvm-project?rev=283054&view=rev Log: [AVX-512] Check rounding mode for builtins that take one. Rounding mode should be either _MM_FROUND_CUR_DIRECTION or a 2-bit rounding mode ORed with _MM_FROUND_NO

Re: r278483 - This patch implements PR#22821.

2016-10-01 Thread Joerg Sonnenberger via cfe-commits
On Fri, Aug 12, 2016 at 08:04:13AM -, Roger Ferrer Ibanez via cfe-commits wrote: > Author: rogfer01 > Date: Fri Aug 12 03:04:13 2016 > New Revision: 278483 > > URL: http://llvm.org/viewvc/llvm-project?rev=278483&view=rev > Log: > This patch implements PR#22821. > > Taking the address of a pa

[PATCH] D25130: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts

2016-10-01 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. One question, but otherwise this looks fine. > coroutines.m:1 > +// RUN: %clang -### %s 2>&1 | FileCheck -check-prefix=CHECK-NO-CORO %s > +// RUN: %clang -fcoroutines-ts -### %s 2>&1 | FileCh

[PATCH] D25130: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts

2016-10-01 Thread Gor Nishanov via cfe-commits
GorNishanov marked an inline comment as done. GorNishanov added inline comments. > rsmith wrote in coroutines.m:1 > Is there any reason you're testing Objective-C and Objective-C++ inputs here > (`.m` and `.mm`) rather than C and C++ inputs? No particular reason (cut and paste from module tests

r283061 - [PowerPC] Enable soft-float for PPC64, and +soft-float -> -hard-float

2016-10-01 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sat Oct 1 21:10:45 2016 New Revision: 283061 URL: http://llvm.org/viewvc/llvm-project?rev=283061&view=rev Log: [PowerPC] Enable soft-float for PPC64, and +soft-float -> -hard-float Enable soft-float support on PPC64, as the backend now supports it. Also, the backend now use

[PATCH] D25130: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts

2016-10-01 Thread Gor Nishanov via cfe-commits
GorNishanov updated this revision to Diff 73206. GorNishanov marked an inline comment as done. GorNishanov added a comment. rename .m and .mm to .c and .cpp https://reviews.llvm.org/D25130 Files: include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td include/clang/Driver/O

r283063 - Alias must point to a definition

2016-10-01 Thread Aditya Kumar via cfe-commits
Author: hiraditya Date: Sat Oct 1 22:06:36 2016 New Revision: 283063 URL: http://llvm.org/viewvc/llvm-project?rev=283063&view=rev Log: Alias must point to a definition Reapplying the patch after modifying the test case. Inlining the destructor caused the compiler to generate bad IR which failed

[PATCH] D25130: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts

2016-10-01 Thread Gor Nishanov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283064: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D25130?vs=73206&id=73208#toc Repository: rL LLVM

r283064 - [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts

2016-10-01 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Sat Oct 1 22:31:58 2016 New Revision: 283064 URL: http://llvm.org/viewvc/llvm-project?rev=283064&view=rev Log: [coroutines] Rename driver flag -fcoroutines to -fcoroutines-ts Summary: Also makes -fcoroutines_ts to be both a Driver and CC1 flag. Patch mostly by EricWF.

[PATCH] D24373: [coroutines] Adding builtins for coroutine intrinsics and backendutil support.

2016-10-01 Thread Gor Nishanov via cfe-commits
GorNishanov updated this revision to Diff 73213. GorNishanov added a comment. rebase on top of the trunk https://reviews.llvm.org/D24373 Files: docs/LanguageExtensions.rst include/clang/Basic/Builtins.def lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGCoroutine.cp

Re: r278483 - This patch implements PR#22821.

2016-10-01 Thread Joerg Sonnenberger via cfe-commits
On Sat, Oct 01, 2016 at 11:28:39PM +0200, Joerg Sonnenberger via cfe-commits wrote: > On Fri, Aug 12, 2016 at 08:04:13AM -, Roger Ferrer Ibanez via cfe-commits > wrote: > > Author: rogfer01 > > Date: Fri Aug 12 03:04:13 2016 > > New Revision: 278483 > > > > URL: http://llvm.org/viewvc/llvm-p