a.sidorin added a comment.
Don't hurry. The segfault is fixed already and patch waits for approval:
https://reviews.llvm.org/D24807. I'll update this fix in Monday.
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm
parallaxe added a comment.
Uhm, is there something missing from my side that i have overseen to go forward
with this patch?
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
This patch address issue 22924.
Context of the issue:
--
Currently code
$ cat bad-init.cpp
class A {
public:
A(int a): i_(a) {}
int i_ = 0;
};
void foo() {
A *p = new A[2] { A(3), A(5) };
}
is rejected with error
bad-init.cpp:8:36: error: no matching constructor
arphaman abandoned this revision.
arphaman added a comment.
I just noticed that PR 30274 is actually a duplicate of PR 29087, which already
has a patch with a fix in review. This patch is now abandoned. Sorry about not
noticing the duplicate earlier.
Repository:
rL LLVM
https://reviews.llvm
Author: mgehre
Date: Sat Sep 24 11:06:53 2016
New Revision: 282330
URL: http://llvm.org/viewvc/llvm-project?rev=282330&view=rev
Log:
[clang-tidy] fix for NOLINT after macro expansion
Summary:
When having
``` c++
#define MACRO code-with-warning
MACRO; // NOLINT
```
clang-tidy would still s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282330: [clang-tidy] fix for NOLINT after macro expansion
(authored by mgehre).
Changed prior to commit:
https://reviews.llvm.org/D24845?vs=72214&id=72391#toc
Repository:
rL LLVM
https://reviews.llv
Author: marshall
Date: Sat Sep 24 12:36:14 2016
New Revision: 282331
URL: http://llvm.org/viewvc/llvm-project?rev=282331&view=rev
Log:
Implement is_error_code_v and is_error_condition_v for c++17. Rework the tests
for is_error_code and is_error_condition, since they were really lacking.
Thanks t
- Original Message -
> From: "George Burgess IV"
> To: "Hal Finkel"
> Cc: "Richard Smith" , "Joerg Sonnenberger"
> , "cfe-commits"
>
> Sent: Monday, September 19, 2016 11:21:33 PM
> Subject: Re: r281277 - [Sema] Fix PR30346: relax __builtin_object_size checks.
>
>
> WFM; I'll put toge
Author: marshall
Date: Sat Sep 24 13:16:53 2016
New Revision: 282332
URL: http://llvm.org/viewvc/llvm-project?rev=282332&view=rev
Log:
Fix incorrect include in is_error_code_enum.pass.cpp
Modified:
libcxx/trunk/test/std/diagnostics/syserr/is_error_code_enum.pass.cpp
Modified: libcxx/trunk/te
NoQ retitled this revision from "[analyzer] A checker for macOS-specific
bool-like objects." to "[analyzer] A checker for macOS-specific bool- and
number-like objects.".
NoQ updated the summary for this revision.
NoQ updated this revision to Diff 72392.
NoQ marked 10 inline comments as done.
NoQ
mgehre added a comment.
I'm sorry if this sounds dumb, but is there a way for me to follow that
particular discussion?
https://reviews.llvm.org/D22587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, hokein.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Adds the option "LiteralInitializers" to
cppcoreguidelines-pro-type-member-init.
If set to non-zero, the check will provide fix-its with
mgehre updated this revision to Diff 72394.
mgehre added a comment.
Extend test to negative case
https://reviews.llvm.org/D24892
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h
docs/clang-tidy/checks/cppcoreguidelines-pr
omtcyfz accepted this revision.
omtcyfz added a comment.
This revision is now accepted and ready to land.
Sorry for a late response.
Yes, this solution is way better. Honestly I just didn't know how to achieve
that; not a Vim pro here :)
Thank you very much!
LGTM.
https://reviews.llvm.org/D2
omtcyfz added a comment.
@NewProggie do you have commit access or do you want me to land this patch for
you?
https://reviews.llvm.org/D24791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek, ioeric.
omtcyfz added subscribers: cfe-commits, Eugene.Zelenko.
This patch extends clang-tidy's readability-redundant-smartptr-get to produce
warnings for previously unsupported cases:
```
std::unique_ptr ptr;
if (ptr.get())
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 282342.
Comment at: include/string:613
@@ +612,3 @@
+ ( is_convertible
>::value &&
+ !is_convertible::value)) {};
+
EricWF wrote:
> The discussion for LWG 2758 gives a `
xazax.hun created this revision.
xazax.hun added reviewers: alexfh, hokein.
xazax.hun added a subscriber: cfe-commits.
xazax.hun set the repository for this revision to rL LLVM.
xazax.hun added a project: clang-tools-extra.
Herald added subscribers: mgorny, beanz.
This check finds the usages of no
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Libc++ still uses per-feature configuration macros when configuring for C++11.
However libc++ requires a feature-complete C++11 compiler so there is no reason
to check individual features.
Author: marshall
Date: Sat Sep 24 18:52:21 2016
New Revision: 282343
URL: http://llvm.org/viewvc/llvm-project?rev=282343&view=rev
Log:
Fix a few static_asserts that need extra parens on -03
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_insert/size_T_size_size.p
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
https://reviews.llvm.org/D24893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
alexfh added inline comments.
Comment at: clang-tidy/readability/RedundantSmartptrGetCheck.cpp:64
@@ -63,3 +63,3 @@
const auto IsAKnownSmartptr = recordDecl(
anyOf(hasName("::std::unique_ptr"), hasName("::std::shared_ptr")));
BTW, this can be done usin
Author: ericwf
Date: Sat Sep 24 22:14:13 2016
New Revision: 282345
URL: http://llvm.org/viewvc/llvm-project?rev=282345&view=rev
Log:
Use __attribute__((internal_linkage)) when available.
Summary:
This patch has been a long time coming (Thanks @eugenis). It changes
`_LIBCPP_INLINE_VISIBILITY` to
EricWF updated this revision to Diff 72410.
EricWF added a comment.
Actually remove _LIBCPP_HAS_NO_STATIC_ASSERT.
https://reviews.llvm.org/D24895
Files:
include/__config
include/iterator
include/memory
include/ratio
include/scoped_allocator
include/type_traits
src/string.cpp
tes
EricWF updated this revision to Diff 72411.
EricWF added a comment.
Fix merge conflicts.
https://reviews.llvm.org/D24895
Files:
include/__config
include/iterator
include/memory
include/ratio
include/scoped_allocator
include/type_traits
test/std/containers/associative/map/map.cons/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282347: [libc++] Remove various C++03 feature test macros
(authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D24895?vs=72411&id=72412#toc
Repository:
rL LLVM
https://reviews.llv
Author: ericwf
Date: Sat Sep 24 22:34:28 2016
New Revision: 282347
URL: http://llvm.org/viewvc/llvm-project?rev=282347&view=rev
Log:
[libc++] Remove various C++03 feature test macros
Summary:
Libc++ still uses per-feature configuration macros when configuring for C++11.
However libc++ requires a
Author: ericwf
Date: Sat Sep 24 23:05:46 2016
New Revision: 282349
URL: http://llvm.org/viewvc/llvm-project?rev=282349&view=rev
Log:
Fix missing _LIBCPP_INLINE_VISIBILITY macro on C++03 specific __hash_table
function
Modified:
libcxx/trunk/include/__hash_table
Modified: libcxx/trunk/include
28 matches
Mail list logo
