Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-21 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:154 @@ -153,3 +153,3 @@ public: - RedeclarableResult(GlobalDeclID FirstID, Decl *MergeWith, bool IsKeyDecl) - : FirstID(FirstID), MergeWith(MergeWith), IsKeyDecl(IsKeyDecl) {} +

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

2016-09-21 Thread Yaron Keren via cfe-commits
yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cf

Re: [PATCH] D24804: clang-format: [JS] reserved words in method names.

2016-09-21 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you. https://reviews.llvm.org/D24804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r282136 - clang-format: Add an option to git-clang-format to diff between to commits

2016-09-21 Thread Stephen Hines via cfe-commits
Author: srhines Date: Thu Sep 22 00:52:55 2016 New Revision: 282136 URL: http://llvm.org/viewvc/llvm-project?rev=282136&view=rev Log: clang-format: Add an option to git-clang-format to diff between to commits Summary: When building pre-upload hooks using git-clang-format, it is useful to limit t

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

2016-09-21 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282136: clang-format: Add an option to git-clang-format to diff between to commits (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24319?vs=72064&id=72138#toc Repository: rL

r282137 - [X86] Fix some illegal rounding modes in some builtin test cases to ones that would properly compile to valid assembly.

2016-09-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Sep 22 01:13:33 2016 New Revision: 282137 URL: http://llvm.org/viewvc/llvm-project?rev=282137&view=rev Log: [X86] Fix some illegal rounding modes in some builtin test cases to ones that would properly compile to valid assembly. Modified: cfe/trunk/test/CodeGen/avx51

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-21 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Can someone commit this patch now after it has been rebased? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2