mstorsjo added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Tooling/Core/Replacement.cpp:407
@@ -409,3 +406,3 @@
bool Result = true;
- for (Replacements::const_iterator I = Replaces.begin(),
-
ioeric updated this revision to Diff 71729.
ioeric marked an inline comment as done.
ioeric added a comment.
- Use auto.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
ioeric updated this revision to Diff 71730.
ioeric added a comment.
- Format code properly.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
=
Author: ioeric
Date: Sat Sep 17 07:26:42 2016
New Revision: 281819
URL: http://llvm.org/viewvc/llvm-project?rev=281819&view=rev
Log:
When replacements have the same offset, make replacements with smaller length
order first in the set.
Summary:
No behavioral change intended. The change makes iter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281819: When replacements have the same offset, make
replacements with smaller length… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24663?vs=71730&id=71731#toc
Repository:
**SpacesAroundConditions** (``bool``)
If ``true``, spaces will be inserted around if/for/while conditions.
**SpacesAfterNot** (``bool``)
If ``true``, spaces will be inserted after ``!``.
---
docs/ClangFormatStyleOptions.rst | 6 ++
include/clang/Format/Format.h| 8
lib/Form
lukasza added a comment.
Richard, could you please take a look?
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:750
@@ +749,3 @@
+else if (auto *ET = Node->getAs())
+ return matchesSpecialized(ET->getNamedType(), Finder, Builder);
+else if (auto *TST = N
Author: alexshap
Date: Sat Sep 17 12:08:47 2016
New Revision: 281826
URL: http://llvm.org/viewvc/llvm-project?rev=281826&view=rev
Log:
[clang-rename] Fix handling of unchanged files
Fix the output of clang-rename for the files without modifications.
Update the code in clang-reorder-fields/tool/Cl
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7600
@@ +7599,3 @@
+// Do not diagnose half type since it is diagnosed as invalid argument
+// type for any function eleswhere.
+if (!PT->isHalfType())
-> elsewhere
https://reviews.ll
EricWF added inline comments.
Comment at: include/__config:340
@@ -339,3 +344,1 @@
#if !defined(_LIBCPP_HAS_MUSL_LIBC)
-# include
-#if __GLIBC_PREREQ(2, 15)
What happened to this include? I believe it's needed to get `__GLIBC_PREREQ`.
Repository:
rL LLVM
ht
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
In https://reviews.llvm.org/D18639#514991, @hfinkel wrote:
> In https://reviews.llvm.org/D18639#491232, @mclow.lists wrote:
>
> > And is there any reason why `__libcpp_isinf` can't just
Author: kcc
Date: Sat Sep 17 23:52:23 2016
New Revision: 281845
URL: http://llvm.org/viewvc/llvm-project?rev=281845&view=rev
Log:
[libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the
guard type to intptr_t; use separate array for 8-bit counters
Modified:
cfe/trunk/
danalbert added a comment.
In https://reviews.llvm.org/D24690#545523, @compnerd wrote:
> So, the only thing that Im confused about is where does `__BIONIC__` get
> defined?
It's in Bionic's ``, which gets pulled in via ``.
Comment at: include/__config:340
@@ -339,3 +344,1 @@
djasper added a comment.
I think, this is the wrong fix. Instead, a
|| (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
should be added to the last return statement of this function.
Also, could you please add a test in unittests/Format/FormatTest.cpp.
https://reviews.llvm.org/D
Author: djasper
Date: Sat Sep 17 02:20:36 2016
New Revision: 281816
URL: http://llvm.org/viewvc/llvm-project?rev=281816&view=rev
Log:
clang-format: [JS] Fix a crash in handledTemplateStrings.
Modified:
cfe/trunk/lib/Format/FormatTokenLexer.cpp
cfe/trunk/unittests/Format/FormatTestJS.cpp
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:291
@@ +290,3 @@
+ static ProgramStateRef addExtentSize(CheckerContext &C,
+
18 matches
Mail list logo
