r281693 - Alter the iOS/tvOS ARM64 C++ ABI to ignore the upper half of the

Author: rjmccall Date: Thu Sep 15 21:40:45 2016 New Revision: 281693 URL: http://llvm.org/viewvc/llvm-project?rev=281693&view=rev Log: Alter the iOS/tvOS ARM64 C++ ABI to ignore the upper half of the virtual table offset in a member function pointer. We are reserving this space for future ABI use

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

tejohnson created this revision. tejohnson added reviewers: mehdi_amini, pcc. tejohnson added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, dschuff, jfb. These options need to be passed to the plugin in order to have an effect on LTO/ThinLTO compiles. https://reviews.llvm.org/

[libcxx] r281695 - Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback

Author: ericwf Date: Thu Sep 15 21:51:26 2016 New Revision: 281695 URL: http://llvm.org/viewvc/llvm-project?rev=281695&view=rev Log: Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback Modified: libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst Modified: libcxx/trunk/docs/DesignDocs/Visi

Re: [PATCH] D24446: Implement revision to LWG#2758

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The new overloads taking string_view's need to guard against self-aliasing string_views. Once that is fixed I would double check that your tests for `!is_convertible<_Tp const&, const _CharT*>

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

compnerd added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1; -

[libcxx] r281697 - Attempt to fix Sphinx build

Author: ericwf Date: Thu Sep 15 22:47:53 2016 New Revision: 281697 URL: http://llvm.org/viewvc/llvm-project?rev=281697&view=rev Log: Attempt to fix Sphinx build Modified: libcxx/trunk/docs/BuildingLibcxx.rst libcxx/trunk/docs/Makefile.sphinx libcxx/trunk/docs/TestingLibcxx.rst Modifi

[PATCH] D24646: [CMake] Allow building Sphinx docs in nit-picky mode

EricWF created this revision. EricWF added reviewers: rnk, delcypher. EricWF added subscribers: llvm-commits, cfe-commits. Herald added subscribers: mgorny, beanz. The actual logic to build http://llvm.org/libcxx/docs does so with "-W" and "-n" enabled, meaning that the website will not be update

Re: Upgrade and fix clang-format-vs

Sorry I haven't had a chance to get back to this. Things got busy at work. I do plan to get back to this as I'm hoping to add some features to this extension :) On Thu, Sep 15, 2016 at 7:31 PM Zachary Turner wrote: > Strange. FWIW you can dump all the variables that are present in your > environ

Re: [PATCH] D24646: [CMake] Allow building Sphinx docs in nit-picky mode

EricWF updated this revision to Diff 71594. EricWF added a comment. Use spaces not tabs. https://reviews.llvm.org/D24646 Files: cmake/modules/AddSphinxTarget.cmake Index: cmake/modules/AddSphinxTarget.cmake === --- cmake/modules

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

zaks.anna added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2055 @@ -2054,1 +2054,3 @@ } +def WarnImpcastToBoolDocs : Documentation { + let Category = DocCatFunction; You probably need to "propose" the attribute to the clang community. I'd send

Re: [PATCH] D24642: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. I'll commit this change tomorrow barring any objections. https://reviews.llvm.org/D24642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5137-5138 @@ -5137,1 +5136,4 @@ + Stmt *CurStmt = AStmt; + if (auto CapS = dyn_cast_or_null(CurStmt)) +CurStmt = CapS->getCapturedStmt(); for (unsigned Cnt = 0; Cnt < NestedLoopCount; ++Cnt) {

Re: [PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

ABataev added a subscriber: ABataev. Comment at: lib/Sema/SemaChecking.cpp:6588 @@ -6587,2 +6587,3 @@ stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr); + } else if (lhsType->isReferenceType()) { Remove empty line Comment at:

[PATCH] D24648: Fix unused result from sign extending an Offset.

srhines created this revision. srhines added a reviewer: cfe-commits. srhines added a subscriber: meikeb. Offset was doubled in size, but the assignment was missing. We just need to reassign to the original variable in this case to fix it. https://reviews.llvm.org/D24648 Files: lib/Sema/SemaCh

Re: [PATCH] D24648: Fix unused result from sign extending an Offset.

sext should probably be marked WARN_UNUSED_RESULT On Thursday, September 15, 2016, Stephen Hines via cfe-commits < cfe-commits@lists.llvm.org> wrote: > srhines created this revision. > srhines added a reviewer: cfe-commits. > srhines added a subscriber: meikeb. > > Offset was doubled in size, but

Re: [PATCH] D24648: Fix unused result from sign extending an Offset.

It is marked LLVM_ATTRIBUTE_UNUSED_RESULT (which boils down to having __warn_unused_result__). I am not sure why this didn't trigger during any local build/test that we did. Steve On Thu, Sep 15, 2016 at 11:45 PM, David Majnemer wrote: > sext should probably be marked WARN_UNUSED_RESULT > > > O

<    1   2