r281285 - Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-09-12 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon Sep 12 20:13:19 2016 New Revision: 281285 URL: http://llvm.org/viewvc/llvm-project?rev=281285&view=rev Log: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.") Differential Revision: http://reviews.llvm.org/D20415 Modified: cfe/trun

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-09-12 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281285: Update Clang for D20147 ("DebugInfo: New metadata representation for global… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D20415?vs=59260&id=71088#toc Repository: rL L

r281286 - Fix interaction between serialization and c++1z feature.

2016-09-12 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Mon Sep 12 20:20:40 2016 New Revision: 281286 URL: http://llvm.org/viewvc/llvm-project?rev=281286&view=rev Log: Fix interaction between serialization and c++1z feature. In c++1z, static_assert is not required to have a StringLiteral message, where previously it was required.

r281287 - Handle empty message in static_asserts.

2016-09-12 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Mon Sep 12 20:37:01 2016 New Revision: 281287 URL: http://llvm.org/viewvc/llvm-project?rev=281287&view=rev Log: Handle empty message in static_asserts. Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewv

[PATCH] D24487: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings in AST; other minor fixes

2016-09-12 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd, Prazek. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Re

[PATCH] D24488: Simplify Clang's version number configuration in CMake.

2016-09-12 Thread David L. Jones via cfe-commits
dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Simplify Clang's version number configuration in CMake. Currently, the Clang version is computed as follows: 1. LLVM defines major, minor, and patch ver

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 71095. lhchavez added a comment. No-op update. Using arcanist to fix the diff and the paths. https://reviews.llvm.org/D24319 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format ==

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez added a comment. I'll post a no-op change with arcanist to fix the paths (I shouldn't have tried to manually upload the diff), and then another one to fix the patch so that the script actually does what it advertises and add the comment explaining the reason for create_tree_from_commit

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 71097. lhchavez added a comment. Fix the script so it does what it advertises. https://reviews.llvm.org/D24319 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

2016-09-12 Thread Meike Baumgärtner via cfe-commits
meikeb updated this revision to Diff 71090. meikeb marked an inline comment as done. meikeb added a comment. Fix mentioned issues. https://reviews.llvm.org/D23820 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c =

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

2016-09-12 Thread Meike Baumgärtner via cfe-commits
meikeb marked 6 inline comments as done. meikeb added a comment. Thanks for taking the time and doing these great reviews! Really appreciated! Comment at: lib/Sema/SemaChecking.cpp:4143-4150 @@ -4049,3 +4142,10 @@ if (StrE) { - CheckFormatString(S, StrE, E, Args, HasVA

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

2016-09-12 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. You can create a separate patch for the changes made to lib/Headers/intrin.h and have it reviewed before committing this patch. Also, __dst, __x and __n should be added to the output list and "memory" to the clobber list as majnemer pointed out. I think you can use con

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 71103. lhchavez added a comment. Using lodato's proposed interface. This patch: - Accepts an arbitrary number of commits as arguments. Validation will be done in main(), such that two commits are valid only when running in --diff mode. - Allows diffing two

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez marked 3 inline comments as done. Comment at: cfe/trunk/tools/clang-format/git-clang-format:93 @@ -92,1 +92,3 @@ help='default commit to use if none is specified'), + p.add_argument('--single-commit', action='store_true', + help=('run cl

r281293 - Reapply r281276 with passing -emit-llvm in one of the tests

2016-09-12 Thread Adam Nemet via cfe-commits
Author: anemet Date: Mon Sep 12 23:32:40 2016 New Revision: 281293 URL: http://llvm.org/viewvc/llvm-project?rev=281293&view=rev Log: Reapply r281276 with passing -emit-llvm in one of the tests Original commit message: Add -fdiagnostics-show-hotness Summary: I've recently added the ability for o

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 71104. lhchavez added a comment. Rebased to r281293 https://reviews.llvm.org/D24401 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format === --- tools/clang

r281294 - clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
Author: srhines Date: Tue Sep 13 00:00:20 2016 New Revision: 281294 URL: http://llvm.org/viewvc/llvm-project?rev=281294&view=rev Log: clang-format: Add Java detection to git-clang-format. Summary: This change adds "java" to the list of known extensions that clang-format supports. Patch by Luis

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

2016-09-12 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281294: clang-format: Add Java detection to git-clang-format. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24401?vs=71104&id=71107#toc Repository: rL LLVM https://review

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez updated this revision to Diff 7. lhchavez marked an inline comment as done. lhchavez added a comment. Got rid of create_tree_from_commit https://reviews.llvm.org/D24319 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

2016-09-12 Thread Luis Héctor Chávez via cfe-commits
lhchavez marked 2 inline comments as done. Comment at: cfe/trunk/tools/clang-format/git-clang-format:323 @@ -312,1 +322,3 @@ +def create_tree_from_commit(commit, filenames): + """Create a new git tree with the given files from `commit`. lhchavez wrote: > lodato

<    1   2