Re: [PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

2016-08-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279151: [CMake] Get libcxx building under LLVM/runtimes (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23696?vs=68610&id=68613#toc Repository: rL LLVM https://reviews.ll

r279154 - CodeGen: use range based for loop, NFC

2016-08-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Aug 18 16:40:06 2016 New Revision: 279154 URL: http://llvm.org/viewvc/llvm-project?rev=279154&view=rev Log: CodeGen: use range based for loop, NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL: http://llvm.org/viewvc/llv

Re: [PATCH] D23492: Make function local tags visible.

2016-08-18 Thread Vassil Vassilev via cfe-commits
v.g.vassilev updated this revision to Diff 68620. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Move DiagnoseUninstantiableTemplate before the late template parsing. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp l

r279159 - CodeGen: Rename a variable to better fit LLVM style. NFC

2016-08-18 Thread Justin Bogner via cfe-commits
Author: bogner Date: Thu Aug 18 16:46:54 2016 New Revision: 279159 URL: http://llvm.org/viewvc/llvm-project?rev=279159&view=rev Log: CodeGen: Rename a variable to better fit LLVM style. NFC Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL: http://llv

r279163 - C++ Modules TS: Add parsing support for module import declaration.

2016-08-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 18 16:59:42 2016 New Revision: 279163 URL: http://llvm.org/viewvc/llvm-project?rev=279163&view=rev Log: C++ Modules TS: Add parsing support for module import declaration. Added: cfe/trunk/test/Parser/cxx-modules-import.cpp Modified: cfe/trunk/include/clang/Bas

r279164 - PR28794: Don't try to instantiate function templates which are not visible.

2016-08-18 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Thu Aug 18 17:01:25 2016 New Revision: 279164 URL: http://llvm.org/viewvc/llvm-project?rev=279164&view=rev Log: PR28794: Don't try to instantiate function templates which are not visible. Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inputs/PR28794/ cfe

r279165 - AMDGPU: Add clang builtin for ds_swizzle.

2016-08-18 Thread Changpeng Fang via cfe-commits
Author: chfang Date: Thu Aug 18 17:04:54 2016 New Revision: 279165 URL: http://llvm.org/viewvc/llvm-project?rev=279165&view=rev Log: AMDGPU: Add clang builtin for ds_swizzle. Summary: int __builtin_amdgcn_ds_swizzle (int a, int imm); while imm is a constant. Differential Revision: http://rev

[clang-tools-extra] r279170 - [Documentation] Fixed style in modernize-use-emplace.rst.

2016-08-18 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Thu Aug 18 17:11:27 2016 New Revision: 279170 URL: http://llvm.org/viewvc/llvm-project?rev=279170&view=rev Log: [Documentation] Fixed style in modernize-use-emplace.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst Modified:

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

2016-08-18 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r279173 https://reviews.llvm.org/D23530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

2016-08-18 Thread Akira Hatanaka via cfe-commits
ahatanak added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone";

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

2016-08-18 Thread Vedant Kumar via cfe-commits
vsk added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone"; -

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

2016-08-18 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 68630. vsk added a comment. Per Akira's suggestion, don't pretend that the Arg* for -arch is a user-specified CPU name (and update the doxygen to reflect this). https://reviews.llvm.org/D23643 Files: lib/Driver/Tools.cpp test/Driver/arm-cortex-cpus.c Inde

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-18 Thread Raphael Isemann via cfe-commits
teemperor updated this revision to Diff 68632. teemperor added a comment. This revision is now accepted and ready to land. - Moved from hash_stream to LLVM's MD5 implementation. https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp

Re: Upgrade and fix clang-format-vs

2016-08-18 Thread Hans Wennborg via cfe-commits
Hi Antonio, On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits wrote: > This patch for clang-format-vs includes the following: > > - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and > upgrading Microsoft.VisualStudio references to v14 versions > - Fix build

[libunwind] r279180 - EHABI: cover switch once more

2016-08-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Aug 18 18:59:12 2016 New Revision: 279180 URL: http://llvm.org/viewvc/llvm-project?rev=279180&view=rev Log: EHABI: cover switch once more When making WMMX support optional, we uncovered the switch. Add the missing entries. Since the entry is a break leading to a dead

[PATCH] D23699: [CMake] Be more consistent about naming targets and components

2016-08-18 Thread Chris Bieneman via cfe-commits
beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The point of this patch is to have a consistent convention for naming build, check and install targets so that the targets can be constructed from the project name. This change renames a bunch of

r279181 - [analyzer] Weaken assertion in trackNullOrUndefValue()

2016-08-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Aug 18 20:05:31 2016 New Revision: 279181 URL: http://llvm.org/viewvc/llvm-project?rev=279181&view=rev Log: [analyzer] Weaken assertion in trackNullOrUndefValue() We should ignore paren casts when making sure that the semantic expression in a PseudoObjectExpr for an Ob

r279183 - [www] Add analyzer FAQ about not releasing ivars in -dealloc.

2016-08-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Thu Aug 18 20:22:50 2016 New Revision: 279183 URL: http://llvm.org/viewvc/llvm-project?rev=279183&view=rev Log: [www] Add analyzer FAQ about not releasing ivars in -dealloc. Modified: cfe/trunk/www/analyzer/faq.html Modified: cfe/trunk/www/analyzer/faq.html URL: http

[libcxxabi] r279189 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:38 2016 New Revision: 279189 URL: http://llvm.org/viewvc/llvm-project?rev=279189&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc2/ (props changed) - copied from r279188, libcxxabi/branches/re

[libcxx] r279188 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:35 2016 New Revision: 279188 URL: http://llvm.org/viewvc/llvm-project?rev=279188&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libcxx/tags/RELEASE_390/rc2/ (props changed) - copied from r279187, libcxx/branches/release_

r279196 - C++ Modules TS: support parsing the 'module' declaration (including extensions

2016-08-18 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Aug 18 20:43:06 2016 New Revision: 279196 URL: http://llvm.org/viewvc/llvm-project?rev=279196&view=rev Log: C++ Modules TS: support parsing the 'module' declaration (including extensions from p0273r0 approved by EWG). We'll eventually need to handle this from the lexer as

[libunwind] r279195 - Creating release candidate rc2 from release_390 branch

2016-08-18 Thread Hans Wennborg via cfe-commits
Author: hans Date: Thu Aug 18 20:42:56 2016 New Revision: 279195 URL: http://llvm.org/viewvc/llvm-project?rev=279195&view=rev Log: Creating release candidate rc2 from release_390 branch Added: libunwind/tags/RELEASE_390/rc2/ (props changed) - copied from r279194, libunwind/branches/re

Re: Upgrade and fix clang-format-vs

2016-08-18 Thread Zachary Turner via cfe-commits
Llvm doesn't support vs2012 anymore, as long as it supports vs2013 it's fine On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano wrote: > Hi, > > What I meant by upgrade was simply making it build in VS 2015. However, > you bring up a valid point about making sure the extension will continue to > wo

Re: Upgrade and fix clang-format-vs

2016-08-18 Thread Zachary Turner via cfe-commits
The key.snk is generated when you build, the problem is the csproj file hardcodes the directory to the sdk instead of using the appropriate project system variable like $(SDKToolsDir) On Thu, Aug 18, 2016 at 7:09 PM Zachary Turner wrote: > Llvm doesn't support vs2012 anymore, as long as it suppor

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

2016-08-18 Thread Faisal Vali via cfe-commits
faisalv updated this revision to Diff 68644. faisalv marked 4 inline comments as done. faisalv added a comment. Address Richard's comments. https://reviews.llvm.org/D23493 Files: lib/AST/ExprConstant.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaCXX/constant-expression-cxx11.cpp

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

2016-08-18 Thread Faisal Vali via cfe-commits
faisalv added a comment. Address Richard's comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:190 @@ -189,3 +189,3 @@ if (A->getCond()->isValueDependent() && !Cond->isValueDependent() && - !Expr::isPotentialConstantExprUnevaluated(Cond, cast(Tmpl), + !Ex

r279206 - Re-commit [OpenCL] AMDGCN: Fix size_t type

2016-08-18 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Fri Aug 19 00:17:25 2016 New Revision: 279206 URL: http://llvm.org/viewvc/llvm-project?rev=279206&view=rev Log: Re-commit [OpenCL] AMDGCN: Fix size_t type There was a premature cast to pointer type in emitPointerArithmetic which caused assertion in tests with assertion enabl

[PATCH] D23705: [GraphTraits] Make nodes_iterator dereference to NodeRef

2016-08-18 Thread Tim Shen via cfe-commits
timshen created this revision. timshen added a reviewer: dblaikie. timshen added a subscriber: cfe-commits. Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make them all dereference to NodeType*, which is NodeRef later. Corresponding LLVM change: D23704 https://reviews.l

r279207 - clang/test/Modules/prebuilt-module.m: Prune "-triple" to fix a configuration mismatch.

2016-08-18 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Aug 19 00:25:26 2016 New Revision: 279207 URL: http://llvm.org/viewvc/llvm-project?rev=279207&view=rev Log: clang/test/Modules/prebuilt-module.m: Prune "-triple" to fix a configuration mismatch. Modified: cfe/trunk/test/Modules/prebuilt-module.m Modified: cfe/trunk

<    1   2