Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs removed rL LLVM as the repository for this revision. abergmeier-dsfishlabs updated this revision to Diff 68487. abergmeier-dsfishlabs added a comment. Removed unnecessary list conversion. https://reviews.llvm.org/D23602 Files: tools/clang-format/git-clang-format Index:

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

abergmeier-dsfishlabs set the repository for this revision to rL LLVM. abergmeier-dsfishlabs updated this revision to Diff 68488. abergmeier-dsfishlabs added a comment. Proper patch of last version (hopefully) Repository: rL LLVM https://reviews.llvm.org/D23602 Files: tools/clang-format/gi

Re: r279024 - PR28438: Update the information on an identifier with local definitions before

On 18/08/16 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024&view=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macr

r279037 - [analyzer] Small cleanups when checkers retrieving statements from exploded

Author: xazax Date: Thu Aug 18 02:54:50 2016 New Revision: 279037 URL: http://llvm.org/viewvc/llvm-project?rev=279037&view=rev Log: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes. Differential Revision: https://reviews.llvm.org/D23550 Modified: cfe/trunk/li

Re: [PATCH] D23550: [analyzer] Small cleanups when checkers retrieving statements from exploded nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279037: [analyzer] Small cleanups when checkers retrieving statements from exploded (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D23550?vs=68166&id=68492#toc Repository: rL

r279041 - [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 03:43:26 2016 New Revision: 279041 URL: http://llvm.org/viewvc/llvm-project?rev=279041&view=rev Log: [analyzer] Added valist related checkers. Differential Revision: https://reviews.llvm.org/D15227 Added: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

Re: [PATCH] D15227: [analyzer] Valist checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279041: [analyzer] Added valist related checkers. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D15227?vs=68157&id=68497#toc Repository: rL LLVM https://reviews.llvm.org/D15

r279042 - test commit

Author: guyblank Date: Thu Aug 18 03:44:33 2016 New Revision: 279042 URL: http://llvm.org/viewvc/llvm-project?rev=279042&view=rev Log: test commit Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

guyblank added a comment. Still, __XSAVE__ should have been defined when compiling for a target that supports the feature. But anyway, the xsaveintrin.h is quite small so always including it shouldn't be an issue. Are you ok with me removing the #if just for this header file, or would you like

r279043 - revert [analyzer] Added valist related checkers.

Author: xazax Date: Thu Aug 18 04:13:37 2016 New Revision: 279043 URL: http://llvm.org/viewvc/llvm-project?rev=279043&view=rev Log: revert [analyzer] Added valist related checkers. Removed: cfe/trunk/lib/StaticAnalyzer/Checkers/ValistChecker.cpp cfe/trunk/test/Analysis/Inputs/system-heade

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

Hi, I had to revert this (r279045) because it breaks some of our buildbots (e.g. clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost-modules). The error is in OpenMP/teams_distribute_simd_ast_print.cpp: clang: /home/buildslave/buildslave/clang-cmake-aarch64-quick/llvm/include/llvm/ADT/DenseMap

[PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. As Miklos Vajna [[ http://lists.llvm.org/pipermail/cfe-dev/2016-August/050398.html | noticed ]] `clang-rename rename-all` has significant performance problems, which exposed the fac

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68503. omtcyfz added a comment. Prevent unnecessary `std::vector` copying. Explicitly write type. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

vmiklos added a comment. I can confirm that with this, the test script from the mail thread shows that clang-rename is almost as fast as clang++ as expected. Thanks! https://reviews.llvm.org/D23651 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 6 inline comments as done. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified()) + markCanNotBeConst(VD->getInit(),

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexshap added a subscriber: alexshap. Comment at: clang-rename/USRFindingAction.h:38 @@ -37,5 +37,3 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + std::vector SymbolOffsets; + std::vector OldNames;

Re: [PATCH] D15227: [analyzer] Valist checkers.

xazax.hun reopened this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks like it broke some of the build bots. Error from the windows build bots: error: 'note' diagnostics expected but not seen: File C:\Buildbot\Slave\llvm-clang-lld-x86_64-sc

[clang-tools-extra] r279049 - [clang-tidy docs] Fix build errors on Sphinx 1.4.5

Author: alexfh Date: Thu Aug 18 06:06:09 2016 New Revision: 279049 URL: http://llvm.org/viewvc/llvm-project?rev=279049&view=rev Log: [clang-tidy docs] Fix build errors on Sphinx 1.4.5 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.r

[clang-tools-extra] r279050 - [clang-tidy docs] Fix formatting.

Author: alexfh Date: Thu Aug 18 06:10:52 2016 New Revision: 279050 URL: http://llvm.org/viewvc/llvm-project?rev=279050&view=rev Log: [clang-tidy docs] Fix formatting. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified: clang-tools-extra/trunk/docs/clang-t

[clang-tools-extra] r279051 - [clang-tidy docs] Minor fix

Author: alexfh Date: Thu Aug 18 06:12:03 2016 New Revision: 279051 URL: http://llvm.org/viewvc/llvm-project?rev=279051&view=rev Log: [clang-tidy docs] Minor fix Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/mpi-type-mismatch.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/ch

[PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap created this revision. alexshap added reviewers: gribozavr, bkramer. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Add the "explicit" specifier to the single-argument constructor o

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

alexshap added a comment. F2283280: Screen Shot 2016-08-18 at 4.29.34 AM.png https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3600-3605 @@ -3598,2 +3599,8 @@ // which definitions should be visible. + if (DiagnoseUninstantiableTemplate(PointOfInstantiation, Function, +Function->getI

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.h:38-41 @@ -37,6 +37,6 @@ private: - unsigned SymbolOffset; - std::string OldName; - std::string SpellingName; - std::vector USRs; + const std::vector &SymbolOffsets; + const std::vector &Ol

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

omtcyfz updated this revision to Diff 68511. omtcyfz added a comment. Prevent std::vector from redundant copying. https://reviews.llvm.org/D23651 Files: clang-rename/USRFindingAction.cpp clang-rename/USRFindingAction.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRenam

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu marked 2 inline comments as done. Comment at: lib/AST/Expr.cpp:2868 @@ +2867,3 @@ +OverloadedOperatorKind binOp = cast(this)->getOperator(); +if (binOp == OO_Equal || (binOp >= OO_PlusEqual && binOp <= OO_PipeEqual)) { + return true; rs

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu removed rL LLVM as the repository for this revision. Abpostelnicu updated this revision to Diff 68507. https://reviews.llvm.org/D22910 Files: include/clang/AST/ExprCXX.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ===

[PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

thegameg created this revision. thegameg added reviewers: aaron.ballman, courbet. thegameg added a subscriber: cfe-commits. Herald added a subscriber: klimek. The example is using `isInteger()` instead of `signed` / `unsigned` version. https://reviews.llvm.org/D23641 Files: docs/LibASTMatchers

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

thegameg added a comment. Can you commit this for me, please? Thanks! https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

NoQ added a comment. On second thought, in `RangeConstraintManager` we need a different functionality. In particular, from `4 * x < 1000` it does not follow that `x < 250` in the general case (due to possible overflows). But in the case of this checker, it doesn't matter - we are always sure th

Re: [PATCH] D23641: [ASTMatchers] Fix documentation of is(Un)SignedInteger()

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r279055 https://reviews.llvm.org/D23641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279055 - Correct the documentation for isSignedInteger() and isUnsignedInteger().

Author: aaronballman Date: Thu Aug 18 07:26:17 2016 New Revision: 279055 URL: http://llvm.org/viewvc/llvm-project?rev=279055&view=rev Log: Correct the documentation for isSignedInteger() and isUnsignedInteger(). Patch by Visoiu Mistrih Francis Modified: cfe/trunk/docs/LibASTMatchersReference

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279056: [analyzer] Teach CloneDetector to find clones that look like copy-paste errors. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23314?vs=68422&id=68518#toc Repositor

r279056 - [analyzer] Teach CloneDetector to find clones that look like copy-paste errors.

Author: dergachev Date: Thu Aug 18 07:29:41 2016 New Revision: 279056 URL: http://llvm.org/viewvc/llvm-project?rev=279056&view=rev Log: [analyzer] Teach CloneDetector to find clones that look like copy-paste errors. The original clone checker tries to find copy-pasted code that is exactly identic

[PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 created this revision. rogfer01 added reviewers: aaron.ballman, rsmith. rogfer01 added a subscriber: cfe-commits. This change remove some false positives when taking the address of packed members. - It silences the warning when a cast to uintptr_t/intptr_t happens. - If the field is in

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 68528. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Fixed review comments https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp clan

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 68531. danielmarjamaki added a comment. Fixed review comments about formatting in doc https://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/NonConstParameterCheck.cpp clang-tidy/readability/NonCons

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 added inline comments. Comment at: unittests/libclang/LibclangTest.cpp:16-20 @@ -15,4 +15,7 @@ #include "gtest/gtest.h" #include #include +#include +#include +#include #define DEBUG_TYPE "libclang-test" rsmith wrote: > Please put these in alpha

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68536. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add setHidden(false) and update fixme. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate

Re: [PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

john.brawn added a subscriber: john.brawn. john.brawn added a comment. > When my Java application calls clang_createIndex() with crash recovery > enabled it replaces the JVM's segfault handler with > CrashRecoverySignalHandler and now this handler gets all the segfault signals > that would have

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1513 @@ -1512,2 +1512,3 @@ // extension. -llvm::Type *MiddleTy = CGF.IntPtrTy; +auto DestLLVMTy = ConvertType(DestTy); +llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(DestLLVMT

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:104 @@ +103,3 @@ + const QualType T = Parm->getType(); + if (!T->isPointerType() || T->getPointeeType().isCo

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl marked an inline comment as done. Comment at: lib/CodeGen/CGExprScalar.cpp:1513 @@ -1512,2 +1512,3 @@ // extension. -llvm::Type *MiddleTy = CGF.IntPtrTy; +auto DestLLVMTy = ConvertType(DestTy); +llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(D

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:69 @@ -69,2 +68,3 @@ } -USRs->insert(USRs->end(), USRSet.begin(), USRSet.end()); +USRs.insert(USRs.end(), USRSet.begin(), USRSet.end

r279076 - [libclang] Add clang_getAllSkippedRanges function

Author: cameron314 Date: Thu Aug 18 10:43:55 2016 New Revision: 279076 URL: http://llvm.org/viewvc/llvm-project?rev=279076&view=rev Log: [libclang] Add clang_getAllSkippedRanges function This complements the clang_getSkippedRanges function which returns skipped ranges filtered by a specific file

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

This revision was automatically updated to reflect the committed changes. Closed by commit rL279076: [libclang] Add clang_getAllSkippedRanges function (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D20132?vs=56964&id=68548#toc Repository: rL LLVM https://reviews

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

rnk added a comment. Hm, resending my comments because it doesn't appear to work from email. I swear it used to... In https://reviews.llvm.org/D21959#519179, @guyblank wrote: > Still, __XSAVE__ should have been defined when compiling for a target that > supports the feature. That's not how M

Re: r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

This doesn't work at all, llvm-config.h does not provide the relevant configuration macros. On 17 Aug 2016 11:56 p.m., "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: vedantk > Date: Thu Aug 18 01:43:07 2016 > New Revision: 279035 > > URL: http://llvm.org/viewvc/llvm

r279085 - [libclang] Fixed signed/unsigned comparison warning introduced in my revision r279076

Author: cameron314 Date: Thu Aug 18 11:25:42 2016 New Revision: 279085 URL: http://llvm.org/viewvc/llvm-project?rev=279085&view=rev Log: [libclang] Fixed signed/unsigned comparison warning introduced in my revision r279076 Modified: cfe/trunk/unittests/libclang/LibclangTest.cpp Modified: cf

Re: r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

Clang isn't allowed to use LLVM's config.h, though, specifically to support the standalone build. You can either create equivalent LLVM_ prefixed macros in llvm-config.h.cmake, or repeat the checks and define the same macros in clang/include/clang/Config/config.h.cmake. On Thu, Aug 18, 2016 at 9:

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r279076 - [libclang] Add clang_getAllSkippedRanges function

On Thu, Aug 18, 2016 at 8:43 AM, Cameron Desrochers via cfe-commits wrote: > Author: cameron314 > Date: Thu Aug 18 10:43:55 2016 > New Revision: 279076 > > URL: http://llvm.org/viewvc/llvm-project?rev=279076&view=rev > Log: > [libclang] Add clang_getAllSkippedRanges function > > This complements t

Re: Record ranges skipped by the preprocessor and expose them with libclang.

(Sending again, somehow the uiuc.edu mailing list address was in my reply-all! Sorry for the duplicates :)) This breaks things for me, I think an entry in 'libclang.exports' is needed for clang_getAllSkippedRanges ? If that sounds right, can someone commit the fix? Thanks! :) ~Will, he-who-buil

Re: r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

On 18 Aug 2016 9:36 a.m., "Reid Kleckner" wrote: > > Clang isn't allowed to use LLVM's config.h, though, specifically to support the standalone build. > > You can either create equivalent LLVM_ prefixed macros in llvm-config.h.cmake, or repeat the checks and define the same macros in clang/include

Re: Record ranges skipped by the preprocessor and expose them with libclang.

Ah, is that why! My fault, sorry. I couldn't figure out why it wouldn't link on the build machines when it worked fine for me locally (on Windows)... Thank you, I will fix this shortly. On Thu, Aug 18, 2016 at 12:52 PM, Will Dietz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > (Sending ag

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor updated this revision to Diff 68556. teemperor added a comment. - Added more documentation to the CloneSignature::Complexity field. - Macros now have a complexity value of 1 + sum(ChildComplexityValues). - Tests should be less cryptic now. https://reviews.llvm.org/D23316 Files: incl

r279092 - [libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges' to libclang.exports

Author: cameron314 Date: Thu Aug 18 12:18:03 2016 New Revision: 279092 URL: http://llvm.org/viewvc/llvm-project?rev=279092&view=rev Log: [libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges' to libclang.exports Modified: cfe/trunk/tools/libclang/libclang.exports Mo

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor marked 10 inline comments as done. Comment at: lib/Analysis/CloneDetection.cpp:436 @@ +435,3 @@ +if (IsInMacro) { + Signature.Complexity = 0; +} NoQ wrote: > omtcyfz wrote: > > omtcyfz wrote: > > > omtcyfz wrote: > > > > NoQ wrote: > > > > >

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

teemperor updated this revision to Diff 68568. teemperor marked 2 inline comments as done. teemperor added a comment. - Added false-positives note for empty macros to the test suite. https://reviews.llvm.org/D23316 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.c

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

This revision was automatically updated to reflect the committed changes. Closed by commit rL279096: Module: add -fprebuilt-module-path to support loading prebuilt modules. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D23125?vs=68456&id=68570#toc Repository: rL LLVM

r279097 - Revert "[Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds"

Author: vedantk Date: Thu Aug 18 12:43:02 2016 New Revision: 279097 URL: http://llvm.org/viewvc/llvm-project?rev=279097&view=rev Log: Revert "[Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds" This reverts commit r279035. According to Richard Smith, llvm-config.h does not con

r279096 - Module: add -fprebuilt-module-path to support loading prebuilt modules.

Author: mren Date: Thu Aug 18 12:42:15 2016 New Revision: 279096 URL: http://llvm.org/viewvc/llvm-project?rev=279096&view=rev Log: Module: add -fprebuilt-module-path to support loading prebuilt modules. In this mode, there is no need to load any module map and the programmer can simply use "@impo

Re: r279035 - [Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds

I shouldn't have assumed that this was correct because it built. Reverted in r279097. vedant > On Aug 18, 2016, at 9:25 AM, Richard Smith wrote: > > This doesn't work at all, llvm-config.h does not provide the relevant > configuration macros. > > > On 17 Aug 2016 11:56 p.m., "Vedant Kumar v

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. This lgtm. I haven't touched clang-format before, so it would be good to double-check with the code owner before committing. Repository: rL LLVM https://reviews.llvm.o

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Thanks Vedant, this also fixes the crash that occurs when -mtune=native is provided. https://reviews.llvm.org/D14471. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked

Re: [PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

djasper accepted this revision. djasper added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone"; -

Re: [PATCH] D23628: Fix unittests after windows command line parsing

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r279112 - Use __has_include rather than a configure-time macro to determine if

Author: rsmith Date: Thu Aug 18 13:22:22 2016 New Revision: 279112 URL: http://llvm.org/viewvc/llvm-project?rev=279112&view=rev Log: Use __has_include rather than a configure-time macro to determine if is available. This should fix out-of-tree builds, at the cost of not providing the higher rlimi

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

llvm-config.h doesn't provide the necessary macros. I've applied a different fix for out-of-tree builds in r279112. On Wed, Aug 17, 2016 at 11:51 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Done in clang/r279035. > > thanks, > vedant > > > On Aug 17, 2016, at 7:43 AM,

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Tue Aug 16 20:05:07 2016 > > New Revision: 278882 > > > > URL: http://llvm.org/vi

Re: [PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

vsk added inline comments. Comment at: lib/Driver/Tools.cpp:1163 @@ -1162,3 +1162,3 @@ // FIXME: Should this be picked by checking the target triple instead? - if (Args.getLastArg(options::OPT_arch)) + if ((A = Args.getLastArg(options::OPT_arch))) return "cyclone"; -

[PATCH] D23684: Resolve ambiguity in a declaration if global nested name specifier is used

sepavloff created this revision. sepavloff added reviewers: rsmith, doug.gregor. sepavloff added a subscriber: cfe-commits. If a declaration references a function from global namespace by its qualified name and if that function return type is a class or enum, there is possible ambiguity. The decla

[PATCH] D23685: [libcxx] [test] Include the iterator header for back_inserter.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Code was recently added to this test that uses std::back_inserter. Therefore, the header must be included. (MSVC's STL demands this, as we don't otherwise drag in back_insert

r279114 - Removed use of 'emplace' on std::map, since not all buildbot slaves support it

Author: cameron314 Date: Thu Aug 18 13:41:41 2016 New Revision: 279114 URL: http://llvm.org/viewvc/llvm-project?rev=279114&view=rev Log: Removed use of 'emplace' on std::map, since not all buildbot slaves support it Modified: cfe/trunk/unittests/libclang/LibclangTest.cpp Modified: cfe/trunk/

[clang-tools-extra] r279115 - [clang-tidy docs] Move option descriptions to the Options section

Author: alexfh Date: Thu Aug 18 13:43:47 2016 New Revision: 279115 URL: http://llvm.org/viewvc/llvm-project?rev=279115&view=rev Log: [clang-tidy docs] Move option descriptions to the Options section + random fixes Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-assert-side-effe

r279116 - [MS] Silence -Wextern-init on const selectany variables

Author: rnk Date: Thu Aug 18 13:45:07 2016 New Revision: 279116 URL: http://llvm.org/viewvc/llvm-project?rev=279116&view=rev Log: [MS] Silence -Wextern-init on const selectany variables In C, 'extern' is typically used to avoid tentative definitions when declaring variables in headers, but adding

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:2865-2867 @@ +2864,5 @@ + case CXXOperatorCallExprClass: { +// If it is an operator call expr it can have side effects when the +// underlaying operator is of assignment kind. +// Othrwise fall through the res

r279120 - Resubmit "[Tooling] Parse compilation database command lines on Windows."

Author: zturner Date: Thu Aug 18 14:31:48 2016 New Revision: 279120 URL: http://llvm.org/viewvc/llvm-project?rev=279120&view=rev Log: Resubmit "[Tooling] Parse compilation database command lines on Windows." This patch introduced the ability to decide at runtime whether to parse JSON compilation

Re: [PATCH] D23628: Fix unittests after windows command line parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL279120: Resubmit "[Tooling] Parse compilation database command lines on Windows." (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D23628?vs=68426&id=68593#toc Repository: rL

r279121 - [OpenCL] AMDGCN: Fix size_t type

Author: yaxunl Date: Thu Aug 18 14:34:04 2016 New Revision: 279121 URL: http://llvm.org/viewvc/llvm-project?rev=279121&view=rev Log: [OpenCL] AMDGCN: Fix size_t type Pointers of certain GPUs in AMDGCN target in private address space is 32 bit but pointers in other address spaces are 64 bit. size

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rL279121: [OpenCL] AMDGCN: Fix size_t type (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D23361?vs=68360&id=68594#toc Repository: rL L

r279122 - Fix json compilation database syntax on non-Windows.

Author: zturner Date: Thu Aug 18 14:42:00 2016 New Revision: 279122 URL: http://llvm.org/viewvc/llvm-project?rev=279122&view=rev Log: Fix json compilation database syntax on non-Windows. Modified: cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp Modified: cfe/trunk/lib/Tooling/JSONCompilati

Re: [PATCH] D23618: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As discussed offline, since the functionality being added in this patch is only useful for tests, the related simplification of tests seems not worth the added complexity. https://

r279127 - Revert [OpenCL] AMDGCN: Fix size_t type

Author: yaxunl Date: Thu Aug 18 15:01:06 2016 New Revision: 279127 URL: http://llvm.org/viewvc/llvm-project?rev=279127&view=rev Log: Revert [OpenCL] AMDGCN: Fix size_t type due to regressions in test/CodeGen/exprs.c on certain platforms. Removed: cfe/trunk/test/CodeGenOpenCL/size_t.cl Modifi

[PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

erichkeane created this revision. erichkeane added reviewers: cfe-commits, majnemer, vbyakovl, DavidKreitzer, andreybokhanko, rsmith. erichkeane set the repository for this revision to rL LLVM. GCC (and other compilers) treat strlen as a 'constexpr' function as an extension to the language. Cla

Re: [PATCH] D23627: [CUDA] Improve handling of math functions.

jlebar added a comment. These changes have always been kind of scary. tra tested this against Thrust all combinations of CUDA 7.0/7.5, c++98/11, libc++/libstdc++{4.8.5/4.9.3,5.3.0}. So we should be good here. I hope. https://reviews.llvm.org/D23627 ___

r279140 - [CUDA] Improve handling of math functions.

Author: jlebar Date: Thu Aug 18 15:43:13 2016 New Revision: 279140 URL: http://llvm.org/viewvc/llvm-project?rev=279140&view=rev Log: [CUDA] Improve handling of math functions. Summary: A bunch of related changes here to our CUDA math headers. - The second arg to nexttoward is a double (well, tec

Re: [PATCH] D23627: [CUDA] Improve handling of math functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279140: [CUDA] Improve handling of math functions. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23627?vs=68427&id=68600#toc Repository: rL LLVM https://reviews.llvm.org/D

Re: [PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This is not a conforming extension. We are explicitly not allowed to make standard library functions `constexpr` if the standard doesn't say they are; see [constexpr.functions] (17.6

Re: [PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

erichkeane abandoned this revision. erichkeane added a comment. In https://reviews.llvm.org/D23692#520081, @rsmith wrote: > This is not a conforming extension. We are explicitly not allowed to make > standard library functions `constexpr` if the standard doesn't say they are; > see [constexpr.f

r279145 - Fixed more signed/unsigned mismatch warnings introduced in my change at r279076

Author: cameron314 Date: Thu Aug 18 15:56:48 2016 New Revision: 279145 URL: http://llvm.org/viewvc/llvm-project?rev=279145&view=rev Log: Fixed more signed/unsigned mismatch warnings introduced in my change at r279076 Modified: cfe/trunk/unittests/libclang/LibclangTest.cpp Modified: cfe/trunk

Re: [PATCH] D23492: Make function local tags visible.

rsmith added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3598-3603 @@ -3599,1 +3597,8 @@ + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. + if (DiagnoseUninstantia

Re: [PATCH] D23684: Resolve ambiguity in a declaration if global nested name specifier is used

PR28422 is invalid. Giving better diagnostics in this case seems reasonable, but we should not accept the ill-formed code. On 18 Aug 2016 11:41 a.m., "Serge Pavlov" wrote: > sepavloff created this revision. > sepavloff added reviewers: rsmith, doug.gregor. > sepavloff added a subscriber: cfe-com

[PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The new LLVM runtimes build directory requires some basic conventions across the runtime projects. These changes make libcxx build under the runtimes subdirectory. The general idea of the changes

Re: [PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[libcxx] r279151 - [CMake] Get libcxx building under LLVM/runtimes

Author: cbieneman Date: Thu Aug 18 16:31:51 2016 New Revision: 279151 URL: http://llvm.org/viewvc/llvm-project?rev=279151&view=rev Log: [CMake] Get libcxx building under LLVM/runtimes Summary: The new LLVM runtimes build directory requires some basic conventions across the runtime projects. Thes

  1   2   >