r278734 - [CUDA] Include CUDA headers before anything else.

Author: jlebar Date: Mon Aug 15 15:38:52 2016 New Revision: 278734 URL: http://llvm.org/viewvc/llvm-project?rev=278734&view=rev Log: [CUDA] Include CUDA headers before anything else. Summary: There's no point to --cuda-path if we then go and include /usr/include first. And if you install the rig

Re: [PATCH] D23340: [CUDA] Fix CUDA install version parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278733: [CUDA] Fix CUDA install version parsing. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23340?vs=67438&id=68071#toc Repository: rL LLVM https://reviews.llvm.org/D23

Re: [PATCH] D23341: [CUDA] Include CUDA headers before anything else.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278734: [CUDA] Include CUDA headers before anything else. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23341?vs=67439&id=68072#toc Repository: rL LLVM https://reviews.llv

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278735: Add the notion of deferred diagnostics. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23241?vs=68063&id=68073#toc Repository: rL LLVM https://reviews.llvm.org/D232

[libcxx] r278736 - Fix new ASAN failures

Author: ericwf Date: Mon Aug 15 15:50:01 2016 New Revision: 278736 URL: http://llvm.org/viewvc/llvm-project?rev=278736&view=rev Log: Fix new ASAN failures Modified: libcxx/trunk/test/libcxx/containers/sequences/vector/asan.pass.cpp libcxx/trunk/test/support/test.support/test_macros_header

r278742 - Objective-C diagnostics: isObjCNSObjectType should check through AttributedType.

Author: mren Date: Mon Aug 15 16:05:00 2016 New Revision: 278742 URL: http://llvm.org/viewvc/llvm-project?rev=278742&view=rev Log: Objective-C diagnostics: isObjCNSObjectType should check through AttributedType. For the following example: typedef __attribute__((NSObject)) CGColorRef ColorAttrRef;

[PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, mclow.lists. EricWF added a subscriber: cfe-commits. The modified assertion fails when the test is compiled at various optimization levels. The value of `nothrow_traced` and `throw_traced` at various optimization levels a

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak updated this revision to Diff 68078. ahatanak added a comment. Fix Sema::getTemplateInstantiationArgs to return the template instantiation args when variable templates are being instantiated. https://reviews.llvm.org/D23096 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cp

[libcxx] r278745 - libcxx: Fix path.compare.pass expected result

Author: azanella Date: Mon Aug 15 16:24:50 2016 New Revision: 278745 URL: http://llvm.org/viewvc/llvm-project?rev=278745&view=rev Log: libcxx: Fix path.compare.pass expected result The expected 'filesystem::path::compare' result states that for different path only result sign contains the informa

r278746 - [ADT] Change PostOrderIterator to use NodeRef. NFC.

Author: timshen Date: Mon Aug 15 16:27:56 2016 New Revision: 278746 URL: http://llvm.org/viewvc/llvm-project?rev=278746&view=rev Log: [ADT] Change PostOrderIterator to use NodeRef. NFC. Summary: Corresponding LLVM change: D23522 Reviewers: dblaikie Subscribers: cfe-commits Differential Revisio

Re: [PATCH] D23523: [ADT] Change PostOrderIterator to use NodeRef. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278746: [ADT] Change PostOrderIterator to use NodeRef. NFC. (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D23523?vs=68070&id=68082#toc Repository: rL LLVM https://reviews.

RE: r278710 - Replace an obsolete company name.

I had tried doing that in the Users.html page when I first added an entry there, and it caused problems. So, I'd rather not embed a unicode character directly into the file, and I'd rather use a semi-intelligible substitution name than some raw hex value. The intent is clearer. --paulr From:

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/Attr.td:1384 @@ +1383,3 @@ +def RequireConstantInit : InheritableAttr { + let Spellings = [GCC<"require_constant_initialization">, + CXX11<"clang", "require_constant_initialization">]; ---

Re: [PATCH] D23453: Add a c2x language mode

rsmith added a comment. This seems premature; according to the charter, we are more than three years away from the C2x committee draft phase. Perhaps we should wait until we have either a new working draft or a paper approved by the WG14 for such a working draft. https://reviews.llvm.org/D234

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 68086. sfantao marked 5 inline comments as done. sfantao added a comment. - Fix comments and diagnostics. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt tools/clang-offload-bundler

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao added a comment. Hi Jonas, Thanks for the review! Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler ) Ha

Re: [PATCH] D23453: Add a c2x language mode

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In https://reviews.llvm.org/D23453#515816, @rsmith wrote: > This seems premature; according to the charter, we are more than three years > away from the C2x committee draft phase. Perhaps we should wait until we have

[PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra created this revision. tra added reviewers: jlebar, sfantao. tra added a subscriber: cfe-commits. If they are, we end up with the last intermediary output preserved in the current directory after compilation. Added a test case to verify that we're using appropriate filenames for outputs of di

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao updated this revision to Diff 68089. sfantao marked an inline comment as done. sfantao added a comment. - Remove redundant return statement. https://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o tools/clang-offload-bundler

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked 7 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:844 @@ +843,3 @@ +the indeterminate order of dynamic initialization. They can also be safely +used by other static constructors across translation units. + rsmith wrote: > static

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 68094. EricWF marked 2 inline comments as done. EricWF added a comment. Address most of @rsmiths review comments. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds

Re: [PATCH] D20561: Warn when taking address of packed member

MatzeB added a subscriber: MatzeB. MatzeB added a comment. The sanitizer code triggers this warning for code that looks conceptually like this: typedef struct Bla { char bar; int foo; } __attribute__((packed)); uintptr_t getu(struct Bla *b) { return (uintptr_t)&b->foo; } Resulting in:

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv removed rL LLVM as the repository for this revision. faisalv updated this revision to Diff 68091. faisalv added a comment. Updated the patch per Richard's direction (which helped clarify my thinking about this): Check only the current call frame - if the VarDecl is contained within the c

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv marked an inline comment as done. faisalv added a comment. https://reviews.llvm.org/D23493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. > This is done so containers, such as `vector` can be used > safely provided `partially_available` is safe at the point of instantiation. > I think the way to improve this is in `Sema:

Re: [PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

jroelofs added a comment. I'm not sure that's guaranteed behavior either. That being said, I don't see a more robust way to write this test. https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

jlebar added a comment. Wow, I have no idea if this is right. I can try to figure it out, but if sfantao can review, that's easier. Comment at: test/Driver/cuda-bindings.cu:10 @@ +9,3 @@ +// way. Instead we check whether we've generated a permanent name on +// device side whic

Re: [PATCH] D23242: [CUDA] Raise an error if a wrong-side call is codegen'ed.

rnk accepted this revision. rnk added a comment. lgtm Comment at: clang/include/clang/Sema/Sema.h:9162 @@ -9161,1 +9161,3 @@ + /// Check whether we're allowed to call Callee from the current context. + /// FWIW I never insert doxygen annotations. I figure if

[PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz created this revision. beanz added reviewers: ddunbar, bob.wilson. beanz added a subscriber: cfe-commits. The eprintf library was added before the general OS X builtins library existed as a place to store one builtin function. Since we have for several years had an actual mandated builtin

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra updated this revision to Diff 68100. tra added a comment. Addressed comments. https://reviews.llvm.org/D23526 Files: lib/Driver/Driver.cpp test/Driver/cuda-bindings.cu Index: test/Driver/cuda-bindings.cu === --- /dev/null

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

echristo added a subscriber: echristo. echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM. Might want to fix the braces while you're there. -eric https://reviews.llvm.org/D23531 __

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

tra marked 2 inline comments as done. tra added a comment. https://reviews.llvm.org/D23526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz updated this revision to Diff 68102. beanz added a comment. Herald added a subscriber: mehdi_amini. Updating code comment and removing unneeded braces. I'm going to sit on this for a bit before committing in case anyone comes up with a reason this is a bad idea. https://reviews.llvm.org/

r278759 - [CUDA] Raise an error if a wrong-side call is codegen'ed.

Author: jlebar Date: Mon Aug 15 18:00:49 2016 New Revision: 278759 URL: http://llvm.org/viewvc/llvm-project?rev=278759&view=rev Log: [CUDA] Raise an error if a wrong-side call is codegen'ed. Summary: Some function calls in CUDA are allowed to appear in semantically-correct programs but are an err

Re: [PATCH] D23242: [CUDA] Raise an error if a wrong-side call is codegen'ed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278759: [CUDA] Raise an error if a wrong-side call is codegen'ed. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D23242?vs=67378&id=68103#toc Repository: rL LLVM https://rev

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: clang-rename/USRFinder.cpp:182 @@ -179,5 +181,3 @@ // We only want to search the decls that exist in the same file as the point. - au

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

omtcyfz updated this revision to Diff 68104. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23397 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp clang-rename/USRLocFinder.cpp Index: clang-rename/USRLocFinder.cpp

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

omtcyfz marked 2 inline comments as done. Comment at: clang-rename/USRFinder.cpp:182-184 @@ -179,6 +181,5 @@ // We only want to search the decls that exist in the same file as the point. - auto Decls = Context.getTranslationUnitDecl()->decls(); - for (auto &CurrDecl : Decls)

[PATCH] D23532: [LibTooling] Allow compilation database to explicitly specify compilation database file and source root

zturner created this revision. zturner added a reviewer: cfe-commits. zturner added subscribers: klimek, alexfh, djasper. Allow explicit specification of a compilation database file and source root. While trying to create a compilation database test for D23455, I ran into the problem that compil

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:858 @@ +857,3 @@ + }; + SAFE_STATIC T x = {42}; // OK. + SAFE_STATIC T y = 42; // error: variable does not have a constant initializer Sure, if that's a conscious design decision for the

[PATCH] D23533: [clang-tidy] Rewrite compilation database test to not require shell

zturner created this revision. zturner added reviewers: alexfh, klimek, djasper. zturner added a subscriber: cfe-commits. This allows the test to run on windows, and also makes writing compilation database tests easier in general. See D23532 for more information. https://reviews.llvm.org/D23533

[clang-tools-extra] r278760 - [clang-rename] cleanup `auto` usages

Author: omtcyfz Date: Mon Aug 15 18:20:05 2016 New Revision: 278760 URL: http://llvm.org/viewvc/llvm-project?rev=278760&view=rev Log: [clang-rename] cleanup `auto` usages As Alexander pointed out, LLVM Coding Standards are more conservative about using auto, i.e. it should be used in the followin

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

This revision was automatically updated to reflect the committed changes. omtcyfz marked an inline comment as done. Closed by commit rL278760: [clang-rename] cleanup `auto` usages (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23397?vs=68104&id=68107#toc Repository:

Buildbot numbers for the week of 7/31/2016 - 8/06/2016

Hello everyone, Below are some buildbot numbers for the week of 7/31/2016 - 8/06/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the last week of 8/07/2016 - 8/13/2016

Hello everyone, Below are some buildbot numbers for the last week of 8/07/2016 - 8/13/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

sfantao added a comment. Hi Art, Thanks for the patch! That looks good. https://reviews.llvm.org/D23526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

andrewmw94 added a comment. I agree that more tests would be good. Where should I put them? Should it be in a separate file or should I just have kmalloc/kfree tests next to the malloc/free ones? https://reviews.llvm.org/D23375 ___ cfe-commits ma

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

manmanren added a subscriber: manmanren. manmanren added a comment. The fix looks reasonable to me. Cheers, Manman Comment at: test/CodeGenObjCXX/encode.mm:231 @@ +230,3 @@ +struct S { + typedef T Ty; + Ty *t; I wonder if we can further reduce the testing cas

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68114. amccarth added a comment. Added a test. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp ==

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added a comment. Thank, dblaikie, for correcting my terminology. https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10519-10520 @@ +10518,4 @@ + auto *CE = dyn_cast(Init); + bool DiagErr = (var->isInitKnownICE() || (CE && CE->getConstructor()->isConstexpr())) + ? !var->checkInitIsICE() : !checkConstInit(); +

r278763 - PR28978: If we need overload resolution for the move constructor of an

Author: rsmith Date: Mon Aug 15 19:13:47 2016 New Revision: 278763 URL: http://llvm.org/viewvc/llvm-project?rev=278763&view=rev Log: PR28978: If we need overload resolution for the move constructor of an anonymous union member of a class, we need overload resolution for the move constructor of the

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added a comment. Ping. https://reviews.llvm.org/D22494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

manmanren added a subscriber: manmanren. Comment at: lib/Sema/SemaDecl.cpp:9739 @@ +9738,3 @@ + DeducedType = DeducedType.setNullability( + Init->getType()->getNullability(Context), Context); + Do we propagate other attributes for deduced types? ht

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10519-10520 @@ +10518,4 @@ + auto *CE = dyn_cast(Init); + bool DiagErr = (var->isInitKnownICE() || (CE && CE->getConstructor()->isConstexpr())) + ? !var->checkInitIsICE() : !checkConstInit(); +

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

rsmith added a subscriber: rsmith. rsmith added a comment. Is this really a good idea? If I write: int *_Nullable f(); int n; int *_Nonnull g() { auto *p = f(); if (!p) p = &n; return p; } ... it would be wrong to produce a warning that I'm converting from a nullable pointer

[PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap created this revision. alexshap added a reviewer: tstellarAMD. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald added subscribers: arsenm, aemerson. The structs ImmOp and RegOp

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

compnerd added a comment. The `Data` and `Length` fields are tied together. Wouldn't it be possible to reorder this as `Val`, `Length`, `Data` and have it achieve similar sizes and keep the `Data` and `Length` fields together? https://reviews.llvm.org/D23530 __

Re: r278763 - PR28978: If we need overload resolution for the move constructor of an

Hi Hans, Eric Fiselier requested that we fix this bug for 3.9 (it affects libc++'s std::optional implementation), so this would be a good candidate for the branch. On Mon, Aug 15, 2016 at 5:13 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Aug

Re: [PATCH] D20561: Warn when taking address of packed member

On Mon, Aug 15, 2016 at 6:20 PM, Matthias Braun wrote: > MatzeB added a subscriber: MatzeB. > MatzeB added a comment. > > The sanitizer code triggers this warning for code that looks conceptually > like this: > > typedef struct Bla { char bar; int foo; } __attribute__((packed)); > > uintptr_t

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Test plan: make -j8 check-llvm-unit F2273124: Screen Shot 2016-08-15 at 5.14.59 PM.png F2273127: Screen Shot 2016-08-15 at 5.14.29 PM.png https://reviews.llvm.org/D23536 _

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

arsenm accepted this revision. arsenm added a reviewer: arsenm. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r278767 - [CUDA] Fix "declared here" note on deferred wrong-side errors.

Author: jlebar Date: Mon Aug 15 19:48:21 2016 New Revision: 278767 URL: http://llvm.org/viewvc/llvm-project?rev=278767&view=rev Log: [CUDA] Fix "declared here" note on deferred wrong-side errors. Previously we weren't deferring these "declared here" notes, which is obviously wrong. Modified:

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 68121. EricWF added a comment. Do strict 'constant initializer' checking in C++11, but fall back to `isConstantInitializer()` in C++03. Add documentation about non-strict C++03 checking. This has weird results for POD types, for example: struct PODType {

Re: [PATCH] D23536: Remove excessive padding from ImmOp and RegOp.

alexshap added a comment. Thx, I don't have commit access, need smb to land this patch https://reviews.llvm.org/D23536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap added a comment. Yes: "Data, Length, Val" would work as well, i will update this diff https://reviews.llvm.org/D23530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r278760 - [clang-rename] cleanup `auto` usages

On Mon, Aug 15, 2016 at 5:20 PM, Kirill Bobyrev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: omtcyfz > Date: Mon Aug 15 18:20:05 2016 > New Revision: 278760 > > URL: http://llvm.org/viewvc/llvm-project?rev=278760&view=rev > Log: > [clang-rename] cleanup `auto` usages > > As Alexa

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

faisalv closed this revision. faisalv added a comment. Closed by http://llvm.org/viewvc/llvm-project?view=revision&revision=278771 https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[libcxxabi] r278773 - Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX

Author: ericwf Date: Mon Aug 15 22:44:55 2016 New Revision: 278773 URL: http://llvm.org/viewvc/llvm-project?rev=278773&view=rev Log: Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL: http://llvm.org/v

Re: [PATCH] D23530: Remove excessive padding from BarrierOp, PrefetchOp, PSBHintOp.

alexshap updated this revision to Diff 68128. alexshap added a comment. Address code review comment https://reviews.llvm.org/D23530 Files: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp ==

[clang-tools-extra] r278780 - [clang-rename] fix broken build

Author: omtcyfz Date: Tue Aug 16 01:19:06 2016 New Revision: 278780 URL: http://llvm.org/viewvc/llvm-project?rev=278780&view=rev Log: [clang-rename] fix broken build As Eric Fiselier pointed out, r278760 breaks build, because RecursiveASTVisitor doesn't have a const overload. This patch is a quic

[PATCH] D23543: Adapt to TraverseLambdaCapture interface change from D23204

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. mboehme added a dependency: D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().. Depends on D23204. This is intended to be submitted immediately after D2320

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme updated this revision to Diff 68139. mboehme added a comment. Update to a clean diff. (Sorry, the last diff included a large number of extraneous changes by others.) https://reviews.llvm.org/D23204 Files: include/clang/AST/RecursiveASTVisitor.h lib/Index/IndexBody.cpp unittests/T

Re: [PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

mboehme marked 2 inline comments as done. Comment at: include/clang/AST/RecursiveASTVisitor.h:892 @@ -891,1 +891,3 @@ + else +TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()])); return true; klimek wrote: > I'd rather pass in the offse

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

xazax.hun added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

r278656 - [CodeGen] Ignore unnamed bitfields before handling vector fields

Author: majnemer Date: Mon Aug 15 02:20:40 2016 New Revision: 278656 URL: http://llvm.org/viewvc/llvm-project?rev=278656&view=rev Log: [CodeGen] Ignore unnamed bitfields before handling vector fields We processed unnamed bitfields after our logic for non-vector field elements in records larger th

[PATCH] D23495: Remove std::tuple's reduced-arity-extension on implicit constructors.

EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith. EricWF added a subscriber: cfe-commits. The reduced-arity-extension on tuple's implicit constructors breaks conforming code. eg ``` #include #include using namespace std; int count(tuple) { return 2; } int count(tuple)

Re: [PATCH] D23495: Remove std::tuple's reduced-arity-extension on implicit constructors.

EricWF updated this revision to Diff 68001. EricWF added a comment. Add missing test case. https://reviews.llvm.org/D23495 Files: include/tuple test/std/utilities/tuple/tuple.tuple/tuple.cnstr/PR27374_implicit_reduced_arity_extension_non_conforming.pass.cpp Index: test/std/utilities/tupl

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki added inline comments. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98 @@ +94,6 @@ +const QualType T = VD->getType(); +if (T->isPointerType() && !T->getPointeeType().isConstQualified()) + markCanNotBeConst(VD->getInit(), true); +

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

eastig added a comment. The issue is reported as: https://llvm.org/bugs/show_bug.cgi?id=28954 https://reviews.llvm.org/D12689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

NoQ added a comment. > @dcoughlin, @NoQ, could you, please, tell, how you get dumps of symbolic > expressions and constraints like "(conj_$6{void *}) != 0U"? Tried different > debug.* checkers and clang_analyzer_explain() but failed. That's `SVal.dump()`, `SymbolRef->dump()`, `MemRegion.dump()

[PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

jmolloy created this revision. jmolloy added reviewers: davide, aaron.ballman. jmolloy added a subscriber: cfe-commits. This means we shouldn't emit ubsan detection code or warn. Fixes PR25552. https://reviews.llvm.org/D23498 Files: lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/C

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath updated this revision to Diff 68011. rmaprath added a comment. Rebased. https://reviews.llvm.org/D21968 Files: CMakeLists.txt include/__config include/__config_site.in include/__threading_support lib/CMakeLists.txt test/CMakeLists.txt test/libcxx/test/config.py test/li

[PATCH] D23503: [clang-cl] Check that we are in clang cl mode before enabling support for the CL environment variable.

pgousseau created this revision. pgousseau added reviewers: rsmith, majnemer. pgousseau added subscribers: cfe-commits, wristow, gbedwell, probinson. Checking for the type of the command line tokenizer should not be the criteria to enable support for the CL environment variable, this change check

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

xazax.hun updated this revision to Diff 68023. xazax.hun added a comment. - Simplifiy generated constraints. https://reviews.llvm.org/D23112 Files: lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp test/Analysis/out-of-bounds.c Index: test/Analysis/out-of-bounds.c ===

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

xazax.hun added a comment. I added a (proof of concept?) implementation to simplify the constraints in the checker. I wonder what do you think. https://reviews.llvm.org/D23112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

xazax.hun added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

xazax.hun added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

[PATCH] D23507: include/math.h: Re-enable missing C++11 decls on SunOS

mgorny created this revision. mgorny added reviewers: EricWF, mclow.lists. mgorny added a subscriber: cfe-commits. The SunOS (tested on OpenIndiana 5.11) C library includes which provides declarations for the standard math routines, both for C and C++(03). However, it lacks the additional integr

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

filcab added a subscriber: filcab. Comment at: test/CodeGen/wrapv-lshr-sanitize.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -fsanitize=shift-base -emit-llvm %s -o - -triple x86_64-linux-gnu -fwrapv | opt -instnamer -S | FileCheck %s + Do you really need `instnamer`?

Re: [PATCH] D23498: Left shifts of negative values are defined if -fwrapv is set

jmolloy updated this revision to Diff 68033. jmolloy added a comment. Hi Filipe, Thanks for the review! SGTM on both counts. https://reviews.llvm.org/D23498 Files: lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/CodeGen/wrapv-lshr-sanitize.c test/Sema/negative-shift-wrapv.c In

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

NoQ added a comment. I couldn't find any real problems - the code's getting mature! Please accept a few very important "please rename this variable" comments :) Comment at: include/clang/Analysis/CloneDetection.h:236 @@ +235,3 @@ +///clone in this pair. +struct

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I can't vouch for the correctness (not having a sun system to play with), but this LGTM. at some point, the repeated expression `!(defined(_LIBCPP_MSVCRT) || defined(_AIX) || define

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

mgorny added a comment. Yes, I don't have commit access. However, Eric wanted to review it as well, so please don't commit it yet. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

NoQ added a comment. Considering the refactoring planned in https://reviews.llvm.org/D23418, i've no more comments on the part of the code that isn't rewritten in the subsequent review. I like how the new hashing system is put to work here. Comment at: lib/Analysis/CloneDetect

[libcxxabi] r278675 - Merging r278579:

Author: hans Date: Mon Aug 15 11:10:06 2016 New Revision: 278675 URL: http://llvm.org/viewvc/llvm-project?rev=278675&view=rev Log: Merging r278579: r278579 | mehdi_amini | 2016-08-12 17:02:33 -0700 (Fri, 12 Aug 2016) | 3 line

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

Merged in r278675. Thanks! On Fri, Aug 12, 2016 at 5:54 PM, Mehdi Amini wrote: > CC hans. > > >> On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith >> wrote: >> >> This seems like a good candidate to cherry-pick to 3.9. >> >>> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits >>> wrote:

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

sisnkemp updated this revision to Diff 68046. sisnkemp added a comment. Now with test case. https://reviews.llvm.org/D22130 Files: lib/Driver/Tools.cpp test/Driver/openbsd.c Index: test/Driver/openbsd.c === --- test/Driver/ope

  1   2   >