Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. toy example: F2262237: toy_example.png https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807 @@ +6806,3 @@ + +def err_has_constant_init_expression_trait_invalid_arg : Error< + "expression does not reference a named variable">; EricWF wrote: > Help improving this w

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF updated this revision to Diff 67776. EricWF added a comment. - Apply @jroelof's suggestions - Add tests for static class members https://reviews.llvm.org/D23385 Files: include/clang/AST/Expr.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/ExpressionTraits.h inclu

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

alexfh added a comment. A couple of comments inline. Comment at: clang-rename/RenamingAction.cpp:73 @@ -72,3 +72,3 @@ // FIXME: better error handling. - auto Replace = tooling::Replacement(SourceMgr, Loc, PrevNameLen, NewName); - auto Err = FileToReplaces[Repla

Re: [PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

zturner updated this revision to Diff 6. zturner added a comment. Seems like dropping all non-main-file include directives is wrong because then it won't be able to detect errors in "non user code". Seems like the real fix is to bucket the include directives by file in which they were decla

r278444 - [Basic] Add const qualifier to SM.isInSystemMacro (NFC)

Author: vedantk Date: Thu Aug 11 19:20:39 2016 New Revision: 278444 URL: http://llvm.org/viewvc/llvm-project?rev=278444&view=rev Log: [Basic] Add const qualifier to SM.isInSystemMacro (NFC) The member function is a predicate, and doesn't apply any changes on the object. Patch by Visoiu Mistrih F

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL278444: [Basic] Add const qualifier to SM.isInSystemMacro (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23433?vs=67737&id=67781#toc Repository: rL LLVM https://revi

r278447 - P0217R3: Constant expression evaluation for decomposition declarations.

Author: rsmith Date: Thu Aug 11 19:39:32 2016 New Revision: 278447 URL: http://llvm.org/viewvc/llvm-project?rev=278447&view=rev Log: P0217R3: Constant expression evaluation for decomposition declarations. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/lib/AST/DeclCXX.cpp cf

r278448 - Remove unused and undesirable reference from BindingDecl to DecompositionDecl.

Author: rsmith Date: Thu Aug 11 19:53:41 2016 New Revision: 278448 URL: http://llvm.org/viewvc/llvm-project?rev=278448&view=rev Log: Remove unused and undesirable reference from BindingDecl to DecompositionDecl. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/lib/AST/DeclCXX.cpp

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF updated this revision to Diff 67790. EricWF marked an inline comment as done. EricWF added a comment. - Add documentation for `__has_constant_initializer` and expression traits in general. - Make expression traits detectable using `__has_extension`. https://reviews.llvm.org/D23385 Files

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF marked an inline comment as done. Comment at: lib/Sema/SemaExprCXX.cpp:4775 @@ +4774,3 @@ + // duration. AObjects with automatic or dynamic lifetime never have + // a 'constant initializer'. + if ((VD->hasGlobalStorage() || I've added docs to

r278456 - [VFS] Add 'ignore-non-existent-contents' field to YAML files

Author: bruno Date: Thu Aug 11 20:50:53 2016 New Revision: 278456 URL: http://llvm.org/viewvc/llvm-project?rev=278456&view=rev Log: [VFS] Add 'ignore-non-existent-contents' field to YAML files Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path obtained via 'external-conten

r278457 - [VFS] Skip non existent files from the VFS tree

Author: bruno Date: Thu Aug 11 20:51:04 2016 New Revision: 278457 URL: http://llvm.org/viewvc/llvm-project?rev=278457&view=rev Log: [VFS] Skip non existent files from the VFS tree When the VFS uses a YAML file, the real file path for a virtual file is described in the "external-contents" field. E

Re: [PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. Applied your comments, and committed in r278456! Thanks https://reviews.llvm.org/D23422 ___ cfe-commits mailing lis

r278458 - P0217R3: template instantiation support for decomposition declarations.

Author: rsmith Date: Thu Aug 11 20:55:21 2016 New Revision: 278458 URL: http://llvm.org/viewvc/llvm-project?rev=278458&view=rev Log: P0217R3: template instantiation support for decomposition declarations. Added: cfe/trunk/test/SemaTemplate/cxx1z-decomposition.cpp Modified: cfe/trunk/inclu

r278459 - Revert "[VFS] Skip non existent files from the VFS tree"

Author: bruno Date: Thu Aug 11 21:17:26 2016 New Revision: 278459 URL: http://llvm.org/viewvc/llvm-project?rev=278459&view=rev Log: Revert "[VFS] Skip non existent files from the VFS tree" Breaking bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/27281/ This rever

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added a comment. I don't think I have any more comments, but I'll let one of the other reviewers give the final go/no-go. Comment at: docs/LanguageExtensions.rst:1047 @@ +1046,3 @@ + Determines whether `expr` names + a object that will be initialized during + `const

r278460 - P0217R3: serialization/deserialization support for c++17 decomposition declarations.

Author: rsmith Date: Thu Aug 11 21:21:25 2016 New Revision: 278460 URL: http://llvm.org/viewvc/llvm-project?rev=278460&view=rev Log: P0217R3: serialization/deserialization support for c++17 decomposition declarations. Added: cfe/trunk/test/PCH/cxx1z-decomposition.cpp Modified: cfe/trunk/

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

rsmith added a comment. Have you considered modelling this as an attribute on the declaration of the variable instead of as a separate check? If so, why do you prefer this approach? (If I were to suggest this for standardization, an attribute is the approach I'd probably take.) ==

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF marked an inline comment as done. EricWF added a comment. In https://reviews.llvm.org/D23385#513443, @rsmith wrote: > Have you considered modelling this as an attribute on the declaration of the > variable instead of as a separate check? If so, why do you prefer this > approach? (If I we

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

compnerd added a comment. No, the inserted character is a literal SOH, not the string "\01". https://reviews.llvm.org/D22666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r278357 - test: relax the FS test a slight bit to be more reliable

On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Aug 11 11:58:12 2016 > New Revision: 278357 > > URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev > Log: > test: relax the FS test a slight bit to be m

r278471 - [Sema] Fix a crash on variadic enable_if functions.

Author: gbiv Date: Thu Aug 11 23:12:31 2016 New Revision: 278471 URL: http://llvm.org/viewvc/llvm-project?rev=278471&view=rev Log: [Sema] Fix a crash on variadic enable_if functions. Currently, when trying to evaluate an enable_if condition, we try to evaluate all arguments a user passes to a fun

Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

Hi Richard, Would you mind if I merged this into the 3.9 branch? :) Thanks, George On Thu, Aug 11, 2016 at 9:12 PM, George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Thu Aug 11 23:12:31 2016 > New Revision: 278471 > > URL: http://llvm.org/viewvc/llvm-

r278472 - [Sema] Fix the wording of a comment. NFC.

Author: gbiv Date: Thu Aug 11 23:19:35 2016 New Revision: 278472 URL: http://llvm.org/viewvc/llvm-project?rev=278472&view=rev Log: [Sema] Fix the wording of a comment. NFC. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm.org/viewv

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap updated this revision to Diff 67797. alexshap added a comment. Update the tests. Update the format again (do not include the type name because the diagnostics becomes too verbose and unreadable (i ran it against LLVM and clang - with type names the diagnostic messages are getting very l

Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

Sure, looks safe enough to me. On 11 Aug 2016 9:23 p.m., "George Burgess IV" wrote: Hi Richard, Would you mind if I merged this into the 3.9 branch? :) Thanks, George On Thu, Aug 11, 2016 at 9:12 PM, George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date

Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

r278479. Thank you! :) On Thu, Aug 11, 2016 at 10:08 PM, Richard Smith wrote: > Sure, looks safe enough to me. > > On 11 Aug 2016 9:23 p.m., "George Burgess IV" > wrote: > > Hi Richard, > > Would you mind if I merged this into the 3.9 branch? :) > > Thanks, > George > > On Thu, Aug 11, 2016 at

<    1   2