[libcxx] r278032 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

Author: eugenezelenko Date: Mon Aug 8 13:01:50 2016 New Revision: 278032 URL: http://llvm.org/viewvc/llvm-project?rev=278032&view=rev Log: CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing. Differential revision: https://reviews.llvm.org/D23091 Modified: li

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886 @@ +2885,3 @@ + // Check if this function has diagnostics that should be emitted when we + // codegen it. If so, don't eit this function definition, but don't emit the + // diags just yet. Emittin

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

NoQ accepted this revision. This revision is now accepted and ready to land. Comment at: test/Analysis/out-of-bounds.c:153 @@ +152,3 @@ +// The result is unknown for the same reason as above. +void test_asume_after_access(unsigned long x) { + int buf[100]; Yay, t

Re: [PATCH] D23016: Enhance treatment of function specializations in friend declarations

Ping. Thanks, --Serge 2016-08-01 21:47 GMT+07:00 Serge Pavlov : > sepavloff created this revision. > sepavloff added a subscriber: cfe-commits. > > Function specializations used in friend declarations in class templates, > like: > ``` > template class C1 { > friend void func<>(int);

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

vleschuk updated this revision to Diff 67212. vleschuk added a comment. Added C++11, C11 and ObjC textual llvm-dwarfdump tests. https://reviews.llvm.org/D23167 Files: include/llvm/IR/DebugInfoFlags.def include/llvm/IR/DebugInfoMetadata.h include/llvm/Support/Dwarf.h lib/CodeGen/AsmPrint

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos updated this revision to Diff 67215. https://reviews.llvm.org/D23198 Files: clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassTestMultiByNameYAML.cpp test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAll.yaml test/clang-rename/Inputs/ClassTestMu

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. > .cpp.rename-at.yaml? I just discovered that lit provides %S that allows getting rid of the confusing .cpp.yaml, I'm using that now. > Ah, and yes, it's better to move *.yaml to extra/test/clang-rename/Inputs Done. https://reviews.llvm.org/D23198 ___

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. Thanks, now all that's missing is an LLVM IR round-trip test. Adding the new flag to test/Assembler/disubprogram would work. Comment at: test/DebugInfo/noreturn_c11.ll:9 @@ +8,3 @@ + +; CHECK: DW_AT_noreturn + Maybe

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

sfantao added a comment. Friendly ping. Thanks! https://reviews.llvm.org/D22946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r278043 - Merging r278029 with version number adjusted:

Author: hans Date: Mon Aug 8 15:04:18 2016 New Revision: 278043 URL: http://llvm.org/viewvc/llvm-project?rev=278043&view=rev Log: Merging r278029 with version number adjusted: r278029 | eugenezelenko | 2016-08-08 10:56:28 -0

Re: [libunwind] r278029 - CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing.

Merged to 3.9 in r278043 with the version number adjusted. On Mon, Aug 8, 2016 at 10:56 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:56:28 2016 > New Revision: 278029 > > URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev > Log: > CMakeLists.tx

[libcxxabi] r278044 - Merging r278030 with version number adjusted:

Author: hans Date: Mon Aug 8 15:06:27 2016 New Revision: 278044 URL: http://llvm.org/viewvc/llvm-project?rev=278044&view=rev Log: Merging r278030 with version number adjusted: r278030 | eugenezelenko | 2016-08-08 10:59:02 -0

Re: [libcxxabi] r278030 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

Merged to 3.9 in r278044 with the version number adjusted. On Mon, Aug 8, 2016 at 10:59 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Mon Aug 8 12:59:02 2016 > New Revision: 278030 > > URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev > Log: > CMakeLists.tx

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

tra added a comment. cuda-detect.cu may be a better place for this test. Comment at: test/Driver/cuda-simple.cu:27 @@ -16,1 +26,3 @@ +// CHECK-CXXINCLUDE: clang{{.*}} "-cc1" "-triple" "x86_64--linux-gnu" {{.*}}"-internal-isystem" "{{.+}}/include/c++/4.8" +// CHECK-CXXINCLUDE: l

[PATCH] D23279: clang-reorder-fields

alexshap created this revision. alexshap added reviewers: klimek, compnerd. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". This diff adds v0 of clang-reorder-fields tool to clang/tools/extra

Re: [libcxx] r278032 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to have always been trunk-svn, and it's at least not as misleading as having the wrong number. I wonder if PACKAGE_VERSION is actually important for anything in libcxx, libcxxabi and libunwind? At least for libcxx, the important vers

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

ahatanak added a subscriber: cfe-commits. ahatanak added a comment. +cfe-commits If this patch is applied, does clang issue a warning if a method marked "nonnull" returns a null value? I see a warning is issued for conditional expressions in the test case you've added, but I don't see a test ca

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Richard: ping? On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote: > Should this be merged to 3.9? > > Thanks, > Hans > > On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits > wrote: >> Author: epilk >> Date: Wed Jul 27 13:25:10 2016 >> New Revision: 276900 >> >> URL: http://llvm

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Do we really need standalone tool for this purpose? If I'm not mistaken, Static Analyzer already has clang-analyzer-optin.performance.Padding check, which is also available through Clang-tidy. https://reviews.ll

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Thank you for the feedback. I was keeping in mind some other use-cases as well - someone might want to change the order of fields even if the padding is not affected. Repository: rL LLVM https://reviews.llvm.org/D23279 ___

Re: [PATCH] D23244: [Driver] Enable CFI for WebAssembly

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. lgtm. https://reviews.llvm.org/D23244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a comment. May be this could be Clang-rename mode? My concern is that every added tool is ~ 15-20 MB on Linux and there are no CMake options to link part of them dynamically. Repository: rL LLVM https://reviews.llvm.org/D23279

r278050 - [Attr] Add support for the `ms_hook_prologue` attribute.

Author: cdavis Date: Mon Aug 8 16:03:39 2016 New Revision: 278050 URL: http://llvm.org/viewvc/llvm-project?rev=278050&view=rev Log: [Attr] Add support for the `ms_hook_prologue` attribute. Summary: Based on a patch by Michael Mueller. This attribute specifies that a function can be hooked or pa

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL278050: [Attr] Add support for the `ms_hook_prologue` attribute. (authored by cdavis). Changed prior to commit: https://reviews.llvm.org/D19909?vs=66729&id=67224#toc Repository: rL LLVM https://revi

Re: [PATCH] D23242: [CUDA] Raise an error if a wrong-side call is codegen'ed.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Few nits, but looks good otherwise. Should be add few tests for calling device functions from host-side global initializers? Perhaps for device->host, too, as there may be unexpected interplay with

Re: [PATCH] D23279: clang-reorder-fields

compnerd added a comment. This isn't really a renaming tool per se. If you squint really hard, yes, it does rename fields. But, if we really want to save space, perhaps we should collapse all the tools into `clang-tidy` or create a new `clang-refactor` tool and just make the other things a pa

r278051 - [Driver] Enable CFI for WebAssembly

Author: dschuff Date: Mon Aug 8 16:14:15 2016 New Revision: 278051 URL: http://llvm.org/viewvc/llvm-project?rev=278051&view=rev Log: [Driver] Enable CFI for WebAssembly Since CFI support has landed in the WebAssembly backend, enable it in the frontend driver. Patch by Dominic Chen Differential

Re: [PATCH] D23244: [Driver] Enable CFI for WebAssembly

This revision was automatically updated to reflect the committed changes. Closed by commit rL278051: [Driver] Enable CFI for WebAssembly (authored by dschuff). Changed prior to commit: https://reviews.llvm.org/D23244?vs=67090&id=67226#toc Repository: rL LLVM https://reviews.llvm.org/D23244

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a comment. I would prefer CMake option to link rarely used tools (list should be adjustable) with libclang, which contain a lot of LLVM/Clang code already. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits

r278052 - Revert "[Attr] Add support for the `ms_hook_prologue` attribute."

Author: cdavis Date: Mon Aug 8 16:19:08 2016 New Revision: 278052 URL: http://llvm.org/viewvc/llvm-project?rev=278052&view=rev Log: Revert "[Attr] Add support for the `ms_hook_prologue` attribute." This reverts commit r278050. It depends on r278048, which will be reverted. Removed: cfe/trun

Re: [PATCH] D23244: [Driver] Enable CFI for WebAssembly

ddcc added a comment. Can you land it? I don't have commit access. https://reviews.llvm.org/D23244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23193: [clang-rename] fix bug with initializer lists

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. The test is fine now. Looks good once the other comment is addressed. https://reviews.llvm.org/D23193 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D23158: [clang-rename] merge tests when possible

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until the comments are addressed. https://reviews.llvm.org/D23158 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. A bunch of nits. Otherwise looks good. Thank you for the fix! Comment at: clang-tidy/ClangTidy.cpp:519 @@ -513,2 +518,3 @@ tooling::TranslationUnitReplacements TUR; for

[libcxxabi] r278058 - Do not depend on unwind when building standalone

Author: phosek Date: Mon Aug 8 17:09:54 2016 New Revision: 278058 URL: http://llvm.org/viewvc/llvm-project?rev=278058&view=rev Log: Do not depend on unwind when building standalone When libcxxabi is being built standalone, unwind dependency is not available, so do not use it even when LLVM unwin

[PATCH] D23284: Add -Rpass-with-hotness

anemet created this revision. anemet added reviewers: hfinkel, rjmccall, aaron.ballman. anemet added a subscriber: cfe-commits. I've recently added the ability for optimization remarks to include the hotness of the corresponding code region. This uses PGO and allows filtering of the optimization

[libunwind] r278067 - Allow building both shared and static library

Author: phosek Date: Mon Aug 8 17:55:48 2016 New Revision: 278067 URL: http://llvm.org/viewvc/llvm-project?rev=278067&view=rev Log: Allow building both shared and static library This change allows building both shared and static version of libunwind in a single build, sharing object files betwee

[libcxx] r278068 - Allow building both shared and static library

Author: phosek Date: Mon Aug 8 17:57:25 2016 New Revision: 278068 URL: http://llvm.org/viewvc/llvm-project?rev=278068&view=rev Log: Allow building both shared and static library This change allows building both shared and static version of libc++ in a single build, sharing object files between b

Re: [clang-tools-extra] r277677 - [clang-tidy] Inefficient string operation

Agreed. Normally, arc copies the full patch description from Phab, but this time the patch didn't apply cleanly, so I had to copy the commit message by hand and missed a substantial part of it. On Mon, Aug 8, 2016 at 5:35 PM, David Blaikie wrote: > > > On Wed, Aug 3, 2016 at 4:13 PM Alexander Ko

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

alexfh added inline comments. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61 @@ +58,5 @@ + IncludeStyle(utils::IncludeSorter::parseIncludeStyle( + Options.get("IncludeStyle", "llvm"))) { + + for (const auto &KeyValue : + {std::make_pair("memcpy",

Re: [PATCH] D23004: [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. LG https://reviews.llvm.org/D23004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18073: Add memory allocating functions

ariccio added a comment. In https://reviews.llvm.org/D18073#504216, @dcoughlin wrote: > No. The identifier info will be null for C++ operators. I assume you mean `operator new/new[]/delete/delete[] > > Thus, when`! isWindowsMSVCEnvironment`, I leave the Windows-only memory > > allocating func

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

dcoughlin added inline comments. Comment at: test/Analysis/nullability.mm:114 @@ -112,1 +113,3 @@ +NSString *_Nonnull testNullReturnInTernaryOperator(int x) { +return x > 3 ? nil : [@"" stringByAppendingString:@""]; // expected-warning {{Null is returned from a function tha

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Ping! On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote: > >> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes >> wrote: >> >> Hi Eric, >> >> After we upgraded our green dragon bots to El Captain (10.11), the >> test below started to fail on some of our machines: >> >> -- >> test/std/experime

[libcxxabi] r278076 - Add lib directory to linker paths when using libunwind

Author: phosek Date: Mon Aug 8 19:27:19 2016 New Revision: 278076 URL: http://llvm.org/viewvc/llvm-project?rev=278076&view=rev Log: Add lib directory to linker paths when using libunwind When using libunwind and not building as standalone project, we need to add LLVM library directory to the lis

Re: [PATCH] D22904: Fix two bugs for musl-libc on ARM

zlei added a comment. @rovka Thanks a lot :) Repository: rL LLVM https://reviews.llvm.org/D22904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23293: Some place that could using TargetParser in clang

jojo created this revision. jojo added a reviewer: rengolin. jojo added a subscriber: cfe-commits. Some missing usage of TargetParser in Tools.cpp and Targets.cpp. https://reviews.llvm.org/D23293 Files: lib/Basic/Targets.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp =

[libcxx] r278087 - Remove *super* old test suite results doc for Linux and Windows.

Author: ericwf Date: Mon Aug 8 22:05:43 2016 New Revision: 278087 URL: http://llvm.org/viewvc/llvm-project?rev=278087&view=rev Log: Remove *super* old test suite results doc for Linux and Windows. Neither of these results files has been update in years. Linux now has a dozen or so buildbots trac

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

2016-08-08 8:33 GMT-07:00 Aaron Ballman : > aaron.ballman added inline comments. > > > Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61 > @@ +58,5 @@ > + IncludeStyle(utils::IncludeSorter::parseIncludeStyle( > + Options.get("IncludeStyle", "llvm"))) { > +

Re: [PATCH] D23257: Fix clang-tidy crash when a single fix is applied on multiple files.

Prazek added a subscriber: Prazek. Prazek added a comment. I remember that it was pissing me off when I used clang-tidy first time. Thanks for fixing that! https://reviews.llvm.org/D23257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

jlebar updated this revision to Diff 67282. jlebar added a comment. Add noexcept. https://reviews.llvm.org/D23239 Files: clang/lib/Headers/__clang_cuda_runtime_wrapper.h Index: clang/lib/Headers/__clang_cuda_runtime_wrapper.h ==

Re: [PATCH] D23239: [CUDA] Add __device__ overloads for placement new and delete.

jlebar added a comment. In https://reviews.llvm.org/D23239#508863, @tra wrote: > I think we need to add `noexcept` for these in c++11. Argh, you are completely right. Thank you for the review. https://reviews.llvm.org/D23239 ___ cfe-commits mail

Re: [PATCH] D23193: [clang-rename] fix bug with initializer lists

omtcyfz updated this revision to Diff 67289. omtcyfz marked an inline comment as done. omtcyfz added a comment. `auto` -> `SourceLocation` https://reviews.llvm.org/D23193 Files: clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/Field.cpp Index: test/clang-rename/

<    1   2