rnk added a comment.
So, if clang were to use a temporary alloca for the byval parameter, then yes,
I agree marking it as a tail call would be incorrect. However, clang doesn't
use an alloca, it forwards the byval pointer parameter directly to the callee:
define i32 @_ZThn4_N1C4SeekE6_LARGE(%
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:177
@@ +176,3 @@
+ if (ExplodedNode *N = C.addTransition(State))
+reportLeakedVALists(LeakedVALists, "Initialized va_list", " is leaked", C,
+N);
---
NoQ updated this revision to Diff 66360.
NoQ added a comment.
Copy-paste the code from CGDebugInfo.cpp to support Objective-C instance and
class methods. Add more tests. Move the `analyze_display_progress.cpp` because
most tests use dashes in names.
https://reviews.llvm.org/D22856
Files:
li
vmiklos updated this revision to Diff 66362.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
Author: bcraig
Date: Mon Aug 1 14:56:39 2016
New Revision: 277373
URL: http://llvm.org/viewvc/llvm-project?rev=277373&view=rev
Log:
Adding smart_ptr benchmark
Initial draft here:
https://reviews.llvm.org/D22470
... though this is Eric Fiselier's rewrite to fit in with Google
Benchmark.
Added:
vmiklos added a comment.
Rebased on top of r277356 and resolved conflicts. (A busy day, it seems. :-) )
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Ping
On Mon, Jul 25, 2016 at 10:24 AM David Blaikie wrote:
> Ping?
>
> On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
>
>> What build problem did this cause? Did this just not compile (it looks as
>> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
>> problem might've
On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> laxmansole created this revision.
> laxmansole added reviewers: mclow.lists, howard.hinnant.
> laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
> flyingforyou.
>
>
> Currently b
Author: epilk
Date: Mon Aug 1 15:19:49 2016
New Revision: 277378
URL: http://llvm.org/viewvc/llvm-project?rev=277378&view=rev
Log:
[ObjC Availability] Fix partial-availability false positive introduced in
r277058
Thanks to Nico Weber for pointing this out!
Differential revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277378: [ObjC Availability] Fix partial-availability false
positive introduced in… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D23024?vs=66348&id=66370#toc
Repository:
rL L
omtcyfz updated this revision to Diff 66372.
omtcyfz added a comment.
Addressed comments; updated to the latest revision.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-
omtcyfz updated this revision to Diff 66373.
omtcyfz added a comment.
Apply `clang-format` to fit 80 cols limit.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-rename/Te
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jfb
Date: Mon Aug 1 15:28:13 2016
New Revision: 277380
URL: http://llvm.org/viewvc/llvm-project?rev=277380&view=rev
Log:
atomics.align: XFAIL GCC
It currently fails because GCC changed the mangling of templates, which affects
std::atomic using __attribute__((vector(X))). The bot using G
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged in r277385.
Cheers,
Hans
On Fri, Jul 29, 2016 at 3:58 PM, Piotr Padlewski
wrote:
> It would be very good to import this patch to clang-tidy-3.9
>
>
> -- Forwarded message --
> From: Piotr Padlewski
> Date: 2016-07-28 19:18 GMT-07:00
> Subject: Re: [Diffusion] rL277097: [c
Thanks!
-eric
On Mon, Aug 1, 2016 at 1:41 PM Hans Wennborg wrote:
> Merged in r277384.
>
> Cheers,
> Hans
>
> On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher
> wrote:
> > Hi Hans,
> >
> > Can you make sure this makes it into 3.9 please?
> >
> > Thanks!
> >
> > -eric
> >
> >
> > On Fri, Jul 2
I don't think I can:
- Hack around __gcc_atomic_t.
- Unconditionally pass -fabi-version=6 to the RUN command (because LLVM
won't accept it).
it seems like changing test/libcxx/test/config.py would be better.
WDYT?
On Mon, Aug 1, 2016 at 1:28 PM, JF Bastien via cfe-commits <
cfe-commits
Merged in r277384.
Cheers,
Hans
On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher wrote:
> Hi Hans,
>
> Can you make sure this makes it into 3.9 please?
>
> Thanks!
>
> -eric
>
>
> On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits
> wrote:
>>
>> Author: echristo
>> Date: Fri Jul
Go ahead (or let me know if you'd prefer me to do it).
Cheers,
Hans
On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote:
> Hi Hans,
>
> I would like to merge this one to release_39, since it fixes a few third
> party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
>
> -
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.h:36-37
@@ -32,1 +35,4 @@
+private:
+ std::vector ContainersWithPushBack;
+ std::vector SmartPointers;
};
aaron.ballman wrote:
> What about `llvm::make_range()`?
llvm::make_range do
dcoughlin added a comment.
It's really great to see this!
Comment at: lib/Sema/SemaExpr.cpp:15200
@@ -15182,2 +15199,3 @@
// platform.
-Diag(AtLoc, diag::warn_available_using_star_case) << RParen << Platform;
+Diag(AtLoc, diag::warn_available_using_star_case)
+
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> Prazek wrote:
Author: compnerd
Date: Mon Aug 1 16:31:24 2016
New Revision: 277390
URL: http://llvm.org/viewvc/llvm-project?rev=277390&view=rev
Log:
CodeGen: simplify the CC handling for TLS wrappers
Use the calling convention of the wrapper directly to set the calling convention
to ensure that the calling con
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
This makes clang's libdevice selection match that of NVCC as described in
http://docs.nvidia.com/cuda/libdevice-users-guide/basic-usage.html#version-selection
If required libdevice variant is not found,
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
I *think* ma
Author: probinson
Date: Mon Aug 1 17:12:46 2016
New Revision: 277396
URL: http://llvm.org/viewvc/llvm-project?rev=277396&view=rev
Log:
Add FIXMEs for MSVC 2013 hacks in r277211. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
tra added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
jlebar wrote:
>
tra updated this revision to Diff 66392.
tra added a comment.
Added tests for libdevice mapping correctness.
https://reviews.llvm.org/D23037
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
test/Driver/Inputs/CUDA_80/usr/local/cuda/nvvm/libdevice/libdevice.co
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
Hm. I total
Author: cbieneman
Date: Mon Aug 1 17:54:00 2016
New Revision: 277401
URL: http://llvm.org/viewvc/llvm-project?rev=277401&view=rev
Log:
[Order Files] Fixing an error in the perf-helper script
Dtrace probemod needs to be based on the first argument of the command, not the
first argument of the ar
Author: jfb
Date: Mon Aug 1 18:34:29 2016
New Revision: 277404
URL: http://llvm.org/viewvc/llvm-project?rev=277404&view=rev
Log:
NFC: fix typo
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llvm.org/viewvc/llvm-project/libcxx
Author: hans
Date: Mon Aug 1 18:34:42 2016
New Revision: 277405
URL: http://llvm.org/viewvc/llvm-project?rev=277405&view=rev
Log:
Revert r276896 "Update Clang Parser test error message to match new parser
errors"
This depended on r276895, which was reverted in r277402.
Modified:
cfe/trunk/
Reverted in r277405 since the LLVM change got reverted.
For what it's worth, it would have been great if this commit mentioned
that it was a companion commit to r276895. That would give some nice
context for anyone reading the log, and also I wouldn't have missed it
when reverting the LLVM side.
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please add install rule for clang-rename.el. See clang-rename CMakeLists.txt as
example.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lis
jfb created this revision.
jfb added a reviewer: EricWF.
jfb added a subscriber: cfe-commits.
The ABI version flag should fix the error.
https://reviews.llvm.org/D23041
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
test/libcxx/test/config.py
Index: test/libcxx/test/config.py
==
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
It does not make sense and violates enough assumptions in the code to crash
compiler.
https://reviews.llvm.org/D23042
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
compnerd added inline comments.
Comment at: lib/Headers/armintr.h:26
@@ +25,3 @@
+#ifndef _MSC_VER
+#include_next
+#else
Hmm, why not do __has_header instead? armv7-windows-itanium won't define
`_MSC_VER` but you may have the header from the SDK.
https://revi
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4834
@@ -4831,2 +4833,3 @@
+getDriver().Diag(diag::err_drv_cuda_nvptx_host);
}
return DAL;
IRL we talked about putting an assert() here and bailing out earlier. Does
that not work?
My
tra added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4834
@@ -4831,2 +4833,3 @@
+getDriver().Diag(diag::err_drv_cuda_nvptx_host);
}
return DAL;
jlebar wrote:
> IRL we talked about putting an assert() here and bailing out earlier. Does
> tha
This is the IR I see in today’s trunk:
*** IR Dump Before Module Verifier ***
; Function Attrs: noinline optsize ssp
define i32 @_ZThn4_N1C4SeekE6_LARGE(%class.C* %this, %union._LARGE* byval align
4) unnamed_addr #2 align 2 {
entry:
%L = alloca %union._LARGE, align 8
%this.addr = alloca %clas
On Mon, Aug 1, 2016 at 9:36 AM, Alexander Kornienko
wrote:
> Please revert or fix (or better revert and then post another patch for
> review).
>
Kirill reverted it in SVN r277354.
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
___
cfe-commits
vsk closed this revision.
vsk added a comment.
Closing old review
https://reviews.llvm.org/D15853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Done in clang/r257092
https://reviews.llvm.org/D15853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
vsk added a comment.
Ping.
https://reviews.llvm.org/D7
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk closed this revision.
vsk added a comment.
Done in clang/r246054
https://reviews.llvm.org/D12344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: ioeric, bkramer, hokein.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I tested this changes on my RHEL 6 build.
Repository:
rL LLVM
https://reviews.llvm.org/
Hi,
What I mean is the spec of spir 1.2/2.0 has very clear example about how the
metadata should organized. But now with this patch, the result of spir is
changed and not like it before. So what I want to know is why we change the old
spir example style code, but not add something alongside.
No
mstorsjo added inline comments.
Comment at: lib/Headers/armintr.h:26
@@ +25,3 @@
+#ifndef _MSC_VER
+#include_next
+#else
compnerd wrote:
> Hmm, why not do __has_header instead? armv7-windows-itanium won't define
> `_MSC_VER` but you may have the header from the
Done in r277425.
-Dimitry
> On 01 Aug 2016, at 22:50, Hans Wennborg wrote:
>
> Go ahead (or let me know if you'd prefer me to do it).
>
> Cheers,
> Hans
>
> On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote:
>> Hi Hans,
>>
>> I would like to merge this one to release_39, since it fixes
101 - 150 of 150 matches
Mail list logo
