sfantao updated this revision to Diff 66027.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Types.cpp
test/Driver/o
sfantao updated this revision to Diff 66025.
sfantao added a comment.
- Refactor code to dump contents of temporary file instead of creating the
actual file in dry-run mode.
- Rebase.
https://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
test/Driver/clang-offload-bundl
sfantao updated this revision to Diff 66026.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
=
sfantao updated this revision to Diff 66028.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 66029.
sfantao added a comment.
- Fix type qualifier.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver
sfantao updated this revision to Diff 66021.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/ToolChain.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolCha
sfantao added a comment.
Any more comments on this patch or depending ones?
Thanks!
Samuel
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added subscribers: joerg, rengolin, cfe-commits.
Herald added subscribers: mehdi_amini, aemerson.
... even though we *should* be able to.
If we used effective triples at the marked sites, we would fail:
- test/Driver/{da
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer.
No functionality change is intended. This set of replacements is fairly
targeted -- hopefully this makes it easier to v
Author: epilk
Date: Thu Jul 28 17:09:53 2016
New Revision: 277058
URL: http://llvm.org/viewvc/llvm-project?rev=277058&view=rev
Log:
[ObjC] Consider availability of context when emitting availability warnings
This means that a function marked with an availability attribute can safely
refer to a de
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer.
Wherever possible, replace:
- getToolChain.getArch() with .getArch()
- getToolChain.getTriple() with
On my end,
tra added a comment.
Samuel, the patch breaks CUDA. With the patch clang no longer adds include
paths to standard c++ library during device-side compilation.
if you run "clang++ -### -c -x cuda /dev/null" you will see that host side gets
`"-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/4.8/.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277058: [ObjC] Consider availability of context when
emitting availability warnings (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22697?vs=65595&id=66037#toc
Repository:
rL
Author: sfantao
Date: Thu Jul 28 17:42:42 2016
New Revision: 277064
URL: http://llvm.org/viewvc/llvm-project?rev=277064&view=rev
Log:
[CUDA] Unswitch enumerators in the selection of the offloading tool chain.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
U
sfantao added a comment.
In https://reviews.llvm.org/D22518#500066, @tra wrote:
> Samuel, the patch breaks CUDA. With the patch clang no longer adds include
> paths to standard c++ library during device-side compilation.
> if you run "clang++ -### -c -x cuda /dev/null" you will see that host si
+Bruno
> On Jul 27, 2016, at 11:58 PM, Nico Weber wrote:
>
> I played with modules a bit today, and as far as I can tell this is still
> broken. If this proves difficult to fix, should this change be reverted for
> now? It breaks using modules on Darwin.
>
> On Sun, Mar 13, 2016 at 12:53 AM, A
Author: epilk
Date: Thu Jul 28 17:51:11 2016
New Revision: 277070
URL: http://llvm.org/viewvc/llvm-project?rev=277070&view=rev
Log:
Revert "[ObjC] Consider availability of context when emitting availability
warnings"
Reverting r277058, while I fugure out why it broke internal bots.
This reverts
The change seems straight-forward, well reviewed and has been in the
tree for a while, so I've merged it to 3.9 in r277075.
Thanks,
Hans
On Mon, Jul 25, 2016 at 1:51 PM, Hans Wennborg wrote:
> Should me merge this to 3.9?
>
> On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits
>
sfantao created this revision.
sfantao added a reviewer: tra.
sfantao added a subscriber: cfe-commits.
Add test to detect the C++ include paths are passed to both CUDA host and
device frontends.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-simple.cu
Index: test/Driver/cuda-simple.
Author: vedantk
Date: Thu Jul 28 18:18:48 2016
New Revision: 277080
URL: http://llvm.org/viewvc/llvm-project?rev=277080&view=rev
Log:
[docs] Mention some new options in llvm-cov
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
URL:
ht
Author: vedantk
Date: Thu Jul 28 18:22:42 2016
New Revision: 277081
URL: http://llvm.org/viewvc/llvm-project?rev=277081&view=rev
Log:
[docs] Coverage: Reference the new -output-dir option
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rs
teemperor marked an inline comment as done.
Comment at: lib/Analysis/CloneDetection.cpp:134
@@ +133,3 @@
+ DEF_ADD_DATA(Stmt, { addData(S->getStmtClass()); })
+ DEF_ADD_DATA(Expr, { addData(S->getType()); })
+
NoQ wrote:
> I noticed something: with this patch, y
Author: wolfgangp
Date: Thu Jul 28 19:54:13 2016
New Revision: 277094
URL: http://llvm.org/viewvc/llvm-project?rev=277094&view=rev
Log:
Change a test to be less prone to random failures due to
unintended matches of label numbers to debug metadata
handles in release builds.
Modified:
cfe/trunk
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D22930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: epilk
Date: Thu Jul 28 19:55:40 2016
New Revision: 277095
URL: http://llvm.org/viewvc/llvm-project?rev=277095&view=rev
Log:
[Parser] Fix bug where delayed typo in conditional expression was corrected
twice
Patch by David Tarditi!
Differential revision: https://reviews.llvm.org/D22930
M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277095: [Parser] Fix bug where delayed typo in conditional
expression was corrected… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22930?vs=65965&id=66067#toc
Repository:
rL
Sorry, I was supposed to chime in here.
I don't have a strong opinion on this, but I don't think it's a
problem for us to allow the -gline-tables-only spelling in addition to
/Zd.
It just doesn't seem like a big deal to me.
On Mon, Jul 11, 2016 at 5:50 PM, Saleem Abdulrasool via cfe-commits
wro
Author: prazek
Date: Thu Jul 28 21:10:23 2016
New Revision: 277097
URL: http://llvm.org/viewvc/llvm-project?rev=277097&view=rev
Log:
[clang-tidy] Fixes to modernize-use-emplace
Not everything is valid, but it should works for 99.8% cases
https://reviews.llvm.org/D22208
Modified:
clang-tools
honggyu.kim updated the summary for this revision.
honggyu.kim updated this revision to Diff 66072.
https://reviews.llvm.org/D22666
Files:
lib/CodeGen/CodeGenFunction.cpp
Index: lib/CodeGen/CodeGenFunction.cpp
===
--- lib/CodeGen/
honggyu.kim marked 4 inline comments as done.
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#499583, @hfinkel wrote:
> Comments about the comment, but otherwise, LGTM.
Just updated the comment as you mentioned. Thanks for correcting my English :)
https://reviews.llvm.org/D226
zlei updated this revision to Diff 66074.
zlei added a comment.
Restructure the code and add a few tests.
https://reviews.llvm.org/D22904
Files:
lib/Driver/ToolChains.cpp
test/Driver/linux-ld.c
Index: test/Driver/linux-ld.c
==
zlei added a comment.
@rengolin Thanks for your comments. Patch updated.
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
honggyu.kim added a comment.
Should we also modify clang/test/CodeGen/mcount.c as well? I'm not actually
familiar with test infra.
$ cat llvm/tools/clang/test/CodeGen/mcount.c
// RUN: %clang_cc1 -pg -triple i386-unknown-unknown -emit-llvm -o - %s |
FileCheck %s
// RUN: %clang_cc1 -pg -tr
rjmccall added a comment.
In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
> Should we also modify clang/test/CodeGen/mcount.c as well? I'm not actually
> familiar with test infra.
Yes, you'll need to modify it to test for the attribute instead.
https://reviews.llvm.org/D22666
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#500327, @rjmccall wrote:
> In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
>
> > Should we also modify clang/test/CodeGen/mcount.c as well? I'm not
> > actually familiar with test infra.
>
>
> Yes, you'll need to mod
hfinkel added a comment.
In https://reviews.llvm.org/D22666#500328, @honggyu.kim wrote:
> In https://reviews.llvm.org/D22666#500327, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
> >
> > > Should we also modify clang/test/CodeGen/mcount.c as well? I'm not
hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
aaron.ballman wrote:
> Usual
Gerolf updated this revision to Diff 66075.
Gerolf added a comment.
Reduced test case.
https://reviews.llvm.org/D22900
Files:
lib/CodeGen/CGVTables.cpp
test/CodeGenCXX/microsoft-abi-structors.cpp
test/CodeGenCXX/tail-byval.cpp
Index: test/CodeGenCXX/tail-byval.cpp
===
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#500329, @hfinkel wrote:
> In this case, I think that making a simple test (changing the current test to
> be) like test/CodeGen/stackrealign.c would be fine. If you have any
> questions, please feel free to ask.
Thanks. Please co
hfinkel added a comment.
In https://reviews.llvm.org/D22666#500338, @honggyu.kim wrote:
> In https://reviews.llvm.org/D22666#500329, @hfinkel wrote:
>
> > In this case, I think that making a simple test (changing the current test
> > to be) like test/CodeGen/stackrealign.c would be fine. If you
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
> I don't suppose there's a way to test these changes, is there?
It's a utility class (which is not even used yet). I am not aware of testing
for the ADTs, etc. aside from using them intern
ABataev created this revision.
ABataev added reviewers: rnk, rsmith, majnemer.
ABataev added subscribers: cfe-commits, andreybokhanko.
MSVC actively uses unqualified lookup in dependent bases, lookup at the
instantiation point (non-dependent names may be resolved on things declared
later) etc. a
Author: jlebar
Date: Fri Jul 29 00:26:58 2016
New Revision: 277113
URL: http://llvm.org/viewvc/llvm-project?rev=277113&view=rev
Log:
[Typo police] s/proccess/process/, s/auxiliary/auxilliary/.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Modified: clang-tools-
Author: jlebar
Date: Fri Jul 29 00:26:58 2016
New Revision: 277113
URL: http://llvm.org/viewvc/llvm-project?rev=277113&view=rev
Log:
[Typo police] s/proccess/process/, s/auxiliary/auxilliary/.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
htt
101 - 144 of 144 matches
Mail list logo
