Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

a.sidorin added a comment. Adam, It is not a debug checker. It is UndefinedAssignment checker which correctly tells us that `Inner.y` is assigned with an uninitialized value while copying. So I wonder if we are allowed to skip such warnings because these warnings don't look like false positive

r275826 - [clang-cl] Reinstate -gline-tables-only as a CoreOption while we sort out the fate of /Zd

Author: rnk Date: Mon Jul 18 12:49:40 2016 New Revision: 275826 URL: http://llvm.org/viewvc/llvm-project?rev=275826&view=rev Log: [clang-cl] Reinstate -gline-tables-only as a CoreOption while we sort out the fate of /Zd Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Hans, I’m happy to revert — but I think r275820 is very unlikely to have been the root cause of the issue at http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/40225/ . (The commit is a change to the clang static analyzer a

Re: [PATCH] D22200: [libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept.

bruno added a subscriber: bruno. bruno added a comment. Hi, Can you provide more details on what the build issues are? It seems that the line you introduce is covered in the ifdef below, wonder why it's not triggering in your build? Repository: rL LLVM https://reviews.llvm.org/D22200 __

[libcxxabi] r275833 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:59 2016 New Revision: 275833 URL: http://llvm.org/viewvc/llvm-project?rev=275833&view=rev Log: Creating release_39 branch off revision 275826 Added: libcxxabi/branches/release_39/ - copied from r275826, libcxxabi/trunk/ __

[libcxx] r275832 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:52:56 2016 New Revision: 275832 URL: http://llvm.org/viewvc/llvm-project?rev=275832&view=rev Log: Creating release_39 branch off revision 275826 Added: libcxx/branches/release_39/ (props changed) - copied from r275826, libcxx/trunk/ Propchange: libcxx

[libunwind] r275841 - Creating release_39 branch off revision 275826

Author: hans Date: Mon Jul 18 12:53:22 2016 New Revision: 275841 URL: http://llvm.org/viewvc/llvm-project?rev=275841&view=rev Log: Creating release_39 branch off revision 275826 Added: libunwind/branches/release_39/ - copied from r275826, libunwind/trunk/ __

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

It looks like Shootout-C++ improved after that commit, if I'm reading these results correctly: http://llvm.org/perf/db_default/v4/nts/87812 > On 2016-Jul-17, at 15:16, Eric Fiselier wrote: > > FYI, > > I recommitted the previously removed optimization in r275734. I believe it > should fix t

Re: [PATCH] D22426: Fix automatic detection of ARM MSVC toolset in clang.exe

rnk added a comment. In https://reviews.llvm.org/D22426#486129, @DaveBartolomeo wrote: > One reasonable solution would be to choose the toolset that is hosted on the > same architecture as the host of clang.exe (e.g. x64-hosted Clang looks for > x64-hosted MSVC). If this sounds good, I can make

r275844 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:05:19 2016 New Revision: 275844 URL: http://llvm.org/viewvc/llvm-project?rev=275844&view=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

probinson added a subscriber: probinson. Comment at: docs/Proposals/GitHub.rst:141 @@ +140,3 @@ +has commit access to our current repository. In the future, you only need to +provide the GitHub user to be granted access. + This reads a little bit like "we will cre

[clang-tools-extra] r275846 - Trunk release notes are now for 4.0.0

Author: hans Date: Mon Jul 18 13:08:59 2016 New Revision: 275846 URL: http://llvm.org/viewvc/llvm-project?rev=275846&view=rev Log: Trunk release notes are now for 4.0.0 The 3.9 release are on the 3.9 branch. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

emaste added a subscriber: emaste. Comment at: docs/Proposals/GitHub.rst:8-9 @@ +7,4 @@ + +This is a proposal to move our current revision control system from Subversion +to GitHub. Below are the financial and technical arguments as to why we need +such a move and how will people

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh updated this revision to Diff 64353. davidsh added a comment. Fix a typo in code and address test case issues. https://reviews.llvm.org/D22075 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_messages.cpp test/OpenMP/target_parallel_for_map_messages.cpp test/OpenMP/target_p

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

winksaville added a subscriber: winksaville. Comment at: docs/Proposals/GitHub.rst:132 @@ +131,3 @@ + +There is no need to additional tags, flags and properties, nor of external +services controlling the history, since both SVN and *git rev-list* can already This

Re: r251898 - [modules] Rationalize the behavior of Decl::declarationReplaces, and in

On 3 November 2015 at 04:13, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Nov 2 21:13:11 2015 > New Revision: 251898 > > URL: http://llvm.org/viewvc/llvm-project?rev=251898&view=rev > Log: > [modules] Rationalize the behavior of Decl::declaration

r275848 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:08 2016 New Revision: 275848 URL: http://llvm.org/viewvc/llvm-project?rev=275848&view=rev Log: docs/conf.py: update version to 4.0 Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL: http://l

[clang-tools-extra] r275849 - docs/conf.py: update version to 4.0

Author: hans Date: Mon Jul 18 13:13:46 2016 New Revision: 275849 URL: http://llvm.org/viewvc/llvm-project?rev=275849&view=rev Log: docs/conf.py: update version to 4.0 Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL: http://llvm.org/viewvc/ll

Re: r275377 - Use hasFlag instead of hasArg

What build problem did this cause? Did this just not compile (it looks as if ArgList has hasArg and hasFlag, so I'm not sure what the specific problem might've been) On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dberris > Date:

[PATCH] D22470: [libcxx] Improve shared_ptr dtor performance

bcraig created this revision. bcraig added reviewers: jfb, mclow.lists, EricWF. bcraig added a subscriber: cfe-commits. If the last destruction is uncontended, skip the atomic store on __shared_weak_owners_. For x86_64, this results in an 8% improvement in shared_ptr ctor+dtor performance. Old be

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

bruno added a subscriber: bruno. bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. LGTM with one small fix, see below. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void ClangAs::AddX86Targ

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

bruno added a subscriber: bruno. Comment at: lib/Headers/cpuid.h:114 @@ -109,2 +113,3 @@ #define bit_AVX 0x1000 +#define bit_F16C0x2000 #define bit_RDRND 0x4000 Isn't this one also meant for gcc compat? https://reviews.llvm.or

[libclc] r275874 - R600: Use new barrier intrinsic

Author: arsenm Date: Mon Jul 18 13:42:17 2016 New Revision: 275874 URL: http://llvm.org/viewvc/llvm-project?rev=275874&view=rev Log: R600: Use new barrier intrinsic Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.ll Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.ll

r275877 - Support -masm= flag for x86 assembly targets.

Author: ygao Date: Mon Jul 18 13:44:51 2016 New Revision: 275877 URL: http://llvm.org/viewvc/llvm-project?rev=275877&view=rev Log: Support -masm= flag for x86 assembly targets. For assembly files without .intel_syntax or .att_syntax directives, allow the -masm= flag to supply a default assembly d

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

ygao marked an inline comment as done. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void ClangAs::AddX86TargetArgs(const ArgList &Args, +ArgStringList &CmdArgs) const { + if (Arg *A = Args.getLastArg(options::OPT_masm_EQ)) { ---

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

ygao closed this revision. ygao marked an inline comment as done. ygao added a comment. Closed by https://reviews.llvm.org/rL275877. https://reviews.llvm.org/D22285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > Are we really supposed to define this mac

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Oops, as you suspected I failed at copy/paste. This is the bot that's broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote: > Hans, > > I’m happy to revert — but I think r275820 is very unlikely to have been the > root caus

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined(__AR

r275880 - Revert "[analyzer] Add checker modeling potential C++ self-assignment"

Author: dcoughlin Date: Mon Jul 18 13:57:50 2016 New Revision: 275880 URL: http://llvm.org/viewvc/llvm-project?rev=275880&view=rev Log: Revert "[analyzer] Add checker modeling potential C++ self-assignment" This reverts commit r275820. It is failing on the bots. Removed: cfe/trunk/lib/Static

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t get an email from the bot about the failure. Thanks Devin > On Jul 18, 2016, at 11:59 AM, Hans Wennborg wrote: > > Oops, as you suspected I failed at copy/paste. This is the bot that's > broken: http://bb.pgr.jp/build

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

weimingz added inline comments. Comment at: src/UnwindRegistersRestore.S:326 @@ +325,3 @@ +#if !defined(__ARM_ARCH_ISA_ARM) && __ARM_ARCH_ISA_THUMB == 1 + @ r8-r12: ldr into r1-r5, then mov to r8-r12 + ldr r1, [r0, #0x20] weimingz wrote: > originally, r0-r7 get

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

dcoughlin reopened this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Re-opening. Reverted in r275880. It was causing a failure on the bots: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780 Repository: rL LLVM https://reviews.llvm.org/D1

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); apaprocki wrote: > majnemer wrote: > > Are we really suppose

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

bcraig added a subscriber: bcraig. Comment at: src/UnwindRegistersRestore.S:325 @@ -324,4 +324,3 @@ DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv) -#if !defined(__ARM_ARCH_ISA_ARM) - ldr r2, [r0, #52] - ldr r3, [r0, #60] +#if !defined(_

[clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

Author: d0k Date: Mon Jul 18 14:21:22 2016 New Revision: 275886 URL: http://llvm.org/viewvc/llvm-project?rev=275886&view=rev Log: Unbreak extra tools build post r275882. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer

Re: [clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

Thanks, I just checked out clang-tool-extras and was in the process of doing that :) — Mehdi > On Jul 18, 2016, at 12:21 PM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Mon Jul 18 14:21:22 2016 > New Revision: 275886 > > URL: http://llvm.org/viewvc/llvm-project?rev=2758

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r275895 - [Driver] Compute effective target triples once per job (NFCI)

Author: vedantk Date: Mon Jul 18 14:56:38 2016 New Revision: 275895 URL: http://llvm.org/viewvc/llvm-project?rev=275895&view=rev Log: [Driver] Compute effective target triples once per job (NFCI) Compute an effective target triple exactly once in ConstructJob(), and then simply pass around refere

r275894 - [Driver] Make Driver::DefaultTargetTriple private (NFCI)

Author: vedantk Date: Mon Jul 18 14:56:33 2016 New Revision: 275894 URL: http://llvm.org/viewvc/llvm-project?rev=275894&view=rev Log: [Driver] Make Driver::DefaultTargetTriple private (NFCI) No in-tree targets access this `DefaultTargetTriple` directly, and usage of default triples is generally d

Re: [PATCH] D22289: [PATCH 1/2] [Driver] Make Driver::DefaultTargetTriple private (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL275894: [Driver] Make Driver::DefaultTargetTriple private (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22289?vs=63756&id=64366#toc Repository: rL LLVM https://rev

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rL275895: [Driver] Compute effective target triples once per job (NFCI) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D22290?vs=64023&id=64367#toc Repository: rL LLVM https:

Re: [PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

vsk added a comment. Ping. https://reviews.llvm.org/D7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22419: [CFG] Fix crash in thread sanitizer.

nandor updated this revision to Diff 64368. nandor added a comment. Fixed typo https://reviews.llvm.org/D22419 Files: lib/Analysis/CFG.cpp test/SemaCXX/warn-thread-safety-analysis.cpp Index: test/SemaCXX/warn-thread-safety-analysis.cpp ==

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added a subscriber: mehdi_amini. Comment at: docs/Proposals/GitHub.rst:122 @@ +121,3 @@ +of understanding the *sequence* in which commits were added by using the +``git rev-list --count hash`` or ``git describe hash`` commands. + filcab wrote: > How ea

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:8-9 @@ +7,4 @@ + +This is a proposal to move our current revision control system from Subversion +to GitHub. Below are the financial and technical arguments as to why we need +such a move and how will people (an

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin updated this revision to Diff 64371. rengolin added a comment. Second round of suggestions applied. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst === --- /dev/null +++

Re: r275820 - [analyzer] Add checker modeling potential C++ self-assignment

Thanks, I've merged the revert in r275902. Cheers, Hans On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote: > Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t > get an email from the bot about the failure. > > Thanks > Devin > > On Jul 18, 2016, at 11:59 AM, Hans

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:198 @@ +197,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account. +4. Make sure bisecting with llvm-project works. mehdi_amini wrote: > Uh, this point i

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin updated this revision to Diff 64373. rengolin added a comment. Removing "broken" to describe the history, just explaining it'll be local. Expanding to mention that hooks will need to be implemented in step 3. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: d

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz updated this revision to Diff 64374. https://reviews.llvm.org/D22465 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRLocFinder.cpp test/clang-rename/ClassNameInFunctionDefenition.cpp test/clang-rename/ComplicatedClassType.cpp test/clang-rename

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:199 @@ +198,3 @@ + +Here's a proposed plan: + Annoyingly my comment does no longer show-up next to the point it was referring to, it was about your third point: > Make sure we have an llvm-

Re: [PATCH] D22465: [clang-rename] introduce better symbol finding and add few more tests

omtcyfz added a comment. Removed two `FIXME`s. Seems like types are now handled correctly. +1 test passing. https://reviews.llvm.org/D22465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:200 @@ +199,3 @@ + +Here's a proposed plan: + You can click on the "<<" button and it will show where it was first inserted. That's how I found out. :) The hooks, AFAICS, will be added to the

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project works.

Re: [PATCH] D22069: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

mgehre added a comment. Friendly ping https://reviews.llvm.org/D22069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275904 - Bump version # to 4.0.0

Author: marshall Date: Mon Jul 18 15:27:19 2016 New Revision: 275904 URL: http://llvm.org/viewvc/llvm-project?rev=275904&view=rev Log: Bump version # to 4.0.0 Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project/libcxx/trun

r275905 - Allow iOS and tvOS version numbers with 2-digit major version numbers.

Author: bwilson Date: Mon Jul 18 15:29:14 2016 New Revision: 275905 URL: http://llvm.org/viewvc/llvm-project?rev=275905&view=rev Log: Allow iOS and tvOS version numbers with 2-digit major version numbers. rdar://problem/26921601 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Dri

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > apaprocki wrote: > > majnemer wrote: > >

[PATCH] D22474: [CodeGen] Suppress C++ static destructor registration

bruno created this revision. bruno added reviewers: rsmith, doug.gregor. bruno added subscribers: cfe-commits, dexonsmith. C++ static destructors can be problematic in multi-threaded environment. Some of the issues users often complain about include: 1. Teardown ordering: crashes when one thread

r275906 - Add missing header in ClangFuzzer (after r275882 cleanup)

Author: mehdi_amini Date: Mon Jul 18 15:33:09 2016 New Revision: 275906 URL: http://llvm.org/viewvc/llvm-project?rev=275906&view=rev Log: Add missing header in ClangFuzzer (after r275882 cleanup) Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified: cfe/trunk/tools/clang-fuzzer/Cl

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

apaprocki updated this revision to Diff 64376. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libclang/CIndexer.cpp Index: tools/libclang/CIndexer.cpp

r275907 - [Sema] Create a separate group for incompatible function pointer warning

Author: bruno Date: Mon Jul 18 15:37:06 2016 New Revision: 275907 URL: http://llvm.org/viewvc/llvm-project?rev=275907&view=rev Log: [Sema] Create a separate group for incompatible function pointer warning Give incompatible function pointer warning its own diagnostic group but still leave it as a

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide added a comment. Richard, can you please take a look at this? The more I look at it the more it seems weird that we can recurse in this case, but I may miss something https://reviews.llvm.org/D20748 ___ cfe-commits mailing list cfe-commits@l

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project works. --

[PATCH] D22476: [AST] Make MemberExpr non-dependent according to core issue 224

mgehre created this revision. mgehre added reviewers: klimek, aaron.ballman, rsmith. mgehre added a subscriber: cfe-commits. A MemberExpr is non-dependent if 1) it is a member of the current instantiation 2) the member is non-dependent We check 1) by asserting that the base of the MemberExpr is a

r275913 - [Coverage] Normalize '..' out of filename strings

Author: vedantk Date: Mon Jul 18 16:01:27 2016 New Revision: 275913 URL: http://llvm.org/viewvc/llvm-project?rev=275913&view=rev Log: [Coverage] Normalize '..' out of filename strings This fixes the issue of having duplicate entries for the same file in a coverage report s.t none of the entries a

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno closed this revision. bruno added a comment. Thanks, r275907. https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno added a comment. Ping! https://reviews.llvm.org/D22183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin updated this revision to Diff 64383. rengolin added a comment. Expand step 2 to make sure we don't forget about the safety hooks on each project as well as the webhook to update the umbrella project. This could turn out to be a buildbot, but makes no difference at this stage. https://

Re: [PATCH] D22476: [AST] Make MemberExpr non-dependent according to core issue 224

rsmith added inline comments. Comment at: lib/AST/Expr.cpp:1425 @@ +1424,3 @@ + + if (E->isTypeDependent() && isa(base)) { +bool MemberOfCurrentInstantiation = true; The language rule for this says nothing about the base being a `this` expression; there are

Re: [PATCH] D22474: [CodeGen] Suppress C++ static destructor registration

rsmith added a comment. Interested reviewers, see also discussion here of whether we want this feature: http://lists.llvm.org/pipermail/cfe-dev/2016-July/050040.html https://reviews.llvm.org/D22474 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history,

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

> On 2016-Jul-17, at 14:09, Eric Fiselier wrote: > > What I'm curious about if this performance regression was cause by (1) the > removal of this 2 week old optimization or (2) the implementation of "fast > mod". I suspect it's because of (1). > BTW, definitely from the 2 week old optimizati

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

majnemer added a comment. Could you please attach a diff with additional context? Comment at: lib/Driver/ToolChains.cpp:3717-3735 @@ -3678,1 +3716,21 @@ + // We need a detected GCC installation on Linux to provide libstdc++'s + // headers. We handled the libc++ case above. +

Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clause SEMA.

On Wed, Mar 9, 2016 at 7:46 AM, Samuel Antao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sfantao > Date: Wed Mar 9 09:46:05 2016 > New Revision: 263019 > > URL: http://llvm.org/viewvc/llvm-project?rev=263019&view=rev > Log: > [OpenMP] Add support for multidimensional array sect

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

rnk added a comment. The approach makes sense to me, but the tests suggest it isn't doing what I'd expect. Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7 @@ -6,3 +6,1 @@ } s; -// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*] -// MSVC-DAG: @"\01??_SS@@6B@" = unn

Re: r202329 - Add a 'use-external-names' option to VFS overlay files

On Wed, Feb 26, 2014 at 4:25 PM, Ben Langmuir wrote: > Author: benlangmuir > Date: Wed Feb 26 18:25:12 2014 > New Revision: 202329 > > URL: http://llvm.org/viewvc/llvm-project?rev=202329&view=rev > Log: > Add a 'use-external-names' option to VFS overlay files > > When true, sets the name of the f

[PATCH] D22481: Allow negative lower bound in array sections based on pointers

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. OpenMP 4.5 removed the restriction that array section lower bound must be non negative. This change is to allow negative values for array sectio

r275924 - [Coverage] Remove '..' from filenames *after* getting an absolute path

Author: vedantk Date: Mon Jul 18 17:32:02 2016 New Revision: 275924 URL: http://llvm.org/viewvc/llvm-project?rev=275924&view=rev Log: [Coverage] Remove '..' from filenames *after* getting an absolute path Failure to do this breaks relative paths which begin with '..'. This issue was caught by th

r275925 - Fix some minor issues found by Coverity.

Author: rsmith Date: Mon Jul 18 17:37:35 2016 New Revision: 275925 URL: http://llvm.org/viewvc/llvm-project?rev=275925&view=rev Log: Fix some minor issues found by Coverity. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/ItaniumMan

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, up

r275926 - [OpenMP] Fix incorrect diagnostics in map clause

Author: kli Date: Mon Jul 18 17:49:16 2016 New Revision: 275926 URL: http://llvm.org/viewvc/llvm-project?rev=275926&view=rev Log: [OpenMP] Fix incorrect diagnostics in map clause Having the following code pattern will result in incorrect diagnostic int main() { int arr[10]; #pragma omp target

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

This revision was automatically updated to reflect the committed changes. Closed by commit rL275926: [OpenMP] Fix incorrect diagnostics in map clause (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22075?vs=64353&id=64410#toc Repository: rL LLVM https://reviews.llvm.or

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

lattner added a subscriber: lattner. lattner added a comment. Please send this to llvm-dev for discussion when it converges, thanks! https://reviews.llvm.org/D22463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r275930 - [OpenMP] Remove dead code in conditional of mappable expressions SEMA.

Author: sfantao Date: Mon Jul 18 18:22:11 2016 New Revision: 275930 URL: http://llvm.org/viewvc/llvm-project?rev=275930&view=rev Log: [OpenMP] Remove dead code in conditional of mappable expressions SEMA. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cp

Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clause SEMA.

Hi Richard,   Thanks for catching that! Fixed in r275930.   Thanks again, Samuel   - Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clau

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

silvas updated this revision to Diff 64420. silvas added a comment. Rebase after r275507. https://reviews.llvm.org/D21954 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt lib/Frontend/CompilerInvoc

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

delcypher added a subscriber: delcypher. Comment at: docs/Proposals/GitHub.rst:102 @@ +101,3 @@ + +How will the new workflow look like +=== s/How will/What will/ Comment at: docs/Proposals/GitHub.rst:136 @@ +135,3

[PATCH] D22487: [OpenMP] Ignore parens in atomic capture

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. Clang misdiagnoses atomic captures cases that contains parens. ie. int v, int *p; #pragma omp atomic capture { v = (*p); (*p)++; } https://revie

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

rivanvx updated this revision to Diff 64417. rivanvx added a comment. Specifically handle only kernels. https://reviews.llvm.org/D20168 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl Index: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl ===

[PATCH] D22490: Append clang system include path for offloading tool chains.

sfantao created this revision. sfantao added reviewers: tra, rsmith. sfantao added subscribers: cfe-commits, rsmith. This patch adds clang system include path when offloading tool chains, e.g. CUDA, are used in the current compilation. This fixes an issue detected by @rsmith in response to r2756

Re: r275645 - [CUDA][OpenMP] Create generic offload action

Art, Richard,   I posted https://reviews.llvm.org/D22490. Let me know if that is what you have in mind.   Thanks! Samuel   - Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create

Re: [PATCH] D22490: Append clang system include path for offloading tool chains.

sfantao updated this revision to Diff 64428. sfantao added a comment. - Add missing context for review. https://reviews.llvm.org/D22490 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++ lib

Re: [PATCH] D22490: Append clang system include path for offloading tool chains.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D22490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

r275931 - Append clang system include path for offloading tool chains.

Author: sfantao Date: Mon Jul 18 19:01:12 2016 New Revision: 275931 URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev Log: Append clang system include path for offloading tool chains. Summary: This patch adds clang system include path when offloading tool chains, e.g. CUDA, are used i

Re: [PATCH] D22490: Append clang system include path for offloading tool chains.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275931: Append clang system include path for offloading tool chains. (authored by sfantao). Changed prior to commit: https://reviews.llvm.org/D22490?vs=64428&id=64432#toc Repository: rL LLVM https:/

Re: r275645 - [CUDA][OpenMP] Create generic offload action

Fixed in r275931.   Thanks! Samuel   - Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create generic offload actionDate: Mon, Jul 18, 2016 7:38 PM      On Mon, Jul 18, 2016 at 4:2

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Comment at: lib/Parse/ParseObjc.cpp:3489 @@ -3478,3 +3488,3 @@ -// Parse the ellipsis that designates this as a pack expansion. -SourceLocati

  1   2   >