Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

2016-07-12 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Jul-12, at 17:47, Vedant Kumar wrote: > > >> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >>> >>> vsk created this revision. >>> vsk added a reviewer: dexonsmith. >>> vsk added a subscriber: cfe-commits. >

Re: [PATCH] D22263: [clang-tidy] Fix syntax error in modernize-use-emplace.rst

2016-07-12 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. List of Clang-tidy checks was not updated for long time (I still don't see modernize-use-emplace). May be documentation contains other mistakes? http://reviews.llvm.org/D22263 _

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

2016-07-12 Thread Vedant Kumar via cfe-commits
> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-12, at 17:47, Vedant Kumar wrote: >> >> >>> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >>> wrote: >>> >>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: vsk created this revision

Re: [PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

2016-07-12 Thread Saleem Abdulrasool via cfe-commits
compnerd added a subscriber: compnerd. compnerd added a comment. Can you explain why the write back is needed? You are doing the write back on r0, but then adjusting it back. So it is unclear why this change is needed. Could you provide some more context. A test case would be even better.

Re: [PATCH] D20352: Add XRay flags to Clang

2016-07-12 Thread Dean Michael Berris via cfe-commits
dberris updated this revision to Diff 63771. dberris added a comment. Rebase http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp li

[PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-12 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rsmith, eugenis. pcc added subscribers: cfe-commits, krasin. pcc added a dependency: D22295: Introduce !splitpoint metadata and GlobalSplit pass.. This metadata can be used to annotate global variables with split points. Each split point specifies a

Re: [PATCH] D20352: Add XRay flags to Clang

2016-07-12 Thread Dean Michael Berris via cfe-commits
dberris added a comment. It looks like I was using `hasArg` instead of `hasFlag`. The dangerous part here is that OptSpecifier has an unsigned non-explicit argument, and I suspect `bool` is being promoted to `unsigned` silently with clang/gcc. http://reviews.llvm.org/D20352

Re: [PATCH] D20352: Add XRay flags to Clang

2016-07-12 Thread Dean Michael Berris via cfe-commits
dberris updated this revision to Diff 63775. dberris added a comment. - Use hasFlag instead of hasArg http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen

r275241 - CodeGen: minor cleanup, NFC

2016-07-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jul 12 21:58:44 2016 New Revision: 275241 URL: http://llvm.org/viewvc/llvm-project?rev=275241&view=rev Log: CodeGen: minor cleanup, NFC Initialise more members in initializer lists. Invert the condition that had grown to be pretty confusing. The `_objc_empty_vtable` i

[clang-tools-extra] r275254 - fix missing newline in sphinx doc

2016-07-12 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Wed Jul 13 01:06:48 2016 New Revision: 275254 URL: http://llvm.org/viewvc/llvm-project?rev=275254&view=rev Log: fix missing newline in sphinx doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst Modified: clang-tools-extra/trunk/docs/

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

2016-07-12 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r275256 - fix missing whitespace in sphinx doc

2016-07-12 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Wed Jul 13 01:37:39 2016 New Revision: 275256 URL: http://llvm.org/viewvc/llvm-project?rev=275256&view=rev Log: fix missing whitespace in sphinx doc Modified: cfe/trunk/docs/ClangFormat.rst Modified: cfe/trunk/docs/ClangFormat.rst URL: http://llvm.org/viewvc/llvm-proj

<    1   2