Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

hokein added inline comments. Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48 @@ +47,3 @@ + + // Assignement slicing: "a = b;" and "a = std::move(b);" variants. + const auto SlicesObjectInAssignment = courbet wrote: > hokein wrote: > > Looks like yo

Re: [PATCH] D22129: [clang-rename] add documentation

omtcyf0 updated this revision to Diff 63646. omtcyf0 marked 6 inline comments as done. omtcyf0 added a comment. Fixed. Thanks for the feedback! http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst Index: docs/clang-rename.rst ==

Re: [PATCH] D22102: [clang-rename] extend testset

omtcyf0 updated this revision to Diff 63647. http://reviews.llvm.org/D22102 Files: test/clang-rename/FunctionMacro.cpp test/clang-rename/Namespace.cpp test/clang-rename/TemplateTypename.cpp test/clang-rename/VariableMacro.cpp test/clang-rename/VirtualFunction.cpp Index: test/clang-rena

[PATCH] D22260: [clang-tidy] Fix misc-definitions-in-headers misplaced fixing to fully templated function.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D22260 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang-tidy/misc-definitions-in-headers.hpp Index: test/clang-tidy/misc-definitions-in-headers.hpp ==

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

rengolin requested changes to this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision now requires changes to proceed. Hi Weiming, We've discussed about creating builtins when I added support for named registers and the consensus was that, since there is alrea

Re: [PATCH] D21991: [libunwind][ARM] Improve unwinder stack usage - Make WMMX support optional

rmaprath added inline comments. Comment at: src/Registers.hpp:1497 @@ -1479,3 +1496,3 @@ _LIBUNWIND_ABORT("unsupported arm register"); } compnerd wrote: > rmaprath wrote: > > compnerd wrote: > > > Early returns would be nicer imo. > > Not sure if I follow,

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

DmitryPolukhin added a comment. Friendly ping, PTAL! http://reviews.llvm.org/D21970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22263: [clang-tidy] Fix syntax error in modernize-use-emplace.rst

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. The missing newline after the ".. code:: c++" was causing a compile error when producing the documentation http://reviews.llvm.org/D22263 Files: docs/clang-tidy/checks/modernize-use-empla

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

Ilod added a comment. I don't have write access to SVN, so IIUC LLVM policy says I can't approve a patch. Repository: rL LLVM http://reviews.llvm.org/D21385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

dsanders added a comment. What sets HAVE_CXX_LIBATOMICS64? I don't see a reference to LLVM's CheckAtomic. Repository: rL LLVM http://reviews.llvm.org/D21599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme updated this revision to Diff 63663. mboehme added a comment. Addressed Prazek's review comments. http://reviews.llvm.org/D0 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MoveForwardingReferenceCheck.cpp clang-tidy/misc/MoveForwardi

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme marked 5 inline comments as done. mboehme added a comment. In http://reviews.llvm.org/D0#480415, @mgehre wrote: > Nice check. This should be mentioned in docs/ReleaseNotes.rst Done. Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:34 @@ +33,3 @@ + if

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

dsanders added a comment. Have you tried a standalone build? I suspect HAVE_CXX_LIBATOMICS64 will never be set for that case. If that's the case, adding 'include(CheckAtomic)' will probably fix it. Repository: rL LLVM http://reviews.llvm.org/D21599 ___

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

dsanders added a comment. I haven't used it that way either and I'm not sure it's a supported build for libcxx but most LLVM projects support a standalone build as far as I know. Can someone from the libcxx project confirm whether standalone builds are supported? Repository: rL LLVM http://

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. Hi Daniel/Vasileios Please could you find sometime to review this? Thanks Repository: rL LLVM http://reviews.llvm.org/D21599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. In http://reviews.llvm.org/D21599#481553, @dsanders wrote: > What sets HAVE_CXX_LIBATOMICS64? I don't see a reference to LLVM's > CheckAtomic. The CheckAtomic.cmake module (http://reviews.llvm.org/D20896) in llvm will set HAVE_CXX_LIBATOMICS64 if library exit and

Re: [PATCH] D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__"

ericLemanissier abandoned this revision. ericLemanissier added a comment. Well, C++ Core Guidelines advises in this case to correct function receiving __PRETTY_FUNCTION__: the parameter type should not be const char* ( https://github.com/isocpp/CppCoreGuidelines/issues/640 ) I'm not sure if it s

Re: [PATCH] D21599: [Libcxx][MIPS] Use LLVM CheckAtomic.cmake module to figure out whether we need to link with libatomic.

nitesh.jain added a comment. In http://reviews.llvm.org/D21599#481588, @dsanders wrote: > Have you tried a standalone build? I suspect HAVE_CXX_LIBATOMICS64 will never > be set for that case. If that's the case, adding 'include(CheckAtomic)' will > probably fix it. I never tried a standalone

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath updated this revision to Diff 63670. rmaprath added a comment. Minor cleanup + Ping. http://reviews.llvm.org/D21968 Files: CMakeLists.txt include/__config include/__config_site.in include/__threading_support lib/CMakeLists.txt test/CMakeLists.txt test/libcxx/test/config.p

r275169 - [Clang][AVX512] Making cosmetic changes

Author: mzuckerm Date: Tue Jul 12 07:42:27 2016 New Revision: 275169 URL: http://llvm.org/viewvc/llvm-project?rev=275169&view=rev Log: [Clang][AVX512] Making cosmetic changes Modified: cfe/trunk/lib/Headers/avx512vbmiintrin.h Modified: cfe/trunk/lib/Headers/avx512vbmiintrin.h URL: http://ll

[PATCH] D22265: [libcxx][filesystem] Remove setgid from parent before testing permissions

Hahnfeld created this revision. Hahnfeld added a reviewer: EricWF. Hahnfeld added a subscriber: cfe-commits. man page for mkdir says: `If the parent directory has the set-group-ID bit set, then so will the newly created directory.` http://reviews.llvm.org/D22265 Files: test/std/experimental/

Re: r273694 - clang-format: [JS] Fix build breakage.

So, turns out top-level conditionals are actually used somewhat frequently. Can I undo this change? It doesn't break any other tests. Do you have other tests that I should run against? On Fri, Jun 24, 2016 at 11:48 PM, Martin Probst wrote: > Yes, test breakage. The problem was that with the chan

Re: r273694 - clang-format: [JS] Fix build breakage.

What do you mean by other tests? On my machine, reverting this change breaks one of the tests in FormatTestJS.Conditional. Martin Daniel Jasper schrieb am Di., 12. Juli 2016 um 06:03 Uhr: > So, turns out top-level conditionals are actually used somewhat > frequently. Can I undo this change? It

[libcxx] r275170 - Mark P0067 as 'postponed', because it will be revised before the next meeting

Author: marshall Date: Tue Jul 12 09:37:39 2016 New Revision: 275170 URL: http://llvm.org/viewvc/llvm-project?rev=275170&view=rev Log: Mark P0067 as 'postponed', because it will be revised before the next meeting Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_s

[libcxx] r275172 - Add option to disable __deallocate #warning

Author: compnerd Date: Tue Jul 12 09:39:13 2016 New Revision: 275172 URL: http://llvm.org/viewvc/llvm-project?rev=275172&view=rev Log: Add option to disable __deallocate #warning From r229162: Visual Studio's SAL extension uses a macro named __deallocate. This macro is used pervasively Using

[libcxx] r275171 - Put the status in the right column

Author: marshall Date: Tue Jul 12 09:38:59 2016 New Revision: 275171 URL: http://llvm.org/viewvc/llvm-project?rev=275171&view=rev Log: Put the status in the right column Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llv

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

t.p.northover added a comment. I agree with Renato too. It seems like, as a compiler, we can provide virtually no guarantees about the value of `__builtin_arm_current_pc`: it's not necessarily in the PC-range of the dynamically innermost frame (inlining); it's not necessarily even in the calls

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

dsanders updated this revision to Diff 63676. dsanders added a comment. Updated to match latest version of http://reviews.llvm.org/D21467. At this point Mips is in the X86/everyone-else camp but there's a loose end to tie up in LLVM in order to prove it. Once LLVM rejects non-empty ABIName's for

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao updated this revision to Diff 63680. sfantao added a comment. - Rebase. - Remove static function no longer necessary. http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 63681. sfantao added a comment. - Rebase. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Dri

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao updated this revision to Diff 63682. sfantao added a comment. - Rebase. http://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.c

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 63683. sfantao added a comment. - Rebase. http://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tools

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao added a comment. @tra, any more comments about this patch? Thanks! Samuel http://reviews.llvm.org/D18171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275176 - mark issue #2181 as complete; this was just a wording clarification

Author: marshall Date: Tue Jul 12 10:15:55 2016 New Revision: 275176 URL: http://llvm.org/viewvc/llvm-project?rev=275176&view=rev Log: mark issue #2181 as complete; this was just a wording clarification Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

Re: [PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:2725 @@ -2724,3 +2724,3 @@ void EmitStoreOfScalar(llvm::Value *Value, Address Addr, - bool Volatile, QualType Ty, + bool Volatile, bool Restrict, QualType T

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao updated this revision to Diff 63684. sfantao added a comment. - Rebase. http://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c === --- test/Driver/o

[libcxx] r275177 - mark issue #2422 as complete; this was just a wording clarification

Author: marshall Date: Tue Jul 12 10:29:35 2016 New Revision: 275177 URL: http://llvm.org/viewvc/llvm-project?rev=275177&view=rev Log: mark issue #2422 as complete; this was just a wording clarification Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

Anastasia added inline comments. Comment at: test/Frontend/opencl-blocks.cl:9 @@ -8,1 +8,3 @@ // RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify -fsyntax-only +// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck --check-prefix=CHECK-INVALID-

r275183 - clang-format: [JS] Allow top-level conditionals again.

Author: djasper Date: Tue Jul 12 10:45:53 2016 New Revision: 275183 URL: http://llvm.org/viewvc/llvm-project?rev=275183&view=rev Log: clang-format: [JS] Allow top-level conditionals again. I am not sure exactly which test breakage Martin was trying to fix in r273694. For now, fix the behavior for

[libcxx] r275184 - Add tests for the meta.unary.props that do not require a complete type. This is part of LWG#2582

Author: marshall Date: Tue Jul 12 10:50:53 2016 New Revision: 275184 URL: http://llvm.org/viewvc/llvm-project?rev=275184&view=rev Log: Add tests for the meta.unary.props that do not require a complete type. This is part of LWG#2582 Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/m

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:83 @@ +82,3 @@ +SamplerTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "__sampler"), + CGM.getContext().getTargetAddressSpace( I am wondering i

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli marked 3 inline comments as done. Comment at: lib/Sema/SemaOpenMP.cpp:11648 @@ +11647,3 @@ +// item should be a pointer or reference to pointer +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) -

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli updated this revision to Diff 63689. carlo.bertolli added a comment. [OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h include/clang/AS

Re: [PATCH] D22242: [analyzer] De-duplicate some code for discovering the origin of the symbol.

NoQ updated this revision to Diff 63688. NoQ marked an inline comment as done. NoQ added a comment. Added a doxygen comment, made the function virtual instead of branching. http://reviews.llvm.org/D22242 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SymExpr.h include/clang/StaticAn

Re: [PATCH] D21989: [OpenCL] Improve diagnostics of OpenCL types

Anastasia added a comment. Wondering if we should add similar restrictions for other OpenCL types incl events or queues? Also I am guessing that the following pipe int (*p) should be parsed as pointer to pipe and not a pointer to a pipe element type (by analogy to function pointers or other

r275190 - [ItaniumMangle] Correctly mangle BuiltinTemplateDecls

Author: majnemer Date: Tue Jul 12 11:48:17 2016 New Revision: 275190 URL: http://llvm.org/viewvc/llvm-project?rev=275190&view=rev Log: [ItaniumMangle] Correctly mangle BuiltinTemplateDecls A BuiltinTemplateDecl has no underlying templated decl and as such they cannot be relied upon for mangling.

Re: [PATCH] D21989: [OpenCL] Improve diagnostics of OpenCL types

Anastasia closed this revision. Anastasia added a comment. r275061 http://reviews.llvm.org/D21989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

davidxl added a comment. Please also update user manual: docs/UserManual.rst Comment at: test/Driver/clang_f_opts.c:90 @@ -89,3 +89,2 @@ // RUN: %clang -### -S -fprofile-instr-generate=file -fno-profile-instr-generate %s 2>&1 | FileCheck -check-prefix=CHECK-DISABLE-GEN %s -//

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

davidxl added inline comments. Comment at: lib/Driver/Tools.cpp:3596 @@ -3576,3 +3595,3 @@ Args.hasFlag(options::OPT_fprofile_generate, -options::OPT_fno_profile_instr_generate, false) || +options::OPT_fno_profile_generate, false) ||

r275191 - Fix for the mingw builder

Author: majnemer Date: Tue Jul 12 11:56:33 2016 New Revision: 275191 URL: http://llvm.org/viewvc/llvm-project?rev=275191&view=rev Log: Fix for the mingw builder Modified: cfe/trunk/test/CodeGenCXX/mangle-template.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-template.cpp URL: http://llvm.o

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia closed this revision. Anastasia added a comment. r262641 http://reviews.llvm.org/D17345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia closed this revision. Anastasia added a comment. r262616 http://reviews.llvm.org/D16928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15293: [OpenCL] Correct NULL constant handling after applying default AS

Anastasia closed this revision. Anastasia added a comment. r255346 http://reviews.llvm.org/D15293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13168: [OpenCL] OpenCL2.0 - Apply default address space rules

Anastasia closed this revision. Anastasia added a comment. r253863 http://reviews.llvm.org/D13168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13105: [OpenCL] Enable program scope variables for OpenCL2.0

Anastasia closed this revision. Anastasia added a comment. r248906 and r250892 http://reviews.llvm.org/D13105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17343: [OpenCL] Diagnose program scope pointers

Anastasia abandoned this revision. Anastasia added a comment. After clarifying with Khronos, it doesn't seem like this is needed indeed! http://reviews.llvm.org/D17343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia closed this revision. Anastasia added a comment. r274540 and r274509 http://reviews.llvm.org/D20249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

tra added a comment. Few minor nits and suggestions. Other than that I'm OK with the patch. Comment at: lib/Driver/Action.cpp:156 @@ +155,3 @@ + // Propagate info to the dependencies. + for (unsigned i = 0; i < getInputs().size(); ++i) +getInputs()[i]->propagateDeviceOfflo

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:129 @@ -95,1 +128,3 @@ + auto CtorCallSourceRange = CharSourceRange::getTokenRange( + InnerCtorCall->getExprLoc(), CallParensRange.getBegin()); There is a bug here that I fo

r275195 - AArch64: fix return type of vqmovun_high_*.

Author: tnorthover Date: Tue Jul 12 12:38:50 2016 New Revision: 275195 URL: http://llvm.org/viewvc/llvm-project?rev=275195&view=rev Log: AArch64: fix return type of vqmovun_high_*. These should be returning an unsigned quantity. Added: cfe/trunk/test/Sema/arm64-neon-header.c Modified: cf

[PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

spyffe created this revision. spyffe added a reviewer: manmanren. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. When importing classes and structs with anonymous structs, it is critical that distinct anonymous structs remain distinct despite havin

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

manmanren added a comment. > Before this patch, the testcase added used to take > 5s to compile!!! A bit more elaborate NSDictionary literal with some > undeclared enums would make the compiler take 22min to run, followed by a > crash. --> this is a big improvement! A few notes from discu

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

mgrang added a comment. Hi Tim/Renato, On a similar note, I have a patch which adds the breakpoint intrinsic (for ARM and Thumb): http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html Could you please let me know if this is something which the community would like

[PATCH] D22272: ARM: define __ARM_VFPV5__ when present.

t.p.northover created this revision. t.p.northover added reviewers: rengolin, jmolloy. t.p.northover added a subscriber: cfe-commits. Herald added subscribers: mcrosier, rengolin, aemerson. We've had embedded developers requesting we extend the __ARM_VFPVn__ series to support Cortex-M7, which sou

[PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

DaveBartolomeo created this revision. DaveBartolomeo added reviewers: rnk, cfe-commits. When compiling as C targeting the MS ABI, but with -fno-ms-compatibility, an enumerator initializer that is not representable as an int is treated as an error. This is correct according to the C standard, but

[PATCH] D22275: Support -fno-delayed-template-parsing in clang-cl.exe

DaveBartolomeo created this revision. DaveBartolomeo added reviewers: rnk, majnemer, cfe-commits. This change adds support for the -fno-delayed-template-parsing option in clang-cl.exe. This allows developers using clang-cl.exe to opt out of emulation of MSVC's non-conformant template instantiati

Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

majnemer added a subscriber: majnemer. majnemer requested changes to this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision now requires changes to proceed. This requires an associated test case. Comment at: lib/Sema/SemaDecl.cpp:14354-14355

Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

rnk added a comment. I think this is just a consequence of https://llvm.org/bugs/show_bug.cgi?id=27098 We should just fix the underlying bug so that `EnumDecl::isFixed()` doesn't return true for plain enums in C or C++ when targeting Windows. http://reviews.llvm.org/D22273

Re: [PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 updated this revision to Diff 63722. ashi1 marked 4 inline comments as done. ashi1 added a comment. Revised to Anastasia's comments. Removed opencl-blocks.cl, and created a generic opencl.cl inside test/Frontend folder. This change passes clang-test. Repository: rL LLVM http://reviews

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

jfb updated this revision to Diff 63723. jfb added a comment. - Move atomics.align to libcxx-specific - Give names to anonymous structs http://reviews.llvm.org/D22073 Files: test/libcxx/atomics/atomics.align/align.pass.cpp Index: test/libcxx/atomics/atomics.align/align.pass.cpp =

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

jfb added a comment. In http://reviews.llvm.org/D22073#481402, @EricWF wrote: > - The test should be moved to `test/libcxx/atomics/atomics.align` since it's > libc++ specific. Done. > - Please give the anonymous struct declarations unique names. `T1`, `T2`, > ..., `TN` is fine. Currently the

[libcxx] r275210 - libc++: name anonymous structs

Author: jfb Date: Tue Jul 12 15:14:52 2016 New Revision: 275210 URL: http://llvm.org/viewvc/llvm-project?rev=275210&view=rev Log: libc++: name anonymous structs As discussed in http://reviews.llvm.org/D22073 Modified: libcxx/trunk/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp

[libcxx] r275211 - Add more tests for LWG#2582. No code changes needed, just tests.

Author: marshall Date: Tue Jul 12 15:15:46 2016 New Revision: 275211 URL: http://llvm.org/viewvc/llvm-project?rev=275211&view=rev Log: Add more tests for LWG#2582. No code changes needed, just tests. Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/array.pass.cpp

Re: [PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

manmanren added a comment. I am not sure if we should handle this inside findAnonymousStructOrUnionIndex. Here is the definition of anonymous structure I found: An unnamed member whose type specifier is a structure specifier with no tag is called an anonymous structure. Cheers, Manman ==

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

I was asking for the debug info to describe the entity as a declaration, rather than a definition. Instead you eliminated the debug-info description entirely. These are pretty different things. --paulr From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Monday, July 11, 2016 12:27 PM T

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

On Tue, Jul 12, 2016 at 2:02 PM, Robinson, Paul wrote: > I was asking for the debug info to describe the entity as a declaration, > rather than a definition. > > Instead you eliminated the debug-info description entirely. These are > pretty different things. > I treated the dllimported entity t

Re: [PATCH] D21695: [clang] Version support for UBSan handlers

filcab added a comment. Ping! http://reviews.llvm.org/D21695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

A declaration that gets used within the CU generally does get a debug-info description. I think no DWARF-using target has dllimport (yet) so you are actually handling a new situation here. Being unable to find the entity in the dllimport-using CU is not a friendly debugging experience. --paulr

Re: [PATCH] D21706: [libcxx] refactor for throw

mclow.lists added a comment. I just realized that this will break the following code: try { __cxxabiv1:: __cxa_bad_cast(); } catch ( std::bad_cast &ex ) {} because what gets thrown is a `const std::bad_cast &` Yes, people should catch by value or const reference. But that doesn't mean that

[PATCH] D22285: Support -masm= flag for x86 assembly targets

ygao created this revision. ygao added subscribers: thakis, cfe-commits. For assembly files without .intel_syntax or .att_syntax directives, allow the -masm= flag to supply a default assembly dialect. For example, C:\TMP> type intel.s .text mov al,0 C:\TMP> clang -masm=intel -c intel.s Without

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

On Tue, Jul 12, 2016 at 2:55 PM, Robinson, Paul wrote: > A declaration that gets used within the CU generally does get a debug-info > description. > It does except if it is a static data member: $ cat t.cpp struct S { static int i; }; int &gv = &S::i; $ ~/llvm/Debug+Asserts/bin/clang t.cpp -ta

Re: [PATCH] D21912: [CUDA] Don't assume that destructors can't be overloaded.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D21912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20100: [NFC] Header cleanup

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Looks like a nice cleanup. http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

r275231 - [CUDA] Don't assume that destructors can't be overloaded.

Author: jlebar Date: Tue Jul 12 18:23:01 2016 New Revision: 275231 URL: http://llvm.org/viewvc/llvm-project?rev=275231&view=rev Log: [CUDA] Don't assume that destructors can't be overloaded. Summary: You can overload a destructor in CUDA, and SemaOverload needs to be tweaked not to crash when it

r275232 - [CUDA] Add additional testcases for EraseUnwantedCUDAMatches.

Author: jlebar Date: Tue Jul 12 18:23:12 2016 New Revision: 275232 URL: http://llvm.org/viewvc/llvm-project?rev=275232&view=rev Log: [CUDA] Add additional testcases for EraseUnwantedCUDAMatches. Summary: Specifically, this patch adds testcases for all three calls to EraseUnwantedCUDAMatches. The

Re: [PATCH] D21912: [CUDA] Don't assume that destructors can't be overloaded.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275231: [CUDA] Don't assume that destructors can't be overloaded. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21912?vs=62444&id=63749#toc Repository: rL LLVM http://revie

Re: [PATCH] D21914: [CUDA] Use the multi-element remove function in EraseUnwantedCUDAMatches.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275233: [CUDA] Use the multi-element remove function in EraseUnwantedCUDAMatches. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21914?vs=62446&id=63751#toc Repository: rL LL

r275233 - [CUDA] Use the multi-element remove function in EraseUnwantedCUDAMatches.

Author: jlebar Date: Tue Jul 12 18:23:13 2016 New Revision: 275233 URL: http://llvm.org/viewvc/llvm-project?rev=275233&view=rev Log: [CUDA] Use the multi-element remove function in EraseUnwantedCUDAMatches. Summary: Bug pointed out by Benjamin Kramer in r264008. I think the bug is benign because

Re: [PATCH] D21913: [CUDA] Add additional testcases for EraseUnwantedCUDAMatches.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275232: [CUDA] Add additional testcases for EraseUnwantedCUDAMatches. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21913?vs=62445&id=63750#toc Repository: rL LLVM http://r

Re: [PATCH] D22272: ARM: define __ARM_VFPV5__ when present.

rengolin added a reviewer: kristof.beyls. rengolin added a comment. I don't mind either way, but would be good to be compatible with gcc in that respect. Least surprise and all. ARM was naming it fpv8 for the command line options and other things, might also be good to keep the consistency. Wo

[PATCH] D22289: [PATCH 1/2] [Driver] Make Driver::DefaultTargetTriple private (NFCI)

vsk created this revision. vsk added a reviewer: dexonsmith. vsk added a subscriber: cfe-commits. The clang driver knows about two kinds of target triples: default and effective. Default triples are needed to get ToolChains. ToolChains can then be used to determine more specific effective triples.

[PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

vsk created this revision. vsk added a reviewer: dexonsmith. vsk added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Compute an effective target triple exactly once in ConstructJob(), and then simply pass around const references to it. This elimina

[PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

weimingz created this revision. weimingz added reviewers: rengolin, rmaprath. weimingz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. ARMv6-m requires the writeback suffix for stm. http://reviews.llvm.org/D22292 Files: src/UnwindRegistersSave.S Index: src/Unwi

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: > > vsk created this revision. > vsk added a reviewer: dexonsmith. > vsk added a subscriber: cfe-commits. > Herald added subscribers: srhines, danalbert, tberghammer, aemerson. > > Compute an effective target triple exactly once in ConstructJob(),

Re: [PATCH] D22289: [PATCH 1/2] [Driver] Make Driver::DefaultTargetTriple private (NFCI)

If no one is using it, making it private is obvious goodness. LGTM. > On 2016-Jul-12, at 16:52, Vedant Kumar wrote: > > vsk created this revision. > vsk added a reviewer: dexonsmith. > vsk added a subscriber: cfe-commits. > > The clang driver knows about two kinds of target triples: default an

Re: [PATCH] D22289: [PATCH 1/2] [Driver] Make Driver::DefaultTargetTriple private (NFCI)

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. If no one is using it, making it private is obvious goodness. LGTM. http://reviews.llvm.org/D22289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

rsmith added a comment. You have two independent functional changes in this patch: one adds a flag to control the emission of timestamps into PCH files, and the other re-enables timestamp checking on Win32. Please separate them out into distinct patches to be committed separately. Both parts o

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >> >> vsk created this revision. >> vsk added a reviewer: dexonsmith. >> vsk added a subscriber: cfe-commits. >> Herald added subscribers: srhines, danalbert, tberghammer, aem

Re: [PATCH] D22290: [PATCH 2/2] [Driver] Compute effective target triples once per job (NFCI)

> On Jul 12, 2016, at 5:47 PM, Vedant Kumar via cfe-commits > wrote: > >> >> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith >> wrote: >> >> >>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote: >>> >>> vsk created this revision. >>> vsk added a reviewer: dexonsmith. >>> vsk added a sub

[PATCH] D22293: Fix MSVC mangling of consecutive pack template arguments

DaveBartolomeo created this revision. DaveBartolomeo added reviewers: rnk, majnemer, cfe-commits. When mangling a template specialization where two consecutive template arguments are both packs, MSVC inserts the separator "$$Z" between the two arguments to disambiguate between the case of { { in

  1   2   >