dberris updated this revision to Diff 62720.
dberris added a comment.
Rebase harder.
http://reviews.llvm.org/D20352
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.
dberris created this revision.
dberris added reviewers: echristo, rnk, aaron.ballman.
dberris added a subscriber: cfe-commits.
dberris added dependencies: D20352: Add XRay flags to Clang, D21982: WIP:
Implement a per-thread inmemory log.
Herald added a subscriber: mehdi_amini.
Depends on D21982 w
aaboud abandoned this revision.
aaboud added a comment.
Different implementation was committed at http://reviews.llvm.org/rL274201.
http://reviews.llvm.org/D21766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: courbet
Date: Tue Jul 5 02:49:31 2016
New Revision: 274531
URL: http://llvm.org/viewvc/llvm-project?rev=274531&view=rev
Log:
[ASTMatchers] New forEachOverriden matcher.
Matches methods overridden by the given method.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trun
Most of AVX-512 intrinsics were not supported in 3.8 version and added between
3.8 and 3.9.
In this case, when a BE intrinsic was introduced between releases, it can be
removed, right?
Anyway, we’d better keep the BE intrinsic inside than maintain it in the
autoupgrade.
> Also should we change
Author: mzuckerm
Date: Tue Jul 5 03:08:01 2016
New Revision: 274532
URL: http://llvm.org/viewvc/llvm-project?rev=274532&view=rev
Log:
[Clang][BuiltIn][AVX512] adding _mm{|256|512}_mask_cvt{s|us|}epi16_storeu_epi8
intrinsics
Differential Revision: http://reviews.llvm.org/D21729
Modified:
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274532: [Clang][BuiltIn][AVX512] adding… (authored by
mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21729?vs=61892&id=62723#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21729
Fil
delena added inline comments.
Comment at: lib/Headers/avx512fintrin.h:4518
@@ -4493,1 +4517,3 @@
+static __inline__ __m128 __DEFAULT_FN_ATTRS
+_mm_mask_store_ss (float * __W, __mmask8 __U, __m128 __A)
this intrinsic should be void.
Comment at:
delena accepted this revision.
This revision is now accepted and ready to land.
Comment at: ../tunkClang/tools/clang/test/CodeGen/avx512f-builtins.c:1413-1414
@@ -1412,3 +1412,4 @@
// CHECK-LABEL: @test_mm512_mask_and_epi32
- // CHECK: @llvm.x86.avx512.mask.pand.d.512
+ // CH
AsafBadouh created this revision.
AsafBadouh added reviewers: m_zuckerman, guyblank, delena.
AsafBadouh added a subscriber: cfe-commits.
AsafBadouh set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D21988
Files:
../llvm/tools/clang/lib/Headers/avx51
AsafBadouh added inline comments.
Comment at: ../tunkClang/tools/clang/test/CodeGen/avx512f-builtins.c:1413-1414
@@ -1412,3 +1412,4 @@
// CHECK-LABEL: @test_mm512_mask_and_epi32
- // CHECK: @llvm.x86.avx512.mask.pand.d.512
+ // CHECK: and <16 x i32>
+ // CHECK: select <16 x
Author: mzuckerm
Date: Tue Jul 5 06:30:31 2016
New Revision: 274539
URL: http://llvm.org/viewvc/llvm-project?rev=274539&view=rev
Log:
ntrinsics _mm256_permutexvar_epi64 doesn't accept three parameters as specify
bellow.
I deleted the extra mask parameter.
__m256i _mm256_permutexvar_epi64 (__m25
Author: stulova
Date: Tue Jul 5 06:31:24 2016
New Revision: 274540
URL: http://llvm.org/viewvc/llvm-project?rev=274540&view=rev
Log:
[OpenCL] An implementation of device side enqueue (DSE) from OpenCL v2.0
s6.13.17.
- Added new Builtins: enqueue_kernel, get_kernel_work_group_size
and get_kernel
Author: abadouh
Date: Tue Jul 5 06:36:21 2016
New Revision: 274541
URL: http://llvm.org/viewvc/llvm-project?rev=274541&view=rev
Log:
[AVX512] minor fix in sqrt{ss|sd} intrinsics arguments
Differential Revision: http://reviews.llvm.org/D21988
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274541: [AVX512] minor fix in sqrt{ss|sd} intrinsics
arguments (authored by abadouh).
Changed prior to commit:
http://reviews.llvm.org/D21988?vs=62734&id=62735#toc
Repository:
rL LLVM
http://reviews
Anastasia created this revision.
Anastasia added reviewers: bader, yaxunl.
Anastasia added a subscriber: cfe-commits.
This change:
1. Changes diagnostics for Blocks to be implicitly const qualified OpenCL v2.0
s6.12.5.
2. Adds and unifies diagnostics of some OpenCL special types: blocks, images,
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
A few minor style comments.
Comment at: lib/Sema/SemaExpr.cpp:10806-10807
@@ -10816,4 +10805,4 @@
// the ATOMIC_VAR_INIT macro.
if (LHSExpr->getType()->isAtomicT
omtcyf0 marked 2 inline comments as done.
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:45
@@ +44,3 @@
+
+These checks don't have effect in C++:
+
At least that's what cppreference tells me.
http://reviews.llvm.org/D17990
___
It does because CC_OpenCLKernel case now uses CGM member.
Nikolay
From: Tom Stellard [t...@stellard.net]
Sent: Tuesday, July 05, 2016 3:47 AM
To: Haustov, Nikolay
Cc: cfe-commits@lists.llvm.org
Subject: Re: r274220 - AMDGPU: Set amdgpu_kernel calling conve
omtcyf0 updated this revision to Diff 62701.
omtcyf0 added a comment.
How it looks better now.
http://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/modernize-deprecated-headers-cxx03.c
Author: abadouh
Date: Tue Jul 5 07:24:14 2016
New Revision: 274542
URL: http://llvm.org/viewvc/llvm-project?rev=274542&view=rev
Log:
[X86][AVX512F] add float/double abs intrinsics
add abs intrinsics that use native LLVM-IR.
change _mm512_mask[z]_and_epi{32|64} to use select intrinsic
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274542: [X86][AVX512F] add float/double abs intrinsics
(authored by abadouh).
Changed prior to commit:
http://reviews.llvm.org/D21973?vs=62679&id=62737#toc
Repository:
rL LLVM
http://reviews.llvm.o
rmaprath created this revision.
rmaprath added reviewers: jroelofs, bcraig.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
These registers are only available on a limited set of ARM targets (those based
on XScale). Other targets should not have to pay the
erikjv added a comment.
ping?
http://reviews.llvm.org/D21176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv added a comment.
ping?
http://reviews.llvm.org/D15926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Tue Jul 5 07:59:33 2016
New Revision: 274544
URL: http://llvm.org/viewvc/llvm-project?rev=274544&view=rev
Log:
[X86][AVX512] Converted the VBROADCAST intrinsics to generic IR
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
cfe/trunk/lib/Headers/avx512fintrin.h
erikjv added a comment.
I'll add tests in the next diff, but I'd like to know if these changes are ok.
Comment at: lib/Sema/SemaType.cpp:1339
@@ +1338,3 @@
+auto R = DS.getSourceRange();
+if (R.getEnd().isInvalid())
+ R.setEnd(R.getBegin());
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:3249
@@ -3248,1 +3248,3 @@
+ /// This is true if this struct ends with an array marked 'flexible_array'.
+ bool HasFlexibleArrayAttr : 1;
Does this require a bit, or can this simply be l
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:436
@@ +435,3 @@
+ CXX11<"clang", "xray_never_instrument">];
+ let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag,
+ "ExpectedFunctionOr
erikjv updated the summary for this revision.
erikjv updated this revision to Diff 62748.
erikjv added a comment.
This version stores/loads the conditional stack in the preprocessor the the
generated pch file. It suppresses errors about unfinished conditional
preprocessor blocks, and after resto
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 62750.
http://reviews.llvm.org/D21936
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:234
@@ +233,3 @@
+};
+
+struct PositiveNonVirualMethod {
alexfh wrote:
> Please add a test for an override not explicitly marked "virtual" or
> "override".
That case is
aaron.ballman added a subscriber: aaron.ballman.
Comment at: include/clang/Basic/LangOptions.h:131
@@ +130,3 @@
+ /// input is a header file (i.e. -x c-header).
+ bool IsHeaderFile = false;
+
Should move the initializer to the constructor (not certain that MSVC
Author: flx
Date: Tue Jul 5 09:40:44 2016
New Revision: 274552
URL: http://llvm.org/viewvc/llvm-project?rev=274552&view=rev
Log:
[clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods
Summary:
As changing virtual methods could break method overrides disable applying the
fix an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274552: [clang-tidy] UnnecessaryValueParamCheck - only warn
for virtual methods (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D21936?vs=62750&id=62752#toc
Repository:
rL LLVM
h
Author: rksimon
Date: Tue Jul 5 09:49:31 2016
New Revision: 274554
URL: http://llvm.org/viewvc/llvm-project?rev=274554&view=rev
Log:
[X86][AVX512] Remove vector BROADCAST builtins.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.de
bcraig added inline comments.
Comment at: CMakeLists.txt:108
@@ -107,2 +107,3 @@
option(LIBUNWIND_ENABLE_CROSS_UNWINDING "Enable cross-platform unwinding
support." OFF)
+option(LIBUNWIND_ENABLE_ARM_WMMX "Enable unwinding support for ARM WMMX
registers." ON)
B
Prazek added a subscriber: Prazek.
Comment at: test/clang-tidy/misc-StdSwap.cpp:7-11
@@ +6,7 @@
+
+// FIXME: Add something that triggers the check here.
+// FIXME: Verify the applied fix.
+// * Make the CHECK patterns specific enough and try to make verified lines
+// unique
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Has this test case been missing from the original commit? If yes, could you
point to it please! Thanks!
http://reviews.llvm.org/D21295
Author: mzuckerm
Date: Tue Jul 5 10:56:03 2016
New Revision: 274559
URL: http://llvm.org/viewvc/llvm-project?rev=274559&view=rev
Log:
[Clang][Feature] Adding CLFLUSHOPT feature and intrinsic to clang
Differential Revision: http://reviews.llvm.org/D21792
Added:
cfe/trunk/lib/Headers/clflush
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274559: [Clang][Feature] Adding CLFLUSHOPT feature and
intrinsic to clang (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21792?vs=62088&id=62759#toc
Repository:
rL LLVM
ht
Author: bogner
Date: Tue Jul 5 11:06:12 2016
New Revision: 274560
URL: http://llvm.org/viewvc/llvm-project?rev=274560&view=rev
Log:
test: Use add_lit_testsuites so that subsets of tests can be specified
This creates make/ninja targets like check-clang-codegen and
check-clang-unit, much like LLVM
rmaprath added inline comments.
Comment at: CMakeLists.txt:108
@@ -107,2 +107,3 @@
option(LIBUNWIND_ENABLE_CROSS_UNWINDING "Enable cross-platform unwinding
support." OFF)
+option(LIBUNWIND_ENABLE_ARM_WMMX "Enable unwinding support for ARM WMMX
registers." ON)
Author: bogner
Date: Tue Jul 5 11:14:58 2016
New Revision: 274562
URL: http://llvm.org/viewvc/llvm-project?rev=274562&view=rev
Log:
Revert "test: Use add_lit_testsuites so that subsets of tests can be specified"
This reverts r274560. It's breaking a bunch of bots due to a directory
with a space
bcraig added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+// called during the loop.
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
The loop does
rmaprath added inline comments.
Comment at: CMakeLists.txt:108
@@ -107,2 +107,3 @@
option(LIBUNWIND_ENABLE_CROSS_UNWINDING "Enable cross-platform unwinding
support." OFF)
+option(LIBUNWIND_ENABLE_ARM_WMMX "Enable unwinding support for ARM WMMX
registers." ON)
m_zuckerman updated this revision to Diff 62766.
http://reviews.llvm.org/D21505
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
--- test/CodeGen/avx512f-builtins.c
++
bcraig added inline comments.
Comment at: CMakeLists.txt:131
@@ -130,2 +130,3 @@
option(LIBCXX_HAS_MUSL_LIBC "Build libc++ with support for the Musl C library"
OFF)
-option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread
API" OFF)
+option(LIBCXX_HAS_PTHRE
m_zuckerman updated this revision to Diff 62768.
http://reviews.llvm.org/D21505
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
--- test/CodeGen/avx512f-builtins.c
++
wolfgangp added a comment.
Ping...
http://reviews.llvm.org/D11360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a comment.
@theraven, do you have any other feedback? :)
http://reviews.llvm.org/D21329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bogner
Date: Tue Jul 5 12:54:40 2016
New Revision: 274565
URL: http://llvm.org/viewvc/llvm-project?rev=274565&view=rev
Log:
Re-apply "test: Use add_lit_testsuites so that subsets of tests can be
specified"
This version should actually remove the empty directories I removed
all of the fi
Author: epilk
Date: Tue Jul 5 12:57:24 2016
New Revision: 274566
URL: http://llvm.org/viewvc/llvm-project?rev=274566&view=rev
Log:
[Sema] Fix a bug where pack expansion was not expanded in type alias
The problem is that the parameter pack in a function type type alias is not
reexpanded after bei
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274566: [Sema] Fix a bug where pack expansion was not
expanded in type alias (authored by epilk).
Changed prior to commit:
http://reviews.llvm.org/D21030?vs=60908&id=62771#toc
Repository:
rL LLVM
ht
vmiklos added a comment.
Manuel, do you have an opinion on this, please?
http://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
We will add it. Thanks.
Sam
-Original Message-
From: Jan Vesely [mailto:jan.ves...@rutgers.edu]
Sent: Friday, July 1, 2016 4:59 PM
To: Shi, Aaron (en ye) ; anastasia.stul...@arm.com
Cc: jan.ves...@rutgers.edu; nhaus...@gmail.com; rich...@metafoo.co.uk;
alexey.ba...@intel.com; xiuli...@o
mehdi_amini added inline comments.
Comment at: include/clang/Basic/LangOptions.h:131
@@ +130,3 @@
+ /// input is a header file (i.e. -x c-header).
+ bool IsHeaderFile = false;
+
aaron.ballman wrote:
> Should move the initializer to the constructor (not certain t
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D21145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
Can we add tests for returning sampler, image and pipe type? Thanks.
http://reviews.llvm.org/D21989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl closed this revision.
yaxunl added a comment.
This patch was superseded by http://reviews.llvm.org/D20389
http://reviews.llvm.org/D20373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
tavianator added inline comments.
Comment at: src/cxa_thread_atexit.cpp:47
@@ +46,3 @@
+// called during the loop.
+if (pthread_setspecific(dtors, ptr) != 0) {
+ abort_message("pthread_setspecific() failed during thread_local
destruction");
bcraig wr
bcraig added inline comments.
Comment at: test/thread_local_destruction_order.pass.cpp:54
@@ +53,3 @@
+ std::thread{thread_fn}.join();
+
+ thread_local OrderChecker fn_thread_local{2};
tavianator wrote:
> bcraig wrote:
> > In the places where you can, validate t
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
http://reviews.llvm.org/D21992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
dim created this revision.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
Some cpuid bit defines are named slightly different from how gcc's cpuid.h
calls them.
Define a few more compatibility names to appease software built for gcc:
* `bit_PCLMUL` alias of `bit_PC
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Add missing includes, especially , to priority.queue/types.pass.cpp.
This is required according to the Standard, and it fixes compiler errors with
MSVC (as our headers don't u
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
bind's function call operator isn't guaranteed to SFINAE.
There's nothing in the Standard that specifies this, and MSVC's implementation
doesn't do it (we explode in a tuple b
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Follow LWG 2520 "N4089 broke initializing unique_ptr from a nullptr".
This library issue permits nullptr, but not 0 or NULL (which can be 0). In
null_ctor.pass.cpp, replace 0
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix a non-Standard allocator in vector.cons/construct_iter_iter_alloc.pass.cpp.
You gotta have a rebinding constructor. MSVC loves rebinding.
http://reviews.llvm.org/D22016
F
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Work around MSVC's non-Standard ABI for enums.
So this is definitely an MSVC bug, but one that's baked into our layout
behavior, so even Clang has to enable it unconditionally
AntonBikineev updated this revision to Diff 62790.
AntonBikineev added a comment.
@rsmith,
Thanks for the comments, I've addressed them (except for tests, they are to be
added asap). I'm especially not sure about changes in CFG.cpp, could you verify
please?
http://reviews.llvm.org/D21834
File
Author: kli
Date: Tue Jul 5 16:38:53 2016
New Revision: 274577
URL: http://llvm.org/viewvc/llvm-project?rev=274577&view=rev
Log:
[OpenMP] remove outdated comment (NFC)
Modified:
cfe/trunk/lib/Basic/OpenMPKinds.cpp
Modified: cfe/trunk/lib/Basic/OpenMPKinds.cpp
URL:
http://llvm.org/viewvc/ll
alexfh added a comment.
In http://reviews.llvm.org/D21472#473813, @JamesReynolds wrote:
> Ah, I took this from a single example in the CPP core guidelines - that PDF
> is indeed a very different style. An idea we toyed with was "UpperSeparated"
> and "UpperSeparatedBack"? Would that work?
You
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:614
@@ -610,1 +613,3 @@
+ SimplifyForwardingBlocks(CurBlock);
+ }
Document
Comment at: lib/CodeGen/CGStmt.cpp:633
@@ -626,1 +632,3 @@
+ if (CurBlock)
+Sim
manmanren added a subscriber: manmanren.
manmanren added a comment.
In http://reviews.llvm.org/D21295#474241, @Anastasia wrote:
> LGTM!
>
> Has this test case been missing from the original commit? If yes, could you
> point to it please! Thanks!
The original commit is the support for tbaa, whe
bruno added a comment.
In http://reviews.llvm.org/D21700#470103, @rnk wrote:
> After writing r266366, we discovered that GCC accepts none of the code in
> that test case, so we should consider turning -flax-vector-conversions off by
> default.
Makes sense, specially given the non obvious sema
bruno updated this revision to Diff 62802.
bruno added a comment.
Update patch after Reid's suggestions.
http://reviews.llvm.org/D21700
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
===
--
joelkevinjones updated this revision to Diff 62793.
joelkevinjones added a comment.
Herald added a subscriber: mehdi_amini.
Updated to ToT. Passes "make check-clang"
http://reviews.llvm.org/D16538
Files:
tools/driver/cc1as_main.cpp
Index: tools/driver/cc1as_main.cpp
=
deadalnix updated this revision to Diff 62791.
deadalnix added a comment.
rebase/ping
http://reviews.llvm.org/D21515
Files:
lib/CodeGen/CGExpr.cpp
Index: lib/CodeGen/CGExpr.cpp
===
--- lib/CodeGen/CGExpr.cpp
+++ lib/CodeGen/CGEx
compnerd added a subscriber: compnerd.
compnerd added a comment.
I don't think that clang nor LLVM have much in terms of support for XScale.
Can we do something more convoluted perhaps? I like the preprocessor based
approach. However, if the compiler doesn't define it with the correct target,
faisalv updated the summary for this revision.
faisalv updated this revision to Diff 62814.
faisalv added a comment.
Mark the lambda's conversion to function-pointer as incontrovertibly constexpr.
auto L = [](auto a) { return a; };
constexpr int* (*fp)(int*) = L; // This is now allowed.
Instead
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
carlo.bertolli updated this revision to Diff 62817.
carlo.bertolli added a comment.
[OpenMP] Remove private variable creation from this patch as requested by
comments and rebase.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:4221
@@ +4220,3 @@
+
+/// \brief This represents clause 'use_device_ptr' in the '#pragma omp ...'
+/// directives.
No \brief's
Comment at: include/clang/Basic/DiagnosticS
Author: vedantk
Date: Tue Jul 5 22:08:47 2016
New Revision: 274599
URL: http://llvm.org/viewvc/llvm-project?rev=274599&view=rev
Log:
Delete some dead code, NFC
Found using clang's code coverage tool.
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/Cov
Author: ctopper
Date: Tue Jul 5 22:25:17 2016
New Revision: 274600
URL: http://llvm.org/viewvc/llvm-project?rev=274600&view=rev
Log:
[AVX512] The 128 and 256-bit vplzcnt builtins require avx512cd in addition to
avx512vl.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Modified: cfe
Author: majnemer
Date: Tue Jul 5 23:19:16 2016
New Revision: 274601
URL: http://llvm.org/viewvc/llvm-project?rev=274601&view=rev
Log:
[AST] Use ArrayRef in more interfaces
ArrayRef is a little better than passing around a pointer/length pair.
No functional change is intended.
Modified:
cfe
Author: ctopper
Date: Tue Jul 5 23:24:29 2016
New Revision: 274603
URL: http://llvm.org/viewvc/llvm-project?rev=274603&view=rev
Log:
[AVX512] Use the generic ctlz intrinsic to implement the vplzcntd/q builtins.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGen/avx512cd
Author: marshall
Date: Wed Jul 6 00:28:44 2016
New Revision: 274605
URL: http://llvm.org/viewvc/llvm-project?rev=274605&view=rev
Log:
Fix typo in #ifdef, and re-enable tests now that the green-dragon bots are no
more
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop
dberris marked 2 inline comments as done.
Comment at: include/clang/Basic/Attr.td:436
@@ +435,3 @@
+ CXX11<"clang", "xray_never_instrument">];
+ let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag,
+ "ExpectedFunct
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Landed as r274605
http://reviews.llvm.org/D21349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
dberris updated this revision to Diff 62824.
dberris marked an inline comment as done.
dberris added a comment.
- Formatting changes
http://reviews.llvm.org/D20352
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/C
Author: ctopper
Date: Wed Jul 6 01:27:31 2016
New Revision: 274608
URL: http://llvm.org/viewvc/llvm-project?rev=274608&view=rev
Log:
[X86] Use native IR for immediate values 0-7 of packed fp cmp builtins. This
makes them the same as what is done when using the SSE builtins for these same
encodi
92 matches
Mail list logo