Re: [cfe-dev] RFC: Default language standard mode policy

On Wed, Jun 29, 2016 at 03:07:33PM -0700, Richard Smith wrote: > On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote: > > > Hi all! > > > > > > I'd like to establi

r274185 - [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

Author: sivachandra Date: Wed Jun 29 17:38:59 2016 New Revision: 274185 URL: http://llvm.org/viewvc/llvm-project?rev=274185&view=rev Log: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::". Reviewers: rsmith, saugustine, rnk Subscribers: klimek, cfe-commits Differential Re

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Thanks for the review; Committed. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21867: [CUDA] Add utility functions for dealing with CUDA versions / architectures.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Currently our handling of CUDA architectures is scattered all around clang. This patch centralizes it. A key advantage of this centralization is that you can now write a C++ switch on e.g. CudaArc

[PATCH] D21869: [CUDA] Check that our CUDA install supports the requested architectures.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Raise an error if you're using a CUDA installation that's too old for the requested architectures. In practice, this means that you need a CUDA 8 install to compile for sm_6*. http://reviews.llvm.

[PATCH] D21868: [CUDA] Rename member variables in CudaInstallationDetector.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Remove the "Cuda" prefix from these variables -- it's clear that they related to CUDA given their containing type. http://reviews.llvm.org/D21868 Files: lib/Driver/ToolChains.cpp lib/Driver/To

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

dimitry added a subscriber: dimitry. Comment at: src/cxa_thread_atexit.cpp:46 @@ +45,3 @@ + pthread_key_delete(key_); +} + run_dtors() is called when/if libc++.so gets unloaded... but only for the thread calling dlclose()? http://reviews.llvm.org/D2180

[PATCH] D21870: [libcxx] [test] Avoid applying unary minus to unsigned integers.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid applying unary minus to unsigned integers. This is confusing because first you have to remember what unsigned negation does, then you have to worry about the usual arith

[PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make vector.bool/construct_default.pass.cpp more portable. vector's default ctor and allocator ctor aren't depicted as noexcept in the Working Paper. We're already directly in

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 62305. pirama added a comment. Added GroupInfo to warning. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cp

[PATCH] D21872: [libcxx] [test] Fix unary_function inheritance assumption.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix unary_function inheritance assumption. C++11 didn't require std::hash to derive from std::unary_function. The portable thing to do is to inspect the typedefs, as the other

[PATCH] D21874: [libcxx] [test] std::array's iterators aren't guaranteed to be pointers.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. std::array's iterators aren't guaranteed to be pointers. Include test_macros.h and mark these static_asserts as libcxx-specific. http://reviews.llvm.org/D21874 Files: test/

[PATCH] D21875: [libcxx] [test] The Standard requires meow_insert_iterator::reference to be void.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. The Standard requires meow_insert_iterator::reference to be void. This is a libcxx product and test bug, since the type is observable. Mark these static_asserts as libcxx-spec

[PATCH] D21876: [libcxx] [test] Make istreambuf.iterator/types.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make istreambuf.iterator/types.pass.cpp more portable. There are two issues here. First, istreambuf_iterator::pointer is unspecified (and MSVC uses a different type). Second,

[PATCH] D21877: [libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. is_swappable_include_order.pass.cpp was using a terse static_assert. As before, this unnecessarily limits compatibility with MSVC and old versions of GCC. http://reviews.llvm

[PATCH] D21878: [libcxx] [test] Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable. future_errc.pass.cpp was assuming specific values, which aren't guaranteed by the Standard, and M

[PATCH] D21879: [libcxx] [test] Fix MSVC "warning C4100: 'argv': unreferenced formal parameter".

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix MSVC "warning C4100: 'argv': unreferenced formal parameter". http://reviews.llvm.org/D21879 Files: test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev added a comment. @rsmith, > This is not correct; TryParseSimpleDeclaration usually stops long before it > reaches the end of the simple-declaration, so this will give false negatives > in lots of cases. Yes, I noticed that, that's why I changed use of TryParseSimpleDeclaration t

r274190 - Use the same type for adjacent bit field members.

Author: ahatanak Date: Wed Jun 29 19:07:17 2016 New Revision: 274190 URL: http://llvm.org/viewvc/llvm-project?rev=274190&view=rev Log: Use the same type for adjacent bit field members. MSVC doesn't pack the bit field members if different types are used. This came up in a patch review. http://lis

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 62317. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/Stmt.cpp lib/Analysis/BodyFarm.cpp lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmt.cpp lib/Sema/TreeTransform.h li

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

On Wed, Jun 29, 2016, 17:43 Joerg Sonnenberger wrote: > On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits > wrote: > > We need to benchmark this to see if it still makes a difference. > > > > My canonical test is the .s of a lto of clang. > > That won't exercise it? Assem

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

dberris added a comment. Changed the description to provide a justification. http://reviews.llvm.org/D21830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 62320. http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/Stmt.cpp lib/Analysis/BodyFarm.cpp lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmt.cpp lib/Sema/TreeTransform.h li

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

AntonBikineev updated this revision to Diff 62321. AntonBikineev added a comment. Test Parser/cxx1z-init-statement.cpp has been updated according to Sema changes http://reviews.llvm.org/D21834 Files: include/clang/AST/Stmt.h include/clang/Sema/Sema.h lib/AST/ASTImporter.cpp lib/AST/Stmt

RE: RFC: Default language standard mode policy

Hi all, > > It may be feasible for us to use a "-std=gnu++latest" behavior and not have > to have a PS4-specific default; CC'ing Warren and Paul. As Sean pointed out, he did some tests and found we'd need to enable the GNU keywords on PS4. Having a PS4-specific patch for this wouldn't be a probl

Re: [PATCH] D21773: [clang] Update an optimization remark test for change D18777

lihuang added a comment. You are right. A regression test could be: void foo2(int *dw, int *uw, int *A, int *B, int *C, int *D, int N) { for (int i = 0; i < N; i++) { dw[i] = A[i] + B[i - 1] + C[i - 2]; uw[i] = A[i] + B[i + 2]; } } need to fix the fundamental problem. h

[PATCH] D21863: Fix typo in atomic macros

zmahler created this revision. zmahler added a reviewer: hfinkel. zmahler added a subscriber: cfe-commits. Some of the macros should be defined without the extra "_T_". Fix https://llvm.org/bugs/show_bug.cgi?id=27200 http://reviews.llvm.org/D21863 Files: lib/Headers/stdatomic.h Index: lib/Hea

Re: r274064 - AvailabilityAttr: we accept "macos" as the platform name.

On Wed, Jun 29, 2016 at 11:57 AM, Manman Ren wrote: > Good point! In r274133. Thank you! ~Aaron > > Manman > > On Wed, Jun 29, 2016 at 7:30 AM, Aaron Ballman > wrote: >> >> On Tue, Jun 28, 2016 at 4:55 PM, Manman Ren via cfe-commits >> wrote: >> > Author: mren >> > Date: Tue Jun 28 15:55:30 2

Re: [PATCH] D21860: [ASTMatcher] Add a node matcher for EnumType.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D21860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D21841: [OpenMP] Use fopenmp prefix for all options introduced by the offloading implementation.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D21841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

ABataev added inline comments. Comment at: lib/Driver/Driver.cpp:464-468 @@ +463,7 @@ + RuntimeName = A->getValue(); +HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName) + .Case("libomp", true) +

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

ABataev added a comment. General comment: remove '\brief' tags, they are not required anymore, just '\\\' is enough Comment at: include/clang/Driver/Action.h:94 @@ -93,1 +93,3 @@ + /// \brief Flag that is set to true if this action can be collapsed with + /// others actions

r274202 - [MS ABI] Pick an inheritance model if we resolve an overload set

Author: majnemer Date: Wed Jun 29 22:02:03 2016 New Revision: 274202 URL: http://llvm.org/viewvc/llvm-project?rev=274202&view=rev Log: [MS ABI] Pick an inheritance model if we resolve an overload set We didn't assign an inheritance model for 'Foo' if the event an exrepssion like '&Foo::Bar' occur

r274201 - [CodeView] Implement support for bitfields in Clang

Author: majnemer Date: Wed Jun 29 22:01:59 2016 New Revision: 274201 URL: http://llvm.org/viewvc/llvm-project?rev=274201&view=rev Log: [CodeView] Implement support for bitfields in Clang Emit the underlying storage offset in addition to the starting bit position of the field. This fixes PR28162.

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL274201: [CodeView] Implement support for bitfields in Clang (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D21783?vs=62095&id=62333#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

ABataev added inline comments. Comment at: include/clang/Driver/Action.h:158 @@ -157,1 +157,3 @@ std::string getOffloadingFileNamePrefix(StringRef NormalizedTriple) const; + /// \brief Return a string containing a offload kind name. + static std::string getOffloadKindName(Off

Re: [PATCH] D21863: Fix typo in atomic macros

majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21863 ___ cfe-commits mailing list

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

ABataev added a comment. Remove '\brief' Comment at: include/clang/Driver/Action.h:158-160 @@ -158,1 +157,5 @@ + /// non-device kinds, except if \a CreatePrefixForHost is set. + static std::string + getOffloadingFileNamePrefix(OffloadKind Kind, StringRef NormalizedTriple, +

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

ABataev added inline comments. Comment at: include/clang/Driver/Action.h:493 @@ -491,1 +492,3 @@ +class OffloadUnbundlingJobAction : public JobAction { + void anchor() override; 'final'? Comment at: include/clang/Driver/Action.h:499 @@ +498,3

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

ABataev added inline comments. Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:324-334 @@ -314,1 +323,13 @@ +// Handler for object files. The bundles are organized by sections with a +// designated name. +// +// In order to bundle we create an IR file with the co

Re: [PATCH] D21836: [AVX512][BUILTIN][vpermilps][intrinsics] Fixing two incorrect IMM check.

craig.topper added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1568 @@ -1569,1 +1567,3 @@ + case X86::BI__builtin_ia32_vpermilps_mask: + case X86::BI__builtin_ia32_vpermilps256_mask: i = 1; l = 0; u = 255; Can you put these adjacent to vpermilps5

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

ABataev added inline comments. Comment at: include/clang/Driver/Compilation.h:73 @@ +72,3 @@ + /// architecture, and device offload kind. + struct TCArgsKey { +const ToolChain *TC; 1. 'final' 2. default initializers for fields. Comment at:

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

ABataev added a comment. Remove empty 'return' and ';' statements where they are not required. Comment at: test/Driver/clang-offload-bundler.c:14 @@ +13,3 @@ +// +// RUN: touch %t.empty + Hmm, will it work on Windows? Maybe it is better just to add an empty test

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

ABataev added inline comments. Comment at: lib/Driver/Tools.cpp:297 @@ +296,3 @@ + StringRef Name = llvm::sys::path::filename(Output.getFilename()); + StringRef Prefix = Name.rsplit('.').first; + if (C.getDriver().isSaveTempsEnabled()) { Use llvm::sys::path::re

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

ABataev added inline comments. Comment at: lib/Driver/Driver.cpp:1778 @@ +1777,3 @@ + /// phase. + class OpenMPActionBuilder : public DeviceActionBuilder { +/// \brief The OpenMP actions for the current input. 'final' http://reviews.llvm.org/D21845

[libcxx] r274203 - Avoid applying unary minus to unsigned integers. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:21:52 2016 New Revision: 274203 URL: http://llvm.org/viewvc/llvm-project?rev=274203&view=rev Log: Avoid applying unary minus to unsigned integers. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp libcxx/

Re: [PATCH] D21870: [libcxx] [test] Avoid applying unary minus to unsigned integers.

EricWF closed this revision. EricWF added a comment. r274203. http://reviews.llvm.org/D21870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274204 - Fix unreferenced parameter warning. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:22:58 2016 New Revision: 274204 URL: http://llvm.org/viewvc/llvm-project?rev=274204&view=rev Log: Fix unreferenced parameter warning. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.

Re: [PATCH] D21879: [libcxx] [test] Fix MSVC "warning C4100: 'argv': unreferenced formal parameter".

EricWF closed this revision. EricWF added a comment. r274204. http://reviews.llvm.org/D21879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

ABataev added a comment. No '\brief's Comment at: lib/Driver/Driver.cpp:1393 @@ +1392,3 @@ +/// generate the required device actions. +class OffloadingActionBuilder { + /// \brief Flag used to trace errors in the builder. 1. 'final' 2. default initializers for

RE: RFC: Default language standard mode policy

What Warren said. We've been carrying the private patch for 4 years or so, and now that we're getting the test changes upstream it will be progressively less of a problem for us. (And thanks Sean for actually trying it on a couple of titles! You read my mind.) I also wanted to add that I agr

Re: [PATCH] D21871: [libcxx] [test] Make vector.bool/construct_default.pass.cpp more portable.

EricWF added a comment. The fact that they are not noexcept in the working paper seems like an oversight. Is there a reason your vector default constructor can't be noexcept? http://reviews.llvm.org/D21871 ___ cfe-commits mailing list cfe-commits@

[libcxx] r274205 - Fix unary_function inheritance assumption. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:28:12 2016 New Revision: 274205 URL: http://llvm.org/viewvc/llvm-project?rev=274205&view=rev Log: Fix unary_function inheritance assumption. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/vector_bool.pass.cpp

Re: [PATCH] D21872: [libcxx] [test] Fix unary_function inheritance assumption.

EricWF closed this revision. EricWF added a comment. r274205. http://reviews.llvm.org/D21872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274206 - Fix use of terse static assert. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:29:12 2016 New Revision: 274206 URL: http://llvm.org/viewvc/llvm-project?rev=274206&view=rev Log: Fix use of terse static assert. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_swappable_include_or

Re: [PATCH] D21877: [libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert.

EricWF closed this revision. EricWF added a comment. r274206. http://reviews.llvm.org/D21877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274207 - Make instreambuf.iterator/types.pass.cpp more portable.

Author: ericwf Date: Wed Jun 29 23:31:09 2016 New Revision: 274207 URL: http://llvm.org/viewvc/llvm-project?rev=274207&view=rev Log: Make instreambuf.iterator/types.pass.cpp more portable. Modified: libcxx/trunk/test/std/iterators/stream.iterators/istreambuf.iterator/types.pass.cpp Modified

Re: [PATCH] D21876: [libcxx] [test] Make istreambuf.iterator/types.pass.cpp more portable.

EricWF closed this revision. EricWF added a comment. r274207. http://reviews.llvm.org/D21876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

ABataev added a comment. No '\brief's Comment at: include/clang/Driver/Action.h:204 @@ -159,1 +203,3 @@ +/// kind to its dependences. +class OffloadAction : public Action { virtual void anchor(); 'final' Comment at: include/clang/Driver/Acti

[libcxx] r274209 - Fix ::reference typedef in insert iterators.

Author: ericwf Date: Wed Jun 29 23:40:50 2016 New Revision: 274209 URL: http://llvm.org/viewvc/llvm-project?rev=274209&view=rev Log: Fix ::reference typedef in insert iterators. Since at least the C++11 standard insert iterators are specified as having ::reference typedef void. Libc++ was not doi

Re: [PATCH] D21875: [libcxx] [test] The Standard requires meow_insert_iterator::reference to be void.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I fixed both the libc++ implementation and tests in r274209. http://reviews.llvm.org/D21875 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[libcxx] r274210 - Make std::array typedef tests more portable.

Author: ericwf Date: Wed Jun 29 23:54:00 2016 New Revision: 274210 URL: http://llvm.org/viewvc/llvm-project?rev=274210&view=rev Log: Make std::array typedef tests more portable. Modified: libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp Modified: libcxx/trunk/test/std/containe

Re: [PATCH] D21874: [libcxx] [test] std::array's iterators aren't guaranteed to be pointers.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I committed a similar change in r274210. It changes the asserts to LIBCPP_STATIC_ASSERT but it also adds additional tests that the iterators provide the correct typedefs and tags. http://rev

[libcxx] r274211 - Make futures.overview enum tests more portable. Patch from s...@microsoft.com

Author: ericwf Date: Thu Jun 30 00:00:32 2016 New Revision: 274211 URL: http://llvm.org/viewvc/llvm-project?rev=274211&view=rev Log: Make futures.overview enum tests more portable. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/thread/futures/futures.overview/future_errc.pass.c

Re: [PATCH] D21878: [libcxx] [test] Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable.

EricWF closed this revision. EricWF added a comment. r274211. http://reviews.llvm.org/D21878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274212 - [cmake] Remove stale comment. NFC.

Author: mgottesman Date: Thu Jun 30 00:51:18 2016 New Revision: 274212 URL: http://llvm.org/viewvc/llvm-project?rev=274212&view=rev Log: [cmake] Remove stale comment. NFC. Modified: cfe/trunk/cmake/modules/ClangConfig.cmake.in Modified: cfe/trunk/cmake/modules/ClangConfig.cmake.in URL: http

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I benchmarked the change against different key types and: 1. The change doesn't have a large detrimental impact when the key equality is as expensive as hash equality. I benchmarked std:

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. C++03 does not support default member initializers but libc++ provides both of these classes an extensions in C++03. C++03 also does not support defaulted special members. I think th

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please make the changes in the above comment. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

<    1   2