This revision was automatically updated to reflect the committed changes.
Closed by commit rL273997: [Driver] Add method to redirect output of
Compilation. (authored by nhaustov).
Changed prior to commit:
http://reviews.llvm.org/D21224?vs=60333&id=62066#toc
Repository:
rL LLVM
http://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274001: [clang-tidy] boost-use-to-string arg expr location
bugfix (authored by Prazek).
Changed prior to commit:
http://reviews.llvm.org/D21642?vs=61665&id=62069#toc
Repository:
rL LLVM
http://revie
Author: prazek
Date: Tue Jun 28 03:16:20 2016
New Revision: 274001
URL: http://llvm.org/viewvc/llvm-project?rev=274001&view=rev
Log:
[clang-tidy] boost-use-to-string arg expr location bugfix
Summary: getExprLoc returns location after dot for member call.
Reviewers: alexfh, sbenza, hokein
Subscr
bmharper added a comment.
Friendly PING.
Please let me know if there's anything else that I need to do here,
otherwise I'll keep quiet and expect a merge at some point?
Repository:
rL LLVM
http://reviews.llvm.org/D21279
___
cfe-commits mailing l
djasper added a comment.
Sorry.. Really busy at the moment, but will try to get this reviewed and
submitted this week. If not, please ping again!
Repository:
rL LLVM
http://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.l
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added subscribers: hokein, cfe-commits.
this enables us to map a group of headers to one header name,
e.g. headers from one directory can be mapped to the same header.
http://reviews.llvm.org/D21787
Files:
include-fixer/fin
ioeric marked 3 inline comments as done.
ioeric added a comment.
Friendly ping
http://reviews.llvm.org/D21601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Ping.
The problem i'm fixing here is how we recover invalid code in the ctor-init
part as we skip the function body.
In particular, we want to know if the '{' is the begining of the body or not.
In C++03, we always consider it as the beginng of the body. The problem
alexfh added inline comments.
Comment at: test/clang-tidy/boost-use-to-string.cpp:154
@@ +153,3 @@
+ float floating;
+ Fields* wierd;
+ const int &getConstInteger() const {return integer;}
alexfh wrote:
> "wierd" is weird ;)
I should have been more clear in the
djasper added a comment.
Sorry, I completely forgot about this. Will try to review today. Is this part
about the patch description accurate?
"This version only fixes the first discovered unidentified symbol.
In the long run, include-fixer should fix all unidentified symbols
with a same name at o
aaboud added a comment.
Looks good, one minor comments below.
Comment at: lib/CodeGen/CGDebugInfo.h:243
@@ +242,3 @@
+ llvm::DIScope *RecordTy,
+ const RecordDecl *RD, SourceLocation Loc);
+
You
Prazek added a comment.
In http://reviews.llvm.org/D21507#465733, @sanjoy wrote:
> One other thing to point out -- have you verified that the changes in
> `unittests/` are benign (i.e. you're not semantically changing the tests)?
Yes I do.
Repository:
rL LLVM
http://reviews.llvm.org/D2150
hokein added a comment.
In http://reviews.llvm.org/D21603#468717, @djasper wrote:
> Sorry, I completely forgot about this. Will try to review today. Is this part
> about the patch description accurate?
Yes, the description is accurate.
> Specifically, what needs to be implemented in vim to ma
vmiklos added a comment.
Something related: currently in case multiple symbols is to be renamed in the
same translation unit, clang-rename has to be invoked multiple times. This is
problematic from a performance point of view, in case the symbols are in common
headers of a codebase (and clang-r
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D21790
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/CMakeLists.txt
lib/Headers/immintrin.h
Index: lib/Headers/immintrin.
Author: sbenza
Date: Tue Jun 28 09:08:56 2016
New Revision: 274015
URL: http://llvm.org/viewvc/llvm-project?rev=274015&view=rev
Log:
[ASTMatchers] Add isLambda() matcher.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
cfe/trunk/
Author: marshall
Date: Tue Jun 28 09:11:54 2016
New Revision: 274016
URL: http://llvm.org/viewvc/llvm-project?rev=274016&view=rev
Log:
Updated C++1Z status page with new work from Oulu WG21 meeting
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
Author: marshall
Date: Tue Jun 28 09:13:28 2016
New Revision: 274018
URL: http://llvm.org/viewvc/llvm-project?rev=274018&view=rev
Log:
Use WG21.link reflector to get to issues, rather than linking directly
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.h
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D21792
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/CMakeLists.txt
lib/Headers/clflushoptintrin.h
lib/Headers/immintrin
Author: sbenza
Date: Tue Jun 28 09:19:41 2016
New Revision: 274019
URL: http://llvm.org/viewvc/llvm-project?rev=274019&view=rev
Log:
[clang-tidy] Do not match on lambdas.
We match on the generated FunctionDecl of the lambda and try to fix it.
This causes a crash.
The right behavior is to ignore l
klimek added inline comments.
Comment at: lib/Sema/SemaType.cpp:1339
@@ +1338,3 @@
+auto R = DS.getSourceRange();
+if (R.getEnd().isInvalid())
+ R.setEnd(R.getBegin());
Do you know in which cases we get source ranges that are half valid?
mehdi_amini added a comment.
Why was it closed? Was it committed? It'd be nice to have a comment with the
closing action.
Repository:
rL LLVM
http://reviews.llvm.org/D21277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/CodeGen/CodeGenFunction.cpp:535
@@ -531,3 +534,3 @@
if (isPipe)
-baseTypeName =
-
cast(ty)->getElementType().getCanonicalT
mehdi_amini requested changes to this revision.
mehdi_amini added a comment.
This revision now requires changes to proceed.
Missing test.
Repository:
rL LLVM
http://reviews.llvm.org/D21737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
mehdi_amini added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:459
@@ -456,2 +458,3 @@
legacy::FunctionPassManager *FPM = getPerFunctionPasses();
+ FPM->add(new TargetLibraryInfoWrapperPass(*TLII));
if (CodeGenOpts.VerifyModule)
It is not super
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added subscribers: cfe-commits, pxli168, pekka.jaaskelainen.
http://reviews.llvm.org/D21795
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
=
majnemer updated this revision to Diff 62095.
majnemer added a comment.
- Address review comments
http://reviews.llvm.org/D21783
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGen/debug-info-packed-struct.c
test/CodeGenCXX/debug-info-ms-bitfields.cpp
Index: test/
cameron314 added a comment.
Anyone have a few minutes to look at this?
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
Okay, thanks! I'll add the assert in.
@rsmith: Any thoughts on this?
http://reviews.llvm.org/D21145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
+Tom who does the "dot" releases.
I don't know if he's planning for a 3.8.2, but just in case, I suppose
it's on the radar now :-)
Thanks,
Hans
On Mon, Jun 27, 2016 at 11:21 PM, George Burgess IV
wrote:
> +Richard, Hans
>
> This patch fixes a crash that's also present in Clang 3.8. So, I think
bader updated this revision to Diff 62100.
bader added a comment.
Re-format the patch.
No functional changes.
http://reviews.llvm.org/D21744
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/pipe_types.cl
Index: test/CodeGenOpenCL/pipe_types.cl
=
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D21795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Anastasia added inline comments.
Comment at: lib/Basic/Targets.cpp:2122
@@ +2121,3 @@
+
+
+ CallingConvCheckResult checkCallingConvention(CallingConv CC) const override
{
One extra line?
http://reviews.llvm.org/D21367
_
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D21799
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
Author: cbieneman
Date: Tue Jun 28 11:32:48 2016
New Revision: 274031
URL: http://llvm.org/viewvc/llvm-project?rev=274031&view=rev
Log:
[CMake] [Apple Clang] Enable Compiler-RT tests on stage2 builds
We want to be able to run the compiler-rt tests on stage2 build configurations
in CI. This shoul
sivachandra added a comment.
Ping.
http://reviews.llvm.org/D21666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cbieneman
Date: Tue Jun 28 12:00:49 2016
New Revision: 274035
URL: http://llvm.org/viewvc/llvm-project?rev=274035&view=rev
Log:
[CMake] Pass LLVM_LIT_ARGS into compiler-rt build.
If top-level lit args are specified, you probably want that in the sub-project
too.
Modified:
cfe/trunk/
ahatanak added a comment.
I think you are right. There are other places that need to be fixed to properly
support over-allocated structures. I'll see if I can come up with a patch that
treats the over-allocated array as flexible array member.
http://reviews.llvm.org/D21453
_
bruno added a comment.
Ping!
http://reviews.llvm.org/D21700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Cool, thanks! LGTM
http://reviews.llvm.org/D21641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: cbieneman
Date: Tue Jun 28 13:32:22 2016
New Revision: 274045
URL: http://llvm.org/viewvc/llvm-project?rev=274045&view=rev
Log:
[CMake] Connect check-compiler-rt to check-all
When using the LLVM_BUILD_EXTERNAL_COMPILER_RT option with
LLVM_ENABLE_TESTS we should also bind check-compiler-rt
jlebar created this revision.
jlebar added a reviewer: chandlerc.
jlebar added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This test was stat()'ing large swaths of /usr/lib hundreds of times, as
every invocation of matchesConditionally*() created a new Linux
toolchain.
In additi
aaboud accepted this revision.
aaboud added a comment.
This revision is now accepted and ready to land.
LGTM.
Please update PR28162.
http://reviews.llvm.org/D21783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: rsmith
Date: Tue Jun 28 14:09:30 2016
New Revision: 274050
URL: http://llvm.org/viewvc/llvm-project?rev=274050&view=rev
Log:
Fix unreasonably-precise CHECK.
Modified:
cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp
Modified: cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp
U
klimek added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:77
@@ +76,3 @@
+ // Some tests need rtti/exceptions on. Use an unknown-unknown triple so we
+ // don't instantiate the full system toolchain. On Linux, instantiting the
+ // toolchain involves s
Hello everyone,
Below are some buildbot numbers for the last week of 6/19/2016 - 6/25/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
yaxunl added a comment.
> Maybe we can use the fact that calling conventions are separate in AST and in
> LLVM IR. So in AST maybe we can have opencl_kernel and in LLVM it can map to
> spir_kernel for SPIR and amdgpu_kernel for AMDGPU.
This approach looks good to me. Thanks.
http://reviews
jlebar added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83
@@ +80,5 @@
+ //
+ // FIXME: This is a hack to work around the fact that there's no way to do
the
+ // equivalent of runToolOnCodeWithArgs without instantiating a full Driver.
+ // We shou
chandlerc added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83
@@ +80,5 @@
+ //
+ // FIXME: This is a hack to work around the fact that there's no way to do
the
+ // equivalent of runToolOnCodeWithArgs without instantiating a full Driver.
+ // We s
jlebar updated this revision to Diff 62132.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Fix typo in comment.
http://reviews.llvm.org/D21810
Files:
unittests/ASTMatchers/ASTMatchersTest.h
Index: unittests/ASTMatchers/ASTMatchersTest.h
=
vmiklos created this revision.
vmiklos added a reviewer: klimek.
vmiklos added a subscriber: cfe-commits.
This way parsing the source input multiple times for multiple renames can be
avoided.
http://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Add 'included from' details to warning message to
google-global-names-in-headers.
It should make it clearer on those cases where a non-header is being mistakenly
#included.
http://reviews.llvm
Author: cbieneman
Date: Tue Jun 28 15:30:52 2016
New Revision: 274056
URL: http://llvm.org/viewvc/llvm-project?rev=274056&view=rev
Log:
[CMake] Adding USES_TERMINAL to a few additional custom targets
These are all long-running commands that should be in the ninja console job
pool.
Modified:
Author: rsmith
Date: Tue Jun 28 15:35:53 2016
New Revision: 274058
URL: http://llvm.org/viewvc/llvm-project?rev=274058&view=rev
Log:
Update cxx_dr_status from test/CXX/drs.
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.org/viewvc/llvm
Author: rsmith
Date: Tue Jun 28 15:37:00 2016
New Revision: 274059
URL: http://llvm.org/viewvc/llvm-project?rev=274059&view=rev
Log:
cxx_status: fix footnote for p0136.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/c
Author: rsmith
Date: Tue Jun 28 15:37:43 2016
New Revision: 274060
URL: http://llvm.org/viewvc/llvm-project?rev=274060&view=rev
Log:
cxx_status: make c++17 footnote list formatting consistent with other footnote
lists.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_stat
Author: mren
Date: Tue Jun 28 15:55:30 2016
New Revision: 274064
URL: http://llvm.org/viewvc/llvm-project?rev=274064&view=rev
Log:
AvailabilityAttr: we accept "macos" as the platform name.
We continue accepting "macosx" but canonicalize it to "macos", When emitting
diagnostics, we use "macOS" ins
rsmith added a comment.
Thank you for working on this! Please also add a test to
test/CXX/drs/dr15xx.cpp with a "// dr1579: 3.9" comment (we have a script that
turns those comments into www/cxx_dr_status.html).
Comment at: include/clang/Sema/Sema.h:3473
@@ -3472,3 +3472,3 @@
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please also add the testcase from PR27601.
http://reviews.llvm.org/D21653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
On Thu, Jun 23, 2016 at 10:37 AM, Erik Pilkington via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> erik.pilkington created this revision.
> erik.pilkington added reviewers: rsmith, faisalv.
> erik.pilkington added a subscriber: cfe-commits.
>
> Previously, Clang would incorrectly accept the
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This seems fine to me.
http://reviews.llvm.org/D21501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
erik.pilkington added a comment.
Do you mean Faisal's example? He committed that in r270016.
Thanks for taking a look!
http://reviews.llvm.org/D21653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rengolin added a comment.
Sorry, this was committed and reverted (bugs, being fixed by
http://reviews.llvm.org/D21785). We should start a new one when that's in.
Ignore this one. :)
Repository:
rL LLVM
http://reviews.llvm.org/D21277
___
cfe-com
rengolin reopened this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Reopening, as this is the right patch.
This patch is approved, waiting on http://reviews.llvm.org/D21785, which fixes
the issue that made us revert http://reviews.llvm.org/D20088 in the fi
etienneb added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:27
@@ -25,1 +26,3 @@
+static bool incrementWithoutOverflow(const llvm::APSInt &Value,
+ llvm::APSInt &Result) {
aaron.ballman wrote:
> I
Author: apilipenko
Date: Tue Jun 28 12:56:29 2016
New Revision: 274041
URL: http://llvm.org/viewvc/llvm-project?rev=274041&view=rev
Log:
NFC. Test commit, remove a redundant empty line in Tooling.cpp
Modified:
cfe/trunk/lib/Tooling/Tooling.cpp
Modified: cfe/trunk/lib/Tooling/Tooling.cpp
URL:
Sorry. I did enter a commit message. I’ve no idea why it’s not there. I’ll
re-commit later today.
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: 28 June 2016 01:12
To: Chris.Dewhurst
Cc: cfe-commits
Subject: Re: r273950 -
Did you land this intentionally? What
Author: nhaustov
Date: Tue Jun 28 03:00:42 2016
New Revision: 273997
URL: http://llvm.org/viewvc/llvm-project?rev=273997&view=rev
Log:
[Driver] Add method to redirect output of Compilation.
Summary:
Currently output of child process, however in my use case, it
needs to be captured and presented t
rsmith added a comment.
Thank you! I'm happy with this implementation (other than some data structure
improvements), and cxx-abi-dev discussion seems to be settling on this approach
(mangling the return type / variable type to extract attributes) being the
right one.
(Minor nit: please make su
Author: apilipenko
Date: Tue Jun 28 13:28:45 2016
New Revision: 274044
URL: http://llvm.org/viewvc/llvm-project?rev=274044&view=rev
Log:
Update the expected masked load/store intrinsics names in tests
The mangling of their names was changed in order to support arbitrary addrspace
pointers as arg
Author: lerochris
Date: Tue Jun 28 07:55:55 2016
New Revision: 274012
URL: http://llvm.org/viewvc/llvm-project?rev=274012&view=rev
Log:
[SPARC] Allows inlining of atomics for Sparc32 with appropriate store barrier.
The final change is required to extend the back-end's AtomicExpandPass that was
i
tavianator created this revision.
tavianator added reviewers: danalbert, jroelofs.
tavianator added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
__cxa_thread_atexit_impl() isn't present on all platforms, for example
Android pre-6.0. This patch uses a weak symbol to
rsmith added a comment.
Well OK then, commit away! :)
http://reviews.llvm.org/D21653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer added a subscriber: majnemer.
Comment at: src/cxa_thread_atexit.cpp:36-47
@@ +35,14 @@
+ public:
+DtorListHolder() {
+ pthread_key_create(&key_, run_dtors);
+}
+
+~DtorListHolder() {
+ run_dtors(get());
+ pthread_key_delete(key_);
+}
+
+
Hello everyone,
LLVM buildmaster will be updated and restarted after 8 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mren
Date: Tue Jun 28 18:01:49 2016
New Revision: 274076
URL: http://llvm.org/viewvc/llvm-project?rev=274076&view=rev
Log:
ObjC Class Property: diagnostics when accessing a class property using instance.
When a class property is accessed with an object instance, before this commit,
we try
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Make swap_noexcept.pass.cpp tests more portable.
These tests define types like some_alloc, which dramatically fail to meet the
allocator requirements. They don't even have all
Author: epilk
Date: Tue Jun 28 18:05:09 2016
New Revision: 274077
URL: http://llvm.org/viewvc/llvm-project?rev=274077&view=rev
Log:
[Sema] Disallow ambigious base classes in template argument deduction
Fixes PR28195.
Differential revision: http://reviews.llvm.org/D21653
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274077: [Sema] Disallow ambigious base classes in template
argument deduction (authored by epilk).
Changed prior to commit:
http://reviews.llvm.org/D21653?vs=61691&id=62149#toc
Repository:
rL LLVM
h
Author: rsmith
Date: Tue Jun 28 18:26:18 2016
New Revision: 274080
URL: http://llvm.org/viewvc/llvm-project?rev=274080&view=rev
Log:
Function declarations are, in fact, permitted in the init-statement of a for
loop. Don't confuse Sema by saying they're not.
Modified:
cfe/trunk/include/clang/S
jakev created this revision.
jakev added reviewers: silvas, davidxl, friss, vsk, bob.wilson, xur.
jakev added a subscriber: cfe-commits.
jakev set the repository for this revision to rL LLVM.
The flags:
For frontend instrumentation: `-fpgo-train=source-cfg`
For IR-level instrumentation: `-fpgo-tra
Author: silvas
Date: Tue Jun 28 19:29:23 2016
New Revision: 274084
URL: http://llvm.org/viewvc/llvm-project?rev=274084&view=rev
Log:
Revert "[PS4] Tighten up a test (noticed in passing)"
This reverts commit r269709.
r262285 changed this deliberately so that the test would not be
sensitive to whi
sanjoy added a subscriber: anemet.
sanjoy added a comment.
Sound plausible, but I don't know this area (optimization remarks) well enough
to sign off on this. @anemet can you please take a look?
http://reviews.llvm.org/D21773
___
cfe-commits maili
anemet added a comment.
> This test checks the loop-vectorization remarks when pointer checking
> threshold is exceeded. The change in http://reviews.llvm.org/D18777 would
> introduce zexts that cannot be removed so that the "loop not vectorized"
> reason is changed, hence breaking this test.
The fix looks fairly obvious, but you haven't added a testcase. Would you
please do so?
> On 2016-May-17, at 12:20, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak created this revision.
> ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant.
> ahatanak added a subscriber: cfe-c
(Ignore me, I was looking at an old version.)
> On 2016-Jun-28, at 17:56, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> The fix looks fairly obvious, but you haven't added a testcase. Would you
> please do so?
>
>> On 2016-May-17, at 12:20, Akira Hatanaka via cfe-commits
>> wrote:
>
dexonsmith added a comment.
I agree with Ben that this looks good.
Marshall and Eric, do you want Akira to hold off, or are you happy deferring to
Ben and me?
http://reviews.llvm.org/D20334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
I agree with Ben that this looks good.
Marshall and Eric, do you want Akira to hold off, or are you happy deferring to
Ben and me?
> On 2016-May-26, at 18:31, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak updated this revision to Diff 58740.
> ahatanak added a comment.
>
> Remove unus
pcc created this revision.
pcc added a reviewer: tejohnson.
pcc added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The other output formats aren't really useful to end users. The equivalent
functionality can still be accessed by developers with tools such as llvm-lto.
http:/
pcc updated this revision to Diff 62160.
pcc marked 2 inline comments as done.
pcc added a comment.
- Use ComputeCrossModuleImportForModule
http://reviews.llvm.org/D21545
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CMakeLists.txt
Index: lib/CodeGen/CMakeLists.txt
===
Author: rsmith
Date: Tue Jun 28 20:10:27 2016
New Revision: 274088
URL: http://llvm.org/viewvc/llvm-project?rev=274088&view=rev
Log:
Mark inheriting constructors as deleted if the corresponding defaulted default
constructor would be; this is effectively required by P0136R1. This has the
effect of
tavianator added inline comments.
Comment at: src/cxa_thread_atexit.cpp:36-47
@@ +35,14 @@
+ public:
+DtorListHolder() {
+ pthread_key_create(&key_, run_dtors);
+}
+
+~DtorListHolder() {
+ run_dtors(get());
+ pthread_key_delete(key_);
+}
+
+Dtor
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/BackendUtil.cpp:757
@@ +756,3 @@
+ }
+
+ lto::Config Conf;
Ok, please add a comment.
http://reviews.llvm.org/D21545
jojo added a comment.
I'm sorry that I should have submitted this and its fix in one review.
Now the old fix http://reviews.llvm.org/D21276 is abandoned,as a latest fix is
included in http://reviews.llvm.org/D21785.
I will commit http://reviews.llvm.org/D21277 and
http://reviews.llvm.org/D21785,
anemet added a comment.
In http://reviews.llvm.org/D21773#469596, @lihuang wrote:
> IV is promoted to 64-bit but the trunc/zext cannot be eliminated (at least
> cannot be eliminated with the -O1 pass pipeline). Then optimzation remark
> becomes:
>
> optimization-remark-options.c:17:3: remark:
Author: anemet
Date: Tue Jun 28 23:55:31 2016
New Revision: 274101
URL: http://llvm.org/viewvc/llvm-project?rev=274101&view=rev
Log:
[Diag] Add getter shouldAlwaysPrint. NFC
For the new hotness attribute, the API will take the pass rather than
the pass name so we can no longer play the trick of A
silvas added a comment.
Some basic comments.
Comment at: include/clang/Driver/Options.td:483
@@ +482,3 @@
+Group, Flags<[DriverOption]>, MetaVarName<"">,
+HelpText<"Generate instrumented code to collect execution counts into
(overridden by LLVM_PROFILE_FILE env var)">;
vsk added a comment.
This lgtm with one nit, and pending approval from others.
Comment at: include/clang/Driver/Options.td:482
@@ +481,3 @@
+def fpgo_train_EQ : Joined<["-"], "fpgo-train=">,
+Group, Flags<[DriverOption]>, MetaVarName<"">,
+HelpText<"Generate instrumented
Author: vedantk
Date: Wed Jun 29 00:33:09 2016
New Revision: 274104
URL: http://llvm.org/viewvc/llvm-project?rev=274104&view=rev
Log:
Revert "[Coverage] Adopt llvm::coverage::encodeFilenamesAndRawMappings (NFC)"
This reverts commit 161ff9db3a3d0d62880d1cb18d58182cd3034912 (r273056).
This is brea
99 matches
Mail list logo
