RE: [PATCH] D20561: Warn when taking address of packed member

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
Hi Aaron, Euvgeni, I'll try to whitelist these functions. Kind regards, Roger -Original Message- From: Aaron Ballman [mailto:aaron.ball...@gmail.com] Sent: 14 June 2016 00:30 To: Evgenii Stepanov Cc: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org; Roger Ferrer Ibanez; Richard

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

2016-06-14 Thread Erik Kessler via cfe-commits
erik65536 added a comment. I don't see any other issues. Thanks for fixing this. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

2016-06-14 Thread jojo.ma via cfe-commits
jojo added inline comments. Comment at: lib/Basic/Targets.cpp:5709 @@ -5715,1 +5708,3 @@ + +return false; } echristo wrote: > compnerd wrote: > > Please collapse this: > > > > return Name == "generic" || llvm::AArch64::parseCPUArch(Name) != > > llvm::

Re: [libcxx] r272632 - Ignore depricated warnings from and

2016-06-14 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jun 14, 2016 at 03:26:11AM -, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Mon Jun 13 22:26:11 2016 > New Revision: 272632 > > URL: http://llvm.org/viewvc/llvm-project?rev=272632&view=rev > Log: > Ignore depricated warnings from and Commit message and change don't a

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

2016-06-14 Thread jojo.ma via cfe-commits
jojo updated this revision to Diff 60658. jojo added a comment. Herald added a subscriber: mehdi_amini. Update according to inline comments. Repository: rL LLVM http://reviews.llvm.org/D21277 Files: lib/Basic/Targets.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp =

Re: [musl] Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-14 Thread Szabolcs Nagy via cfe-commits
* Rafael Esp?ndola [2016-06-13 17:00:17 -0400]: > Do you need someone to commit it for you? > On Jun 13, 2016 9:50 AM, "Lei Zhang via cfe-commits" < > > http://git.alpinelinux.org/cgit/aports/plain/main/clang/clang-0004-Add-musl-targets-and-dynamic-linker.patch > > > > This looks neat :) the dyna

Re: [libcxx] r272632 - Ignore depricated warnings from and

2016-06-14 Thread Eric Fiselier via cfe-commits
The depreciation warnings are emitted from and using "#warning". The actual types are not marked deprecated using attributes. That's why the tests suppress "-W#warning". I'm trying to get our test suite passing with -Wsystem-headers -Werror so this is a necessary evil. Hope that clears things u

r272645 - [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases.

2016-06-14 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Tue Jun 14 03:58:50 2016 New Revision: 272645 URL: http://llvm.org/viewvc/llvm-project?rev=272645&view=rev Log: [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases. Summary: The validity of ABI/CPU pairs is no longer checked on the fly

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

2016-06-14 Thread Marek Sokołowski via cfe-commits
mnbvmar added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:69 @@ +68,3 @@ +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + haveOneActiveArgument) { + return anyOf(parameterCountIs(1), Probably hasOneActive

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-14 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 60662. Prazek marked an inline comment as done. Prazek added a comment. Runned on LLVM and bug fixed one thing http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/U

r272653 - Reverting "Warn when taking address of a packed member"

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
Author: rogfer01 Date: Tue Jun 14 06:20:07 2016 New Revision: 272653 URL: http://llvm.org/viewvc/llvm-project?rev=272653&view=rev Log: Reverting "Warn when taking address of a packed member" This new diagnostic is causing some false positives that have to be addressed. This reverts commit 272552

Re: [PATCH] D20561: Warn when taking address of packed member

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 reopened this revision. rogfer01 added a comment. This revision is now accepted and ready to land. I've reverted the commit. During implementation of the white list I felt the changes were too much for a follow up commit, so I prefer some feedback first. Repository: rL LLVM http://

[PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

2016-06-14 Thread michael zuckerman via cfe-commits
m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. _mm512_prefetch_i64gather_ps _mm512_prefetch_i32gather_pd _mm512_prefetch_i64gather_pd _mm512_prefetch_i32gather_ps http://reviews.llvm.org/D21322 Files: lib/

r272654 - clang-format: [JS] Support annotated classes.

2016-06-14 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jun 14 06:28:02 2016 New Revision: 272654 URL: http://llvm.org/viewvc/llvm-project?rev=272654&view=rev Log: clang-format: [JS] Support annotated classes. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp Modified: cfe/

Re: [PATCH] D20561: Warn when taking address of packed member

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 removed rL LLVM as the repository for this revision. rogfer01 updated this revision to Diff 60664. rogfer01 added a comment. This new patch adds a whitelist for memcpy, memmove, memset and memcmp. I'm not entirely happy with the strategy that I'm using, where Parser communicates to Sema

Re: [PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

2016-06-14 Thread Igor Breger via cfe-commits
igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r272656 - Add loop pragma for Loop Distribution

2016-06-14 Thread Adam Nemet via cfe-commits
Author: anemet Date: Tue Jun 14 07:04:26 2016 New Revision: 272656 URL: http://llvm.org/viewvc/llvm-project?rev=272656&view=rev Log: Add loop pragma for Loop Distribution Summary: This is similar to other loop pragmas like 'vectorize'. Currently it only has state values: distribute(enable) and d

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-06-14 Thread Adam Nemet via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272656: Add loop pragma for Loop Distribution (authored by anemet). Changed prior to commit: http://reviews.llvm.org/D19403?vs=55445&id=60665#toc Repository: rL LLVM http://reviews.llvm.org/D19403

[clang-tools-extra] r272657 - [include-fixer] remove redundant code.

2016-06-14 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jun 14 07:14:36 2016 New Revision: 272657 URL: http://llvm.org/viewvc/llvm-project?rev=272657&view=rev Log: [include-fixer] remove redundant code. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp Modified: clang-tools-extra/trunk/include-fix

Re: [PATCH] D21295: Add a negative TBAA test

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 updated this revision to Diff 60667. rogfer01 added a comment. Much simpler version thanks to @jmolloy comment. http://reviews.llvm.org/D21295 Files: test/CodeGen/tbaa.cpp Index: test/CodeGen/tbaa.cpp === --- test/CodeG

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

2016-06-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272658: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20626?vs=59663&id=60668#toc Repository: rL LL

r272658 - [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

2016-06-14 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Jun 14 07:38:58 2016 New Revision: 272658 URL: http://llvm.org/viewvc/llvm-project?rev=272658&view=rev Log: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps Differential Revision: http://reviews.llvm.org/D20626 Modified: cfe/trunk/lib/Headers

[PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. do not add existing includes. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/Clean

r272662 - Start adding support for Musl.

2016-06-14 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Tue Jun 14 07:47:24 2016 New Revision: 272662 URL: http://llvm.org/viewvc/llvm-project?rev=272662&view=rev Log: Start adding support for Musl. The two patches together enable clang to support targets like "x86_64-pc-linux-musl" and build binaries against musl-libc instead of

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-14 Thread Rafael Espíndola via cfe-commits
On 13 June 2016 at 21:07, Lei Zhang wrote: > 2016-06-14 5:00 GMT+08:00 Rafael Espíndola : >> Do you need someone to commit it for you? > > Yes, please :) Committed. Cheers, Rafael ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. I am happy to get this in for now, but I actually think the right solution might be to let clang-format de-duplicate #includes in general. What do you think? http://reviews.llvm.org/D21323 ___ cfe-commits mailing list cfe-

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

2016-06-14 Thread Martin Böhme via cfe-commits
mboehme updated this revision to Diff 60671. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp ===

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric added a comment. It should be quite straight-forward to de-duplicate #includes in the same block in `sortIncludes`. I'm happy to add this into `sortIncludes`, but I'm not sure if this is a behavior users would expect from clang-format since it deletes code? And maybe duplicated headers

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

2016-06-14 Thread John Brawn via cfe-commits
john.brawn added a comment. In http://reviews.llvm.org/D20732#456239, @jyknight wrote: > This looks okay. The only downside: it will increase sizeof(Decl) on 32bit > platforms, since the layout is: > vtable ptr (4) > NextInContextAndBits ptr (4) > DeclCtx ptr (4) > Loc int (4) > bitfield in

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

2016-06-14 Thread Martin Böhme via cfe-commits
mboehme added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +struct NonMoveable { + public: + NonMoveable(); aaron.ballman wrote: > This type isn't non-moveable. For that, you need to explicitly delete the > move constr

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. Well, it is easy to not see duplicated #includes when they aren't properly sorted. When clang-format then goes in and sorts them, they end up next to each other. And I think no user really wants that. http://reviews.llvm.org/D21323 __

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric added a comment. Agreed. So, do we still want to skip existing #includes here or simply rely on `sortIncludes` to de-duplicate? http://reviews.llvm.org/D21323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. Lets get this in for now. We can always remove it if we think it is no longer useful. Comment at: unittests/Format/CleanupTest.cpp:692 @@ +691,3 @@ +TEST_F(CleanUpReplacementsTest, SkipExistingHeaders) { + std::string Code = "#include \"a.h\"\n#include

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 60675. ioeric marked an inline comment as done. ioeric added a comment. - Addressed reviewer's comments: test case added. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cp

Re: [PATCH] D20561: Warn when taking address of packed member

2016-06-14 Thread Roger Ferrer Ibanez via cfe-commits
rogfer01 added a comment. A build of Firefox does not show any false positive now. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: unittests/Format/CleanupTest.cpp:693 @@ +692,3 @@ + std::string Code = "#include \"a.h\"\n#include \n"; + std::string Expected = "#include \"a.h\"\n#include \n"; + tooling::Replacements Replaces = {createInsertion("#include "), ---

r272667 - [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

2016-06-14 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Tue Jun 14 08:45:17 2016 New Revision: 272667 URL: http://llvm.org/viewvc/llvm-project?rev=272667&view=rev Log: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics Differential Revision: http://reviews.llvm.org/D21322 Modified: cfe/trunk/lib/Headers/avx512pfi

Re: [PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

2016-06-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272667: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D21322?vs=60663&id=60678#toc Repository: rL LLVM http:/

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

2016-06-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +class NonMoveable { + public: + NonMoveable(); > Can you expand on this? > > The standard says: "If the definition of a class X does not explicitly > de

r272668 - clang-format: [JS] Fix failing format with TypeScript casts.

2016-06-14 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Tue Jun 14 08:54:38 2016 New Revision: 272668 URL: http://llvm.org/viewvc/llvm-project?rev=272668&view=rev Log: clang-format: [JS] Fix failing format with TypeScript casts. Before, this could be formatted at all (with BracketAlignmentStyle AlwaysBreak): foo = [ 1, /*

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 60680. ioeric marked 2 inline comments as done. ioeric added a comment. - addressed reviewer's comments. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp ===

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: unittests/Format/CleanupTest.cpp:701 @@ +700,3 @@ + std::string Code = "#include \"a.h\"\n#include \n"; + std::string Expected = "#include \"a.h\"\n#include \"vector\"\n" + "#include \n#include \n"; --

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good :-) http://reviews.llvm.org/D21323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

r272669 - [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Jun 14 09:09:21 2016 New Revision: 272669 URL: http://llvm.org/viewvc/llvm-project?rev=272669&view=rev Log: [clang-format] do not add existing includes. Summary: do not add existing includes. Reviewers: djasper Subscribers: klimek, cfe-commits Differential Revision: ht

Re: [PATCH] D21323: [clang-format] do not add existing includes.

2016-06-14 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272669: [clang-format] do not add existing includes. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21323?vs=60680&id=60681#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

2016-06-14 Thread Martin Böhme via cfe-commits
mboehme updated this revision to Diff 60686. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp ===

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

2016-06-14 Thread Martin Böhme via cfe-commits
mboehme added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +class NonMoveable { + public: + NonMoveable(); aaron.ballman wrote: > > Can you expand on this? > > > > The standard says: "If the definition of a class X does

[libcxx] r272671 - Partially Revert r272613. FreeBSD needs the non-trivial constructors in pair.

2016-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 14 09:34:19 2016 New Revision: 272671 URL: http://llvm.org/viewvc/llvm-project?rev=272671&view=rev Log: Partially Revert r272613. FreeBSD needs the non-trivial constructors in pair. Modified: libcxx/trunk/include/__config libcxx/trunk/include/utility Modified

Re: r272656 - Add loop pragma for Loop Distribution

2016-06-14 Thread Rafael Espíndola via cfe-commits
Looks like this broke the docs: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/docs-clang-html/logs/stdio Cheers, Rafael On 14 June 2016 at 08:04, Adam Nemet via cfe-commits wrote: > Author: anemet > Date: Tue Jun 14 07:04:26 2016 > New Revision: 272656 > > URL: http://l

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

2016-06-14 Thread Kostya Serebryany via cfe-commits
kcc added a comment. What run-time is going to be linked when coverage is used w/o any of the sanitizers? Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[libcxx] r272679 - Found a couple bugs in the test suite. No functionality change.

2016-06-14 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Jun 14 10:25:46 2016 New Revision: 272679 URL: http://llvm.org/viewvc/llvm-project?rev=272679&view=rev Log: Found a couple bugs in the test suite. No functionality change. Modified: libcxx/trunk/test/std/containers/unord/unord.multiset/unord.multiset.swap/swap_noex

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

2016-06-14 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM, I think it would be nice if the block related code goes in a separate commit. Thanks! http://reviews.llvm.org/D20444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

2016-06-14 Thread Asiri Rathnayake via cfe-commits
Author: asiri Date: Tue Jun 14 10:51:01 2016 New Revision: 272680 URL: http://llvm.org/viewvc/llvm-project?rev=272680&view=rev Log: [libunwind] Improve unwinder stack usage - III Implement the same optimization committed under r271004 on non-EHABI, non-SJLJ unwinder as well. Change-Id: I7f80ed91

Re: [libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

2016-06-14 Thread Jonathan Roelofs via cfe-commits
On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote: Author: asiri Date: Tue Jun 14 10:51:01 2016 New Revision: 272680 URL: http://llvm.org/viewvc/llvm-project?rev=272680&view=rev Log: [libunwind] Improve unwinder stack usage - III Implement the same optimization committed under r27100

Re: [libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

2016-06-14 Thread Asiri Rathnayake via cfe-commits
Sorry it took this long, got pushed down on my TODO list :) Cheers, / Asiri On Tue, Jun 14, 2016 at 5:04 PM, Jonathan Roelofs via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote: > >> Author: asiri >> Date: Tue Jun 14 10:51:01 20

Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

2016-06-14 Thread Michael Kuperstein via cfe-commits
mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

2016-06-14 Thread Krystyna via cfe-commits
krystyna updated this revision to Diff 60697. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h docs/ReleaseNotes.rst

Re: r272604 - [docs] Coverage: Document the profile merge pool specifier

2016-06-14 Thread Vedant Kumar via cfe-commits
I think David got rid of that limitation. The related warning in compiler-rt does not reflect this: PROF_WARN("%%m specifier can only be specified once at the end of %s.\n", ...); Fixed the warning in r272685. thanks, vedant > On Jun 13, 2016, at 8:13 PM, Sean Silva wrote: > > > > On Mo

[PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

2016-06-14 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, dim, emaste, theraven. EricWF added a subscriber: cfe-commits. Herald added a subscriber: emaste. This patch does the following: * It renames `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR` to `_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_C

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

2016-06-14 Thread Tim Shen via cfe-commits
timshen updated this revision to Diff 60704. timshen added a comment. Done. http://reviews.llvm.org/D21241 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Index: uni

RE: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

2016-06-14 Thread Stephan T. Lavavej via cfe-commits
[Eric Fiselier] > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the > following C++11 features: > - `cxx_noexcept` > - `cxx_atomic` > - `cxx_access_control_sfinae` > Also if the entire test is wrapped in a `TEST_HAS_FEATURE(XXX)` please > translate that into a `// UNSUP

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

2016-06-14 Thread Michael Spertus via cfe-commits
On Mon, Jun 13, 2016 at 11:27 AM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", > and then potentially waiting an indeterminate amount of time. > > I think that actually

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

2016-06-14 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D21098#457726, @STL_MSFT wrote: > [Eric Fiselier] > > > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the > > following C++11 features: > > > > > > - `cxx_noexcept` > > > - `cxx_atomic` > > > - `cxx_access_control_sfin

Re: [PATCH] D20561: Warn when taking address of packed member

2016-06-14 Thread Richard Smith via cfe-commits
rsmith added a comment. This still looks like it will have has lots of false positives for cases like: struct __attribute__((packed)) A { char c; int n; } a; void *p = &a.n; It also looks like it will now have false negatives for cases like: memcpy(x, y, *&a.n); I think whiteli

Re: [PATCH] D20772: Automatically detect export lists for OS X.

2016-06-14 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting to commit. http://reviews.llvm.org/D20772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

2016-06-14 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. ubsan_standalone (that's what the needsUbsanRt change is for). Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

2016-06-14 Thread Nico Weber via cfe-commits
I locally set up an SVN repo with a file called "File.txt" and then renamed it with `svn mv` using a new svn client (1.8). Then I tried updating several local checkouts of my local repo with svn 1.6.6 clients. All methods of updating I tried (`svn up`, `svn co current_checkout_url@2`) worked witho

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

2016-06-14 Thread Kostya Serebryany via cfe-commits
kcc added a comment. Can you at least add a compiler-rt test where we ensure that this flag can not be used such that it wil compile but fail to link? E.g. clang -fsanitize-coverage=edge x.c should compile *and* link (and run) Repository: rL LLVM http://reviews.llvm.org/D21317 _

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

2016-06-14 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. FTR, I finally test it out for compile time and could not notice any difference besides noise. Thanks Eric! http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r272695 - [perf-training] Ignore 'Profile Note' warnings from the runtime

2016-06-14 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Tue Jun 14 14:06:48 2016 New Revision: 272695 URL: http://llvm.org/viewvc/llvm-project?rev=272695&view=rev Log: [perf-training] Ignore 'Profile Note' warnings from the runtime After r272599, -DLLVM_BUILD_INSTRUMENTED passes a default argument to -fprofile-instr-generate. Thi

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60718. pirama added a comment. Herald added subscribers: danalbert, tberghammer. - Add TargetInfo for 32-bit and 64-bit RenderScript http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.

[PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama created this revision. pirama added reviewers: rsmith, echristo. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: mehdi_amini, danalbert, tberghammer, aemerson. The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. http://reviews.llvm.org/D21333 is the corresponding patch to LLVM http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60723. pirama added a comment. - Undo bad merge from different patch http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. http://reviews.llvm.org/D21333 and http://reviews.llvm.org/D21334 add the RenderScript triple and modify 'long' based off the triple. r272317, r272342, r272438 take care of the LangOpt and handling of '-x renderscript' and '.rs' extensions. http://reviews.llvm.org/D20

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. This patch is based on the discussion in http://reviews.llvm.org/D20709. http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r272656 - Add loop pragma for Loop Distribution

2016-06-14 Thread Adam Nemet via cfe-commits
On it, sorry about it. > On Jun 14, 2016, at 4:51 PM, Rafael Espíndola > wrote: > > Looks like this broke the docs: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/docs-clang-html/logs/stdio > > Cheers, > Rafael > > > On 14 June 2016 at 08:04, Adam Nemet via cfe-comm

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

2016-06-14 Thread Hans Wennborg via cfe-commits
SGTM, then :-) On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > I locally set up an SVN repo with a file called "File.txt" and then renamed > it with `svn mv` using a new svn client (1.8). > > Then I tried updating several local checkouts of my local repo with svn > 1.6.6 clients. All method

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272699 - Fix documentation bot after r272656

2016-06-14 Thread Adam Nemet via cfe-commits
Author: anemet Date: Tue Jun 14 14:33:16 2016 New Revision: 272699 URL: http://llvm.org/viewvc/llvm-project?rev=272699&view=rev Log: Fix documentation bot after r272656 Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llvm.org/viewv

Re: r272656 - Add loop pragma for Loop Distribution

2016-06-14 Thread Adam Nemet via cfe-commits
r272699 should do it. > On Jun 14, 2016, at 9:32 PM, Adam Nemet via cfe-commits > wrote: > > On it, sorry about it. > >> On Jun 14, 2016, at 4:51 PM, Rafael Espíndola >> wrote: >> >> Looks like this broke the docs: >> http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/do

[PATCH] D21337: [CUDA] Give templated device functions internal linkage, templated kernels external linkage.

2016-06-14 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. This lets LLVM perform IPO over these functions. In particular, it allows LLVM to emit ld.global.nc for loads to __restrict pointers in kernels that are never written to. http://reviews.llv

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

2016-06-14 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. In http://reviews.llvm.org/D20444#457588, @Anastasia wrote: > LGTM, I think it would be nice if the block related code goes in a separate > commit. > > Thanks! Will do. Thanks. http://reviews.llvm.org/D20444 ___ cfe-commi

r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Jun 14 14:54:40 2016 New Revision: 272701 URL: http://llvm.org/viewvc/llvm-project?rev=272701&view=rev Log: Rename Intrin.h to intrin.h, that's how all the documentation calls it. Added: cfe/trunk/lib/Headers/intrin.h (props changed) - copied unchanged from r272

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Nico Weber via cfe-commits
This change was generated by running `svn mv -m "Rename Intrin.h to intrin.h, that's how all the documentation calls it." https://n...@llvm.org/svn/llvm-project/cfe/trunk/lib/Headers/Intrin.h https://n...@llvm.org/svn/llvm-project/cfe/trunk/lib/Headers/intrin.h` – I didn't manually do anything with

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

2016-06-14 Thread Nico Weber via cfe-commits
r272701, thanks! On Tue, Jun 14, 2016 at 9:34 PM, Hans Wennborg wrote: > SGTM, then :-) > > On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > > I locally set up an SVN repo with a file called "File.txt" and then > renamed > > it with `svn mv` using a new svn client (1.8). > > > > Then I tri

[PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

2016-06-14 Thread Matthias Braun via cfe-commits
MatzeB created this revision. MatzeB added reviewers: doug.gregor, bkramer. MatzeB added a subscriber: cfe-commits. MatzeB set the repository for this revision to rL LLVM. Herald added a subscriber: mcrosier. llvm statistics are currently printed when the destructor of a "static ManagedStatic Stat

r272702 - s/Intrin.h/intrin.h/, trying to fix the build after r272701

2016-06-14 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jun 14 15:14:24 2016 New Revision: 272702 URL: http://llvm.org/viewvc/llvm-project?rev=272702&view=rev Log: s/Intrin.h/intrin.h/, trying to fix the build after r272701 Modified: cfe/trunk/lib/Headers/CMakeLists.txt cfe/trunk/lib/Headers/intrin.h cfe/trunk/test/C

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

2016-06-14 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60735. pirama added a comment. - revise test http://reviews.llvm.org/D21334 Files: lib/Basic/Targets.cpp test/CodeGen/renderscript.c Index: test/CodeGen/renderscript.c === --- /dev/null +++

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Vitaly Buka via cfe-commits
Probably the bot was broken by this CL http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/9922 On Tue, Jun 14, 2016 at 1:03 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change was generated by running `svn mv -m "Rename Intrin.h to > intrin.h, that

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Rui Ueyama via cfe-commits
Hans seems to fix it in r272701. On Tue, Jun 14, 2016 at 1:26 PM, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Probably the bot was broken by this CL > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/9922 > > On Tue, Jun 14, 2016 at 1:03 PM Nico Weber

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Vitaly Buka via cfe-commits
thanks On Tue, Jun 14, 2016 at 1:31 PM Rui Ueyama wrote: > Hans seems to fix it in r272701. > > On Tue, Jun 14, 2016 at 1:26 PM, Vitaly Buka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Probably the bot was broken by this CL >> http://lab.llvm.org:8011/builders/sanitizer-x86_64-li

Re: [PATCH] D21320: Alternative to D1332

2016-06-14 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT resigned from this revision. STL_MSFT removed a reviewer: STL_MSFT. STL_MSFT added a comment. My only concern is that the tests in test/std shouldn't exercise this bug in the standard, as MSVC's implementation doesn't special-case it. If you'd like to special-case it in your product cod

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

2016-06-14 Thread Evgeniy Stepanov via cfe-commits
eugenis added a comment. In http://reviews.llvm.org/D21317#457784, @kcc wrote: > Can you at least add a compiler-rt test where we ensure that this flag can > not be used such that it wil compile but fail to link? > > E.g. > > clang -fsanitize-coverage=edge x.c > > should compile *and* link (a

Re: [PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

2016-06-14 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT updated this revision to Diff 60736. STL_MSFT added a comment. Inspect TEST_STD_VER and cast to void* as requested. I used a static_cast to avoid triggering any old-style cast warnings. (I also just noticed that I deleted an empty line, but was too lazy to regenerate the diff. Oops.)

Re: [PATCH] D21337: [CUDA] Give templated device functions internal linkage, templated kernels external linkage.

2016-06-14 Thread Justin Lebar via cfe-commits
jlebar added a comment. tra makes the good point that maybe this should be done in ASTContext, where we already have a special case for __global__. (I think I gravitated to doing it this way because the GVA* enums have zero documentation -- at least I have a vague idea of what the LLVM attribu

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. Adding `-cl-opt-disable` to the tests seems fine as an alternative short-term approach; LGTM with that approach (either as part of this change or a separate ch

[PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-14 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. These are probably going to end up in C++17 as well. This is a straight addition; no changes to existing code. http://reviews.llvm.org/D21343 Files: include/exp

r272710 - Update clang for D20348

2016-06-14 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Tue Jun 14 16:02:05 2016 New Revision: 272710 URL: http://llvm.org/viewvc/llvm-project?rev=272710&view=rev Log: Update clang for D20348 Differential Revision: http://reviews.llvm.org/D20339 Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk/lib/CodeGen/CGExpr.cpp

Re: [PATCH] D20339: Update clang for D20260

2016-06-14 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272710: Update clang for D20348 (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D20339?vs=57527&id=60747#toc Repository: rL LLVM http://reviews.llvm.org/D20339 Files: cfe/trunk

  1   2   >