Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

yaxunl updated this revision to Diff 60105. yaxunl marked an inline comment as done. yaxunl added a comment. Refactor to eliminate lambda function argument. http://reviews.llvm.org/D20681 Files: include/clang/CodeGen/BackendUtil.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CodeGenAction.cpp

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

dcoughlin added a comment. A 6% speed improvement could be a big win! Do we have a sense of what the expected increased memory cost (as a % of average use over the lifetime of the process) is? My guess is it would be relatively low. I suspect most analyzer users run relatively few concurrent 'c

Re: r272198 - [DebugInfo] Add calling conventions to DISubroutineType

At least in theory it'd be nice to have test cases for the other call sites this change adds CC to. On Wed, Jun 8, 2016 at 1:41 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Wed Jun 8 15:41:54 2016 > New Revision: 272198 > > URL: http://llvm.org/vie

[libcxx] r272212 - [CMake] Cleanup uses of USES_TERMINAL

Author: cbieneman Date: Wed Jun 8 17:20:28 2016 New Revision: 272212 URL: http://llvm.org/viewvc/llvm-project?rev=272212&view=rev Log: [CMake] Cleanup uses of USES_TERMINAL Now that we are on CMake 3.4.3 we no longer need a version check around this. This is the libcxx side of r272211. Modifie

r272213 - [CMake] Cleanup uses of USES_TERMINAL

Author: cbieneman Date: Wed Jun 8 17:20:43 2016 New Revision: 272213 URL: http://llvm.org/viewvc/llvm-project?rev=272213&view=rev Log: [CMake] Cleanup uses of USES_TERMINAL Now that we are on CMake 3.4.3 we no longer need a version check around this. This is the clang side of r272211. Modified

r272214 - [docs] Coverage: Flesh out instructions for avoiding static initializeres

Author: vedantk Date: Wed Jun 8 17:24:52 2016 New Revision: 272214 URL: http://llvm.org/viewvc/llvm-project?rev=272214&view=rev Log: [docs] Coverage: Flesh out instructions for avoiding static initializeres Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/Source

r272215 - [docs] Coverage: Clarify return value of __llvm_profile_write_file

Author: vedantk Date: Wed Jun 8 17:32:03 2016 New Revision: 272215 URL: http://llvm.org/viewvc/llvm-project?rev=272215&view=rev Log: [docs] Coverage: Clarify return value of __llvm_profile_write_file Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCo

[libcxx] r272216 - Add notes for 2688

Author: marshall Date: Wed Jun 8 17:33:25 2016 New Revision: 272216 URL: http://llvm.org/viewvc/llvm-project?rev=272216&view=rev Log: Add notes for 2688 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-projec

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:220 @@ +219,3 @@ +// In the ASCII range? +if (Ch < 0 || Ch > 0xff) + return false; // Can't be a standard header rsmith wrote: > Comment doesn't match code: the ASCII range ends

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

rsmith added inline comments. Comment at: lib/Lex/PPDirectives.cpp:33 @@ -28,2 +32,2 @@ #include "llvm/Support/Path.h" #include "llvm/Support/SaveAndRestore.h" eric_niebler wrote: > You mean, instead of the `StringSet` below? Looks like `StringSwitch` just > tu

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added inline comments. Comment at: lib/Lex/PPDirectives.cpp:179 @@ +178,3 @@ +"exception", "iterator", "random", "strstream", "vector", +"forward_list", "limits", "ratio", "system_error", + Applying your patch reveled a bunch of ^M (carriage-return)

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user68m42.09

[PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, jholewinski. Clang changes to make use of the LLVM intrinsics added in D21160. http://reviews.llvm.org/D21162 Files: include/clang/Basic/BuiltinsNVPTX.def lib/Headers/__clang_cuda_intrinsics.h

r272233 - Update to match LLVM r272232.

Author: rsmith Date: Wed Jun 8 19:53:41 2016 New Revision: 272233 URL: http://llvm.org/viewvc/llvm-project?rev=272233&view=rev Log: Update to match LLVM r272232. Modified: cfe/trunk/tools/arcmt-test/arcmt-test.cpp cfe/trunk/tools/c-index-test/c-index-test.c cfe/trunk/tools/c-index-te

[clang-tools-extra] r272235 - Update to match LLVM r272232.

Author: rsmith Date: Wed Jun 8 19:54:42 2016 New Revision: 272235 URL: http://llvm.org/viewvc/llvm-project?rev=272235&view=rev Log: Update to match LLVM r272232. Modified: clang-tools-extra/trunk/clang-query/tool/ClangQuery.cpp clang-tools-extra/trunk/tool-template/ToolTemplate.cpp Modi

[PATCH] D21163: Strip Android version when looking up toolchain paths.

jmgao created this revision. jmgao added reviewers: srhines, danalbert. jmgao added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Android target triples can include a version number in the abi field (e.g. 'aarch64-linux-android21'), used for checki

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

Since we found only one user, I think my preference is to handle it there. Cheers, Rafael On 8 June 2016 at 13:49, Vedant Kumar wrote: > vsk added a comment. > > Ping, any updates on this patch? > > > http://reviews.llvm.org/D20748 > > > ___ cfe-commi

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

I agree with Rafael. I ran with -ftime-report for a couple of weeks on a lot of tests and never hit this problem. It actually seems weird we have to handle the timer recursively here as well (I'd like to avoid it at all), but let's see what Richard has to say when he gets to this review. On Wed, J

r272244 - [X86] Add void to the argument list of intrinsics that don't take arguments since empty argument list mean something else in C.

Author: ctopper Date: Thu Jun 9 00:14:28 2016 New Revision: 272244 URL: http://llvm.org/viewvc/llvm-project?rev=272244&view=rev Log: [X86] Add void to the argument list of intrinsics that don't take arguments since empty argument list mean something else in C. Modified: cfe/trunk/lib/Header

r272246 - [X86] Handle AVX2 pslldqi and psrldqi intrinsics shufflevector creation directly in the header file instead of in CGBuiltin.cpp. Simplify the sse2 equivalents as well.

Author: ctopper Date: Thu Jun 9 00:15:12 2016 New Revision: 272246 URL: http://llvm.org/viewvc/llvm-project?rev=272246&view=rev Log: [X86] Handle AVX2 pslldqi and psrldqi intrinsics shufflevector creation directly in the header file instead of in CGBuiltin.cpp. Simplify the sse2 equivalents as

r272245 - [X86] Reuse the EmitX86Select routine to handle the select for masked palignr too.

Author: ctopper Date: Thu Jun 9 00:15:00 2016 New Revision: 272245 URL: http://llvm.org/viewvc/llvm-project?rev=272245&view=rev Log: [X86] Reuse the EmitX86Select routine to handle the select for masked palignr too. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/Code

r272247 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

Author: majnemer Date: Thu Jun 9 00:26:56 2016 New Revision: 272247 URL: http://llvm.org/viewvc/llvm-project?rev=272247&view=rev Log: [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name It is possible for a field and a class to have the same name. In such cases, perf

<    1   2