pcc created this revision.
pcc added reviewers: eugenis, mehdi_amini, kcc.
pcc added a subscriber: cfe-commits.
pcc added a dependency: D21121: IR: Introduce llvm.type.checked.load intrinsic..
Depends on D21121
http://reviews.llvm.org/D21122
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGen
Author: kromanova
Date: Wed Jun 8 02:34:31 2016
New Revision: 272121
URL: http://llvm.org/viewvc/llvm-project?rev=272121&view=rev
Log:
Add doxygen comments to xmmintrin.h's intrinsics.
Only half of the intrinsics in this file is documented here. The patch for the o
ther half will be sent out late
Author: mzuckerm
Date: Wed Jun 8 03:19:27 2016
New Revision: 272123
URL: http://llvm.org/viewvc/llvm-project?rev=272123&view=rev
Log:
[Clang][AVX512][BUILTIN]Adding intrinsics for range_round_{sd|ss}
Differential Revision: http://reviews.llvm.org/D21002
Modified:
cfe/trunk/include/clang/Bas
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272123: [Clang][AVX512][BUILTIN]Adding intrinsics for
range_round_{sd|ss} (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21002?vs=59664&id=60009#toc
Repository:
rL LLVM
ht
Author: djasper
Date: Wed Jun 8 03:23:46 2016
New Revision: 272124
URL: http://llvm.org/viewvc/llvm-project?rev=272124&view=rev
Log:
clang-format: Fix bug in function ref qualifier identification.
.. and simplify it.
Before:
void A::f()&& {}
void f() && {}
After:
void A::f() && {}
void
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D21120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
pgousseau added a comment.
> > Are you asking for the 2 seconds tolerance to be part of this patch?
>
> > Or, as it seems the main problem here is the lack of a reproducible, are
> > you ok with the idea of committing this patch first, to see if the
> > inconsistent time stamps is still an i
Author: djasper
Date: Wed Jun 8 04:45:08 2016
New Revision: 272125
URL: http://llvm.org/viewvc/llvm-project?rev=272125&view=rev
Log:
clang-format: Fix incorrect calculation of "length" of /**/ comments.
This could lead to column limit violations.
Modified:
cfe/trunk/lib/Format/ContinuationI
yaron.keren added a subscriber: yaron.keren.
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
You mean
Some target platforms do not support -fsanitize=address.
http://reviews.llvm.org/D21
christof added a comment.
In http://reviews.llvm.org/D21082#451393, @kubabrecka wrote:
> This doesn’t make sense to me, Clang is able to produce ASanified code even
> when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER
> does). Where exactly is this test failing?
Right.
christof accepted this revision.
christof added a reviewer: christof.
christof added a comment.
I've tested it and it removes the issue I saw. The following error is gone:
clang-3.9: error: unsupported option '-fsanitize=address' for target
'aarch64-arm-none-eabi’
Thanks
http://reviews.llvm.o
Author: danielmarjamaki
Date: Wed Jun 8 05:30:24 2016
New Revision: 272128
URL: http://llvm.org/viewvc/llvm-project?rev=272128&view=rev
Log:
[clang-tidy] misc-macro-parentheses - avoid adding parentheses in variable
declarations
Fixes bugzilla issues 26273 and 27399
Reviewers: alexfh
Subscri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272128 (authored by danielmarjamaki).
Changed prior to commit:
http://reviews.llvm.org/D20853?vs=59208&id=60013#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20853
Files:
clang-tools-extra/trun
faisalv added a comment.
Seems reasonable to me if we have the bit to spare. I wasn't a huge fan of the
sentinel approach - but i appreciated Richard showing me that trick. I don't
think I realized that Decl has to be aligned on an 8 byte boundary. I'm not
too familiar with the alignment gym
Alexander_Droste added a comment.
Hi Devin,
thanks for fixing the GCC build errors and setting up the commit!
Unfortunately, creating an `MPIBugReporter` instance only when a bug occurs
does cause a separate issue.
The instance seems to be freed, before the reports get flushed.
void MPIChecke
JamesReynolds marked an inline comment as done.
JamesReynolds added a comment.
http://reviews.llvm.org/D21020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amilburn created this revision.
amilburn added a reviewer: rsmith.
amilburn added a subscriber: cfe-commits.
If an argument is a placeholder, rewriteBuiltinFunctionDecl should skip it when
trying to rewrite address spaces.
This situation can happen because not all placeholders are rejected by
A
JamesReynolds updated this revision to Diff 60010.
JamesReynolds added a comment.
Changed the clang-tidy release notes addition to be in alphabetical order.
http://reviews.llvm.org/D21020
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingCheck.h
rmaprath updated this revision to Diff 60017.
rmaprath added a comment.
Addressed comments from @mclow.lists.
http://reviews.llvm.org/D20328
Files:
CMakeLists.txt
include/__config
include/__config_site.in
include/__dynamic_threading
include/__threading_support
include/thread
lib/C
rmaprath marked 2 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D20328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Wed Jun 8 07:13:14 2016
New Revision: 272132
URL: http://llvm.org/viewvc/llvm-project?rev=272132&view=rev
Log:
[include-fixer] do not add enum forward declaration into symbol index table.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp
Author: aaronballman
Date: Wed Jun 8 07:33:18 2016
New Revision: 272136
URL: http://llvm.org/viewvc/llvm-project?rev=272136&view=rev
Log:
Correcting a typo in a comment; NFC.
Modified:
cfe/trunk/lib/Sema/TypeLocBuilder.h
Modified: cfe/trunk/lib/Sema/TypeLocBuilder.h
URL:
http://llvm.org/vi
rogfer01 added a comment.
Ping?
Thanks a lot.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erikjv updated this revision to Diff 60023.
http://reviews.llvm.org/D15926
Files:
include/clang/Basic/LangOptions.h
lib/Frontend/CompilerInvocation.cpp
lib/Lex/PPDirectives.cpp
lib/Lex/PPMacroExpansion.cpp
lib/Lex/Pragma.cpp
test/Preprocessor/header_is_main_file.c
Index: test/Preproc
aaron.ballman added a comment.
One thing this patch does not do but needs to is fix
`ASTContext::adjustExceptionSpec()` (Thanks to Don Hinton for pointing this out
off-list!), however, I am at a bit of a loss for how best to rebuild the type
location.
Would it be correct to call `CreateTypeSou
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: alexfh.
danielmarjamaki added a subscriber: cfe-commits.
danielmarjamaki set the repository for this revision to rL LLVM.
this is a new check for clang-tidy that diagnoses when it see unusual array
index syntax.
there is no
hokein created this revision.
hokein added reviewers: bkramer, ioeric.
hokein added a subscriber: cfe-commits.
Currently, removing dot dot in header's path doesn't make include-fixer
minimize path correctly in some cases, for example, specify a relative search
path based on the build directory("-I
Author: ibreger
Date: Wed Jun 8 08:59:20 2016
New Revision: 272141
URL: http://llvm.org/viewvc/llvm-project?rev=272141&view=rev
Log:
[AVX512] Emit select instruction instead of using x86 specific instrinsics.
This will allow us to remove the x86 instrinics from the backend.
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272141: [AVX512] Emit select instruction instead of using
x86 specific instrinsics. (authored by ibreger).
Changed prior to commit:
http://reviews.llvm.org/D21060?vs=59840&id=60030#toc
Repository:
rL
Author: mprobst
Date: Wed Jun 8 09:04:04 2016
New Revision: 272142
URL: http://llvm.org/viewvc/llvm-project?rev=272142&view=rev
Log:
clang-format: [JS] fix an assertion failure caused by shrinking sources.
Summary:
The JavaScript import sorter has a corner condition that can cause the overall
so
Author: mprobst
Date: Wed Jun 8 09:05:26 2016
New Revision: 272143
URL: http://llvm.org/viewvc/llvm-project?rev=272143&view=rev
Log:
clang-format: [JS] fix a FIXME.
Modified:
cfe/trunk/lib/Format/SortJavaScriptImports.cpp
Modified: cfe/trunk/lib/Format/SortJavaScriptImports.cpp
URL:
http:/
Author: alexfh
Date: Wed Jun 8 09:27:43 2016
New Revision: 272144
URL: http://llvm.org/viewvc/llvm-project?rev=272144&view=rev
Log:
[clang-tidy] correct clang-tidy-diff.py help message
Summary:
Looks like the original code was copied from clang-format-diff.py.
Update help message to make it clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272144: [clang-tidy] correct clang-tidy-diff.py help message
(authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D21050?vs=59813&id=60035#toc
Repository:
rL LLVM
http://reviews.ll
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Ok, let's try this. Maybe it will solve our path problems once and for all.
ONCE AND FOR ALL.
http://reviews.llvm.org/D21132
___
cfe-commits m
Author: marshall
Date: Wed Jun 8 09:54:35 2016
New Revision: 272150
URL: http://llvm.org/viewvc/llvm-project?rev=272150&view=rev
Log:
Patch ready for #2436
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: ioeric
Date: Wed Jun 8 09:57:43 2016
New Revision: 272151
URL: http://llvm.org/viewvc/llvm-project?rev=272151&view=rev
Log:
[include-fixer] explicitly set minimize-paths in test.
Modified:
clang-tools-extra/trunk/test/include-fixer/include_path.cpp
Modified: clang-tools-extra/trunk/
Author: hokein
Date: Wed Jun 8 10:10:18 2016
New Revision: 272152
URL: http://llvm.org/viewvc/llvm-project?rev=272152&view=rev
Log:
[include-fixer] Keep dot dot in SymbolInfo file paths.
Summary:
Currently, removing dot dot in header's path doesn't make include-fixer
minimize path correctly in s
Author: yaxunl
Date: Wed Jun 8 10:11:21 2016
New Revision: 272153
URL: http://llvm.org/viewvc/llvm-project?rev=272153&view=rev
Log:
[OpenCL] Fix __builtin_astype for vec3 types.
__builtin_astype does not generate correct LLVM IR for vec3 types. This patch
inserts bitcasts to/from vec4 when nece
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272152: [include-fixer] Keep dot dot in SymbolInfo file
paths. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21132?vs=60041&id=60042#toc
Repository:
rL LLVM
http://reviews.
Author: lerochris
Date: Wed Jun 8 09:46:05 2016
New Revision: 272148
URL: http://llvm.org/viewvc/llvm-project?rev=272148&view=rev
Log:
[Sparc] Complex return value ABI compliance.
According to the Sparc V8 ABI, complex numbers should be passed and returned as
pairs of registers:
https://docs.o
hokein updated this revision to Diff 60041.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D21132
Files:
include-fixer/find-all-symbols/PathConfig.cpp
include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp
test/include-fixer/include_path.cpp
unittests/include-fixer/find-all
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272153: [OpenCL] Fix __builtin_astype for vec3 types.
(authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20133?vs=59630&id=60043#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: lerochris
Date: Wed Jun 8 09:47:25 2016
New Revision: 272149
URL: http://llvm.org/viewvc/llvm-project?rev=272149&view=rev
Log:
[Sparc] Complex return value ABI compliance.
According to the Sparc V8 ABI, complex numbers should be passed and returned as
pairs of registers:
https://docs.o
alexfh added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:142
@@ +141,3 @@
+SourceManager &SM(PP->getSourceManager());
+if (!SM.isInMainFile(MacroNameTok.getLocation()))
+ return;
I'm not sure the check currently refus
Author: alexfh
Date: Wed Jun 8 10:27:46 2016
New Revision: 272155
URL: http://llvm.org/viewvc/llvm-project?rev=272155&view=rev
Log:
[clang-tidy] misc-argument-comment: don't bail out when an argument is a macro
expansion (e.g. NULL).
Add CHECK-FIX tests.
Modified:
clang-tools-extra/trunk/c
Turns out that this is causing weirdness when path minimization is
disabled, we will insert includes with .. in that case. I don't know
how to solve that, maybe still clean up the path in the fixer if
minimization is off?
On Wed, Jun 8, 2016 at 5:10 PM, Haojian Wu via cfe-commits
wrote:
> Author:
Author: d0k
Date: Wed Jun 8 10:34:36 2016
New Revision: 272156
URL: http://llvm.org/viewvc/llvm-project?rev=272156&view=rev
Log:
Prune away some unused using decls. NFC.
Found by clang's misc-unused-using-decls.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.c
Author: majnemer
Date: Wed Jun 8 11:05:07 2016
New Revision: 272159
URL: http://llvm.org/viewvc/llvm-project?rev=272159&view=rev
Log:
[Sema] Don't permit catching variably modified types
Variably modified types shouldn't be permitted in catch clauses.
This fixes PR28047.
Modified:
cfe/trun
zaks.anna added a comment.
> For the pile of LLVM projects that I am currently building (llvm, clang,
> libcxx, libcxxabi), 18.9% of all analyzed
> functions hit the maximum step count. For the previously discussed large .C
> file, 37% of the analyzed functions hit the maximum step count.
Th
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Repository:
rL LLVM
http://reviews.llvm.org/D21134
___
cfe-commits mailing list
cfe-com
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileChec
john.brawn added a comment.
In http://reviews.llvm.org/D20732#452055, @faisalv wrote:
> I'm assuming you've given some thought to any existing pathological code that
> might break if the actual compile-time alignment of Decl itself is changed
> (since currently it seems to be that the alignment
rnk created this revision.
rnk added reviewers: aprantl, dblaikie.
rnk added a subscriber: cfe-commits.
rnk added a dependency: D21114: [DebugInfo] Add calling convention support for
DWARF and CodeView.
This should have been a very simple change, but it was greatly
complicated by the construction
hans updated this revision to Diff 60054.
hans marked 2 inline comments as done.
hans added a comment.
Addressing Saleem's comments, and renaming the flag to
-fcase-insensitive-paths, since this doesn't apply just to includes, but
anything that goes through vfs, including the main source filenam
Anastasia added inline comments.
Comment at: lib/Sema/SemaType.cpp:6494
@@ +6493,3 @@
+default:
+ assert(0 && "unable to find corresponding image type");
+}
Please start the assert message from the upper case and finish with .
Commen
eric_niebler reopened this revision.
eric_niebler added a subscriber: bogner.
eric_niebler added a comment.
This revision is now accepted and ready to land.
Reopening. I would like some eyes on the updated patch before we merge. @rsmith
Would you prefer this (and http://reviews.llvm.org/D19842) i
thakis added a comment.
For performance: Can you check how build times for some large target in
Chromium on Linux targeting Windows compares with this vs having the sdk in a
fat mount? That would give us some data.
The discussion in the include case warning thread sounds like MS might update
i
It looks like we're starting to be more careful about header case. MSVC's
intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
upper-case 'I' for no good reason.
It looks like file-only renames work fine as of svn 1.7 without any
workarounds (
http://subversion.apache.org/docs/re
Anastasia added a comment.
Looking good generally, I am just not sure about mixing two different
representations.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote:
> It looks like we're starting to be more careful about header case. MSVC's
> intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
> upper-case 'I' for no good reason.
>
> It looks like file-only renames work fine as of svn 1.7 w
JamesReynolds added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.h:89
@@ +88,3 @@
+
+ typedef std::pair NamingCheckId;
+
I think I thought that this wouldn't get picked up by the specialization
machinery - but you're right, a typedef
JamesReynolds marked an inline comment as done.
JamesReynolds added a comment.
http://reviews.llvm.org/D21020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JamesReynolds marked an inline comment as done.
JamesReynolds added a comment.
http://reviews.llvm.org/D21020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JamesReynolds updated this revision to Diff 60056.
JamesReynolds marked 5 inline comments as done.
JamesReynolds added a comment.
Applied suggested code changes.
http://reviews.llvm.org/D21020
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingChe
JamesReynolds updated this revision to Diff 60058.
JamesReynolds marked an inline comment as not done.
JamesReynolds added a comment.
Missed one modification in last update.
http://reviews.llvm.org/D21020
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/Identif
On Wed, Jun 8, 2016 at 1:27 PM, Hans Wennborg wrote:
> On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote:
> > It looks like we're starting to be more careful about header case. MSVC's
> > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an
> > upper-case 'I' for no good reason
> I still think it would be good if the extensions that only affect the
> host-side are removed, in particular cl_khr_icd and cl_khr_terminate_context.
> We have a runtime that indirectly includes both Clang’s OpenCLExtensions.def
> and the Khronos extension header, and we run into problems when
vsk added a comment.
Ping, any updates on this patch?
http://reviews.llvm.org/D20748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Ping.
http://reviews.llvm.org/D20880
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington created this revision.
erik.pilkington added reviewers: faisalv, rsmith, ahatanak.
erik.pilkington added a subscriber: cfe-commits.
Clang crashes during the instantiation of a lambda call operator where a
`VarDecl` is initialized with an expression that requires the `this` type of
Anastasia added a comment.
In http://reviews.llvm.org/D20681#450073, @yaxunl wrote:
> In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
>
> > Do you think we could add any test for this change?
>
>
> We have prelinking passes in amdgpu backend but it requires the llvm change
> to be co
On Wed, Jun 8, 2016 at 1:56 PM, Eric Niebler wrote:
> (adding back cfe-commits, answers inline)
>
> On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber" <
> tha...@google.com on behalf of tha...@chromium.org> wrote:
> >Sounds like "commit to the current file case and fix all the world
aprantl added a comment.
Assuming that we could usually get the calling convention from the Function —
what's the motivation for emitting the calling convention of a subprogram that
has been optimized away?
http://reviews.llvm.org/D21141
___
cfe-c
Author: vitalybuka
Date: Wed Jun 8 13:18:08 2016
New Revision: 272185
URL: http://llvm.org/viewvc/llvm-project?rev=272185&view=rev
Log:
Specify target in lifetime-asan test.
Summary: Some target platforms -fsanitize=address.
Reviewers: pcc, eugenis
Subscribers: cfe-commits, christof, chapuni,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272185: Specify target in lifetime-asan test. (authored by
vitalybuka).
Changed prior to commit:
http://reviews.llvm.org/D21117?vs=59987&id=60071#toc
Repository:
rL LLVM
http://reviews.llvm.org/D211
rnk added a comment.
In http://reviews.llvm.org/D21141#452517, @aprantl wrote:
> Assuming that we could usually get the calling convention from the Function —
> what's the motivation for emitting the calling convention of a subprogram
> that has been optimized away?
I don't have any motivatio
hans added a comment.
In http://reviews.llvm.org/D21113#452431, @thakis wrote:
> For performance: Can you check how build times for some large target in
> Chromium on Linux targeting Windows compares with this vs having the sdk in a
> fat mount? That would give us some data.
I measured compil
thakis added a comment.
Can you try building a few more files? Say, v8_base?
http://reviews.llvm.org/D21113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
In http://reviews.llvm.org/D20933#452352, @zaks.anna wrote:
> > For the pile of LLVM projects that I am currently building (llvm, clang,
> > libcxx, libcxxabi), 18.9% of all analyzed
>
> > functions hit the maximum step count. For the previously discussed large
> > .C f
Author: vmiklos
Date: Wed Jun 8 13:38:23 2016
New Revision: 272188
URL: http://llvm.org/viewvc/llvm-project?rev=272188&view=rev
Log:
clang-rename: implement renaming of classes inside dynamic_cast
Refactor to do the same as what is done already for static_cast.
Reviewers: klimek
Differential R
(adding back cfe-commits, answers inline)
On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber"
wrote:
>Sounds like "commit to the current file case and fix all the world's includes"
>then :-) (MinGW's windows headers have different case than MSVC's, making this
>extra annoying.)
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272188: clang-rename: implement renaming of classes inside
dynamic_cast (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21120?vs=60001&id=60073#toc
Repository:
rL LLVM
http:
On 6/8/16, 11:12 AM, "tha...@google.com on behalf of Nico Weber"
wrote:
>On Wed, Jun 8, 2016 at 1:56 PM, Eric Niebler wrote:
>>
>>(adding back cfe-commits, answers inline)
>>
>>On 6/8/16, 10:11 AM, "tha...@google.com on behalf of Nico Weber"
>> wrote:
>>>Sounds like "commit to the current file
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Function pointers make sense to me, thanks!
LGTM
Comment at: lib/CodeGen/CGDebugInfo.cpp:834
@@ -833,1 +833,3 @@
+static unsigned getDwarfCC(CallingConv CC) {
+ switch (C
yaxunl updated this revision to Diff 60078.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Modified the test for module as Anastasia suggested.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/LangOptions.def
include/cl
yaxunl marked 5 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+
+// ===
+// Compile for OpenCL 1.0 for the second time. The module should not be
re-created.
I changed the module to read only. If Clang tries to create a new mo
yaxunl added a comment.
In http://reviews.llvm.org/D20979#452463, @Anastasia wrote:
> Looking good generally, I am just not sure about mixing two different
> representations.
If we choose only one form of representation, would you suggest to use function
metadata or function attribute?
http
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
> > We have prelinking passes in amdgpu backend but it requires the llvm change
> > to be committed first. We can add a test for this after that.
>
>
> Sure. Could you subscribe me to the relevant backend reviews if possible
>
hans added a comment.
In http://reviews.llvm.org/D21113#452558, @thakis wrote:
> Can you try building a few more files? Say, v8_base?
Well, that was depressing:
Putting the sdk on a vfat fs:
real2m26.077s
user68m31.476s
sys 1m25.702s
Using the flag:
real9m5.179s
thakis added a comment.
Not sure if we want a flag that adds 50% overhead, no matter how convenient it
might be :-/
http://reviews.llvm.org/D21113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, arpith-jacob, carlo.bertolli, kkwli0.
sfantao added subscribers: caomhin, cfe-commits.
This patch fixes an issue detected when firstprivate variables are passed to an
OpenMP outlined function vararg list. Currently they are
hintonda added a comment.
The comment says to rebuild TypeSourceInfo, but isn't that what this does?
if (TSInfo->getType() != FD->getType())
Updated = getFunctionTypeWithExceptionSpec(*this, TSInfo->getType(), ESI);
TSInfo->overrideType(Updated);
If so, could you fix this by either remov
vmiklos added a comment.
Hmm,
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332/steps/test/logs/stdio
fails with "error: cannot use dynamic_cast with -fno-rtti"; is there some way
to detect if "-fno-rtti" is the default, and in that case don't execute the
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/Decl.cpp:2938-2948
@@ -2937,1 +2937,13 @@
+SourceRange FunctionDecl::getExceptionSpecSourceRange() const {
+ const TypeSourceInfo *TSI = getTypeSourceInfo();
+ if (!TSI)
+re
Author: rnk
Date: Wed Jun 8 15:41:54 2016
New Revision: 272198
URL: http://llvm.org/viewvc/llvm-project?rev=272198&view=rev
Log:
[DebugInfo] Add calling conventions to DISubroutineType
Summary:
This should have been a very simple change, but it was greatly
complicated by the construction of new
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272198: [DebugInfo] Add calling conventions to
DISubroutineType (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D21141?vs=60055&id=60101#toc
Repository:
rL LLVM
http://reviews.ll
bruno added a comment.
Before this goes in again, I want to double check that this doesn't affect
compile time on darwin + frameworks. Will get back to you asap.
Comment at: lib/Lex/PPDirectives.cpp:218
@@ +217,3 @@
+ SmallString<32> LowerInclude{Include};
+ for (char& Ch : L
rsmith added a comment.
Looks OK to me, pending Bruno's confirmation that performance is acceptable.
Comment at: lib/Lex/PPDirectives.cpp:102
Can you use `llvm::StringSwitch` for this? I'd be interested to see how the
performance compares.
http://reviews.llv
Author: marshall
Date: Wed Jun 8 16:25:38 2016
New Revision: 272202
URL: http://llvm.org/viewvc/llvm-project?rev=272202&view=rev
Log:
Mark 2441 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-projec
eric_niebler added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:33
@@ -28,2 +32,2 @@
#include "llvm/Support/Path.h"
#include "llvm/Support/SaveAndRestore.h"
You mean, instead of the `StringSet` below? Looks like `StringSwitch` just
turns into cascading
1 - 100 of 122 matches
Mail list logo
