srhines added a comment.
In http://reviews.llvm.org/D20709#443536, @kristof.beyls wrote:
> Hi Pirama,
>
> My understanding is that this introduces (yet another) ARM 32 bit ABI variant
> - in this case with longs being 64 bit.
> My understanding is also that this is the ABI that is used in Rende
majnemer added a subscriber: majnemer.
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better allocation behavior here if we don't
+// provide the same exce
Hi Will,
Thanks for the report and sorry for a delay with answer. Generally, your patch
looks good with some small nits. I can fix some minor issues like extra braces
etc. and commit it if you don't mind.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
28.05.2016
Author: ericwf
Date: Mon May 30 23:27:57 2016
New Revision: 271249
URL: http://llvm.org/viewvc/llvm-project?rev=271249&view=rev
Log:
Mark LWG issue 2520 as complete
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/pointer_deleter02.pass.c
Hi Alexey,
On 31 May 2016 at 12:25, Alexey Bataev wrote:
> Hi Will,
> Thanks for the report and sorry for a delay with answer. Generally, your
> patch looks good with some small nits. I can fix some minor issues like
> extra braces etc. and commit it if you don't mind.
>
Sure thing. Commit away
EricWF marked 6 inline comments as done.
EricWF added a comment.
@majnemer Thanks for looking at this!
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better allo
Author: ctopper
Date: Tue May 31 00:49:13 2016
New Revision: 271250
URL: http://llvm.org/viewvc/llvm-project?rev=271250&view=rev
Log:
[X86] Use unaligned load intrinsics to implement other intrinsics instead of
manually creating the unaligned load.
Modified:
cfe/trunk/lib/Headers/avxintrin.h
Author: abataev
Date: Tue May 31 01:21:27 2016
New Revision: 271251
URL: http://llvm.org/viewvc/llvm-project?rev=271251&view=rev
Log:
[MSVC] Fix stack overflow in unqualified type lookup logic, by Will
Wilson.
An unqualified lookup for in base classes may cause stack overflow if
the base class is
rmaprath added a comment.
Thanks Eric.
I think I noted a few other `assert(true)` statements elsewhere (with similar
application), will update those separately.
Btw, do you use some systematic way to detect ABI breakages? I've only bumped
into http://lvc.github.io/abi-compliance-checker/ but d
EricWF added a comment.
In http://reviews.llvm.org/D20677#443997, @rmaprath wrote:
> Thanks Eric.
>
> I think I noted a few other `assert(true)` statements elsewhere (with similar
> application), will update those separately.
>
> Btw, do you use some systematic way to detect ABI breakages? I've
EricWF added a comment.
In http://reviews.llvm.org/D16948#443945, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443942, @EricWF wrote:
>
> > In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
> >
> > > I'm seeing a few failures on my Fedora 20 system. Will go through these
> > > t
rmaprath added a comment.
In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
> I installed a Fedora 23 system and ran the test suite and I didn't see any of
> the same failures. It must be something other than the distro.
> Are you using an odd filesystem? Or maybe it could be your system
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
>
EricWF added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
> >
101 - 114 of 114 matches
Mail list logo
