Author: sfantao
Date: Thu May 26 13:30:22 2016
New Revision: 270886
URL: http://llvm.org/viewvc/llvm-project?rev=270886&view=rev
Log:
[OpenMP] Codegen for target update directive.
Summary: This patch implements the code generation for the `target update`
directive. The implemntation relies on th
aturetsk added inline comments.
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
bruno wrote:
> aturetsk wrote:
> > bruno wrote
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:446
@@ +445,3 @@
+ case SD_FullExpression:
+EHStack.pushCleanup(NormalEHLifetimeMarker, Object,
+ Size);
This should use pushFullExprCleanup.
Author: kzhuravl
Date: Thu May 26 14:36:39 2016
New Revision: 270895
URL: http://llvm.org/viewvc/llvm-project?rev=270895&view=rev
Log:
[AMDGPU] Remove individual debugger options + update features
Differential Revision: http://reviews.llvm.org/D20336
Modified:
cfe/trunk/include/clang/Driver/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270895: [AMDGPU] Remove individual debugger options + update
features (authored by kzhuravl).
Changed prior to commit:
http://reviews.llvm.org/D20336?vs=57518&id=58668#toc
Repository:
rL LLVM
http:/
kzhuravl added a comment.
http://reviews.llvm.org/rL270895
Repository:
rL LLVM
http://reviews.llvm.org/D20336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Thu May 26 14:42:56 2016
New Revision: 270897
URL: http://llvm.org/viewvc/llvm-project?rev=270897&view=rev
Log:
Re-commit r270748 "clang-cl: Treat dllimport explicit template instantiation
definitions as declarations (PR27810, PR27811)"
Also make explicit instantiation decls n
delena added inline comments.
Comment at: test/CodeGen/avx512f-builtins.c:1927
@@ +1926,3 @@
+ // check-label: @test_mm512_div_pd
+ // check: @llvm.x86.avx512.mask.div.pd.512
+ return _mm512_div_pd(__a,__b);
I don't understand how do you receive intrinsic if
bcraig added a comment.
LGTM. Probably want a "LGTM" from at least one other person though.
In http://reviews.llvm.org/D20677#441085, @rmaprath wrote:
> In http://reviews.llvm.org/D20677#441061, @jroelofs wrote:
>
> > This is the canonical reference for the Itanium ABI:
> > https://mentorembed
timshen updated this revision to Diff 58676.
timshen added a comment.
Update to reflect the comments.
http://reviews.llvm.org/D20498
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Sema/CleanupInfo.h
include/clang/Sema/ScopeInfo.h
include/clang/Sema/Sema.h
timshen marked 7 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:6190-6191
@@ +6189,4 @@
+ MaterializeTemporaryExpr(T, Temporary, BoundToLvalueReference);
+
+ // Order an ExprWithCleanups for lifetime marks.
+ //
> Please also sink the calls to m
Author: rsmith
Date: Thu May 26 15:23:13 2016
New Revision: 270904
URL: http://llvm.org/viewvc/llvm-project?rev=270904&view=rev
Log:
Produce better pretty stack traces from crashes in template instantiation: add
pretty stack trace entries for all cases where we instantiate the definition of
someth
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6197
@@ +6196,3 @@
+ // but there may be a chance to merge them.
+ if (getLangOpts().CPlusPlus)
+Cleanup.setExprNeedsCleanups(false);
Why is this C++-only? We presumably would want to clean up a
rmaprath added a comment.
Looks like this patch breakes gcc builds of libunwind (none of the bots seem to
test it though).
The problem is two-fold, in `src/config.h` we have:
// Define static_assert() unless already defined by compiler.
timshen updated this revision to Diff 58694.
timshen marked 2 inline comments as done.
timshen added a comment.
Removed C++ constrain and added back the missing comment line.
http://reviews.llvm.org/D20498
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Sema/Clea
jroelofs added a comment.
In http://reviews.llvm.org/D20119#441516, @rmaprath wrote:
> Please shout!
Just add some parens:
static_assert((check_fit::does_fit),
"or1k registers do not fit into unw_context_t");
http://reviews.llvm.org/D20119
___
LGTM.
> On 2016-May-26, at 11:34, Bruno Cardoso Lopes wrote:
>
> bruno added a comment.
>
> Ping!
>
>
> http://reviews.llvm.org/D20404
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
LGTM.
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In http://reviews.llvm.org/D20119#441548, @jroelofs wrote:
> In http://reviews.llvm.org/D20119#441516, @rmaprath wrote:
>
> > Please shout!
>
>
> Just add some parens:
>
> static_assert((check_fit::does_fit),
> "or1k registers do not fit into unw_co
Author: asiri
Date: Thu May 26 16:45:54 2016
New Revision: 270925
URL: http://llvm.org/viewvc/llvm-project?rev=270925&view=rev
Log:
Fix gcc libunwind build.
r270692 seems to have broken gcc builds of libunwind. This is because
statements like:
static_assert(check_fit::does_fit,
On 5/26/16 3:45 PM, Asiri Rathnayake via cfe-commits wrote:
struct blk_count {
-static const uint32_t count =
+static const uint64_t count =
(sizeof(T) + sizeof(uint64_t) -
Should that be 'size_t' instead?
Jon
--
Jon Roelofs
jonat...@codesourcery.com
CodeSourcery / Ment
EricWF added a comment.
I want to take a look at this as well. I'll review it tomorrow.
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: mclow.lists.
EricWF added a comment.
Adding @mclow.lists to this as well.
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: asiri
Date: Thu May 26 16:56:04 2016
New Revision: 270927
URL: http://llvm.org/viewvc/llvm-project?rev=270927&view=rev
Log:
Use size_t to store the results of sizeof calculations.
NFC.
Modified:
libunwind/trunk/src/config.h
Modified: libunwind/trunk/src/config.h
URL:
http://llvm.or
rmaprath added a comment.
In http://reviews.llvm.org/D20677#441407, @bcraig wrote:
> https://mentorembedded.github.io/cxx-abi/abi-eh.html mentions the functions,
> but it doesn't really say what they are for. The C++ standard mentions when
> an exception of std::bad_cast and std::bad_typeid ar
rmaprath added a comment.
In http://reviews.llvm.org/D20677#441598, @EricWF wrote:
> I want to take a look at this as well. I'll review it tomorrow.
Thanks! will wait until we have ironed out all the details, no hurry.
/ Asiri
http://reviews.llvm.org/D20677
___
sfantao updated this revision to Diff 58704.
sfantao updated the summary for this revision.
sfantao added a comment.
Remove most of the logic in the first diff. It is no longer necessary given
that all firstprivate
captures are now passed by value no matter the directive they are captured in.
S
craig.topper added a subscriber: craig.topper.
Comment at: test/CodeGen/avx512f-builtins.c:1927
@@ +1926,3 @@
+ // check-label: @test_mm512_div_pd
+ // check: @llvm.x86.avx512.mask.div.pd.512
+ return _mm512_div_pd(__a,__b);
delena wrote:
> I don't understand
pirama created this revision.
pirama added a reviewer: kristof.beyls.
pirama added subscribers: srhines, cfe-commits.
Herald added subscribers: rengolin, aemerson.
Set alignment and width of long datatype to be 64-bits if the ARM
subtarget feature +long64 is set.
http://reviews.llvm.org/D20709
F
tigerleapgorge created this revision.
tigerleapgorge added a reviewer: rsmith.
tigerleapgorge added a subscriber: cfe-commits.
Hi everyone,
I am back again with Lit test C++11 compatibility patch #9.
30 tests are updated this time.
They are follows.
CXX/basic/basic.stc/basic.stc.dynamic/p2-no
bryanpkc updated this revision to Diff 58722.
bryanpkc added a comment.
Fixed the code to set GoodVersion.MajorStr before returning, and removed an
unnecessary file
(test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o).
http://reviews.llvm.org/D14727
Files:
l
jroelofs added a comment.
In http://reviews.llvm.org/D14727#441758, @bryanpkc wrote:
> Fixed the code to set GoodVersion.MajorStr before returning, and removed an
> unnecessary file
> (test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o).
That file is not unnec
Author: chapuni
Date: Thu May 26 19:15:11 2016
New Revision: 270940
URL: http://llvm.org/viewvc/llvm-project?rev=270940&view=rev
Log:
OpenMPClause.h: Fix r270882. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/AST/OpenMPClause.h
Modified: cfe/trunk/include/clang/AST/OpenMPClause.h
URL:
bryanpkc updated this revision to Diff 58723.
bryanpkc added a comment.
Re-added
test/Driver/Inputs/gcc_version_parsing5/lib/gcc/i386-unknown-linux/4.9.2/crtbegin.o.
http://reviews.llvm.org/D14727
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/gcc_version_parsing5/
test/Driver/Input
rsmith added a comment.
Seems reasonable to me.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3427
@@ -3402,5 +3402,6 @@
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ SourceRange NoexceptRange(Tok.getLocation(),
+
rsmith added inline comments.
Comment at: include/clang/AST/TypeLoc.h:1251
@@ -1250,2 +1250,3 @@
SourceLocation RParenLoc;
+ SourceRange ExceptionSpecRange;
SourceLocation LocalRangeEnd;
Can you arrange things so we only store this if there is an exception
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, hokein, etienneb.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLV
timshen updated this revision to Diff 58734.
timshen added a comment.
Herald added a subscriber: klimek.
Used pushFullExprCleanup.
microsoft-abi-eh-cleanups.cpp fails because each pushFullExprCleanup introduces
a new cleanup.cond variable, even if that pushFullExprCleanup is just for
lifetime m
timshen updated this revision to Diff 58738.
timshen added a comment.
Upload the rebased patch.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/EHScopeStack.h
test/CodeGen/tempora
timshen updated this revision to Diff 58737.
timshen added a comment.
Upload the rebased patch.
http://reviews.llvm.org/D20499
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Sema/CleanupInfo.h
include/clang/Sema/ScopeInfo.h
include/clang/Sema/Sema.h
lib/AS
vsk created this revision.
vsk added a reviewer: bogner.
vsk added subscribers: kcc, cfe-commits, silvas.
It would be helpful to have a user-friendly guide for code coverage. There is
some overlap with [1], but this document visits issues which may affect users
in more depth.
Prompted by: https
timshen marked an inline comment as done.
timshen added a comment.
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 58740.
ahatanak added a comment.
Remove unused variable and add test case.
http://reviews.llvm.org/D20334
Files:
src/strstream.cpp
test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp
Index:
test/std/depr/d
ahatanak marked an inline comment as done.
ahatanak added a comment.
I spent some time debugging the code and here is what I found.
The initial buffer size is 0 when strstreambuf is constructed and all six
pointers are null initially. When the first character is pushed,
strstreambuf::overflow a
Author: majnemer
Date: Thu May 26 21:06:14 2016
New Revision: 270952
URL: http://llvm.org/viewvc/llvm-project?rev=270952&view=rev
Log:
[Intrin.h] Sort the __read[fg]s intrinsics
No functional change is intended.
Modified:
cfe/trunk/lib/Headers/Intrin.h
Modified: cfe/trunk/lib/Headers/Intrin
Author: majnemer
Date: Thu May 26 21:06:19 2016
New Revision: 270953
URL: http://llvm.org/viewvc/llvm-project?rev=270953&view=rev
Log:
[CodeGen] Don't crash when sizeof(long) != 4 for some intrins
_InterlockedIncrement and _InterlockedDecrement have 'long' in their
prototypes. We assumed 'long'
alexfh added a comment.
Full context diffs, please. See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
for instructions.
Repository:
rL LLVM
http://reviews.llvm.org/D20714
___
cfe-commits mailing list
cfe-commit
pxli168 added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntegerC
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added a comment.
Hi Daniel,
Will fix it ASAP
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
27.05.2016 1:33, Samuel Antao пишет:
> sfantao updated the summary for this revision.
>
> http://reviews.llvm.org/D18110
http://reviews.llvm.org/D18110
mclow.lists added a comment.
Let's file a bug on this too - http://llvm.org/bugs (make it easier to find in
the future)
http://reviews.llvm.org/D20334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: abataev
Date: Thu May 26 23:13:39 2016
New Revision: 270962
URL: http://llvm.org/viewvc/llvm-project?rev=270962&view=rev
Log:
[OPENMP] Fixed processing of '-fopenmp-version=' option and test.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
101 - 152 of 152 matches
Mail list logo
