This revision was automatically updated to reflect the committed changes.
Closed by commit rL270279: Update -ffast-math documentation to match reality.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D20457?vs=57958&id=57995#toc
Repository:
rL LLVM
http://reviews.llvm
Author: jlebar
Date: Fri May 20 16:33:01 2016
New Revision: 270279
URL: http://llvm.org/viewvc/llvm-project?rev=270279&view=rev
Log:
Update -ffast-math documentation to match reality.
Reviewers: rsmith
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20457
Modified:
jlebar added a comment.
Thank you for the review!
http://reviews.llvm.org/D20457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked 2 inline comments as done.
jlebar added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DaveBartolomeo updated this revision to Diff 58014.
DaveBartolomeo added a comment.
Removed unnecessary braces.
Moved BTT_IsAssignable case to a more clear location.
http://reviews.llvm.org/D20492
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/Ty
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
These ExprWithCleanups are added for holding a RunCleanupsScope not
for destructor calls; rather, they are for lifetime marks. This requires
ExprWithCleanups
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's
easy to add correct lifetime.end marks into the right RunCleanupsScope.
http://reviews.llvm.org/D20499
Files:
lib/Co
timshen abandoned this revision.
timshen added a comment.
Abandon this change, since http://reviews.llvm.org/D20498 and
http://reviews.llvm.org/D20499 handle all temporaries.
http://reviews.llvm.org/D19930
___
cfe-commits mailing list
cfe-commits@l
rnk created this revision.
rnk added reviewers: avt77, rsmith.
rnk added a subscriber: cfe-commits.
In dependent contexts where we know a type name is required, such as a
new expression, we can recover by forming a DependentNameType.
Works towards parsing atlctrlw.h, which is PR26748.
http://rev
rnk added a comment.
In http://reviews.llvm.org/D19479#435620, @rnk wrote:
> To deal with the specific case in ATL, we can use the 'new' expression as a
> hint that the unknown identifier is actually a dependent type. There should
> be some bit of context we can look at in DiagnoseUnknownTypeNa
Author: alexfh
Date: Fri May 20 17:42:03 2016
New Revision: 270288
URL: http://llvm.org/viewvc/llvm-project?rev=270288&view=rev
Log:
Fix docs
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-avoid-bind.rst
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:2871-2872
@@ -2870,1 +2870,4 @@
+ // When false, it must not have side effects.
+ bool CleanupsHaveSideEffects;
+
You may as well put this in the bitfield storage on `Stmt`.
===
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5636-5639
@@ -5634,4 +5635,6 @@
- Expr *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ auto *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ if (Cleanup.cleanupsHaveSideEffects())
+
rsmith added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2282
@@ -2281,3 +2281,3 @@
// Otherwise, if we don't consume this token, we are going to emit an
// error anyway. Try to recover from various common problems. Check
Maybe put the check her
EricWF added a subscriber: EricWF.
EricWF added a comment.
Should this have a test in `test/Lexer/has_feature_type_traits.cpp`?
http://reviews.llvm.org/D20492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
101 - 115 of 115 matches
Mail list logo
