curdeius added a subscriber: curdeius.
curdeius added a comment.
Some minor remarks. Sorry for being finicky :).
Comment at: include/clang/Basic/VirtualFileSystem.h:97
@@ +96,3 @@
+ return Status->getName();
+else
+ return Status.getError();
No els
hokein updated this revision to Diff 57569.
hokein marked an inline comment as done.
hokein added a comment.
Make a node matcher for unresolvedLookupExpr type.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index:
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Add a node matcher for UnresolvedLookupExpr in ASTMatcher.
+AST_MATCHER(CallExpr, hasUnresolvedLookupExpr) {
+ return isa(Node.getCallee());
a
Author: ioeric
Date: Wed May 18 03:02:56 2016
New Revision: 269888
URL: http://llvm.org/viewvc/llvm-project?rev=269888&view=rev
Log:
Make clang-format cleaner remove redundant commas in list and redundant colon
in constructor initializer.
Summary: Make clang-format cleaner remove redundant comma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269888: Make clang-format cleaner remove redundant commas in
list and redundant colon… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D19804?vs=57146&id=57570#toc
Repository:
apelete updated this revision to Diff 57571.
apelete retitled this revision from "[scan-build] fix warnings emitted on Clang
AST code base " to "[scan-build] fix warnings emitted on Clang AST code base".
apelete added a comment.
[scan-build] fix warnings emitted on Clang AST code base
Changes si
a.makarov added a comment.
Thanks!
http://reviews.llvm.org/D20171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Wed May 18 03:14:49 2016
New Revision: 269889
URL: http://llvm.org/viewvc/llvm-project?rev=269889&view=rev
Log:
[clang-format] Make FormatTokenLess::operator() const.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.or
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+ return isa(Node);
That's because we need a node matcher, not narrowing
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+ return isa(Node);
alexfh wrote:
> That's because we need a
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+AST_MATCHER(Stmt, unresolvedLookupExpr) {
+ return isa(Node);
hokein wrote:
> alexfh wrote:
> > That's because we
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include-fixer/SymbolIndexManager.cpp:45
@@ +44,3 @@
+ while (IdentiferContext != Names.rend() &&
+ SymbolContext != Symbol.getContexts().end(
On 18 May 2016 at 03:45, Tim Northover via cfe-commits
wrote:
> Well yes, it's probably got orders of magnitude less bugs than the
> backend for a start.
:D
> Generally we're far more relaxed as long as a specification is on the
> way. We're up to to v8.2 in LLVM proper already, and I don't thi
bkramer added a comment.
I expect the insertion code in the python part to cause trouble in the future
again but I guess this is fine for now.
Can you add a section to include-fixer.rst on how to set this up?
http://reviews.llvm.org/D20329
___
cfe
hokein updated this revision to Diff 57576.
hokein added a comment.
Create a node matcher for UnresolvedLookupExpr.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cp
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:24
@@ +23,3 @@
+// FIXME: Move this node matcher to ASTMatcher.
+const internal::VariadicDynCastAllOfMatcher
+unresolvedLookupExpr;
Sounds good. Done.
http://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269890: [include-fixer] Ignore non-scoped enum declaration
during search. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20354?vs=57572&id=57577#toc
Repository:
rL LLVM
http
Author: hokein
Date: Wed May 18 04:04:43 2016
New Revision: 269890
URL: http://llvm.org/viewvc/llvm-project?rev=269890&view=rev
Log:
[include-fixer] Ignore non-scoped enum declaration during search.
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.o
Author: abataev
Date: Wed May 18 04:06:38 2016
New Revision: 269891
URL: http://llvm.org/viewvc/llvm-project?rev=269891&view=rev
Log:
Support for MSVS default calling convention options (/Gd, /Gz, /Gv,
/Gr), by Alexander Makarov
Patch for bug #27711
Differential Revision: http://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269891: Support for MSVS default calling convention options
(/Gd, /Gz, /Gv, (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D20171?vs=57344&id=57579#toc
Repository:
rL LLVM
h
vmiklos created this revision.
vmiklos added reviewers: cfe-commits, klimek.
The result of the test was C::D(), not D::D().
http://reviews.llvm.org/D20356
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/CtorDefTest.cpp
Index: test/clang-rename/CtorDefTest.cpp
rs marked an inline comment as done.
rs added a comment.
> It's been our stance for a long time to require docs to approve changes,
> however small. I don't want to relax that which I think is a good constraint,
> not for such a seemly irrelevant issue.
> I also doubt this will be the only addi
ikudrin added a comment.
In http://reviews.llvm.org/D20287#431055, @davidxl wrote:
> On the other hand, I wonder what is the real root cause of the problem. The
> dummy function record does not have its 'own' profile counts, so
>
> if (std::error_code EC = ProfileReader.getFunctionCounts(
>
Author: d0k
Date: Wed May 18 04:28:45 2016
New Revision: 269894
URL: http://llvm.org/viewvc/llvm-project?rev=269894&view=rev
Log:
[include-fixer] Run tests with -fno-ms-compatibility.
Something behind that flag makes us get fewer typo correction callbacks,
unbreak the tests on windows for now.
M
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:95
@@ +94,3 @@
+ if (auto *ULE = Result.Nodes.getNodeAs("used")) {
+for (auto I = ULE->decls_begin(), E = ULE->de
Author: d0k
Date: Wed May 18 04:48:46 2016
New Revision: 269896
URL: http://llvm.org/viewvc/llvm-project?rev=269896&view=rev
Log:
[clang-tidy] Fix a functional change from r269656.
Instead of forming char ranges that patch made us form token ranges,
which behave subtly different. Sadly I'm only s
rengolin added a comment.
Thanks Ranjeet,
The tests don't really need the new builtin to exist at all and can be added
now.
When you submit the __arm_cdp patch, you just need to make sure Clang generates
a call to @llvm.arm.cdp and everything else will be covered.
cheers,
--renato
Repositor
Thanks for the work here - but this bug is a duplicate of this:
https://llvm.org/bugs/show_bug.cgi?id=27507, which unearthed some
other subtle bugs with the cv capture of *this by copy.
I've submitted a patch for review here: http://reviews.llvm.org/D19783
that addresses both issues - about 2-3 wee
hokein updated this revision to Diff 57586.
hokein marked an inline comment as done.
hokein added a comment.
Use for-range loop.
http://reviews.llvm.org/D20326
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-us
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Thank you for fixing this!
On Wed, May 18, 2016 at 11:48 AM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Wed May 18 04:48:46 2016
> New Revision: 269896
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269896&view=rev
> Log:
> [clang-tidy] Fix a func
m_zuckerman created this revision.
m_zuckerman added a reviewer: craig.topper.
m_zuckerman added subscribers: delena, cfe-commits.
http://reviews.llvm.org/D20358
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx512f-builtins.c
Index: lib/CodeGen/CGBuiltin.cpp
m_zuckerman created this revision.
m_zuckerman added a reviewer: craig.topper.
m_zuckerman added subscribers: delena, cfe-commits, AsafBadouh, igorb.
http://reviews.llvm.org/D20359
Files:
include/llvm/IR/IntrinsicsX86.td
lib/Target/X86/X86IntrinsicsInfo.h
test/CodeGen/X86/avx512-intrinsics.
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
docs/tools/dump_ast_matchers.py
include/clang/ASTMatchers/ASTMatchers.h
lib/AST
Author: hokein
Date: Wed May 18 06:49:34 2016
New Revision: 269906
URL: http://llvm.org/viewvc/llvm-project?rev=269906&view=rev
Log:
[clang-tidy] Fix a template function false positive in misc-unused-using-decls
check.
Summary: Ignore warning uninstantiated template function usages.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269906: [clang-tidy] Fix a template function false positive
in misc-unused-using… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20326?vs=57586&id=57591#toc
Repository:
rL LL
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they be
reverted?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1089
@@ -
alexfh added a comment.
In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote:
> The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they
> be reverted?
The script should be executable, so the change looks fine to me.
http://reviews.llvm.org/D20360
___
Author: rafael
Date: Wed May 18 06:58:56 2016
New Revision: 269910
URL: http://llvm.org/viewvc/llvm-project?rev=269910&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp
aaron.ballman added a comment.
In http://reviews.llvm.org/D20360#432878, @alexfh wrote:
> In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote:
>
> > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can
> > they be reverted?
>
>
> The script should be executable, so
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269907: Add new intrinsic support for MONITORX and MWAITX
instructions (authored by Ashutosh).
Changed prior to commit:
http://reviews.llvm.org/D19796?vs=55788&id=57593#toc
Repository:
rL LLVM
http:
Author: ashutosh
Date: Wed May 18 06:56:23 2016
New Revision: 269907
URL: http://llvm.org/viewvc/llvm-project?rev=269907&view=rev
Log:
Add new intrinsic support for MONITORX and MWAITX instructions
Summary:
MONITORX/MWAITX instructions provide similar capability to the MONITOR/MWAIT
pair while ad
Thank you for the patch! Note, however, that most clang-tidy reviews are
done using Phabricator (see llvm.org/docs/Phabricator.html). It's not
required, but it makes the reviews much easier (and much easier to keep
track of).
On Tue, May 17, 2016 at 10:47 PM, Mads Ravn via cfe-commits <
cfe-commit
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (const auto *Overridden : Node.overridden_methods()) {
+BoundNodesTreeBuilder OverriddenBuilder(*Builder);
courbet wrote
hokein updated this revision to Diff 57596.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
docs/tools/dump_ast_matchers.py
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMa
Hi,
To add my oar in, I agree with Tim here. It is regrettable but true that
documentation, be that the ARMARM or ACLE tends to lag behind our
development. If LLVM wants to be at the leading edge of architecture
support (I hope it does!) then patches will just have to be accepted
without pointers
hokein updated this revision to Diff 57597.
hokein added a comment.
Remove modification of dump_ast_matchers.py
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTM
hokein added a comment.
> ! In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote:
> World executable? That's a bit presumptuous. ;-) 0744 may be fine, but 0755
> does not seem correct to me.
>
> Regardless, I think that it should be a separate commit, not part of this one
> as a d
On 18 May 2016 at 13:18, James Molloy wrote:
> The ACLE in particular stays in draft for some time, because it often waits
> for implementations to be done in GCC and LLVM to see if the specification
> is actually workable!
I can't imagine ARM sharing a draft, so this is actually a better
argumen
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D20360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hokein updated this revision to Diff 57600.
hokein added a comment.
Rebase to master.
http://reviews.llvm.org/D20360
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNodeTest.cpp
Index
m_zuckerman accepted this revision.
m_zuckerman added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D20321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ABataev added a comment.
Please, update to latest revision. I made some changes in firstprivates that
may affect your patch. Will review it after it.
http://reviews.llvm.org/D20112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4873-4877
@@ -4880,1 +4872,7 @@
+OMP_MAP_IS_PTR = 0x10,
+/// \brief This flags signals that an argument is the first one relating to
+/// a map/private clause expression. For some cases a single
ioeric created this revision.
ioeric added reviewers: bkramer, djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
[clang-format] Make formatReplacements() also sort #includes.
http://reviews.llvm.org/D20362
Files:
lib/Format/Format.cpp
unittests/Format/Format
Author: petarj
Date: Wed May 18 07:46:06 2016
New Revision: 269914
URL: http://llvm.org/viewvc/llvm-project?rev=269914&view=rev
Log:
[Mips] Finetuning MIPS32 Android default variants
MIPS32 Android defaults to FPXX ("-fpxx").
MIPS32R6 Android defaults to FP64A ("-mfp64 -mno-odd-spreg").
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269914: [Mips] Finetuning MIPS32 Android default variants
(authored by petarj).
Changed prior to commit:
http://reviews.llvm.org/D20345?vs=57543&id=57603#toc
Repository:
rL LLVM
http://reviews.llvm.
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. I am not even certain whether we want to keep a separate
sortIncludes in the interface at all, but as this doesn't change the public
API, it doesn't hurt.
http://reviews.llvm.o
Author: hokein
Date: Wed May 18 07:53:59 2016
New Revision: 269916
URL: http://llvm.org/viewvc/llvm-project?rev=269916&view=rev
Log:
[ASTMatcher] Add a node matcher for UnresolvedLookupExpr.
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, klimek, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269916: [ASTMatcher] Add a node matcher for
UnresolvedLookupExpr. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20360?vs=57600&id=57605#toc
Repository:
rL LLVM
http://revie
Author: hokein
Date: Wed May 18 08:07:13 2016
New Revision: 269918
URL: http://llvm.org/viewvc/llvm-project?rev=269918&view=rev
Log:
[clang-tidy] Fix misc-unused-using-decls test failure in windows
buildbot.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls.cpp
Modifi
madsravn created this revision.
madsravn added reviewers: alexfh, vsk, djasper, klimek.
madsravn added a subscriber: cfe-commits.
This is a patch for bug: https://llvm.org/bugs/show_bug.cgi?id=27731
I have excluded types which are trivially copyable from being called with
std::move in the modern
Author: rksimon
Date: Wed May 18 08:17:39 2016
New Revision: 269921
URL: http://llvm.org/viewvc/llvm-project?rev=269921&view=rev
Log:
[X86][SSE3] Sync with llvm/test/CodeGen/X86/sse3-intrinsics-fast-isel.ll
Modified:
cfe/trunk/test/CodeGen/sse3-builtins.c
Modified: cfe/trunk/test/CodeGen/sse
klimek added inline comments.
Comment at: lib/Format/SortJavaScriptImports.cpp:46-47
@@ +45,4 @@
+// An ES6 module reference.
+//
+// ES6 implements a module system, where individual modules (~= source files)
+// can reference other modules, either importing symbols from them, or
Author: d0k
Date: Wed May 18 08:32:38 2016
New Revision: 269923
URL: http://llvm.org/viewvc/llvm-project?rev=269923&view=rev
Log:
[include-fixer] Don't insert #includes if a fatal error occurred.
This typically happens when the user didn't setup include paths correctly
and the fixer starts adding
Author: ioeric
Date: Wed May 18 08:43:48 2016
New Revision: 269924
URL: http://llvm.org/viewvc/llvm-project?rev=269924&view=rev
Log:
[clang-format] Make formatReplacements() also sort #includes.
Summary: [clang-format] Make formatReplacements() also sort #includes.
Reviewers: bkramer, djasper
S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269924: [clang-format] Make formatReplacements() also sort
#includes. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20362?vs=57601&id=57612#toc
Repository:
rL LLVM
http://r
Author: rksimon
Date: Wed May 18 08:47:16 2016
New Revision: 269926
URL: http://llvm.org/viewvc/llvm-project?rev=269926&view=rev
Log:
[X86][SSE41] Sync with llvm/test/CodeGen/X86/sse41-intrinsics-fast-isel.ll
Modified:
cfe/trunk/test/CodeGen/sse41-builtins.c
Modified: cfe/trunk/test/CodeGen/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Do you need me to submit the patch for you?
Next time please create diff with the full context
(http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
Thank you
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20366
Files:
docs/tools/dump_ast_matchers.py
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
hokein added a comment.
I don't why the diff shows 755 here. But in my local directory, it's
`rwxr--r--`.
http://reviews.llvm.org/D20366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433052, @hokein wrote:
> I don't why the diff shows 755 here. But in my local directory, it's
> `rwxr--r--`.
Yeah, I'm not certain either (I've never used phab for reviewing this sort of
thing). I would prefer this to be 0744 so
ioeric updated this revision to Diff 57615.
ioeric added a comment.
- Added docs for Vim integration into include-fixer.rst.
http://reviews.llvm.org/D20329
Files:
docs/include-fixer.rst
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
Index: include-fixe
alexfh added a comment.
Please create a diff with the full context:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:84
@@ +83,3 @@
+ const auto DiagMsg =
+ "Inefficient s
Author: ioeric
Date: Wed May 18 09:10:16 2016
New Revision: 269927
URL: http://llvm.org/viewvc/llvm-project?rev=269927&view=rev
Log:
[clang-include-fixer] Added Vim integration for clang-include-fixer.
Summary: [clang-include-fixer] Added Vim integration for clang-include-fixer.
Reviewers: hokei
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269927: [clang-include-fixer] Added Vim integration for
clang-include-fixer. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20329?vs=57615&id=57618#toc
Repository:
rL LLVM
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269928: [clang-tidy] Use unresolvedLookupExpr node matcher
from ASTMatcher. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20367?vs=57616&id=57619#toc
Repository:
rL LLVM
ht
Author: hokein
Date: Wed May 18 09:11:20 2016
New Revision: 269928
URL: http://llvm.org/viewvc/llvm-project?rev=269928&view=rev
Log:
[clang-tidy] Use unresolvedLookupExpr node matcher from ASTMatcher.
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, cfe-commits
Differential Revision
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20367
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
Index: clang-tidy/misc/UnusedUsingDeclsCheck.cpp
==
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D20367
__
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
alexfh added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.h:30
@@ -29,1 +29,3 @@
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+ void registerPPCallbacks(clang::CompilerInstance &Compiler) override;
+ void storeOp
flx marked 4 inline comments as done.
flx added a comment.
Thanks for the feedback!
http://reviews.llvm.org/D20277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:131
@@ +130,3 @@
+ for (const auto *Constructor : Record->ctors()) {
+if (Constructor->isMoveConstructor() && !Constructor->isDeleted())
+ return true;
Sorry I missed this. Will addre
mprobst updated this revision to Diff 57621.
mprobst marked 2 inline comments as done.
mprobst added a comment.
- address review comments
- - extract parseModuleReferences
http://reviews.llvm.org/D20198
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
mprobst marked 6 inline comments as done.
mprobst added a comment.
PTAL.
Comment at: lib/Format/SortJavaScriptImports.cpp:93-96
@@ +92,6 @@
+return LHS.Category < RHS.Category;
+ if (LHS.Category == JsModuleReference::ReferenceCategory::SIDE_EFFECT)
+// Side effect impo
Doesn't look like this helped:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12300
On Wed, May 18, 2016 at 9:07 AM, Haojian Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Wed May 18 08:07:13 2016
> New Revision: 269918
>
> URL: http://llvm.org/vie
hokein added a comment.
In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
> Yeah, I'm not certain either (I've never used phab for reviewing this sort of
> thing). I would prefer this to be 0744 so that it is not group or world
> executable.
No idea on this now. I tried `chmod 7
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 57620.
http://reviews.llvm.org/D20277
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/performance/UnnecessaryValueParamCheck.h
clang-tidy/utils/CMakeLists.txt
clang-tidy/util
Author: rksimon
Date: Wed May 18 09:32:16 2016
New Revision: 269932
URL: http://llvm.org/viewvc/llvm-project?rev=269932&view=rev
Log:
Removed duplicate SSE42 builtin tests from avx-builtins.c
Modified:
cfe/trunk/test/CodeGen/avx-builtins.c
Modified: cfe/trunk/test/CodeGen/avx-builtins.c
URL:
mprobst added a comment.
PTAL.
http://reviews.llvm.org/D20198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote:
> In http://reviews.llvm.org/D20360#432878, @alexfh wrote:
>
> > In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote:
> >
> > > The changes to docs/tools/dump_ast_matchers.py look to be spurious, ca
hokein created this revision.
hokein added reviewers: alexfh, aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D20369
Files:
unittests/ASTMatchers/ASTMatchersTest.h
Index: unittests/ASTMatchers/ASTMatchersTest.h
=
aaron.ballman added a comment.
In http://reviews.llvm.org/D20366#433103, @hokein wrote:
> In http://reviews.llvm.org/D20366#433054, @aaron.ballman wrote:
>
> > Yeah, I'm not certain either (I've never used phab for reviewing this sort
> > of thing). I would prefer this to be 0744 so that it is n
aaron.ballman added a comment.
Hrm, I kind of worry about this masking bugs when delayed template parsing is
enabled (which it is by default on MSVC-built versions of clang).
http://reviews.llvm.org/D20369
___
cfe-commits mailing list
cfe-commits@l
Author: kparzysz
Date: Wed May 18 09:56:14 2016
New Revision: 269934
URL: http://llvm.org/viewvc/llvm-project?rev=269934&view=rev
Log:
[Hexagon] Recognize "q" and "v" in inline-asm as register constraints
Clang follow-up to r269933.
Added:
cfe/trunk/test/CodeGen/hexagon-inline-asm.c
Modified
thakis added a subscriber: thakis.
thakis added a comment.
I agree with Aaron. Maybe you could change Matcher.UnresolvedLookupExpr to call
bar() from a new function foo() so that it gets instantiated?
http://reviews.llvm.org/D20369
___
cfe-commits
klimek added a comment.
We're getting there. Couple of nits left.
Comment at: lib/Format/SortJavaScriptImports.cpp:94-97
@@ +93,6 @@
+// Side effect imports might be ordering sensitive. Consider them equal so
+// that they maintain their relative order in the stable sort
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I like this approach much better, thank you. LGTM!
http://reviews.llvm.org/D20369
___
cfe-commits mailing list
cfe-commits@lists.ll
1 - 100 of 199 matches
Mail list logo
