DmitryPolukhin added a comment.
Richard, could you please share your counterexample so I could test it on my
patch and GCC?
As for separate pass, it was my first reaction on the original patch from
Stefan but soon I realized that I'll have to copy parts of magnler to some
simplified mangler bu
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.
Comment at: tools/c-index-test/c-index-test.c:1435-1436
@@ -1434,3 +1434,4 @@
/* recurse to get the first parent record that is not anonymous. */
-CXCurs
hfinkel added a comment.
In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
> This discussion of the command line interface makes me think that we should
> be taking Richard's suggestion one step further. Why is Clang's involvement
> here more than just handing down specific requests f
Author: sbenza
Date: Tue May 3 15:11:09 2016
New Revision: 268430
URL: http://llvm.org/viewvc/llvm-project?rev=268430&view=rev
Log:
[clang-tidy] Speedup misc-static-assert.
Summary:
Speedup the misc-static-assert check by not use `stmt()` as the toplevel
matcher.
The framework runs a filter on
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
I like this approach. LGTM.
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268430: [clang-tidy] Speedup misc-static-assert. (authored
by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D19877?vs=56028&id=56053#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1987
mclow.lists added a comment.
Q: Should the .a file get installed into /lib when you do a make install?
That will make it easier to link against.
http://reviews.llvm.org/D19856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268432: Add address space 258 (X86 SS segment) to clang
documentation. (authored by dlkreitz).
Changed prior to commit:
http://reviews.llvm.org/D19458?vs=54877&id=56056#toc
Repository:
rL LLVM
http:
Author: dlkreitz
Date: Tue May 3 15:20:59 2016
New Revision: 268432
URL: http://llvm.org/viewvc/llvm-project?rev=268432&view=rev
Log:
Add address space 258 (X86 SS segment) to clang documentation.
The change reflects llvm r268431.
Patch by Michael Lemay (michael.le...@intel.com)
Differential Re
rjmccall added a comment.
In http://reviews.llvm.org/D19678#420358, @hfinkel wrote:
> In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
>
> > This discussion of the command line interface makes me think that we should
> > be taking Richard's suggestion one step further. Why is Clang's
apelete updated this revision to Diff 56059.
apelete added a comment.
[scan-build] fix dead store warnings emitted on clang code base
Changes since last revision:
- Move 'Record' and 'Parent' variables into if() {} scope where they are
actually used.
http://reviews.llvm.org/D19831
Files:
t
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
Please do add tests before committing. Otherwise ok.
Thanks.
-eric
Comment at: lib/Basic/Targets.cpp:1239
@@ -1227,1 +1238,3 @@
+ if (defs & ArchDefinePwr9)
+Builder.defineMacr
Thanks - do you need someone (me) to commit this, or do you have commit
access?
On Tue, May 3, 2016 at 1:32 PM, Apelete Seketeli via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> apelete updated this revision to Diff 56059.
> apelete added a comment.
>
> [scan-build] fix dead store warnings
On Tue, May 3, 2016 at 12:51 PM, Dmitry Polukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> DmitryPolukhin added a comment.
>
> Richard, could you please share your counterexample so I could test it on
> my patch and GCC?
>
Sure:
struct __attribute__((abi_tag("X"))) Foo {};
void
EricWF added a comment.
In http://reviews.llvm.org/D19856#420366, @mclow.lists wrote:
> Q: Should the .a file get installed into /lib when you do a make install?
>
> That will make it easier to link against.
For now the install rule is off by default.
`-DLIBCXX_INSTALL_EXPERIMENTAL_LIBRARY=ON
Author: ericwf
Date: Tue May 3 16:30:18 2016
New Revision: 268443
URL: http://llvm.org/viewvc/llvm-project?rev=268443&view=rev
Log:
Create new library 'libc++experimental.a' for packaging TS symbols.
Summary:
Out-of-line symbols for headers are not ABI or API stable
and cannot live in the 'lib
apelete added a comment.
In http://reviews.llvm.org/D19831#420410, @dblaikie wrote:
> Thanks - do you need someone (me) to commit this, or do you have commit
> access?
I would appreciate if you could commit this for me since I don't have commit
access.
Thanks.
http://reviews.llvm.org/D19831
Author: ericwf
Date: Tue May 3 16:58:07 2016
New Revision: 268451
URL: http://llvm.org/viewvc/llvm-project?rev=268451&view=rev
Log:
Make check-libcxx dependant on libc++experimental if present.
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
http:
Author: dblaikie
Date: Tue May 3 17:14:14 2016
New Revision: 268453
URL: http://llvm.org/viewvc/llvm-project?rev=268453&view=rev
Log:
[scan-build] fix dead store warnings emitted on clang code base
This fixes dead store warnings of the type "dead assignment" reported
by CLang Static Analyzer on
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268453: [scan-build] fix dead store warnings emitted on
clang code base (authored by dblaikie).
Changed prior to commit:
http://reviews.llvm.org/D19831?vs=56059&id=56071#toc
Repository:
rL LLVM
http
koriakin created this revision.
koriakin added reviewers: uweigand, rjmccall.
koriakin added a subscriber: cfe-commits.
koriakin set the repository for this revision to rL LLVM.
koriakin added a dependency: D19889: [SystemZ] Implement backchain attribute..
This option, like the corresponding gcc o
Author: ericwf
Date: Tue May 3 17:32:08 2016
New Revision: 268456
URL: http://llvm.org/viewvc/llvm-project?rev=268456&view=rev
Log:
Add documentation for new experimental library
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
libcxx/trunk/docs/UsingLibcxx.rst
Modified: libcxx/trunk/docs
Author: ericwf
Date: Tue May 3 17:50:33 2016
New Revision: 268459
URL: http://llvm.org/viewvc/llvm-project?rev=268459&view=rev
Log:
Update version numbers in docs
Modified:
libcxx/trunk/docs/conf.py
Modified: libcxx/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/d
Author: dblaikie
Date: Tue May 3 18:06:40 2016
New Revision: 268460
URL: http://llvm.org/viewvc/llvm-project?rev=268460&view=rev
Log:
[modules][debuginfo] Only include imported modules when targeting LLDB
These constructs are only applicable to a debugger capable of loading a
Clang AST, so omit
Author: flx
Date: Tue May 3 18:07:44 2016
New Revision: 268461
URL: http://llvm.org/viewvc/llvm-project?rev=268461&view=rev
Log:
[clang-tidy] MoveConstructorInitCheck - Add parameter name to check message.
Reviewers: alexfh
Subscribers: aaron.ballman, cfe-commits
Differential Revision: http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268461: [clang-tidy] MoveConstructorInitCheck - Add
parameter name to check message. (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D19849?vs=55975&id=56076#toc
Repository:
rL LL
probinson marked 2 inline comments as done.
Comment at: include/clang/Basic/Attr.td:86-88
@@ -85,1 +85,5 @@
+def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam &&
+ S->getKind() != Decl::ParmVar &&
+ S->ge
probinson updated this revision to Diff 56079.
probinson marked an inline comment as done.
probinson added a comment.
Correct the attribute condition, and refine the Objective-C test.
http://reviews.llvm.org/D19754
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Cod
Author: benlangmuir
Date: Tue May 3 19:53:13 2016
New Revision: 268471
URL: http://llvm.org/viewvc/llvm-project?rev=268471&view=rev
Log:
Fix CodeCompletion & TypoCorrection when combining a PCH with Modules
This commit fixes the IdentifierIterator to actually include identifiers
from a PCH or pr
Author: rnk
Date: Tue May 3 21:58:24 2016
New Revision: 268473
URL: http://llvm.org/viewvc/llvm-project?rev=268473&view=rev
Log:
[X86] Add -malign-double support
The -malign-double flag causes i64 and f64 types to have alignment 8
instead of 4. On x86-64, the behavior of -malign-double is enable
etienneb added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1578
@@ +1577,3 @@
+/// \endcode
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
aaron.ballman wrote:
> Perhaps we can adjust the `hasSize()
ahatanak updated this revision to Diff 56090.
ahatanak added a comment.
Apply John's patch with a few modifications.
I had to special case __block variables and remove the line creating a load
from a reference to fix the failing regression tests.
http://reviews.llvm.org/D19536
Files:
lib/Co
ahatanak added reviewers: manmanren, doug.gregor, rjmccall.
ahatanak updated this revision to Diff 56092.
ahatanak added a comment.
Rebase and add reviewers.
http://reviews.llvm.org/D18815
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaObjCXX/block-cleanup.mm
Index: test/SemaObjCXX/block-cleanup
Author: compnerd
Date: Tue May 3 23:22:29 2016
New Revision: 268477
URL: http://llvm.org/viewvc/llvm-project?rev=268477&view=rev
Log:
libc++abi: fix visibility of personalities
The personality routines need to be exposed to the users as the functions
reference the personality routine to handle e
101 - 134 of 134 matches
Mail list logo
