ioeric updated this revision to Diff 55382.
ioeric added a comment.
- removed redundant '#'
http://reviews.llvm.org/D19587
Files:
lib/Format/AffectedRangeManager.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/Format.cpp
lib/Format/WhitespaceManager.
Author: ioeric
Date: Thu Apr 28 02:52:03 2016
New Revision: 267859
URL: http://llvm.org/viewvc/llvm-project?rev=267859&view=rev
Log:
Addressed reviewer's post-submission comments from
http://reviews.llvm.org/D18551.
Summary: Make SourceManager in Environment, WhitespaceManager, and
FormatTokenA
Author: ioeric
Date: Thu Apr 28 02:51:47 2016
New Revision: 267858
URL: http://llvm.org/viewvc/llvm-project?rev=267858&view=rev
Log:
Addressed review's comments.
Modified:
cfe/trunk/lib/Format/AffectedRangeManager.h
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/AffectedR
Author: ioeric
Date: Thu Apr 28 02:52:06 2016
New Revision: 267860
URL: http://llvm.org/viewvc/llvm-project?rev=267860&view=rev
Log:
removed redundant '#'
Modified:
cfe/trunk/lib/Format/AffectedRangeManager.h
Modified: cfe/trunk/lib/Format/AffectedRangeManager.h
URL:
http://llvm.org/viewvc/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267859: Addressed reviewer's post-submission comments from
http://reviews.llvm. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D19587?vs=55382&id=55383#toc
Repository:
rL LLVM
baloghadamsoftware added a comment.
I see this one is accepted, but the prerequisite is not reviewed yet (after the
update). Without that this one should not be merged into the code because it
will not compile.
http://reviews.llvm.org/D18265
___
c
hokein added a comment.
@chapuni, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D19482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Thu Apr 28 04:15:06 2016
New Revision: 267862
URL: http://llvm.org/viewvc/llvm-project?rev=267862&view=rev
Log:
[OPENMP 4.5] Codegen for 'grainsize/num_tasks' clauses of 'taskloop'
directive.
OpenMP 4.5 defines 'taskloop' directive and 2 additional clauses
'grainsize' and 'n
Author: abataev
Date: Thu Apr 28 04:23:51 2016
New Revision: 267863
URL: http://llvm.org/viewvc/llvm-project?rev=267863&view=rev
Log:
[OPENMP] Simplified interface for codegen of tasks, NFC.
Reduced number of arguments in member functions of runtime support
library for task-based directives.
Mod
xazax.hun added a comment.
In http://reviews.llvm.org/D19586#415123, @Pajesz wrote:
> Both dangling else and the other check now ignore one-line if-else
> statements. Corrected other reviews as well.
I can not see a test case for one line if-then-else. Could you add it?
http://reviews.llvm.o
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg.
Repository:
rL LLVM
http://reviews.llvm.org/D19647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Nice. Ship it!
Comment at: include-fixer/YamlXrefsDB.h:25
@@ +24,3 @@
+public:
+ YamlXrefsDB(const std::string &FilePath);
+
StringRef instead of std::stri
Author: dpolukhin
Date: Thu Apr 28 04:56:22 2016
New Revision: 267865
URL: http://llvm.org/viewvc/llvm-project?rev=267865&view=rev
Log:
Revert "[MSVC] PR27337: allow static_cast from private base to derived for WTL"
This reverts commit r267534.
Removed:
cfe/trunk/test/SemaCXX/ext_ms_downcast
Thank you for the fix! We've actually tried adding -fdelayed-template-parsing
and -fms-compatibility on linux, and the test passed. Not sure why it
failed on Windows. Is there any other subtle difference?
On Thu, Apr 28, 2016 at 2:39 AM, NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org
Reverted in r267865.
On Wed, Apr 27, 2016 at 10:31 PM, Dmitry Polukhin wrote:
> So it seems that there is an agreement that Clang don't need this MSVC
> "feature" so I'll revert my patch tomorrow when I get to the office.
>
> On Wed, Apr 27, 2016 at 10:09 PM, Stephan T. Lavavej <
> s...@exchange
Author: dzobnin
Date: Thu Apr 28 05:13:18 2016
New Revision: 267866
URL: http://llvm.org/viewvc/llvm-project?rev=267866&view=rev
Log:
[MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)
Rework implementation of several MS pragmas that use internal stack:
vtordisp, {bss|code|const|d
Hi,
I don't know if you've noticed, but this commit broke a lot of builds -
e.g. http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/11865.
Regards,
Diana
On 28 April 2016 at 13:13, Denis Zobnin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dzobnin
> Date: Thu Apr
Author: d0k
Date: Thu Apr 28 06:21:29 2016
New Revision: 267868
URL: http://llvm.org/viewvc/llvm-project?rev=267868&view=rev
Log:
[include-fixer] Add an option to minimize include paths.
This will always pick the shortest possible path based on -I options. Based
on the #include suggestion code fo
avt77 added inline comments.
Comment at: test/SemaCXX/dllimport.cpp:179
@@ -140,1 +178,3 @@
+template
+int ExternVarTmplDeclInit = 1;
majnemer wrote:
> avt77 wrote:
> > rnk wrote:
> > > Can you check with MSVC 2015 update 2 actually does with definitions of
>
Author: sbaranga
Date: Thu Apr 28 06:29:08 2016
New Revision: 267869
URL: http://llvm.org/viewvc/llvm-project?rev=267869&view=rev
Log:
PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4
Summary:
According to the ACLE spec, "__ARM_FEATURE_FMA is defined to 1 if
the hardware floating-
sbaranga added a comment.
Thanks, r267869!
-Silviu
http://reviews.llvm.org/D18963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dzobnin
Date: Thu Apr 28 06:32:10 2016
New Revision: 267870
URL: http://llvm.org/viewvc/llvm-project?rev=267870&view=rev
Log:
Revert "[MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)"
This reverts commit r267866.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe
On Thu, Apr 28, 2016 at 7:32 AM, Denis Zobnin via cfe-commits
wrote:
> Author: dzobnin
> Date: Thu Apr 28 06:32:10 2016
> New Revision: 267870
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267870&view=rev
> Log:
> Revert "[MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)"
>
> T
Pajesz updated this revision to Diff 55389.
Pajesz marked 5 inline comments as done.
Pajesz added a comment.
Both dangling else and the other check now ignore one-line if-else statements.
Corrected other reviews as well.
http://reviews.llvm.org/D19586
Files:
clang-tidy/readability/CMakeLists
hokein updated this revision to Diff 55398.
hokein added a comment.
Don't append absolute path to build directory.
We will get the absolute file paths in some cases, such as STL.
http://reviews.llvm.org/D19647
Files:
include-fixer/find-all-symbols/FindAllSymbols.cpp
Index: include-fixer/fin
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, thakis, majnemer.
andreybokhanko added a subscriber: cfe-commits.
This is exactly same patch as http://reviews.llvm.org/D18596 (already reviewed
and LGTMed by rnk), with a couple of changes to fix PR27367:
* A check for v
Hi Nico,
I have a fix. What is the right way of putting it in? Shall I revert
the "revert" and commit the fix afterwards?
Many thanks
Vassil
On 27/04/16 19:26, Nico Weber via cfe-commits wrote:
Author: nico
Date: Wed Apr 27 12:26:08 2016
New Revision: 267744
URL: http://llvm.org/viewvc/llvm-
Author: abataev
Date: Thu Apr 28 07:14:51 2016
New Revision: 267872
URL: http://llvm.org/viewvc/llvm-project?rev=267872&view=rev
Log:
[OPENMP 4.5] Initial codegen for 'taskloop simd' directive.
OpenMP 4.5 defines 'taskloop simd' directive, which is combined
directive for 'taskloop' and 'simd' dir
Author: d0k
Date: Thu Apr 28 07:14:47 2016
New Revision: 267871
URL: http://llvm.org/viewvc/llvm-project?rev=267871&view=rev
Log:
Revert r267784, r267824 and r267830.
It makes compiler-rt tests fail if the gold plugin is enabled.
Revert "Rework interface for bitset-using features to use a notion
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:753
@@ +752,3 @@
+ let Args = [IntArgument<"ElemSizeParam">, IntArgument<"NumElemsParam", 1>];
+ let TemplateDependent = 1;
+ let Documentation = [AllocSizeDocs];
I don't see any C++ t
Author: mzuckerm
Date: Thu Apr 28 07:47:30 2016
New Revision: 267876
URL: http://llvm.org/viewvc/llvm-project?rev=267876&view=rev
Log:
[Clang][BuiltIn][AVX512] Adding intrinsics fot align{d|q} and palignr
instruction set
Differential Revision: http://reviews.llvm.org/D19588
Modified:
cfe/t
aaron.ballman added inline comments.
Comment at: docs/LanguageExtensions.rst:2161
@@ +2160,3 @@
+
+ #pragma clang loop distribute(enable)
+ for(...) {
It would be nice to use a more compelling example than an empty for loop. Also,
it would be helpful if the use
I'd reland with the fix, and with an additional test that catches the
problem this introduced.
On Apr 28, 2016 8:16 AM, "Vassil Vassilev via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Hi Nico,
> I have a fix. What is the right way of putting it in? Shall I revert the
> "revert" and comm
Author: klimek
Date: Thu Apr 28 08:37:45 2016
New Revision: 267877
URL: http://llvm.org/viewvc/llvm-project?rev=267877&view=rev
Log:
Fix spuriously dematerializing reference bug. Fixes PR26612.
Modified:
cfe/trunk/docs/CMakeLists.txt
Modified: cfe/trunk/docs/CMakeLists.txt
URL:
http://llvm.
aturetsk created this revision.
aturetsk added reviewers: rsmith, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.
Herald added a subscriber: joker.eph.
Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87.
-m[no-]80387 options is added for compatibility with GCC.
http://re
Author: bryanpkc
Date: Thu Apr 28 08:56:43 2016
New Revision: 267879
URL: http://llvm.org/viewvc/llvm-project?rev=267879&view=rev
Log:
[SystemZ] Support Swift calling convention
Summary:
Port rL265324 to SystemZ to allow using the 'swiftcall' attribute on that
architecture.
Depends on D19414.
bryanpkc added a comment.
Thank you for the reviews.
http://reviews.llvm.org/D19432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tnorthover
Date: Thu Apr 28 08:59:55 2016
New Revision: 267880
URL: http://llvm.org/viewvc/llvm-project?rev=267880&view=rev
Log:
ARMv7k: define __ARM_PCS_VFP since we're hard-float.
It's a little debateable because we're not truly AAPCS, so I'm
certainly not going to define __ARM_PCS, but
Author: tnorthover
Date: Thu Apr 28 09:01:49 2016
New Revision: 267881
URL: http://llvm.org/viewvc/llvm-project?rev=267881&view=rev
Log:
Add accidentally dropped test to r267880.
Forgot "git add".
Modified:
cfe/trunk/test/Preprocessor/arm-target-features.c
Modified: cfe/trunk/test/Preproces
hokein updated this revision to Diff 55412.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19648
Files:
include-fixer/CMakeLists.txt
include-fixer/YamlXrefsDB.cpp
include-fixer/YamlXrefsDB.h
include-fixer/tool/ClangIncludeFixer.cpp
test/include-fixer/Inputs/fake_yaml_db.y
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vbyakovl added a comment.
@rsmith ping
http://reviews.llvm.org/D18823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Thu Apr 28 09:13:28 2016
New Revision: 267882
URL: http://llvm.org/viewvc/llvm-project?rev=267882&view=rev
Log:
Reland r267691 fixing PR27535.
Added:
cfe/trunk/test/Modules/Inputs/PR27401/
cfe/trunk/test/Modules/Inputs/PR27401/a.h
cfe/trunk/test/Modules/Inputs/
r267882.
On 28/04/16 15:23, Nico Weber wrote:
I'd reland with the fix, and with an additional test that catches the
problem this introduced.
On Apr 28, 2016 8:16 AM, "Vassil Vassilev via cfe-commits"
mailto:cfe-commits@lists.llvm.org>> wrote:
Hi Nico,
I have a fix. What is the ri
Author: klimek
Date: Thu Apr 28 09:28:19 2016
New Revision: 267883
URL: http://llvm.org/viewvc/llvm-project?rev=267883&view=rev
Log:
Fix build.
Modified:
cfe/trunk/docs/CMakeLists.txt
Modified: cfe/trunk/docs/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/CMakeLists.
djasper added inline comments.
Comment at: lib/Format/AffectedRangeManager.cpp:103
@@ -102,1 +102,3 @@
AnnotatedLine *Line, const AnnotatedLine *PreviousLine) {
+ assert(Line && "does not contain any line");
+
klimek wrote:
> Perhaps we should change this to
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
When comparing unqualified types, canonical types should be used, otherwise
equivalent types may be treated as different type.
For example,
typedef int int_t;
generic int* a;
gl
probinson added a subscriber: probinson.
Comment at: test/Modules/getSourceDescriptor-crash.cpp:1
@@ +1,2 @@
+// RUN: %clang -I %S/Inputs/getSourceDescriptor-crash -c -g
-fimplicit-module-maps %s
+
Should run %clang_cc1 not the driver.
http://reviews.llvm.org/
> On Apr 27, 2016, at 7:27 PM, Douglas Yung wrote:
>
> dyung added a comment.
>
> In http://reviews.llvm.org/D19048#414568, @aprantl wrote:
>
>> Thanks!
>>
>> Is there anything meaningful that could be CHECKed here?
>> Usually a crash means that we previously had a code path without test
>>
sbaranga created this revision.
sbaranga added a reviewer: rengolin.
sbaranga added subscribers: t.p.northover, cfe-commits.
Herald added subscribers: rengolin, aemerson.
Conversions between float and half are only available when the
taraget has the half-precision extension. Guard these intrinsics
rmaprath updated this revision to Diff 55425.
rmaprath added a comment.
Addressing review comments by @mclow.lists:
- Switched to `_LIBCPP_ALWAYS_INLINE` from `_LIBCPP_INLINE_VISIBILITY` for all
`__os_xxx` functions.
I've left the remaining points (naming of `__os_support` header and
initializ
filcab created this revision.
filcab added a reviewer: rsmith.
filcab added a subscriber: cfe-commits.
This option allows the user to control how much of the file name is
emitted by UBSan. Tuning this option allows one to save space in the
resulting binary, which is helpful for restricted executio
anemet added inline comments.
Comment at: docs/LanguageExtensions.rst:2161
@@ +2160,3 @@
+
+ #pragma clang loop distribute(enable)
+ for(...) {
aaron.ballman wrote:
> It would be nice to use a more compelling example than an empty for loop.
> Also, it would be
bruno added a subscriber: bruno.
bruno added a reviewer: bruno.
bruno added a comment.
Hi Andrey,
What about the code / tests that check for this flags?
http://reviews.llvm.org/D19658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab created this revision.
filcab added reviewers: kcc, samsonov, rsmith.
filcab added a subscriber: cfe-commits.
This patch makes the type_mismatch static data 7 bytes smaller (and it ends up
being 16 bytes smaller due to alignment restrictions, at least on some x86-64
environments).
Currentl
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/address-spaces-conversions.cl:52
@@ -51,3 +51,3 @@
generic void *var_gen_v;
-
+
var_gen = var_gen ? var_gen : var_gen2; // operands of the same addr spaces
and the same type
Inserting a white
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1446-1451
@@ -1445,5 +1445,8 @@
Out << 'E';
+ if (!PointeeType.isNull() && PointeeType.getLocalQualifiers().hasUnaligned())
+Out << 'F';
+
if (HasRestrict)
Out << 'I';
}
H
bcraig added a subscriber: bcraig.
bcraig added a comment.
Is there an associated patch on the consuming side for this data?
http://reviews.llvm.org/D19667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
bcraig added a comment.
In http://reviews.llvm.org/D19412#414374, @rmaprath wrote:
> > On a bikeshed note: is `<__os_support>` the right name? Or should it be
> > something like `<__thread>` or `<__threading_support>`?
>
>
> I went with `__os_support` in case if we'd want to group further exte
Author: pcc
Date: Thu Apr 28 12:09:37 2016
New Revision: 267903
URL: http://llvm.org/viewvc/llvm-project?rev=267903&view=rev
Log:
Re-apply r267784, r267824 and r267830.
I have updated the compiler-rt tests.
Added:
cfe/trunk/docs/LTOVisibility.rst
cfe/trunk/test/CodeGenCXX/bitset-inferenc
Anastasia added a comment.
Could you export a full diff please? There are too many small bits here to
review! Thanks!
Comment at: test/SemaOpenCL/extensions.cl:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
+// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-
rob.lougher added a comment.
Ping.
http://reviews.llvm.org/D16298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 55438.
yaxunl added a comment.
Removed accidentally inserted blanks.
http://reviews.llvm.org/D19662
Files:
lib/AST/ASTContext.cpp
test/CodeGenOpenCL/address-spaces-conversions.cl
Index: test/CodeGenOpenCL/address-spaces-conversions.cl
==
Author: adrian
Date: Thu Apr 28 12:21:56 2016
New Revision: 267904
URL: http://llvm.org/viewvc/llvm-project?rev=267904&view=rev
Log:
Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.
The LLVM Verifier expects all inlinable calls in debuggable functions to
have a locatio
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: yaxunl
Date: Thu Apr 28 12:34:57 2016
New Revision: 267906
URL: http://llvm.org/viewvc/llvm-project?rev=267906&view=rev
Log:
[OpenCL] Fix bug in mergeTypes which causes equivalent types treated as
different.
When comparing unqualified types, canonical types should be used, otherwise
equ
anemet updated this revision to Diff 55439.
anemet added a comment.
Added more context to the documentation per Aaron's comments.
http://reviews.llvm.org/D19403
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticParseKinds.td
lib/CodeGen/CGLoopI
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267906: [OpenCL] Fix bug in mergeTypes which causes
equivalent types treated as… (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D19662?vs=55438&id=55440#toc
Repository:
rL LLV
filcab added a comment.
http://reviews.llvm.org/D19668 is the compiler-rt side of the patch.
http://reviews.llvm.org/D19667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh created this revision.
alexfh added a reviewer: sbenza.
alexfh added subscribers: cfe-commits, flx, michael_miller.
Variables with static storage duration are zero-initialized per
[stmt.dcl]p4 and [basic.start.init]p2.
http://reviews.llvm.org/D19672
Files:
clang-tidy/cppcoreguidelines/P
anemet updated this revision to Diff 55445.
anemet added a comment.
A little tweak to the example to make it clear that 'i' is the induction
variable
http://reviews.llvm.org/D19403
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticParseKinds.td
rmaprath updated this revision to Diff 55443.
rmaprath added a comment.
Renamed `__os_support` to `__threading_support` as suggested by @mclow.lists
and @bcraig. I've left the namespace name `__libcpp_os_support` untouched, can
change it to `__libcpp_threading_support` if the latter is preferred
Author: probinson
Date: Thu Apr 28 12:52:28 2016
New Revision: 267909
URL: http://llvm.org/viewvc/llvm-project?rev=267909&view=rev
Log:
Make the test exercise all paths modified in r267746.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-nodebug.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug-i
bcraig added a comment.
LGTM. You'll still need to wait for one of the other reviewers though
(probably @mclow.lists )
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
george.burgess.iv added a subscriber: george.burgess.iv.
george.burgess.iv accepted this revision.
george.burgess.iv added a reviewer: george.burgess.iv.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
Hey -- I'm really sorry about the latency on this; I recentl
Author: rsmith
Date: Thu Apr 28 13:26:32 2016
New Revision: 267914
URL: http://llvm.org/viewvc/llvm-project?rev=267914&view=rev
Log:
Fix use of uninitialized value exposed by r267802. Accessors of an invalid
PresumedLoc should not be called.
Modified:
cfe/trunk/include/clang/Basic/SourceLocat
t.p.northover added a comment.
Couple of issues, as far as I can see:
Comment at: include/clang/Basic/arm_neon.td:710-711
@@ +709,4 @@
+ def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">;
+ def VCVT_HIGH_F16_F32 : SOpInst<"vcvt_high_f16", "hmj", "Hf",
OP_VCVT_NA_HI_F16>;
+
rsmith added inline comments.
Comment at: include/clang/Driver/Options.td:1102
@@ -1101,1 +1101,3 @@
def Wlarge_by_value_copy_EQ : Joined<["-"], "Wlarge-by-value-copy=">,
Flags<[CC1Option]>;
+def fubsan_strip_path_components_EQ : Joined<["-"],
"fubsan-strip-path-components=">,
ahatanak updated this revision to Diff 55453.
ahatanak added a comment.
Use ParseScopeFlags to clear the TemplateParamScope rather than calling
setFlags directly.
I tried calling Init(AnyParent, F) is Scope::setFlags, but it caused a lot of
test cases to fail, which I'm currently investigating.
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of nits. Please submit this as a single patch, there's
no need to add an empty "boost" module separately.
Comment at: clang-tidy/boost/UseToStringChe
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
hasType(recordDecl(has(fieldDecl()),
alexfh added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
hasType(recordDecl(has(fieldDecl()),
---
michael_miller added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
hasType(recordDecl(has(fieldDecl()),
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
hasType(recordDecl(has(fieldDecl()),
hfinkel created this revision.
hfinkel added reviewers: rsmith, chandlerc, rcox2, jmolloy, anemet,
silviu.baranga, mzolotukhin, spatel, rengolin, delena, Carrot, congh, echristo.
hfinkel added a subscriber: cfe-commits.
Herald added subscribers: joker.eph, mcrosier.
This patch implements support
dyung updated this revision to Diff 55457.
dyung added a comment.
Modified the test to emit llvm assembly and check for the presence of a
DIModule in the output.
http://reviews.llvm.org/D19048
Files:
test/Modules/Inputs/getSourceDescriptor-crash/h1.h
test/Modules/Inputs/getSourceDescriptor
Should these have no/artificial location? It seems like perhaps they should
have the same location as the scope they're for? (well, the beginning or
end of that scope, respectively, etc)
On Thu, Apr 28, 2016 at 10:21 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author:
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
Method Pool in modules: we make sure that if a module contains an entry for a
selector, the entry should be complete, containing
everything introduced by that module and all modul
dyung updated this revision to Diff 55460.
dyung added a comment.
Change test to not use the driver.
http://reviews.llvm.org/D19048
Files:
test/Modules/Inputs/getSourceDescriptor-crash/h1.h
test/Modules/Inputs/getSourceDescriptor-crash/module.modulemap
test/Modules/getSourceDescriptor-cra
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but you should wait in case @rsmith has feedback.
http://reviews.llvm.org/D19403
___
cfe-commits mailing list
cfe-commits@lis
Author: dcoughlin
Date: Thu Apr 28 14:44:40 2016
New Revision: 267924
URL: http://llvm.org/viewvc/llvm-project?rev=267924&view=rev
Log:
[analyzer] Add path note for localizability checker.
Add a path note indicating the location of the non-localized string
literal in NonLocalizedStringChecker.
r
> On Apr 28, 2016, at 12:34 PM, David Blaikie wrote:
>
> Should these have no/artificial location? It seems like perhaps they should
> have the same location as the scope they're for? (well, the beginning or end
> of that scope, respectively, etc)
While there is usually a single source locati
rjmccall added a comment.
I see what you're going for with "listing file", but I like ICC's option name
much better, or at least something along those lines.
http://reviews.llvm.org/D19678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
On Thu, Apr 28, 2016 at 12:50 PM, Adrian Prantl wrote:
>
> On Apr 28, 2016, at 12:34 PM, David Blaikie wrote:
>
> Should these have no/artificial location? It seems like perhaps they
> should have the same location as the scope they're for? (well, the
> beginning or end of that scope, respective
EricWF added a comment.
The patch looks good for the most part. Nit picking I would rather have
`__libcpp_thread_foo` instead of `__libcpp_os_support::__os_thread_foo`. IMO
the namespace is undeeded.
@mclow.lists can you weigh in on this?
Comment at: include/__mutex_base:43
@@
alexfh added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
hasType(recordDecl(has(fieldDecl()),
---
hfinkel added a comment.
> My primary inspiration here is the reports generated by Cray's tools
> (http://docs.cray.com/books/S-2496-4101/html-S-2496-4101/z1112823641oswald.html).
http://docs.cray.com/books/S-2315-52/html-S-2315-52/fixedds0jdeh38.html is a
better link.
http://reviews.llvm.or
aaron.ballman accepted this revision.
This revision is now accepted and ready to land.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:284
@@ -283,2 +283,3 @@
varDecl(isDefinition(), HasDefaultConstructor,
+ hasAutomaticStorageDuration(),
1 - 100 of 207 matches
Mail list logo
