Author: kromanova
Date: Wed Apr 27 02:14:02 2016
New Revision: 267676
URL: http://llvm.org/viewvc/llvm-project?rev=267676&view=rev
Log:
Updated doxygen comments for intrinsics.
(1) Removed \code.. \endcode tags around the instruction name. This matches the
doxygen format for all other intrinsics.
ogoffart added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5044-5045
@@ -5043,4 +5043,4 @@
// function template specialization, add it to the scope stack.
- if (New->getDeclName() && AddToScope &&
- !(D.isRedeclaration() && New->isInvalidDecl())) {
+ if (New->get
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the quick fix!
http://reviews.llvm.org/D19539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: abataev
Date: Wed Apr 27 02:56:03 2016
New Revision: 267677
URL: http://llvm.org/viewvc/llvm-project?rev=267677&view=rev
Log:
[OPENMP] Fix for codegen of captured variables in inlined directives.
Currently there is a problem with codegen of inlined directives inside
lambdas, it may cause
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4421-4423
@@ +4420,5 @@
+ llvm::Value *ElemSize;
+ if (auto *PTy = BaseTy->getAs()) {
+ElemSize = CGF.getTypeSize(PTy->getPointeeType().ge
hokein updated this revision to Diff 55170.
hokein added a comment.
Fix remaining nits.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-ti
hokein marked 2 inline comments as done.
Comment at: clang-tidy/ClangTidyOptions.h:233
@@ -200,2 +232,3 @@
- ClangTidyOptions getOptions(llvm::StringRef FileName) override;
+ std::vector getRawOptions(
+ llvm::StringRef FileName) override;
alexfh wrote:
>
sheredom closed this revision.
sheredom added a comment.
Thanks!
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 55172.
hokein marked 2 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:38
@@ +37,3 @@
+private:
+ ResultReporter *const Reporter;
+};
bkramer wrote:
> nit: move const to the start of the line.
Moving `const` to the start of line will change se
Author: hokein
Date: Wed Apr 27 04:15:01 2016
New Revision: 267683
URL: http://llvm.org/viewvc/llvm-project?rev=267683&view=rev
Log:
[ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes
from.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://rev
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL267683: [ClangTidy] Add an 'explain-checks' option to
diagnose where each checks… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D18694?v
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:39
@@ +38,3 @@
+ ResultReporter *const Reporter;
+};
+
Ah, sorry, my bad.
http://reviews.llvm.org/D19482
___
cfe-commits ma
I added example with 'B*' to 'A*' just to make sure that my patch doesn't
break it accidentally in MSVC mode.
As for 'A*' to 'B*" case, indeed it is not very common and it looks like
someone just forgot to specify 'public'. I tried to find more real world
examples in public source codes but withou
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D19583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: hokein
Date: Wed Apr 27 05:22:31 2016
New Revision: 267687
URL: http://llvm.org/viewvc/llvm-project?rev=267687&view=rev
Log:
Don't search compilation database in explain-check test.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D19583
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267687: Don't search compilation database in explain-check
test. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19583?vs=55177&id=55178#toc
Repository:
rL LLVM
http://review
Author: mzuckerm
Date: Wed Apr 27 05:44:15 2016
New Revision: 267690
URL: http://llvm.org/viewvc/llvm-project?rev=267690&view=rev
Log:
[Clang][BuiltIn][AVX512]Adding intrinsics for vmovntdqa vmovntpd vmovntps
instruction set
Differential Revision: http://reviews.llvm.org/D19529
Modified:
c
Author: vvassilev
Date: Wed Apr 27 05:46:06 2016
New Revision: 267691
URL: http://llvm.org/viewvc/llvm-project?rev=267691&view=rev
Log:
[modules] Fix Decl's Used invariant.
The Decl::isUsed has a value for every decl. In non-module builds it is very
difficult (but possible) to break this invarian
baloghadamsoftware added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:69
@@ +68,3 @@
+void UnconventionalAssignOperatorCheck::check(const MatchFinder::MatchResult
&Result) {
+ if (const auto *RetStmt = Result.Nodes.getNodeAs("returnStmt")) {
alexfh added a comment.
I'm somewhat reluctant to add LLVM-specific checks to misc-. I would prefer
either to split the LLVM-specific part to a separate check in llvm/ (which
might derive from this check or somehow reuse the logic) or make the check
configurable enough so that these checks can
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/StringConstructorCheck.cpp:110
@@ -106,2 +109,3 @@
if (Result.Nodes.getNodeAs("swapped-parameter")) {
-diag(Loc, "constructor parameters are probably swappe
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/boost/BoostTidyModule.cpp:26
@@ -22,3 +25,3 @@
ClangTidyOptions getModuleOptions() override {
ClangTidyOptions Options;
This method doesn't d
Author: abataev
Date: Wed Apr 27 06:38:05 2016
New Revision: 267695
URL: http://llvm.org/viewvc/llvm-project?rev=267695&view=rev
Log:
[OPENMP] Fix crash on initialization of classes with no init clause in
declare reductions.
If reduction clause is applied to instance of class with user-defined
re
djasper added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:22-24
@@ +21,5 @@
+
+using SymbolInfo = clang::find_all_symbols::SymbolInfo;
+using SymbolType = clang::find_all_symbols::SymbolInfo::SymbolType;
+using ContextType = clang::find_all_symbo
Author: mzuckerm
Date: Wed Apr 27 06:43:14 2016
New Revision: 267696
URL: http://llvm.org/viewvc/llvm-project?rev=267696&view=rev
Log:
[Clang][BuiltIn][AVX512] Adding intrinsics without mask for VBROADCAST and
VPBROADCAST instruction set .
Differential Revision: http://reviews.llvm.org/D19196
A
Author: alexfh
Date: Wed Apr 27 06:45:14 2016
New Revision: 267697
URL: http://llvm.org/viewvc/llvm-project?rev=267697&view=rev
Log:
clang-tidy -list-checks should exit with non-zero code when no checks are
enabled.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
Modifie
Stumbling over this (much too late, of course), is this still a problem for
you?
On Thu, Nov 26, 2015 at 5:01 PM jean-yves desbree via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I use clang 3.6.2 with qt creator 3.5.1 on windows 7 for parsing code in
> this IDE.
> It works well.
>
> Howev
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D18641#413277, @rsmith wrote:
> I'm a little concerned about the possibility of this breaking uses of this
> feature on platforms where Clang is the system compiler. For instance, this
> pattern would be broken by your change:
>
> //
teemperor updated this revision to Diff 55189.
teemperor added a comment.
- Moved checks to the UninitializedFieldVisitor
- Also check for dynamic_cast on this during construction
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclCXX.cpp
tes
Author: hokein
Date: Wed Apr 27 07:17:04 2016
New Revision: 267700
URL: http://llvm.org/viewvc/llvm-project?rev=267700&view=rev
Log:
Fix a crash in cppcoreguidelines-pro-type-member-init when checking a type with
a template parameter as a base class.
Summary: Fixed a crash in cppcoreguidelines-p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267700: Fix a crash in
cppcoreguidelines-pro-type-member-init when checking a type… (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D19539?vs=55026&id=55192#toc
Repository:
rL
Pajesz created this revision.
Pajesz added a reviewer: alexfh.
Pajesz added subscribers: cfe-commits, xazax.hun.
This is a clang-tidy check for llvm. It checks for dangling else and for
possible misleading indentation due to omitted braces.
http://reviews.llvm.org/D19586
Files:
clang-tidy/r
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Make SourceManager in Environment, WhitespaceManager, and FormatTokenAnalyzer
etc constant members.
http://reviews.llvm.org/D19587
Files:
lib/Forma
Author: jbcoe
Date: Wed Apr 27 07:48:25 2016
New Revision: 267706
URL: http://llvm.org/viewvc/llvm-project?rev=267706&view=rev
Log:
Expose cxx constructor and method properties through libclang and python
bindings.
Summary:
I have exposed the following function through libclang and the clang.cin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267706: Expose cxx constructor and method properties through
libclang and python… (authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D15469?vs=53519&id=55196#toc
Repository:
rL LLV
ioeric marked 6 inline comments as done.
Comment at: cfe/trunk/lib/Format/Format.cpp:1355
@@ -1352,2 +1354,3 @@
std::find(ForEachMacros.begin(), ForEachMacros.end(),
-FormatTok->Tok.getIdentifierInfo()) !=
ForEachMacros.end()) {
+
bcraig added a comment.
LGTM. You will still need to get approval from one of your original reviewers
though.
http://reviews.llvm.org/D19415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
alexfh added a comment.
The patch is broken:
Index: clang-tidy/readability/Mislead
===
--- /dev/null
+++ clang-tidy/readability/Mislead
@@ -0,0 +1,77 @@
+//===--- MisleadingIndentationCheck.cpp -
clang-tidy--
bcraig added a comment.
LGTM. You will still need to get approval from one of your original reviewers
though.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: hokein
Date: Wed Apr 27 08:23:39 2016
New Revision: 267711
URL: http://llvm.org/viewvc/llvm-project?rev=267711&view=rev
Log:
Remove explain-config testcase that detect hard-coded check.
Remove it for now, we need to better way to figure out how to test it.
Modified:
clang-tools-extra
koriakin created this revision.
koriakin added reviewers: asl, rjmccall.
koriakin added a subscriber: cfe-commits.
koriakin set the repository for this revision to rL LLVM.
Herald added subscribers: jyknight, aemerson.
This is now supported for ARM, AArch64, PowerPC, SystemZ, SPARC. Patches
for X
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Some numeric conversion APIs like atoi() and scanf() do not check the validity
of the value being converted, so it is impossible to tell whether range errors
have oc
koriakin updated this revision to Diff 55216.
koriakin added a comment.
Updated version: changed triple in a test to linux - ios doesn't support TLS,
so __builtin_thread_pointer now rightly fails.
Repository:
rL LLVM
http://reviews.llvm.org/D19589
Files:
include/clang/Basic/Builtins.def
hokein updated this revision to Diff 55220.
hokein marked 13 inline comments as done.
hokein added a comment.
Add Daniel's comments.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbo
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:22-24
@@ +21,5 @@
+
+using SymbolInfo = clang::find_all_symbols::SymbolInfo;
+using SymbolType = clang::find_all_symbols::SymbolInfo::SymbolType;
+using ContextType = clang::find_all_symbol
djasper accepted this revision.
djasper added a comment.
Looks good.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:39
@@ +38,3 @@
+} else {
+ const auto *RD = llvm::cast(Context);
+ Symbol->Contexts.emplace_back(SymbolInfo::Record, RD->getName().str
hokein updated this revision to Diff 55223.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols
Author: d0k
Date: Wed Apr 27 09:24:32 2016
New Revision: 267718
URL: http://llvm.org/viewvc/llvm-project?rev=267718&view=rev
Log:
Clean up the include fixer 'driver' a bit and make the database configurable.
Also add a test for it. The library is covered by unit tests, the driver
was not.
Added:
hokein updated this revision to Diff 55226.
hokein added a comment.
Fix another nit.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllS
Author: hokein
Date: Wed Apr 27 09:27:05 2016
New Revision: 267719
URL: http://llvm.org/viewvc/llvm-project?rev=267719&view=rev
Log:
[include-fixer] Add a find-all-symbols tool for include-fixer.
Summary:
The find-all-symbols tool generates a yaml symbol database for
include-fixer.
The symbol ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267719: [include-fixer] Add a find-all-symbols tool for
include-fixer. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19482?vs=55226&id=55227#toc
Repository:
rL LLVM
http://
yaxunl added a comment.
LGTM
http://reviews.llvm.org/D19524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Wed Apr 27 09:32:36 2016
New Revision: 267721
URL: http://llvm.org/viewvc/llvm-project?rev=267721&view=rev
Log:
Add missing dependency.
Modified:
clang-tools-extra/trunk/test/CMakeLists.txt
Modified: clang-tools-extra/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/l
sbenza accepted this revision.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:69
@@ +68,3 @@
+void UnconventionalAssignOperatorCheck::check(const MatchFinder::MatchResult
&Result) {
+ if (const auto *RetStmt = Result.Nodes.getNodeAs("returnStmt")) {
+diag(
d.zobnin.bugzilla added a comment.
This is just a weekly friendly ping.
Please take a look at the new patch!
Thank you,
Denis Zobnin
http://reviews.llvm.org/D18700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Is it needed to parse system headers? In general, we implement things like
this if they're needed for system headers but don't otherwise.
On Wed, Apr 27, 2016 at 6:19 AM, Dmitry Polukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I added example with 'B*' to 'A*' just to make sure tha
etienneb updated this revision to Diff 55240.
etienneb marked an inline comment as done.
etienneb added a comment.
address alexfh comments, add a macro FP.
http://reviews.llvm.org/D19577
Files:
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
test/clang-tidy/misc-suspicious-string-compare.c
etienneb added a comment.
In http://reviews.llvm.org/D19577#413526, @alexfh wrote:
> I'm somewhat reluctant to add LLVM-specific checks to misc-. I would prefer
> either to split the LLVM-specific part to a separate check in llvm/ (which
> might derive from this check or somehow reuse the logic
Author: mzuckerm
Date: Wed Apr 27 10:35:13 2016
New Revision: 267728
URL: http://llvm.org/viewvc/llvm-project?rev=267728&view=rev
Log:
[Clang][Builtin][AVX512] Adding intrisnics for the vpconflict{q|d} instruction
set
Differential Revision: http://reviews.llvm.org/D19525
Modified:
cfe/trunk
etienneb added inline comments.
Comment at: clang-tidy/misc/StringConstructorCheck.cpp:110
@@ -106,2 +109,3 @@
if (Result.Nodes.getNodeAs("swapped-parameter")) {
-diag(Loc, "constructor parameters are probably swapped");
+assert(E->getNumArgs() == 2 && "Invalid number o
etienneb updated this revision to Diff 55242.
etienneb added a comment.
address alexfh comments.
http://reviews.llvm.org/D19547
Files:
clang-tidy/misc/StringConstructorCheck.cpp
clang-tidy/misc/SwappedArgumentsCheck.cpp
clang-tidy/utils/FixItHintUtils.cpp
clang-tidy/utils/FixItHintUtils
aprantl added a comment.
Debug info changes otherwise look good to me.
Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:17
@@ +16,3 @@
+// YESINFO-DAG: !DIGlobalVariable(name: "global_int_def"
+// NOINFO-NOT: !DIGlobalVariable(name: "global_int_def"
+
I don't
teemperor updated this revision to Diff 55245.
teemperor added a comment.
- Added checks and tests for typeid
- Moved warnings into same warning group
- Check that only possibly evaluated expressions are checked
http://reviews.llvm.org/D19312
Files:
include/clang/Basic/DiagnosticGroups.td
i
Author: hokein
Date: Wed Apr 27 11:09:34 2016
New Revision: 267731
URL: http://llvm.org/viewvc/llvm-project?rev=267731&view=rev
Log:
Don't search compilation database in explain-check, fixing buildbot test
failure.
Modified:
clang-tools-extra/trunk/test/clang-tidy/explain-checks.cpp
Modified
Pajesz updated this revision to Diff 55247.
Pajesz added a comment.
Probably fixed the broken patch.
http://reviews.llvm.org/D19586
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MisleadingIndentationCheck.cpp
clang-tidy/readability/MisleadingIndentationCheck.h
clan
rjmccall added a comment.
Why the random triple change on the test?
Otherwise LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: hokein
Date: Wed Apr 27 11:39:42 2016
New Revision: 267736
URL: http://llvm.org/viewvc/llvm-project?rev=267736&view=rev
Log:
Fix explain-check failure test on Windows.
Modified:
clang-tools-extra/trunk/test/clang-tidy/explain-checks.cpp
Modified: clang-tools-extra/trunk/test/clang-ti
probinson added inline comments.
Comment at: include/clang/Basic/Attr.td:976
@@ -975,3 +975,3 @@
let Spellings = [GCC<"nodebug">];
- let Documentation = [Undocumented];
+ let Documentation = [NoDebugDocs];
}
aaron.ballman wrote:
> This isn't your problem to
Author: d0k
Date: Wed Apr 27 11:50:17 2016
New Revision: 267738
URL: http://llvm.org/viewvc/llvm-project?rev=267738&view=rev
Log:
[find-all-symbols] Clean up dependencies, fixing cmake shared build.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
Modified
Author: d0k
Date: Wed Apr 27 11:56:29 2016
New Revision: 267739
URL: http://llvm.org/viewvc/llvm-project?rev=267739&view=rev
Log:
[find-all-symbols] Also update unittest dependencies.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/CMakeLists.txt
Modified:
clang-
koriakin added a comment.
In http://reviews.llvm.org/D19589#413924, @rjmccall wrote:
> Why the random triple change on the test?
>
> Otherwise LGTM.
See the comment above - arm64-apple-ios doesn't support TLS, so
__builtin_thread_pointer is meaningless (it compiled before, but would result
in
rjmccall added a comment.
Oh, I see. Sure, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
What about for ans while statements?
Comment at: docs/clang-tidy/checks:10
@@ +9,3 @@
+
+The way to avoid dangling else
Author: adrian
Date: Wed Apr 27 12:06:22 2016
New Revision: 267740
URL: http://llvm.org/viewvc/llvm-project?rev=267740&view=rev
Log:
Module debugging: Fix the DWO filename for PCH in a relative path.
PCH in a relative location had a redundant relative path on the DWO
filename and the DW_AT_compila
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please add check options descriptions to documentation.
http://reviews.llvm.org/D19577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
t.p.northover added a comment.
I'm opposed to the changes on ARM. It would be undefined behaviour if the user
wrote it at the C level, but not LLVM IR I think, which means Clang is
perfectly entitled to emit calls like that.
Tim.
http://reviews.llvm.org/D19275
_
jfb added a comment.
@t.p.northover: would an acceptable solution be to add a new trait such as
`CGM.getCXXABI().CanCallMismatchedFunctionType()` or something of the sort? ARM
would set it to true, wasm to false.
http://reviews.llvm.org/D19275
___
aprantl added a comment.
Ah great, I didn't know that!
http://reviews.llvm.org/D19567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t.p.northover added a comment.
Yep, that sounds about perfect to me. Exactly what the different CXXABI classes
are for, really.
Tim.
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
dblaikie added a comment.
For 3 code paths (that seem fairly independent from one another) I'd only
really expect to see 3 variables in the test - one to exercise each codepath.
What's the reason for the larger set of test cases?
Then it might be simpler just to include 6 variables, one of each
Author: nico
Date: Wed Apr 27 12:26:08 2016
New Revision: 267744
URL: http://llvm.org/viewvc/llvm-project?rev=267744&view=rev
Log:
Revert r267691, it caused PR27535.
Removed:
cfe/trunk/test/Modules/Inputs/PR27401/
cfe/trunk/test/Modules/pr27401.cpp
Modified:
cfe/trunk/include/clang/AS
rnk added a subscriber: rnk.
rnk added a comment.
+1 for canCallMismatchedFunctionType.
I guess there's a more general issue here which is that LLVM appears to be more
permissive about prototype mismatch than wasm. Specifically, I'm thinking about
how swifterror relies on being able to pass ext
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267746: PR21823: 'nodebug' attribute on global/static
variables. (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D19567?vs=55116&id=55260#toc
Repository:
rL LLVM
http://rev
jfb added a subscriber: pcc.
jfb added a comment.
> I guess there's a more general issue here which is that LLVM appears to be
> more permissive about prototype mismatch than wasm. Specifically, I'm
> thinking about how swifterror relies on being able to pass extra parameters
> to a function th
Author: probinson
Date: Wed Apr 27 12:37:12 2016
New Revision: 267746
URL: http://llvm.org/viewvc/llvm-project?rev=267746&view=rev
Log:
PR21823: 'nodebug' attribute on global/static variables.
Make 'nodebug' on a global/static variable suppress all debug info
for the variable. Previously it would
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D19432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[Dmitry Polukhin]
> As for 'A*' to 'B*" case, indeed it is not very common and it looks like
> someone just forgot to specify 'public'.
If we're doing something gratuitously nonconformant in MS product code or even
sample code, you should report it to us, so we can fix it upstream, instead of
h
On Wed, Apr 27, 2016 at 11:50 AM, Stephan T. Lavavej via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> [Dmitry Polukhin]
> > As for 'A*' to 'B*" case, indeed it is not very common and it looks like
> someone just forgot to specify 'public'.
>
> If we're doing something gratuitously nonconform
Author: dblaikie
Date: Wed Apr 27 13:47:45 2016
New Revision: 267754
URL: http://llvm.org/viewvc/llvm-project?rev=267754&view=rev
Log:
Fix a bunch of sign-compare warnings
Modified:
clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Modified:
clang-too
On Wed, Apr 27, 2016 at 11:52 AM, Richard Smith
wrote:
> On Wed, Apr 27, 2016 at 11:50 AM, Stephan T. Lavavej via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> [Dmitry Polukhin]
>> > As for 'A*' to 'B*" case, indeed it is not very common and it looks
>> like someone just forgot to speci
Author: cbieneman
Date: Wed Apr 27 13:52:48 2016
New Revision: 267756
URL: http://llvm.org/viewvc/llvm-project?rev=267756&view=rev
Log:
[CMake] On Darwin bootstrap LTO builds set DYLD_LIBRARY_PATH instead of using
llvm-ar
llvm-ar isn't really supported for Darwin, instead the host tools will loa
mclow.lists added a comment.
In general, I'm happy with this direction. I think we need to check that there
are no ABI changes that happen here (I don't see any, but I'll keep looking),
and I think the stuff in `<__os_support>` should be marked "always inline"
On a bikeshed note: is `<__os_supp
Prazek marked 4 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D18136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D19524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Prazek updated this revision to Diff 55280.
http://reviews.llvm.org/D18136
Files:
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang-tidy/boost/UseToStringCheck.cpp
clang-tidy/boost/UseToStringCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/boost-use-to-st
[Richard Smith]
> You can find a description of the problem in http://llvm.org/PR27337
> Brief summary:
> The WTL bug is the missing 'public' on the second base class on this line:
> https://sourceforge.net/p/wtl/code/HEAD/tree/trunk/wtl/Samples/MDIDocVw/mainfrm.h#l636
> The C1xx bug is that it ac
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267764: Call TargetMachine::addEarlyAsPossiblePasses from
BackendUtil. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18617?vs=53415&id=55290#toc
Repository:
rL LLVM
http://
Author: jlebar
Date: Wed Apr 27 14:12:56 2016
New Revision: 267764
URL: http://llvm.org/viewvc/llvm-project?rev=267764&view=rev
Log:
Call TargetMachine::addEarlyAsPossiblePasses from BackendUtil.
Summary:
As of D18614, TargetMachine exposes a hook to add a set of passes that should
be run as earl
Prazek marked 3 inline comments as done.
Prazek added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 195 matches
Mail list logo
