vsk added a subscriber: vsk.
vsk added a comment.
Just a few nitpicks.
Comment at: lib/CodeGen/BackendUtil.cpp:785
@@ +784,3 @@
+ llvm::WriteBitcodeToFile(M, OS, /* ShouldPreserveUseListOrder */ true);
+ ModuleData = ArrayRef((uint8_t*)OS.str().data(),
+
Author: ericwf
Date: Thu Apr 21 19:15:18 2016
New Revision: 267085
URL: http://llvm.org/viewvc/llvm-project?rev=267085&view=rev
Log:
Complete LWG issue #2016. Allocators must be nothrow swappable
Modified:
libcxx/trunk/test/std/containers/associative/map/map.special/swap_noexcept.pass.cpp
steven_wu updated this revision to Diff 54597.
steven_wu added a comment.
Thanks Vedant!
Address all of your review in this update.
http://reviews.llvm.org/D17392
Files:
include/clang/CodeGen/BackendUtil.h
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
includ
srhines added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
Anna should probably d
Author: chapuni
Date: Thu Apr 21 19:33:39 2016
New Revision: 267087
URL: http://llvm.org/viewvc/llvm-project?rev=267087&view=rev
Log:
clangTidyReadabilityModule: Add clangTidyUtils in libdeps, corresponding to
r267003.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/CMakeLists.txt
Does r267089 help?
On Thu, Apr 21, 2016 at 5:56 PM, Vedant Kumar wrote:
> Hm, here's something weird --
>
> The test passes if I change this RUN line:
>
> // RUN: %clang_cl -Werror /Ycpchfile.h /FIpchfile.h /c -###
> %S/Inputs/file.prof
>
> To this:
>
> // RUN: %clang_cl -Werror /Ycpchfi
Author: nico
Date: Thu Apr 21 19:38:09 2016
New Revision: 267089
URL: http://llvm.org/viewvc/llvm-project?rev=267089&view=rev
Log:
Try to get test passing on OS X (see comment at top of file).
Modified:
cfe/trunk/test/Driver/cl-pch.cpp
Modified: cfe/trunk/test/Driver/cl-pch.cpp
URL:
http://
Author: ericwf
Date: Thu Apr 21 19:47:15 2016
New Revision: 267090
URL: http://llvm.org/viewvc/llvm-project?rev=267090&view=rev
Log:
Fix C++03 build breakage
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.special/swap.pass.cpp
Modified:
libcxx/trunk/test/std/containers/seq
Author: ericwf
Date: Thu Apr 21 19:49:12 2016
New Revision: 267091
URL: http://llvm.org/viewvc/llvm-project?rev=267091&view=rev
Log:
Fix LWG issue #2106: move_iterators returning prvalues
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/test/std/iterators/predef.iterators/move.iterat
EricWF added a comment.
Still LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis closed this revision.
eugenis added a comment.
r267093
Thanks for your help!
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: eugenis
Date: Thu Apr 21 20:04:55 2016
New Revision: 267093
URL: http://llvm.org/viewvc/llvm-project?rev=267093&view=rev
Log:
Cleanup: move visibility/linkage attributes to the first declaration.
http://reviews.llvm.org/D15404
Modified:
libcxx/trunk/include/complex
libcxx/trunk/i
Yes, thank you very much!
vedant
> On Apr 21, 2016, at 5:43 PM, Nico Weber wrote:
>
> Does r267089 help?
>
> On Thu, Apr 21, 2016 at 5:56 PM, Vedant Kumar wrote:
> Hm, here's something weird --
>
> The test passes if I change this RUN line:
>
> // RUN: %clang_cl -Werror /Ycpchfile.h /FI
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/CMakeLists.txt:3
@@ +2,3 @@
+ -I ${CMAKE_CURRENT_SOURCE_DIR}/../../../
+ SOURCE ../../../../lib/StaticAnalyzer/Checkers/Checkers.td
+ TARGET ClangSACheckers)
srhines wrote:
> Ann
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:696
@@ -695,1 +695,3 @@
+assert(ArgExpr && "cannot get the type of a NULL expression");
+
LGTM
http://reviews.llvm.org/D19278
___
Author: abataev
Date: Thu Apr 21 22:56:56 2016
New Revision: 267101
URL: http://llvm.org/viewvc/llvm-project?rev=267101&view=rev
Log:
[OPENMP] Fix for LCV in simd directives in explicit clauses.
If loop control variable for simd-based directives is explicitly marked
as linear/lastprivate in claus
anemet created this revision.
anemet added reviewers: aaron.ballman, rsmith.
anemet added subscribers: hfinkel, cfe-commits.
This is similar to other loop pragmas like 'vectorize'. Currently it
only has state values: distribute(enable) and distribute(disable). When
one of these is specified the
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2789-2797
@@ +2788,11 @@
+// \brief Expression associated with the component.
+Expr *AssociatedExpression;
+// \brief Declaration associated with the declaration. If the component
does
+//
101 - 118 of 118 matches
Mail list logo
