Re: [PATCH] D19270: Fix a crash in cppcoreguidelines-pro-type-member-init related to missing constructor bodies.

2016-04-20 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. LGTM. Thanks. http://reviews.llvm.org/D19270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19311: Self Assignment Checker

2016-04-20 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: dcoughlin. baloghadamsoftware added subscribers: cfe-commits, xazax.hun, o.gyorgy. This checker checks copy and move assignment operators whether they are protected against self-assignment. Since C++ core guidelines di

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

2016-04-20 Thread Serge Pavlov via cfe-commits
2016-03-29 1:08 GMT+06:00 Serge Pavlov : > 2016-03-18 20:50 GMT+06:00 Richard Smith : > >> rsmith added a comment. >> >> Can we instead not add the function to the redeclaration chain until it's >> instantiated (like we do if it's dependent)? >> >> > I prepared implementation that uses this approa

Re: [PATCH] D19270: Fix a crash in cppcoreguidelines-pro-type-member-init related to missing constructor bodies.

2016-04-20 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266862: Fix a crash in cppcoreguidelines-pro-type-member-init related to missing… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19270?vs=54210&id=54327#toc Repository: rL LL

[clang-tools-extra] r266862 - Fix a crash in cppcoreguidelines-pro-type-member-init related to missing constructor bodies.

2016-04-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 20 03:29:08 2016 New Revision: 266862 URL: http://llvm.org/viewvc/llvm-project?rev=266862&view=rev Log: Fix a crash in cppcoreguidelines-pro-type-member-init related to missing constructor bodies. Summary: Fixes a crash in cppcoreguidelines-pro-type-member-init when

Re: [PATCH] D11781: Refactored pthread usage in libcxx

2016-04-20 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In http://reviews.llvm.org/D11781#403349, @rmaprath wrote: > In http://reviews.llvm.org/D11781#403343, @theraven wrote: > > > In http://reviews.llvm.org/D11781#403335, @rmaprath wrote: > > > > > For us (ARM), a threads porting layer is important on several RTOSes > > >

[PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-20 Thread Raphael Isemann via cfe-commits
teemperor created this revision. teemperor added a reviewer: rsmith. teemperor added a subscriber: cfe-commits. According to [12.6.2 p16] calling member functions of the current class before all the base classes are initialized is undefined behavior. Some compilers (such as GCC 5.3 + ubsan)

[clang-tools-extra] r266864 - clang-tidy: [misc-unused-using-decls] Always use the canonical decl to

2016-04-20 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Apr 20 03:58:27 2016 New Revision: 266864 URL: http://llvm.org/viewvc/llvm-project?rev=266864&view=rev Log: clang-tidy: [misc-unused-using-decls] Always use the canonical decl to identify things. This fixes llvm.org/PR27430. Modified: clang-tools-extra/trunk/clang-t

[clang-tools-extra] r266866 - clang-tidy: [misc-unused-using-decls] Support template types.

2016-04-20 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Wed Apr 20 04:48:56 2016 New Revision: 266866 URL: http://llvm.org/viewvc/llvm-project?rev=266866&view=rev Log: clang-tidy: [misc-unused-using-decls] Support template types. This fixes llvm.org/PR27429. Modified: clang-tools-extra/trunk/clang-tidy/misc/UnusedUsingDeclsC

[PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: djasper. bkramer added subscribers: cfe-commits, hokein, ioeric. The goal of this tool is fairly simple, look up unknown identifiers in a global database and add the corresponding #include line. It accomplishes this by hooking into Sema as a

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Manuel Klimek via cfe-commits
klimek added a subscriber: klimek. Comment at: include-fixer/FixedXrefsDB.h:18 @@ +17,3 @@ + +/// Xref database with fixed content, intended for testing +// FIXME: Move to unittest once ClangIncludeFixer doesn't depend on it anymore. Add '.', remove "intended for

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-20 Thread Andrey Turetskiy via cfe-commits
aturetsk updated this revision to Diff 54341. aturetsk added a comment. Fixed the remarks. http://reviews.llvm.org/D19274 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

Re: [PATCH] D18080: CIndex: add support for static_assert

2016-04-20 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. Ping? http://reviews.llvm.org/D18080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18081: Make sizeof and alignof a CXCursor_UnaryExpr

2016-04-20 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. Ping? http://reviews.llvm.org/D18081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 54342. bkramer added a comment. - FixedXrefsDB -> FakeXrefsDB - FakeXrefsDB is now configurable - Cosmetic & comment fixes. - Moved query to private methods. - Always insert new includes at the top, let clang-format sort out the rest (not yet implemented in t

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-20 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Hi Mandeep, Thanks for the review. Comment at: lib/Driver/ToolChains.cpp:2153 @@ -2148,1 +2152,3 @@ + FilterNonExistent NonExistent( + Path, TargetTriple.isOSIAMCU() ? "/libgcc.a" : "/crtbegin.o", D.getVFS()); Does anybody know

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-20 Thread Raphael Isemann via cfe-commits
teemperor updated this revision to Diff 54343. teemperor added a comment. - Fixed indentation http://reviews.llvm.org/D19312 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ctor-init-with-member-call.cpp Index: test/SemaCXX/ctor-init-with-member-ca

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 54344. bkramer added a comment. From now on you shall be known as InMemoryXrefsDB. http://reviews.llvm.org/D19314 Files: CMakeLists.txt include-fixer/CMakeLists.txt include-fixer/InMemoryXrefsDB.cpp include-fixer/InMemoryXrefsDB.h include-fixer/In

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Benjamin Kramer via cfe-commits
bkramer marked 8 inline comments as done. Comment at: include-fixer/IncludeFixer.cpp:132 @@ +131,3 @@ + +private: + /// Query the database for a given identifier. klimek wrote: > Can we sort this so the public interface comes first? Also, why is the public > int

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. Cool, lg. Comment at: include-fixer/IncludeFixer.cpp:133 @@ +132,3 @@ + StringRef filename() const { return Filename; } + + /// Called for e

Re: [PATCH] D19314: [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266870: [include-fixer] Add a prototype for a new include fixing tool. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19314?vs=54344&id=54350#toc Repository: rL LLVM http://rev

[clang-tools-extra] r266870 - [include-fixer] Add a prototype for a new include fixing tool.

2016-04-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Apr 20 07:43:43 2016 New Revision: 266870 URL: http://llvm.org/viewvc/llvm-project?rev=266870&view=rev Log: [include-fixer] Add a prototype for a new include fixing tool. Summary: The goal of this tool is fairly simple, look up unknown identifiers in a global database and ad

Re: [PATCH] D19323: Fix cast compiler warning message in include-fixer.

2016-04-20 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rL LLVM http://reviews.llvm.org/D19323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-20 Thread Clement Courbet via cfe-commits
courbet created this revision. courbet added a subscriber: cfe-commits. Herald added a subscriber: klimek. Matches methods overridden by the given method. http://reviews.llvm.org/D19324 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatcher

[clang-tools-extra] r266874 - IncludeFixerTest.cpp: Tweak not to assume clang-tools-extra were onto clang/tools/extra.

2016-04-20 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Wed Apr 20 09:14:16 2016 New Revision: 266874 URL: http://llvm.org/viewvc/llvm-project?rev=266874&view=rev Log: IncludeFixerTest.cpp: Tweak not to assume clang-tools-extra were onto clang/tools/extra. Modified: clang-tools-extra/trunk/unittests/include-fixer/CMakeLists.

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-20 Thread Filipe Cabecinhas via cfe-commits
filcab added a subscriber: filcab. filcab added a comment. You might want to mention that it's 12.6.2p16 in C++14/17 but p13 in C++11. I wonder if we should have the example in the standard, verbatim. (Plus the added tests you made) http://reviews.llvm.org/D19312

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Sanjay Patel via cfe-commits
spatel added a comment. [reposting this as a general comment because the inline comment did not seem to make it to the mailing list] Yes, I want to merge the handling of builtin_expect and builtin_unpredictable. Currently, the 'unpredictable' metadata has no parameters; it is an empty string l

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Amaury SECHET via cfe-commits
deadalnix added a subscriber: deadalnix. Comment at: lib/CodeGen/CGStmt.cpp:1560-1588 @@ -1560,1 +1559,31 @@ +MDHelper.createUnpredictable()); + } else if (FD->getBuiltinID() == Builtin::BI__builtin_expect) { + +// FIXME: builtin_expect

[PATCH] D19327: Keep invalid function body as part of the AST

2016-04-20 Thread Olivier Goffart via cfe-commits
ogoffart created this revision. ogoffart added reviewers: cfe-commits, rsmith. struct XX { double foo(invalid_type xx); }; double XX::foo(invalid_type xx) { return 45; } We should keep XX::foo and its function body as part of the AST so tools can still do something with the body even if

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

2016-04-20 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D19278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-20 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:421 @@ +420,3 @@ +switch (LangOpts.OpenCLVersion) { +case 100: + Builder.defineMacro("__OPENCL_C_VERSION__", "100"); Yes, perfectly makes sense. I don't think passing C std

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:636 @@ -640,1 +635,3 @@ + case Builtin::BI__builtin_unpredictable: case Builtin::BI__builtin_expect: { +// Always return the first argument. LLVM does not handle these builtins. Can this

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-20 Thread Filipe Cabecinhas via cfe-commits
filcab added a comment. I meant changing the diff, but if you prefer to have a smaller comment, I'm ok with the different "paths" in the standards being mentioned only in the commit message. Comment at: lib/Sema/SemaDeclCXX.cpp:3941 @@ +3940,3 @@ + // Calling a member fun

Re: [PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

2016-04-20 Thread Raphael Isemann via cfe-commits
teemperor added a comment. Oh, totally forgot that I also had a reference in the code, thanks! Will fix it ASAP. Adding the example from the standard to the test cases sounds good. It actually tests a few things that aren't covered by the current test. http://reviews.llvm.org/D19312 __

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

2016-04-20 Thread Reid Kleckner via cfe-commits
rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. As mentioned twice in https://llvm.org/bugs/show_bug.cgi?id=27212, I don't think this is the right direction. To my knowledge, this only causes an ABI break when importing a class. I think

Re: [PATCH] D19253: [Tooling] Fix getting fully qualified names of template alias types.

2016-04-20 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D19253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Sanjay Patel via cfe-commits
spatel added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:1562 @@ +1561,3 @@ + +// FIXME: builtin_expect should use the same metadata type as +// builtin_unpredictable and be handled above. For now, we're mimicking davidxl wrote: > I am not

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-20 Thread Mandeep Singh Grang via cfe-commits
mgrang added a subscriber: mgrang. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3719 @@ +3718,3 @@ +/// matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and +/// once with "b" binding "A2::f" and "d" binding "C::f", and +AST_MATCHER_P(CXXMethodDecl,

[PATCH] D19336: Repair redeclaration chain of friend template functions.

2016-04-20 Thread Serge Pavlov via cfe-commits
sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff added a subscriber: cfe-commits. When friend template function is parsed, it obtains wrong type. For instance, in the code: template void func(T1 *x); template struct C1 { template void func(T1 *x); }; the friend

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-20 Thread Douglas Yung via cfe-commits
dyung added a comment. Ping http://reviews.llvm.org/D19003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

2016-04-20 Thread Reid Kleckner via cfe-commits
rnk added a comment. I think this generally seems right, but we should make sure our behavior is more consistent in the case of a template definition. Comment at: lib/Sema/SemaDecl.cpp:5570-5571 @@ -5565,4 +5569,4 @@ // exceptions being inline function definitions, local ext

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

2016-04-20 Thread Douglas Yung via cfe-commits
dyung added a comment. Any thoughts on this test? http://reviews.llvm.org/D19048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. (hit Submit early...) 2. How does AST look for these test cases? I wonder whether there are any similar cases not covered by PredefinedExpr. And thank you for the patch! Repository: rL LLVM http://reviews.llvm.org/D19331 __

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. 1. Please generate diffs with full context when sending patches. Use any of the methods described in http://llvm.org/docs/Phabricator.html. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:111 @@ -110,2 +110,3 @@ void RawStringLiteralCheck::re

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-20 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 54404. yaxunl added a comment. Fix test/preprocessor/predefined_macros.c. Merge test/frontend/std.cl into langstd.c since they are similar. http://reviews.llvm.org/D19071 Files: lib/Frontend/CompilerInvocation.cpp lib/Frontend/InitPreprocessor.cpp tes

Re: [PATCH] D19336: Repair redeclaration chain of friend template functions.

2016-04-20 Thread Richard Smith via cfe-commits
rsmith added a comment. Sorry, I don't think this approach can work. Consider: template struct X { template friend void f(T); template friend void f(U); }; These two friend declarations declare different friend function templates, but this transformation would incorrectly make them

[libunwind] r266913 - unwind: unify _LIBUNWIND_SUPPORT_DWARF_UNWIND

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:53:40 2016 New Revision: 266913 URL: http://llvm.org/viewvc/llvm-project?rev=266913&view=rev Log: unwind: unify _LIBUNWIND_SUPPORT_DWARF_UNWIND Join the two paths for this macro. At the end of the day, the difference was that MIPS and ARM on Apple have differ

[libunwind] r266916 - unwind: remove a second instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:54:55 2016 New Revision: 266916 URL: http://llvm.org/viewvc/llvm-project?rev=266916&view=rev Log: unwind: remove a second instance of -Wexpansion-to-defined Remove the use of undefined behaviour in the c preprocessor by always defining the value according to t

[libunwind] r266915 - unwind: remove an instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 15:54:51 2016 New Revision: 266915 URL: http://llvm.org/viewvc/llvm-project?rev=266915&view=rev Log: unwind: remove an instance of -Wexpansion-to-defined This follows the pattern in the Apple clause duplicating a tuple of definitions. However, it will define them

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Sanjay Patel via cfe-commits
spatel marked 4 inline comments as done. Comment at: lib/CodeGen/CGBuiltin.cpp:636 @@ -640,1 +635,3 @@ + case Builtin::BI__builtin_unpredictable: case Builtin::BI__builtin_expect: { +// Always return the first argument. LLVM does not handle these builtins.

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Sanjay Patel via cfe-commits
spatel updated this revision to Diff 54423. spatel added a comment. Patch updated: 1. Fixed/removed comments 2. Changed likely/unlikely profile weights to be min/max values. I'm not sure why 4 and 64 were used in LowerExpectIntrinsics, but that may not trigger the programmer's intent with built

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the explanation! The change looks good now. Do you need me to submit the patch for you? As for other cases that can lead to this, it might be possible to achieve the same effect

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: lib/CodeGen/CodeGenPGO.cpp:47 @@ +46,3 @@ + // Create PGOFuncName meta data. + if (!llvm::getPGOFuncNameMetadata(*Fn)) +llvm::createPGOFuncNameMetadata(*Fn); This check be folded into the creator. The creator interf

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

2016-04-20 Thread Vladimir Yakovlev via cfe-commits
vbyakovl added a comment. Richard, now my changes are good for you? http://reviews.llvm.org/D18823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19299: lower __builtin_expect() directly to prof metadata instead of LLVM intrinsic

2016-04-20 Thread Amaury SECHET via cfe-commits
deadalnix added a comment. In http://reviews.llvm.org/D19299#406517, @spatel wrote: > Rereading your question, I'm now wondering if you are asking if we can get > rid of the source level builtin_unpredictable() ? I had not considered that, > but I think that is also possible if we add a flag to

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-20 Thread Paul Robinson via cfe-commits
probinson added a subscriber: probinson. Comment at: test/Sema/attr-deprecated.c:124 @@ -123,1 +123,3 @@ +// This note requires C11. +#if __STDC_VERSION__ > 199901L Just the note? Or the warning? Comment at: test/Sema/nullability.c:30 @@ -25,1

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Marek via cfe-commits
edyp87 removed rL LLVM as the repository for this revision. edyp87 updated this revision to Diff 54401. edyp87 added a comment. Extended diff range + removed unnecessary variable. http://reviews.llvm.org/D19331 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp test/clang-tidy/modernize-

r266887 - Add warning about CR+LF line endings on Windows.

2016-04-20 Thread Adrian McCarthy via cfe-commits
Author: amccarth Date: Wed Apr 20 11:43:34 2016 New Revision: 266887 URL: http://llvm.org/viewvc/llvm-project?rev=266887&view=rev Log: Add warning about CR+LF line endings on Windows. s/checkout/check out/ when used as a verb. Differential Revision: http://reviews.llvm.org/D19285 Modified:

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Marek via cfe-commits
edyp87 marked an inline comment as done. edyp87 added a comment. 1. Extended diff has been generated - sorry, I am new to Phabricator. 2. AST for this case looks like this: > AST for crashing case: > > -VarDecl 0x2b27370 col:19 function 'const char *const' > callinit >`-ImplicitCastEx

r266925 - [Tooling] Fix getting fully qualified names of template alias types.

2016-04-20 Thread Chaoren Lin via cfe-commits
Author: chaoren Date: Wed Apr 20 17:12:07 2016 New Revision: 266925 URL: http://llvm.org/viewvc/llvm-project?rev=266925&view=rev Log: [Tooling] Fix getting fully qualified names of template alias types. Reviewers: rsmith, rnk Subscribers: cfe-commits, klimek Differential Revision: http://review

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

2016-04-20 Thread Richard Smith via cfe-commits
rsmith added a comment. In http://reviews.llvm.org/D18953#397279, @rnk wrote: > Richard, do you think we should be handling this by rewriting the AST-level > attribute in Sema or by changing our interpretation of things in CodeGen? > We're already creating a bunch of implicit attributes to impl

Re: [PATCH] D19253: [Tooling] Fix getting fully qualified names of template alias types.

2016-04-20 Thread Chaoren Lin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266925: [Tooling] Fix getting fully qualified names of template alias types. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D19253?vs=54225&id=54435#toc Repository: rL LLVM

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

2016-04-20 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla added a comment. Richard, Eric, Please take a look at the patch. Thank you, Denis Zobnin http://reviews.llvm.org/D18652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Rong Xu via cfe-commits
the reason for splitting the check is we don't need this check at all in llvm instrument,-- as it's done per function. but I guess it does not matter much to move it in to create -- it's only called once per function. On Wed, Apr 20, 2016 at 3:04 PM, David Li wrote: > davidxl added inline co

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Rong Xu via cfe-commits
xur added a comment. the reason for splitting the check is we don't need this check at all in llvm instrument,-- as it's done per function. but I guess it does not matter much to move it in to create -- it's only called once per function. http://reviews.llvm.org/D18624 ___

[libunwind] r266926 - unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 17:18:47 2016 New Revision: 266926 URL: http://llvm.org/viewvc/llvm-project?rev=266926&view=rev Log: unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS Unify the definition of the _LIBUNWIND_SUPPORT_FRAME_APIS macro. This is in preparation to remove a

[libunwind] r266927 - unwind: remove another instance of -Wexpansion-to-defined

2016-04-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 20 17:18:50 2016 New Revision: 266927 URL: http://llvm.org/viewvc/llvm-project?rev=266927&view=rev Log: unwind: remove another instance of -Wexpansion-to-defined Remove the use of undefined behaviour in the c preprocessor by always defining the value according to th

Re: [PATCH] D18652: [Inline asm] Correctly parse GCC-style asm line following MS-style asm line

2016-04-20 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D18652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [libunwind] r266926 - unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS

2016-04-20 Thread Richard Smith via cfe-commits
On Wed, Apr 20, 2016 at 3:18 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Wed Apr 20 17:18:47 2016 > New Revision: 266926 > > URL: http://llvm.org/viewvc/llvm-project?rev=266926&view=rev > Log: > unwind: unify the definition of _LIBUNWIND_S

Re: [libunwind] r266926 - unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS

2016-04-20 Thread Richard Smith via cfe-commits
On Wed, Apr 20, 2016 at 3:31 PM, Richard Smith wrote: > On Wed, Apr 20, 2016 at 3:18 PM, Saleem Abdulrasool via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: compnerd >> Date: Wed Apr 20 17:18:47 2016 >> New Revision: 266926 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=266

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Adam Nemet via cfe-commits
anemet added a comment. Still does not to work. The metadata has the full path for the file while the prof data only has the filename. FTR, I applied this and the ICP patch on top of r266465. http://reviews.llvm.org/D18624 ___ cfe-commits mailing

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

2016-04-20 Thread Sean Silva via cfe-commits
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > (sorry, accidentally sent this mid-mail) > > ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable > 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Rong Xu via cfe-commits
these two patches work fine in my build. My llvm was on top ov r265491. The opt remarks in the last email were emitted by the compiler. I'll try to reproduce with r266465. On Apr 20, 2016 4:00 PM, "Adam Nemet" wrote: > anemet added a comment. > > Still does not to work. The metadata has the f

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Rong Xu via cfe-commits
xur added a comment. these two patches work fine in my build. My llvm was on top ov r265491. The opt remarks in the last email were emitted by the compiler. I'll try to reproduce with r266465. http://reviews.llvm.org/D18624 ___ cfe-commits mailing

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

2016-04-20 Thread Sean Silva via cfe-commits
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > (sorry, accidentally sent this mid-mail) > > ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable > 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

2016-04-20 Thread Adam Nemet via cfe-commits
anemet added a comment. Rong, do you have full paths or just the filename? http://reviews.llvm.org/D18624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-20 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 54439. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments http://reviews.llvm.org/D18635 Files: docs/ControlFlowIntegrity.rst docs/LTOVisibility.rst docs/UsersManual.rst docs/index.rst include/clang/Basic/Attr.td in

Re: [PATCH] D18635: Rework interface for bitset-using features to use a notion of LTO visibility.

2016-04-20 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Thanks for the comments. I've also taken another pass over the docs and changed them to specify that classes defined in translation units compiled without LTO receive public LTO visibility. This seems more precise to me, but please let me know what you think. I have also a

r266937 - Module Debugging: Emit the canonical debug info for Objective-C classes

2016-04-20 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Apr 20 18:59:32 2016 New Revision: 266937 URL: http://llvm.org/viewvc/llvm-project?rev=266937&view=rev Log: Module Debugging: Emit the canonical debug info for Objective-C classes in the compile unit that contains their implementation even if their interface is declared in

r266938 - Remove the (ignored) -Wreceived-is-weak diagnostic.

2016-04-20 Thread Bob Wilson via cfe-commits
Author: bwilson Date: Wed Apr 20 19:11:24 2016 New Revision: 266938 URL: http://llvm.org/viewvc/llvm-project?rev=266938&view=rev Log: Remove the (ignored) -Wreceived-is-weak diagnostic. We kept this around for a while since Xcode 6 and earlier had a build setting for this warning. It was removed

Re: [PATCH] D19344: [libc++] fix constexpr error when build with MUSL and macro redef warning when no exception

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. This revision now requires changes to proceed. Comment at: include/__mutex_base:43 @@ -42,3 +42,3 @@ _LIBCPP_INLINE_VISIBILITY -#ifndef _LIBCPP_HAS_NO_CONSTEXPR +#ifndef _LIBCPP_HAS_NO_CXX14_CONSTEXPR constexpr mutex() _NOEXCEP

[PATCH] D19346: [CUDA] Copy host builtin types to NVPTXTargetInfo.

2016-04-20 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, jhen, cfe-commits. Host and device types must match, otherwise when we pass values back and forth between the host and device, we will get the wrong result. This patch makes NVPTXTargetInfo inherit most

r266945 - [modules] Make the tweak to avoid circular inclusion of emmintrin.h and

2016-04-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 20 20:46:37 2016 New Revision: 266945 URL: http://llvm.org/viewvc/llvm-project?rev=266945&view=rev Log: [modules] Make the tweak to avoid circular inclusion of emmintrin.h and xmmintrin.h a bit more directed. If for whatever reason modules are enabled but we textually

Re: [PATCH] D19344: [libc++] fix constexpr error when build with MUSL and macro redef warning when no exception

2016-04-20 Thread Weiming Zhao via cfe-commits
weimingz added inline comments. Comment at: include/__config:300 @@ -299,3 +299,3 @@ -#if !(__has_feature(cxx_exceptions)) +#if !(__has_feature(cxx_exceptions)) && !defined(_LIBCPP_NO_EXCEPTIONS) #define _LIBCPP_NO_EXCEPTIONS Is this change OK? ===

Re: [PATCH] D19344: [libc++] fix constexpr error when build with MUSL and macro redef warning when no exception

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: include/__config:300 @@ -299,3 +299,3 @@ -#if !(__has_feature(cxx_exceptions)) +#if !(__has_feature(cxx_exceptions)) && !defined(_LIBCPP_NO_EXCEPTIONS) #define _LIBCPP_NO_EXCEPTIONS weimingz wrote: > Is this change OK?

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

2016-04-20 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast updated this revision to Diff 54455. hubert.reinterpretcast added a comment. Store the RequiresClause expression into the created storage; add accessor; add unnecessary parens to silence warning http://reviews.llvm.org/D19322 Files: include/clang/AST/DeclTemplate.h li

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

2016-04-20 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast updated this revision to Diff 54456. hubert.reinterpretcast added a comment. Actually add parens this time http://reviews.llvm.org/D19322 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp lib/Sema/SemaTemplateDeduction.cpp Index: lib/Sema/SemaTemplat

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Weiming Zhao via cfe-commits
weimingz retitled this revision from "[libc++] fix constexpr error when build with MUSL and macro redef warning when no exception" to "[libc++] fix macro redef warning when exception is disabled". weimingz updated the summary for this revision. weimingz updated this revision to Diff 54457. http:

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Normally system header would simply ignore this problem. However it's valuable to compile libc++ as a non-system header for both users and developers. Than you for the patch. http://r

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Eric Fiselier via cfe-commits
EricWF added a comment. s/than you/thank you http://reviews.llvm.org/D19344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19344: [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Weiming Zhao via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266956: [libc++] fix macro redef warning when exception is disabled (authored by weimingz). Changed prior to commit: http://reviews.llvm.org/D19344?vs=54457&id=54459#toc Repository: rL LLVM http://r

[libcxx] r266956 - [libc++] fix macro redef warning when exception is disabled

2016-04-20 Thread Weiming Zhao via cfe-commits
Author: weimingz Date: Thu Apr 21 00:28:18 2016 New Revision: 266956 URL: http://llvm.org/viewvc/llvm-project?rev=266956&view=rev Log: [libc++] fix macro redef warning when exception is disabled Summary: when setting LIBCXX_ENABLE_EXCEPTIONS=false, _LIBCPP_NO_EXCEPTIONS wil be defined in both c

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-20 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 54462. courbet marked an inline comment as done. courbet added a comment. Fix typo in doc. http://reviews.llvm.org/D19324 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp In