r266280 - [Clang][AVX512][BUILTIN] Adding support for intrinsics of vpmov{d|q}{b|w|d}{128|256|512} instruction set

2016-04-14 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Thu Apr 14 02:56:51 2016 New Revision: 266280 URL: http://llvm.org/viewvc/llvm-project?rev=266280&view=rev Log: [Clang][AVX512][BUILTIN] Adding support for intrinsics of vpmov{d|q}{b|w|d}{128|256|512} instruction set Differential Revision: http://reviews.llvm.org/D19055

Re: r266108 - clang-cl: Remove -isystem, add -imsvc.

2016-04-14 Thread Ismail Donmez via cfe-commits
Hi, On Tue, Apr 12, 2016 at 10:04 PM, Nico Weber via cfe-commits wrote: > Author: nico > Date: Tue Apr 12 14:04:37 2016 > New Revision: 266108 > > URL: http://llvm.org/viewvc/llvm-project?rev=266108&view=rev > Log: > clang-cl: Remove -isystem, add -imsvc. > > r260990 exposed -isystem in clang-cl.

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Piotr Padlewski via cfe-commits
Prazek added a subscriber: Prazek. Prazek added a comment. Does it solve my problem with isInTemplateInstantiation? :) Repository: rL LLVM http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Alexander Kornienko via cfe-commits
No, but I'm working on the solution. On Apr 14, 2016 11:06, "Piotr Padlewski" wrote: > Prazek added a subscriber: Prazek. > Prazek added a comment. > > Does it solve my problem with isInTemplateInstantiation? :) > > > Repository: > rL LLVM > > http://reviews.llvm.org/D19059 > > > >

Re: [PATCH] D19059: Reorder ASTNodeKind::AllKindInfo to match NodeKindId.

2016-04-14 Thread Alexander Kornienko via cfe-commits
alexfh added a subscriber: alexfh. alexfh added a comment. No, but I'm working on the solution. Repository: rL LLVM http://reviews.llvm.org/D19059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-14 Thread Joerg Sonnenberger via cfe-commits
On Wed, Apr 13, 2016 at 03:02:09PM +, Taewook Oh wrote: > Sure, I'll take a look. > Thanks! Please provide two versions of the test, one hard-coded for an architecture with signed char, one hard-coded for an architecture with unsigned char. That should cover the difference. Joerg

r266287 - [MSVC] Fix check for wchar_t type in case of -fno-wchar

2016-04-14 Thread Dmitry Polukhin via cfe-commits
Author: dpolukhin Date: Thu Apr 14 04:52:06 2016 New Revision: 266287 URL: http://llvm.org/viewvc/llvm-project?rev=266287&view=rev Log: [MSVC] Fix check for wchar_t type in case of -fno-wchar The example below should work identically with and without compiler native wchar_t support. void foo(wch

Re: [PATCH] D19056: [MSVC] Fix check for wchar_t type in case of -fno-wchar

2016-04-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266287: [MSVC] Fix check for wchar_t type in case of -fno-wchar (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D19056?vs=53542&id=53681#toc Repository: rL LLVM http://revi

Re: [PATCH] D19056: [MSVC] Fix check for wchar_t type in case of -fno-wchar

2016-04-14 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. I added few more negative tests. Thank you for the review! Repository: rL LLVM http://reviews.llvm.org/D19056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r266108 - clang-cl: Remove -isystem, add -imsvc.

2016-04-14 Thread Nico Weber via cfe-commits
On Thu, Apr 14, 2016 at 4:09 AM, Ismail Donmez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > On Tue, Apr 12, 2016 at 10:04 PM, Nico Weber via cfe-commits > wrote: > > Author: nico > > Date: Tue Apr 12 14:04:37 2016 > > New Revision: 266108 > > > > URL: http://llvm.org/viewvc/llvm

r266290 - Reapply r258505 after r266254, this time with a comment to make it more sticky.

2016-04-14 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Apr 14 06:12:32 2016 New Revision: 266290 URL: http://llvm.org/viewvc/llvm-project?rev=266290&view=rev Log: Reapply r258505 after r266254, this time with a comment to make it more sticky. Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Modified: cfe/trunk/i

Re: r266254 - [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID

2016-04-14 Thread Nico Weber via cfe-commits
This broke building on http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 . I tried fixing in r266290. On Wed, Apr 13, 2016 at 5:57 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Apr 13 16:57:08 2016 > New Revision: 266254 > > URL: http://l

[PATCH] D19106: Fixed a bug in AnnotatedLine::startsWith when there are comments in the line.

2016-04-14 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added reviewers: djasper, mprobst. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. When there are comments in the line, one token may be checked multiple times. http://reviews.llvm.org/D19106 Files: lib/Format/TokenAnnotator.h In

Re: [PATCH] D19106: Fixed a bug in AnnotatedLine::startsWith when there are comments in the line.

2016-04-14 Thread Daniel Jasper via cfe-commits
djasper added a comment. Can you add a test? Comment at: lib/Format/TokenAnnotator.h:143 @@ +142,3 @@ + Tok = Tok->Next; +return startsWithInternal(Tok, K1) && + startsWithInternal(Tok->Next, Tokens...); It's a bit subtle that this works even

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

2016-04-14 Thread Nico Weber via cfe-commits
thakis added a subscriber: thakis. thakis added a comment. > I want to replace all unsigned that are 1 bits with bool. MSVC only packs bitfields of the same type together, so doing that change would make clang use much more memory on Windows. http://reviews.llvm.org/D19105

Re: [PATCH] D11781: Refactored pthread usage in libcxx

2016-04-14 Thread Asiri Rathnayake via cfe-commits
rmaprath added a subscriber: rmaprath. rmaprath added a comment. Hi, could I know the status of this? I'd like to push this forward. @espositofulvio: Are you working on this? (just checking since this has gone stale for a while). @EricWF: I can create a separate diff for further review if this

Re: r266276 - Do not use llvm:getGlobalContext() in unittests

2016-04-14 Thread Rafael Espíndola via cfe-commits
On 14 April 2016 at 01:34, Mehdi Amini via cfe-commits wrote: > Author: mehdi_amini > Date: Thu Apr 14 00:34:32 2016 > New Revision: 266276 > > URL: http://llvm.org/viewvc/llvm-project?rev=266276&view=rev > Log: > Do not use llvm:getGlobalContext() in unittests > > Currently trying to nuke this AP

Re: [PATCH] D19106: Fixed a bug in AnnotatedLine::startsWith when there are comments in the line.

2016-04-14 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 53691. ioeric added a comment. - Addressed reviewer comment. http://reviews.llvm.org/D19106 Files: lib/Format/TokenAnnotator.h Index: lib/Format/TokenAnnotator.h === --- lib/Format/TokenAnnot

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

2016-04-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266292: [ASTImporter] Implement some expression-related AST node import. (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D14286?vs=53389&id=53692#toc Repository: rL LLVM ht

r266293 - [analyzer] Make it possible to query the function name from a CallDescription.

2016-04-14 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Thu Apr 14 06:56:28 2016 New Revision: 266293 URL: http://llvm.org/viewvc/llvm-project?rev=266293&view=rev Log: [analyzer] Make it possible to query the function name from a CallDescription. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h M

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

2016-04-14 Thread Vladimir Yakovlev via cfe-commits
vbyakovl updated this revision to Diff 53658. vbyakovl added a comment. Sema/SemaType.cpp: Deleted POD type and default constructor checkings. test/SemaCXX/c99-variable-length-array-cxx11.cpp: Edited dianocnics. http://reviews.llvm.org/D18823 Files: llvm/tools/clang/lib/CodeGen/CGClass.cpp

r266292 - [ASTImporter] Implement some expression-related AST node import.

2016-04-14 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Apr 14 06:51:27 2016 New Revision: 266292 URL: http://llvm.org/viewvc/llvm-project?rev=266292&view=rev Log: [ASTImporter] Implement some expression-related AST node import. Introduce ASTImporter unit test framework. Fix a memory leak introduced in cf8ccff5: an array i

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

2016-04-14 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. In http://reviews.llvm.org/D19105#400966, @thakis wrote: > > I want to replace all unsigned that are 1 bits with bool. > > > MSVC only packs bitfields of the same type together, so doing that change > would make clang use much more memory on Windows. Seriously MSVC? Ser

[PATCH] D19108: [Sema] Fixed assert failure in template code analyzer

2016-04-14 Thread Eugene via cfe-commits
kevgs created this revision. kevgs added reviewers: rsmith, dblaikie. kevgs added a subscriber: cfe-commits. Fix for this bug https://llvm.org/bugs/show_bug.cgi?id=27312 http://reviews.llvm.org/D19108 Files: lib/Sema/SemaAccess.cpp test/SemaTemplate/crash-bug-27258.cpp Index: test/SemaTempl

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

2016-04-14 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. http://reviews.llvm.org/D19105 Here is a diff containing fixes for clang. What I see is that it would be nice to detect bitfields of 1 bit and treet it as bool, so it won't warn it such cases. http://reviews.llvm.org/D18821 ___

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. I tested this patch using http://reviews.llvm.org/D15227 Unfortunately for non-array variables the getDescriptiveName returned var_name[0]. Note the spurious [0] part. Could you look into that? http://reviews.llvm.org/D16044 __

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. > I tested this patch using http://reviews.llvm.org/D15227 > Unfortunately for non-array variables the getDescriptiveName returned > var_name[0]. Note the spurious [0] part. > Could you look into that? Could you provide a code example where this effect turns

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. Sure, the test case of http://reviews.llvm.org/D15227 is faiing because of this. In test/Analysis/valist-unterminated.c, line 10 Initialized va_list 'va[0]' is leaked is emitted instead of Initialized va_list 'va' is leaked http://reviews.llvm.org/D16044 __

[PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet created this revision. courbet added a subscriber: cfe-commits. Herald added a subscriber: klimek. - hasType() should be able to match the types of TypedefAliasDecl in addition to TypedefDecl, so made it work on TypedefNameDecl. - new typedefNameDecl() matcher, which should be mostly used

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. Looking at the code it seems that this data structure: `typedef SmallVector RegionVector;` tricks the function into rating the MemRegion as an ElementRegion. http://reviews.llvm.org/D16044 ___ cfe-commits mailing li

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. If we're going to add this (which I think is a good idea), perhaps we should also add `typeAliasDecl()` at the same time? Comment at: unittests/ASTMatc

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. > Looking at the code it seems that this data structure: > typedef SmallVector RegionVector; > tricks the function into rating the MemRegion as an ElementRegion. That's not the problem. I'm using the same data structure in the MPI-Checker patch. http://revi

Re: r266108 - clang-cl: Remove -isystem, add -imsvc.

2016-04-14 Thread Ismail Donmez via cfe-commits
On Thu, Apr 14, 2016 at 2:09 PM, Nico Weber wrote: > It's supposed to match the > > "-internal-isystem" > "/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0/include" > "-internal-isystem" "myincludedir" > > bit in your output. Looks like it's "lib64" instead of "lib" on your system.

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. Might the problem be in the va_list checker? Obviously the va_list variable is identified as an ElementRegion what seems not to be correct. Only if the passed region is an ElementRegion indices get appended. http://reviews.llvm.org/D16044 __

Re: [PATCH] D16044: getDescriptiveName() for MemRegion

2016-04-14 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. I will look into it tomorrow. http://reviews.llvm.org/D16044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19069: clang-format: Fixed various brace wrapping and block merging bugs

2016-04-14 Thread Maxime Beaulieu via cfe-commits
mxbOctasic added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:789-790 @@ -773,4 +788,4 @@ if (FormatTok->Tok.is(tok::l_brace)) { -if (Style.BraceWrapping.AfterObjCDeclaration) - addUnwrappedLine(); +CompoundStatementIndenter Inden

Re: r266108 - clang-cl: Remove -isystem, add -imsvc.

2016-04-14 Thread Nico Weber via cfe-commits
On Thu, Apr 14, 2016 at 10:32 AM, Ismail Donmez wrote: > On Thu, Apr 14, 2016 at 2:09 PM, Nico Weber wrote: > > It's supposed to match the > > > > "-internal-isystem" > > > "/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang/3.9.0/include" > > "-internal-isystem" "myincludedir" > > > > b

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-14 Thread Taewook Oh via cfe-commits
Joerg, Thank you for your comments. I submitted a new patch (http://reviews.llvm.org/D19062) with a new test that checks attributes but not types. I think this should cover both cases. What do you think? Thanks, Taewook On 4/14/16, 2:46 AM, "Joerg Sonnenberger" wrote: >On Wed, Apr 13, 2016 at

Re: [PATCH] D18998: [CodeGen] Explicitly widen non-power-of-2 vector HFA base types.

2016-04-14 Thread Ulrich Weigand via cfe-commits
uweigand added a comment. Makes sense to me. http://reviews.llvm.org/D18998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet updated the summary for this revision. courbet updated this revision to Diff 53724. courbet marked an inline comment as done. courbet added a comment. Added typeAliasDecl. More tests. http://reviews.llvm.org/D19113 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatc

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet added a comment. In http://reviews.llvm.org/D19113#401095, @aaron.ballman wrote: > If we're going to add this (which I think is a good idea), perhaps we should > also add `typeAliasDecl()` at the same time? Makes sense, done. http://reviews.llvm.org/D19113

Re: r266276 - Do not use llvm:getGlobalContext() in unittests

2016-04-14 Thread Mehdi Amini via cfe-commits
> On Apr 14, 2016, at 4:38 AM, Rafael Espíndola > wrote: > > On 14 April 2016 at 01:34, Mehdi Amini via cfe-commits > wrote: >> Author: mehdi_amini >> Date: Thu Apr 14 00:34:32 2016 >> New Revision: 266276 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=266276&view=rev >> Log: >> Do not us

[PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Clement Courbet via cfe-commits
courbet created this revision. courbet added a subscriber: cfe-commits. RedundantVoidArgCheck will now warn on: using f_t = int (*(void))(void); too. (Depends on http://reviews.llvm.org/D19113) http://reviews.llvm.org/D19117 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp clang-tidy

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet added a comment. Example of where this is useful as a drop-in replacement for typedefDecl(): http://reviews.llvm.org/D19117 http://reviews.llvm.org/D19113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

2016-04-14 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. Hi Anna, > I am fine with committing it and iterating with smaller updates in tree if it > is more convenient for you. This sounds good! The last thing I'll change before are the improvements you pointed out. > One task that I would like to very strongly enc

r266320 - clang-format: Implemented tab usage for continuation and indentation

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
Author: mamai Date: Thu Apr 14 09:52:26 2016 New Revision: 266320 URL: http://llvm.org/viewvc/llvm-project?rev=266320&view=rev Log: clang-format: Implemented tab usage for continuation and indentation Use tabs to fill whitespace at the start of a line. Patch by Maxime Beaulieu Differential Revi

r266319 - clang-format: Allow include of clangFormat.h in managed context

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
Author: mamai Date: Thu Apr 14 09:47:37 2016 New Revision: 266319 URL: http://llvm.org/viewvc/llvm-project?rev=266319&view=rev Log: clang-format: Allow include of clangFormat.h in managed context Including VirtualFileSystem.h in the clangFormat.h indirectly includes . This header is blocked when

Re: [PATCH] D19064: clang-format: Allow include of clangFormat.h in managed context

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266319: clang-format: Allow include of clangFormat.h in managed context (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19064?vs=53608&id=53717#toc Repository: rL LLVM http://

Re: [PATCH] D19065: clang-format: Last line in incomplete block is indented incorrectly

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266321: clang-format: Last line in incomplete block is indented incorrectly (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19065?vs=53582&id=53723#toc Repository: rL LLVM htt

r266321 - clang-format: Last line in incomplete block is indented incorrectly

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
Author: mamai Date: Thu Apr 14 09:56:49 2016 New Revision: 266321 URL: http://llvm.org/viewvc/llvm-project?rev=266321&view=rev Log: clang-format: Last line in incomplete block is indented incorrectly Indentation of the last line was reset to the initial indentation of the block when reaching EOF

Re: [PATCH] D19028: clang-format: Implemented tab usage for continuation and indentation

2016-04-14 Thread Marianne Mailhot-Sarrasin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266320: clang-format: Implemented tab usage for continuation and indentation (authored by mamai). Changed prior to commit: http://reviews.llvm.org/D19028?vs=53444&id=53721#toc Repository: rL LLVM ht

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. A few minor nits remain. Please run clang\docs\tools\dump_ast_matchers.py to regenerate the AST matcher documentation with your changes. Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:5420 @@ -5409,1 +5419,3 @@ typed

[PATCH] D19118: [clang-tidy] Add checker for operations between integrals and pointers

2016-04-14 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This check is finding suspicious operations involving pointers and integral types; which are most likely bugs. Examples: subversion/v1_6/subversion/libsvn_subr/utf.c ``` static const char

Re: [PATCH] D19118: [clang-tidy] Add checker for operations between integrals and pointers

2016-04-14 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 53730. etienneb added a comment. nits http://reviews.llvm.org/D19118 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/PointerAndIntegralOperationCheck.cpp clang-tidy/misc/PointerAndIntegralOperationCheck.h

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added reviewers: aaron.ballman, alexfh. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-110 @@ -107,4 +108,4 @@ SourceLocation Start = Function->getLocStart(); -SourceLocation End = Body ? Body-

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. http://reviews.llvm.org/D19117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266324 - Fix testcase for the LLVM_LIBDIR_SUFFIX=64 case. Fallout from r266108.

2016-04-14 Thread Ismail Donmez via cfe-commits
Author: ismail Date: Thu Apr 14 10:32:24 2016 New Revision: 266324 URL: http://llvm.org/viewvc/llvm-project?rev=266324&view=rev Log: Fix testcase for the LLVM_LIBDIR_SUFFIX=64 case. Fallout from r266108. Modified: cfe/trunk/test/Driver/cl-options.c Modified: cfe/trunk/test/Driver/cl-options

Re: r266108 - clang-cl: Remove -isystem, add -imsvc.

2016-04-14 Thread Ismail Donmez via cfe-commits
On Thu, Apr 14, 2016 at 5:52 PM, Nico Weber wrote: > On Thu, Apr 14, 2016 at 10:32 AM, Ismail Donmez wrote: >> >> On Thu, Apr 14, 2016 at 2:09 PM, Nico Weber wrote: >> > It's supposed to match the >> > >> > "-internal-isystem" >> > >> > "/home/abuild/rpmbuild/BUILD/llvm/stage2/bin/../lib64/clang

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 53732. courbet marked 2 inline comments as done. courbet added a comment. Regenerate doc, cosmetics. http://reviews.llvm.org/D19113 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersI

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! http://reviews.llvm.org/D19113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Clement Courbet via cfe-commits
courbet added a comment. Thanks for the review ! I don't have write access, could you please submit this for me ? http://reviews.llvm.org/D19113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Clement Courbet via cfe-commits
courbet marked an inline comment as done. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-110 @@ -107,4 +108,4 @@ SourceLocation Start = Function->getLocStart(); -SourceLocation End = Body ? Body->getLocStart().getLocWithOffset(-1) : -

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 53735. courbet added a comment. Fix error message in case of type alias declaration. http://reviews.llvm.org/D19117 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp clang-tidy/modernize/RedundantVoidArgCheck.h test/clang-tidy/modernize-redundant-

Re: [PATCH] D19071: [OpenCL] Add predefined macros.

2016-04-14 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:421 @@ +420,3 @@ +switch (LangOpts.OpenCLVersion) { +case 0: +case 100: pxli168 wrote: > What is 0 stand for as OpenCLVersion, it seems the default OpenCLVersion if > we did n

[PATCH] D19121: [clang-tidy] Fix documentation generation.

2016-04-14 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The patch is fixing the generation of clang-tidy documentation. http://reviews.llvm.org/D19121 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/readability-deleted-default.rst Ind

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! I can submit the patch on your behalf if you would like. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-111

Re: [PATCH] D19113: [ASTMatchers] Upgrading typedef matching to c++11

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r266331 http://reviews.llvm.org/D19113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266331 - Add typedefNameDecl() and typeAliasDecl() to the AST matchers; improves hasType() to match on TypedefNameDecl nodes.

2016-04-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 14 11:05:45 2016 New Revision: 266331 URL: http://llvm.org/viewvc/llvm-project?rev=266331&view=rev Log: Add typedefNameDecl() and typeAliasDecl() to the AST matchers; improves hasType() to match on TypedefNameDecl nodes. Patch by Clement Courbet. Modified:

Re: [PATCH] D19121: [clang-tidy] Fix documentation generation.

2016-04-14 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 53741. etienneb added a comment. right fix. http://reviews.llvm.org/D19121 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/readability-deleted-default.rst Index: docs/clang-tidy/checks/readability-deleted-default.rst ==

Re: [PATCH] D19121: [clang-tidy] Fix documentation generation.

2016-04-14 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D19121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] r266333 - [clang-tidy] Fix documentation generation.

2016-04-14 Thread Etienne Bergeron via cfe-commits
Author: etienneb Date: Thu Apr 14 11:08:04 2016 New Revision: 266333 URL: http://llvm.org/viewvc/llvm-project?rev=266333&view=rev Log: [clang-tidy] Fix documentation generation. Summary: The patch is fixing the generation of clang-tidy documentation. Reviewers: alexfh Subscribers: cfe-commits

Re: [PATCH] D19121: [clang-tidy] Fix documentation generation.

2016-04-14 Thread Etienne Bergeron via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266333: [clang-tidy] Fix documentation generation. (authored by etienneb). Changed prior to commit: http://reviews.llvm.org/D19121?vs=53741&id=53744#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D19062: Add functions in ctype.h to builtin function database (Fix)

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. This looks reasonable to me, but I am curious what @joerg thinks of this approach. http://reviews.llvm.org/D19062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D19118: [clang-tidy] Add checker for operations between integrals and pointers

2016-04-14 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Nice check! Comment at: test/clang-tidy/misc-pointer-and-integral-operation-cxx98.cpp:9 @@ +8,3 @@ + pb = false; + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: suspicious

Re: [PATCH] D18073: Add memory allocating functions

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D18073#399270, @ariccio wrote: > In http://reviews.llvm.org/D18073#398882, @zaks.anna wrote: > > > "Since we are adding support for so many new APIs that are only available > > on Windows, could you please condition checking them only whe

Re: [PATCH] D18956: [Sema] Fix assertion failure at vector comparison

2016-04-14 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. rnk added a comment. I think Sema::CheckVectorOperands isn't supposed to return a scalar type. Fixing that with http://reviews.llvm.org/D19123 also solves this problem. Richard, WDYT? Repository: rL LLVM http://reviews.llvm.org/D18956

[PATCH] D19123: In vector comparisons, handle scalar LHS just as we handle scalar RHS

2016-04-14 Thread Reid Kleckner via cfe-commits
rnk created this revision. rnk added a reviewer: rsmith. rnk added a subscriber: cfe-commits. Fixes PR27258 http://reviews.llvm.org/D19123 Files: lib/Sema/SemaExpr.cpp test/CodeGen/vector.c Index: test/CodeGen/vector.c === ---

Re: [PATCH] D19058: clang-format: Pointer `*` is seen as multiplication in C-style casts

2016-04-14 Thread Maxime Beaulieu via cfe-commits
mxbOctasic updated this revision to Diff 53755. mxbOctasic added a comment. Moved cast detection logic to `rParenEndsCast`. http://reviews.llvm.org/D19058 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Clement Courbet via cfe-commits
courbet added a comment. Thanks for the review ! > I can submit the patch on your behalf if you would like. That'd be great, thank you. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-111 @@ -107,5 +108,5 @@ SourceLocation Start = Function->getLocStart();

r266353 - Fix off-by-one error in worst-case number of offsets needed for an AST record.

2016-04-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 14 13:32:54 2016 New Revision: 266353 URL: http://llvm.org/viewvc/llvm-project?rev=266353&view=rev Log: Fix off-by-one error in worst-case number of offsets needed for an AST record. Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h cfe/trunk/test/Mo

Re: r266160 - [modules] Refactor handling of cases where we write an offset to a prior record into the bitstream and simplify a little, in preparation for doing this in more cases.

2016-04-14 Thread Richard Smith via cfe-commits
r266353. On Thu, Apr 14, 2016 at 11:09 AM, Richard Smith wrote: > On Thu, Apr 14, 2016 at 9:00 AM, Nico Weber wrote: > >> On Wed, Apr 13, 2016 at 10:24 PM, Nico Weber wrote: >> >>> On Tue, Apr 12, 2016 at 10:12 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>>

Re: r266254 - [modules] Remove CXX_CTOR_INITIALIZERS_OFFSETS table. Instead of storing an ID

2016-04-14 Thread Richard Smith via cfe-commits
On Thu, Apr 14, 2016 at 4:18 AM, Nico Weber wrote: > This broke building on > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 . I tried fixing > in r266290. > Oh, this is the hilarious MSVC do-while-inside-range-for bug again. Thanks for the fix =) > On Wed, Apr 13, 2016 at 5:57 PM, Ric

Re: [PATCH] D18698: [C11] PR24451: Allow restrict _Atomic pointers

2016-04-14 Thread Denis Zobnin via cfe-commits
d.zobnin.bugzilla added a comment. Richard, please let me know what in your opinion we should do with this revision. Thank you, Denis Zobnin http://reviews.llvm.org/D18698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[clang-tools-extra] r266358 - Add support for type aliases to modernize-redundant-void-arg.cpp

2016-04-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 14 14:28:13 2016 New Revision: 266358 URL: http://llvm.org/viewvc/llvm-project?rev=266358&view=rev Log: Add support for type aliases to modernize-redundant-void-arg.cpp Patch by Clement Courbet. Modified: clang-tools-extra/trunk/clang-tidy/modernize/Redunda

Re: [PATCH] D19117: [clang-tidy] Update RedundantVoidArgCheck to check for type aliases in addition to typedefs

2016-04-14 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r266358 http://reviews.llvm.org/D19117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

2016-04-14 Thread Yaxun Liu via cfe-commits
yaxunl marked 4 inline comments as done. Comment at: lib/Headers/opencl.h:13721-13726 @@ +13720,8 @@ + +/** + * Queue a memory fence to ensure correct ordering of memory + * operations between work-items of a work-group to + * image memory. + */ +#define CLK_IMAGE_MEM_FENCE 0x04

r266359 - Make this code less brittle. The benefits of a fixed-size array aren't worth the maintenance cost.

2016-04-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 14 14:45:19 2016 New Revision: 266359 URL: http://llvm.org/viewvc/llvm-project?rev=266359&view=rev Log: Make this code less brittle. The benefits of a fixed-size array aren't worth the maintenance cost. Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h

Re: [PATCH] D18956: [Sema] Fix assertion failure at vector comparison

2016-04-14 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I agree. In the example, the type of `y == z` should be `vec`, not `int` -- we should "promote" to the vector type. Repository: rL LLVM http://reviews.llvm.org/D18956

Re: [PATCH] D18698: [C11] PR24451: Allow restrict _Atomic pointers

2016-04-14 Thread Richard Smith via cfe-commits
rsmith added a comment. I mailed WG14 asking for clarification on how these rules are supposed to work (10 days ago) and am yet to hear anything in response. Is this apparent GCC extension/bug seeing much use in the wild? If not, I think our path forward is to file this as a bug against GCC and

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

2016-04-14 Thread Tom Stellard via cfe-commits
tstellarAMD added inline comments. Comment at: lib/Headers/opencl.h:11-13 @@ +10,5 @@ + +#if !defined(__SPIR32__) && !defined(__SPIR64__) +#error "This header file should be used with SPIR target only." +#endif + This should be removed so they can be used with any

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

2016-04-14 Thread Yaxun Liu via cfe-commits
yaxunl marked 8 inline comments as done. Comment at: lib/Headers/opencl.h:11-13 @@ +10,5 @@ + +#if !defined(__SPIR32__) && !defined(__SPIR64__) +#error "This header file should be used with SPIR target only." +#endif + tstellarAMD wrote: > This should be removed s

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

2016-04-14 Thread Yaxun Liu via cfe-commits
yaxunl marked 4 inline comments as done. Comment at: lib/Headers/opencl.h:15636-15637 @@ +15635,4 @@ +#if defined(__OPENCL_C_VERSION__) && __OPENCL_C_VERSION__ >= 200 +#define PIPE_RESERVE_ID_VALID_BIT (1U << 30) +#define CLK_NULL_RESERVE_ID (__builtin_astype(((void*)(~PIPE_RESER

r266366 - In vector comparisons, handle scalar LHS just as we handle scalar RHS

2016-04-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Apr 14 16:03:38 2016 New Revision: 266366 URL: http://llvm.org/viewvc/llvm-project?rev=266366&view=rev Log: In vector comparisons, handle scalar LHS just as we handle scalar RHS Summary: Fixes PR27258 Reviewers: rsmith Subscribers: cfe-commits Differential Revision: http:

Re: [PATCH] D19123: In vector comparisons, handle scalar LHS just as we handle scalar RHS

2016-04-14 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266366: In vector comparisons, handle scalar LHS just as we handle scalar RHS (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D19123?vs=53745&id=53782#toc Repository: rL LLVM htt

[PATCH] D19131: Lit C++11 Compatibility Patch #8

2016-04-14 Thread Charles Li via cfe-commits
tigerleapgorge created this revision. tigerleapgorge added a reviewer: rsmith. tigerleapgorge added a subscriber: cfe-commits. 24 tests have been updated for C++11 compatibility. CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp Ambiguous class member lookup has been fixed in C++11 http://

[clang-tools-extra] r266369 - [clang-tidy] Add check misc-multiple-statement-macro

2016-04-14 Thread Samuel Benzaquen via cfe-commits
Author: sbenza Date: Thu Apr 14 16:15:57 2016 New Revision: 266369 URL: http://llvm.org/viewvc/llvm-project?rev=266369&view=rev Log: [clang-tidy] Add check misc-multiple-statement-macro Summary: The check detects multi-statement macros that are used in unbraced conditionals. Only the first statem

Re: [PATCH] D18766: [clang-tidy] Add check misc-multiple-statement-macro

2016-04-14 Thread Samuel Benzaquen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266369: [clang-tidy] Add check misc-multiple-statement-macro (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D18766?vs=53398&id=53786#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D18970: Add functions in ctype.h to builtin function database

2016-04-14 Thread Joerg Sonnenberger via cfe-commits
On Thu, Apr 14, 2016 at 03:02:31PM +, Taewook Oh via cfe-commits wrote: > Thank you for your comments. I submitted a new patch > (http://reviews.llvm.org/D19062) with a new test that checks attributes > but not types. I think this should cover both cases. What do you think? I think just pickin

r266383 - AMDGPU: Add test for generic builtin behavior

2016-04-14 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Thu Apr 14 17:34:39 2016 New Revision: 266383 URL: http://llvm.org/viewvc/llvm-project?rev=266383&view=rev Log: AMDGPU: Add test for generic builtin behavior Added: cfe/trunk/test/CodeGenOpenCL/builtins-generic-amdgcn.cl Added: cfe/trunk/test/CodeGenOpenCL/builtins-gener

Re: [PATCH] D18473: AMDGPU: Add test for generic builtin behavior

2016-04-14 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r266383 http://reviews.llvm.org/D18473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >